- 17 Sep, 2020 40 commits
-
-
Lei Zhang authored
They are not used anywhere. Change-Id: Iff2aabff98d992d987b57a326c98eb6123533139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414686 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#807868}
-
Sébastien Séguin-Gagnon authored
This is a reland of 74b8ec6f Original change's description: > [Empties] Enable the IllustratedEmptyStates field trial testing config. > > Change-Id: I664fa63b5b69369cb69fb4b87463ba3bb4cfc94d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386295 > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: sebsg <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805136} Change-Id: Ieb3e461efb4c55e7ef601417819cc4470e8fe4cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401398 Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Auto-Submit: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#807867}
-
Ian Kilpatrick authored
This patch ensures that we always have a "consistent" fragment-tree (or rather a portion of a fragment-tree if we have legacy nodes). Previously it was possible for a fragment-tree to become inconsistent whenever we performed layout from a subtree root. Now when we layout from a node like this, we rebuild the "spine" of the tree. After this change we'll be able to remove most "PostLayout" calls, except where they are used for building this "consistent" tree. Bug: 1066616 Change-Id: I3993fcc5be1cd9043555ecad553fc569fc985314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407032Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#807866}
-
Adithya Srinivasan authored
Follow up to https://crrev.com/c/2404384. Bug: 1127046 Change-Id: I282557314ec24e505cd04fa2ad28976d99930740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414411Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#807865}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/26d327a7..8e25d6ac Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib7b1e90bc5c50fb9b2b10035a097731eb37aee53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416328Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807864}
-
Demetrios Papadopoulos authored
Original CL at r806929 was reverted due to failures on Mac bots. Fixed by moving the test in question from browser_tests to interactive_ui_tests. It's a known issue that tests involving DOM focus don't work on Mac unless they are interactive_ui_tests. Fixed: 1065659 Change-Id: I8ed0d23a7318c5fa28596d0bd9d0b57f41db536c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411945Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#807863}
-
Rohit Agarwal authored
Incognito Interstitial. This CL adds the logic to close the regular tab where the incognito interstitial bottom sheet is displayed once the user clicks on "Continue" button in the incognito interstitial. Bug: 1125960 Change-Id: Iadab65f07a1177b08d13dd601c52d38f0e5c063f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398920 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#807862}
-
Clemens Arbesser authored
This fixes an issue where first-time users would not be flagged as such if they simply closed the tab. Now, this is marked as soon as the UI is shown. Bug: b/168281605 Change-Id: Ifcb32d69536ed6f7c8f6acbf68e67287d62c0404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414170 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#807861}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f5ee7c40c31b..25f15e6f33a4 2020-09-17 changhaohan@chromium.org Fix Runtime.instance to return singleton when it exists 2020-09-17 jacktfranklin@chromium.org Fix typo in component server comment 2020-09-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-09-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-09-16 patrick.brosset@microsoft.com Grid: Set a light background color on the persistent grid overlay 2020-09-16 jegarc@microsoft.com Normalize BezierPopoverIcon behavior 2020-09-16 raphaellucena@google.com Add performance.mark() events to Performance Tab -> Timeline UI 2020-09-16 andoli@chromium.org [ts] Typecheck css_overview/CSSOverviewPanel.js with TypeScript 2020-09-16 patrick.brosset@microsoft.com Rolling DevTools deps 2020-09-16 jegarc@microsoft.com Normalize ShadowSwatchPopover behavior 2020-09-16 jacktfranklin@chromium.org Fix loading images in components server 2020-09-16 andoli@chromium.org Disables flaky e2e test on the Issues tab 2020-09-16 jacktfranklin@chromium.org Migrate heap snapshot multiple retainers layout test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1047356,chromium:1110817,chromium:1126495,chromium:1126496,chromium:1128534 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I444cf4e5252ba43e9efbd06963377b673a3de288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416111Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807860}
-
Alexander Surkov authored
Bug: 1124366 Change-Id: I14e9badd2bef2e5315e5893cbb4fae0a35b13e78 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411702 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#807859}
-
Vasilii Sukhanov authored
Fixed: 1126407 Change-Id: I06fc60a4c9800450d41eb8b5d312c25224e8e4b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414221 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Rohit Agarwal authored
Bug: 1127812, 1127852 Change-Id: I1704677ba9e82b3c00589f860b9c43abf5897f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414269Reviewed-by:
-
Swapnil authored
The browsertests of full screen allowed policy are moved from policy_browsertests to a separate file. Bug: 1128323 Change-Id: I6a470347be838d58b1b2d24b37f8f0bd852bc35e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410064 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#807856}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/19b910d7964b..6419bddd9b0c 2020-09-17 hao.x.li@intel.com Add buffer lazy initialization before resolve queries on D3D12 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: If8513d817fb200967b9ceba47ca87b33b316dd40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415871Reviewed-by:
-
Youkichi Hosoi authored
We are going to mount /home/.shadow/<user-hash>/mount/user/MyFiles instead of /home/chronos/user/MyFiles in the arcvm-mount-myfiles upstart job. In order to achieve it, this CL makes ArcVmClientAdapter pass the Chrome OS user id hash to the upstart job. BUG=b:123641356 TEST=$ components_unittests --gtest_filter="ArcVmClientAdapterTest.*" TEST=Confirm that ${CHROMEOS_USER_ID_HASH} is available in the TEST=arcvm-mount-myfiles upstart job. Change-Id: I4adac56aadd7cf4f5f513921b1ccc7c8f874f077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412112Reviewed-by:Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Satoshi Niwa <niwa@chromium.org> Commit-Queue: Youkichi Hosoi <youkichihosoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#807854}
-
Swapnil authored
The browsertests of statistics collector policy are moved from policy_browsertests to a separate file. Bug: 1128322 Change-Id: Ie35643f650c86d710ae470ec51745f8d227a07c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410063 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
-
Benoit Lize authored
This reverts commit 91b2c272. Reason for reland: Don't use `thread_local` Original change's description: > base/allocator: Add a thread cache to PartitionAlloc. > > This CL adds a thread cache to PartitionAlloc. It is optional, only > applies to thread-safe partitions, and uses the same freelist encoding > and bucketing as the main allocator. > > The thread cache is added "in the middle" of the main allocator, that is: > - After all the cookie/tag management > - Before the "raw" allocator. > > That is, the general allocation flow is: > 1. Adjustment of requested size to make room for tags / cookies > 2. Allocation: > a. Call to the thread cache, if it succeeds, return. > b. Otherwise, call the "raw" allocator <-- Locking > 3. Handle cookies/tags, zero allocation if required > > On the deallocation side, the process is reversed: > 1. Check cookies / tags, adjust the pointer > 2. Deallocation > a. Return to the thread cache of possible. If it succeeds, return. > b. Otherwise, call the "raw" allocator <-- Locking > > The thread cache maintains an array of buckets, the same as the parent > allocator. A single thread cache instance is only used by a single > partition. Each bucket is a linked list of allocations, capped to a set > maximum size. Elements in this "freelist" are encoded the same way they > are for the main allocator. > Only the smallest buckets are eligible for caching, to reduce the > memory impact. > > There are several limitations: > - Only a single partition is allowed to have a thread cache > - No periodic purging of thread caches is done > - No statistics are collected > > The last two limitations will be addressed in subsequent CLs. Regarding > the first one, it is not possible to use Chrome's native thread local > storage support, as it allocates. It is also desirable to use > thread_local to improve performance. > > Bug: 998048 > Change-Id: Ia771f507d9dd1c2c26a4668c76da220fb0c65dd4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375206 > Commit-Queue: Benoit L <lizeb@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805697} Bug: 998048 Change-Id: If7fa5c2e1e10bc7dd1d41cdb188840668aad888f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410126Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#807852}
-
Roman Sorokin authored
Update the value on the session start. Fixed: 893938 Change-Id: I949ecfcaba81c6d53d78853d0d4576ac5ae003c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414209 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#807851}
-
Philipp Hancke authored
as buildbots missing H264 comes up frequently. BUG=chromium:840659 Change-Id: I8db4bee8bbbc04d1227d957dcd6a73ee658ec829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414315Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#807850}
-
Vasilii Sukhanov authored
Fixed: 1125731 Change-Id: Icba338d52cce5a05de22e180a046157e22b7726b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410871Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#807849}
-
Prashant Nevase authored
I reviewed many of the changes in core dark mode module and recently have been adding many changes. Going forward to assess correctness and completeness, I would like to get involved in reviewing changes related to this module. Bug: None Change-Id: I2bb51c6cbcff3bfb2b18be1a160c70952e1f8839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416188Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#807848}
-
Rune Lillesveen authored
TBR=leese@chromium.org Bug: 1129347 Change-Id: I576ab5489586e495cda867befa800b375d0add66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414305Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#807847}
-
Miyoung Shin authored
This is a follow up CL of https://crrev.com/c/2377630 and moves |never_composited| variable into WidetBase from RenderWidget. Bug: 1102446 Change-Id: I7821c5890831cf4ccc17fc10f88b1d628f87114c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407680 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#807846}
-
Makoto Shimazu authored
As a part of the effort to understand the current behavior of the resource timing, I changed the tests to use async/await for readability with adding a few comments. Bug: 1128786 Change-Id: I45daee67e52a13c98ad3f2010131d858a58781d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413927 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#807845}
-
Sergei Datsenko authored
Bug: 1105381 Change-Id: I4f63f8d7de3bf9bd530dbe842fe47d736e2b04d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413567Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#807844}
-
My Nguyen authored
Logic is partly carried over from manage_input_methods.js The original CL that added this logic doesn't explain much https://crrev.com/1908483003. This CL https://crrev.com/c/1109441 suggests component IMEs are pre-installed system IMEs, which makes sense to ensure at least one is enabled in case the third-party one get removed and users can no longer type. Button disabled view: http://screen/3qQgdYTc6UQBn8Y Bug: 1113439 Change-Id: I4d07687a8ac0a2c705d8e83bfb938909149a2723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413677 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#807843}
-
Michael van Ouwerkerk authored
Screenshot before: https://screenshot.googleplex.com/BARaxjkyDLmdPR5.png Screenshot after: https://screenshot.googleplex.com/92GvmjRmJsErz2q.png Bug: 1091563 Change-Id: Icfaccb7888cafe18a22c8897737bef458e20f3d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412341 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#807842}
-
Olivier Robin authored
The hiding/showing is normally done via ReadingListListViewControllerAudience but the initial setup is done before the navigationController was create. It is necessary to create the navigationController in the correct state. Bug: 1128059 Change-Id: I2303356c71bf70f178a5f9a5c65f023750ecf05d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414273Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#807841}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d03abd8af735..1d8e2d5acaf5 2020-09-17 vovoy@chromium.org Include the first valid tab switch latency If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:899174 Tbr: oysteine@google.com Change-Id: I64ebdd5ff5b43f89e01480a9e9729af477a7d701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415889Reviewed-by:
-
Hidehiko Abe authored
Currently WaylandKeyboardDelegate internally tracks the state of XKB. To fix the zwp_text_input behavior, XKB state needs to be shared. So this CL extracts it. Bug: 1123705 Test: Ran locally. Change-Id: I72806731f778aadca07ff73ba2cc0a08abb59141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413612 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#807839}
-
nancylingwang authored
Add content::RunAllTasksUntilIdle() to resolve the test case ChromeLauncherControllerWithArcTest.ArcAppPinCrossPlatformWorkflow flaky issue. BUG=1083331 Change-Id: Ib142e74c194625f8a180a34bc4f755b01b3c4e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409428 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#807838}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Change code in //components/variations to check the platform before adding plaform-specific source files to "sources" variable and clear the filter to prevent regressions. Bug: 1018739 Change-Id: Ib4c82f8dd2ede72ab9fcdb4ec193d7efa8c2bd3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414232 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#807837}
-
Oleg Maximenko authored
ComputedStyle::AccessAnimations() (and AccessTransitions) are used to modify corresponding properties. But ComputedStyle::AccessAnimations() uses inside ComputedStyleBase::AnimationsInternal() which meant to be used for constant access only. Due to copy-on-write semantics of ComputedStyle it causes modifications to cloned ComputedStyle affect source ComputedStyle instance. Replacing call to AnimationsInternal() with copy-on-write-aware MutableAnimationsInternal() eliminate this problem. Change-Id: I67a0342151bbd4e0aee1fd8fbf16aa2a02a6310a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410018 Commit-Queue: Alexander Semashko <ahest@yandex-team.ru> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#807836}
-
Henrique Ferreiro authored
Several fields are optional. Use the ? Mojo type specifier to explicitly mark them as such. Bug: 1039255 Change-Id: Ib5aa530059b90d0c41fe3288d8b9964c333e3cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351831 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#807835}
-
Tim Song authored
This CL adds PhoneHubNotificationController, which creates and manages a ChromeOS notification for each corresponding PhoneHub notification. This basic implementation only creates a simple notification and additional details will be added in following CLs: * Images and icons * Buttons and inline reply * Settings BUG=1128091,1106937 Change-Id: Ifd57011c68e480f5956b628823ca461bb7ee39fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413531 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
Now flaky on MacOS. Already disabled for most other platforms. Disable for all. TBR=skyostil@chromium.org Bug: 1078405 Change-Id: Ib0212de28302de1581a63db55c2e6227856bed3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414303Reviewed-by:
-
Johann authored
The MIDIDispatcher ctor recently gained access to execution_context. Use it to generate a TaskRunner when it is needed. Since it is only needed in the ctor, remove task_runner_. Change-Id: I7873fddd1ae815fd7ac909b3a5f9a49e257ef0c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409561Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#807832}
-
Swapnil authored
The browsertests of google requests are moved from policy_browsertests to a separate file. Bug: 1128321 Change-Id: Ia64c8e4cefea56cedff9bd29c3baa390cc160867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410388 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
-
Clovis PJ authored
MojoLPM should add handles (DataPipeProducer/Consumers etc) directly to its context, instead of attempting to ToProto convert these. As this is consistent with HandleDataPipeRead/Write. Bug: 1076336 Change-Id: Ia509064339724db82548ba24eebeb0bdfac39a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351991Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Clovis PJ <clovispj@google.com> Cr-Commit-Position: refs/heads/master@{#807830}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2ff41ff5..26d327a7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icc68d14c5b57bb902b61982a2dbffa18097587ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415289Reviewed-by:
-
