- 06 Jun, 2018 40 commits
-
-
edchin authored
This CL enables the badged reading list by default. Bug: 848358 Change-Id: I23e371c2de66f39c6e2b856c802451129911140f Reviewed-on: https://chromium-review.googlesource.com/1088191Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#565085}
-
David Grogan authored
Old code only supported auto and fixed flex bases. This makes 3 more tests pass. Also added a ton of comments. From spot checking, it seems many non-crash failures are due to not setting the flex container's height correctly, e.g. external/wpt/css/css-flexbox/align-content-001.htm css3/flexbox/relpos-with-percentage-top.html Bug: 845235 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I06a3d8f4b8923c8acb1d6fb07826da66d55826a5 Reviewed-on: https://chromium-review.googlesource.com/1088229 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#565084}
-
John Z Wu authored
will combine signin and sync for //ios/web_view. //ios/web_view only needs to signin because it needs to sync autofill data. As such, we will combine them to simplify the API. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9ecefad6523ae0207ec5c33516fd90bc536633b1 Reviewed-on: https://chromium-review.googlesource.com/1089352Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#565083}
-
Varun Khaneja authored
No change to README.chromium required since it already contains: - Replace exceptions with terminating the current process. Guarded with the macro UNRAR_NO_EXCEPTIONS. R=wfh Bug: 750327,847635,767906 Change-Id: Ie5efe8b637f87647ea2972c115a2ac2464ef793d Reviewed-on: https://chromium-review.googlesource.com/1081434Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#565082}
-
Ryan Hansberry authored
This class is no longer used and can be deleted. BeaconSeeds are no longer fetched on demand; they are always present in a RemoteDevice object. R=jhawkins@chromium.org Bug: 824568, 752273 Change-Id: I6047f5ed9da2abd01c93e26c752e46e9562ff2a1 Reviewed-on: https://chromium-review.googlesource.com/1087875 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#565081}
-
Oystein Eftevaag authored
This will act as a fallback while derived types are converted to their own optimized proto messages. Dependent on https://android-review.googlesource.com/c/platform/external/perfetto/+/699955 being rolled into third_party/perfetto first. Bug: 839063 Change-Id: I00fc5a639a770d06fbf08c60fb43d12871aa69c7 Reviewed-on: https://chromium-review.googlesource.com/1087643Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#565080}
-
David Trainor authored
This is the initial implementation of a prefetch view item for the new download home UI. This change includes the following: - Builds out the ViewHolder that can handle thumbnails (automatically processes it and pushes it to the view). - Builds out the ViewHolder that can handle a 3-dot menu (automatically handles the callback information). - Adds the initial XML for the prefetched item. BUG=849584 Change-Id: I965df4b6bdffc73f084f2f18c15588488b4beb0f Reviewed-on: https://chromium-review.googlesource.com/1087319 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#565079}
-
Xianzhu Wang authored
GeometryMapper::SourceToDestinationProjection(parent, child) returns identity if child transform is not invertible, so it's not reliable to use it to check if parent and child are in the same transform space. Now avoid the function, while still handle most common cases to combine clips through identity transforms. Bug: 849382 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I747e857d3828a5fb6eea0f69ed8746843912baf4 Reviewed-on: https://chromium-review.googlesource.com/1086492Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#565078}
-
Quinten Yearsley authored
The results for these files are likely changed by recent ShiftShader changes. This CL involves rebaselining and adding a flaky timeout for expectation for virtual/gpu/fast/canvas/canvas-composite-video.html associated with crbug.com/726075. Bug: 736177 Change-Id: Id18ca42ad63ebe27869eec599f22d441b43bad34 Reviewed-on: https://chromium-review.googlesource.com/1085750 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#565077}
-
Ingvar Stepanyan authored
Now that new clipboard API is available in stable Chrome, it can be used to enable copy actions by default even in hosted mode. Change-Id: Ifacb15f7db990c03df21f97560a6e81e9b7746f0 Reviewed-on: https://chromium-review.googlesource.com/1068946Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#565076}
-
Yuichiro Hanada authored
Bug: 829383, 834027 Test: IME works on ARC++ apps and notifications from ARC++ apps. Change-Id: I98d7cb43845c668ad0afb273c623b49abf08f595 Reviewed-on: https://chromium-review.googlesource.com/1051433Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#565075}
-
Tommy Martino authored
This new flag is meant to enable all upcoming ui features, so it should force the new dropdown on even if the dropdown-specific flag is off. Change-Id: Ia3aa38285bf4a60fa72250ac35d8cc9e20ae98a7 Reviewed-on: https://chromium-review.googlesource.com/1089791 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#565074}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1a3e67e..874afdd git log 1a3e67e..874afdd --date=short --no-merges --format='%ad %ae %s' 2018-06-06 jclinton@chromium.org cbuildbot_launch: Blow away everything if cleaning up locks fails Created with: gclient setdep -r src/third_party/chromite@874afdd The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:850236 TBR=chrome-os-gardeners@chromium.org Change-Id: Id5e16d8dc9ad7f322e079286221bae29d82463aa Reviewed-on: https://chromium-review.googlesource.com/1089694Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565073}
-
Max Moroz authored
https://chromium.googlesource.com/webm/libwebm.git/+log/af81f26025b7..01c1d1d76f13 $ git log af81f2602..01c1d1d76 --date=short --no-merges --format='%ad %ae %s' 2018-06-06 mmoroz Move definition of IMkvReader::~IMkvReader() to mkvparser.h. 2018-05-14 johannkoenig replace vp10 with av1 2018-04-24 johannkoenig remove unused PesHeader 2018-04-24 johannkoenig add codereview.settings Created with: roll-dep src/third_party/libwebm/source Bug: 849812,764514 Change-Id: I87e412794820fd1d8a7a320faca2b4220b7bf23b Reviewed-on: https://chromium-review.googlesource.com/1089571Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#565072}
-
edchin authored
This CL hooks up the URLLoader for remote tabs in tab grid. When the user taps on a remote tab, the tab will be loaded and the tab will be displayed. Bug: 804588 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7a6dbe200d8e806b14012d3986bbd61789cf810b Reviewed-on: https://chromium-review.googlesource.com/1088188Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
Current LayoutNG hit test code computes wrong |accumulated_offset| when falling back to legacy. It tries to maintain an additional offset for legacy, but fails to do so. This patch computes the fallback offset directly from NG offset, which fixes legacy fallback, and also removes the legacy offset maintenance code. Bug: 811502 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I06b2df66dc2a36efaf32077ea26a3abb4a26eb49 Reviewed-on: https://chromium-review.googlesource.com/1089800Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#565070}
-
Sahel Sharify authored
We already skip recording scroll metrics when the GSU events are ignored since ignored events don't cause GPU swap. This cl terminates the latency info from ignored GSU events and adds a unittest to verify the termination. It also has a browsertest to verify no scroll latency gets recorded when GSU events are ignored. ScrollLatencyBrowserTest.ScrollLatencyNotRecordedIfGSUIgnored Bug: 773740 Test: RenderWidgetHostLatencyTrackerTest.LatencyTerminatedOnAckIfGSUIgnored, Change-Id: Idaa4c3d739a79a8e44e4c3db82a74877428d404c Reviewed-on: https://chromium-review.googlesource.com/1080035 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#565069}
-
Dominik Röttsches authored
The device scale factor that is configured in the browser process, for example through Gtk environment settings, or through the command line flag --force-scale-factor is not always identical with the one in the renderer process. The renderer process DSF can be configures als through TestingInternals and other configuration mechanisms. So these two can go out of sync and do not have the same semantics. As a solution, pass the DSF from Blink via IPC to identify the intended rasterization settings for a system font. Rebaselines are needed for those tests where the DSF settings in browser and renderer went out of sync. Overall, this CL is preparation for moving the Sandbox IPC functions to Mojo instead of the current filedescriptor communication approach. Also, addressing an older TODO about not passing size and is_bold, is_italic in one variable. Bug: 845468 Change-Id: I6fbe5c906f31f2e8872296404ffa269fbeb652f0 Reviewed-on: https://chromium-review.googlesource.com/1071512 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#565068}
-
Ian Vollick authored
With this change, we should revert to the behavior prior to crrev.com/c/1087170, however the reported dirtiness will still only be true if the transform is actually updated. Bug:850210 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I6a038953e0b658d9ea0b9a64a599faf5073cde9b Reviewed-on: https://chromium-review.googlesource.com/1089854Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#565067}
-
Khushal authored
The image animation system selects the frame index for the animation during tile raster. As a result updating the frame of the image is missed for Webview resourceless draw mode which does not use these tiles and later rasterizes the display list in SoftwareRenderer. Plumb through the animation state on the PictureDrawQuad and use it to select the frame index for image at raster. R=boliu@chromium.org, danakj@chromium.org Bug: 849565 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I20f48a664ae816da29e7d55012b7da4dec488ede Reviewed-on: https://chromium-review.googlesource.com/1087321Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#565066}
-
Jao-ke Chin-Lee authored
BUG=731417 Change-Id: Ic2e8071ce052e2d8ef5b6f0c508f6f62da7624fc Reviewed-on: https://chromium-review.googlesource.com/1089913Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#565065}
-
David Bertoni authored
Change-Id: Ia662afb410051f747178486ac3c29e3ed1548725 Reviewed-on: https://chromium-review.googlesource.com/1089832Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#565064}
-
nacl-chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/93deff4..82ff2ae git log 93deff4..82ff2ae --date=short --no-merges --format='%ad %ae %s' 2018-06-06 thomasanderson@chromium.org Remove manual references to exe_and_shlib_deps Created with: gclient setdep -r src/native_client@82ff2ae The AutoRoll server is located here: https://nacl-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:845700 TBR=mseaborn@chromium.org Change-Id: Iea87daa701390fc3f17f4fbbd2b88aad16dce4f2 Reviewed-on: https://chromium-review.googlesource.com/1089550Reviewed-by:
nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565063}
-
David Bokan authored
This CL does some cleanups around size-related methods in VisualViewport. Changes here include: - Making VisibleRect methods allow including or excluding the scrollbar sizes. The default is now to exclude, matching the intuition of what the visible rect is as well as the convention set in ScrollableArea. - VisibleWidth, VisibleHeight are no longer overriden and use the correct convention regarding scrollbars. - Use VisibleRect in other methods rather than duplicating code - Added, clarified, and corrected comments in visual viewport - Updated tests (and converted to more modern style) to not use internals visual viewport methods where a web-visible API exists. - Explicitly use PageZoomFactor for zoom adjustment, rather than the misleadingly named AdjustScroll helper. Change-Id: I4df38bbff78224cccf47f0ee86a573c8fe033c5d Reviewed-on: https://chromium-review.googlesource.com/1082928Reviewed-by:
Jianpeng Chao <chaopeng@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#565062}
-
Adrienne Walker authored
Currently, out of process rasterization (oop-r) is controlled by a single command line flag (--enable-oop-rasterization) and default off. Many places in the code check this. This patch centralizes the enabling logic into gpu_util.cc and GpuFeatureList as the definitive source for whether oop-r is enabled. First, command line entries are forwarded via GpuPreferences to the gpu process. Then, GpuInfo decides whether or not oop-r can be supported. Then the gpu preferenes (enable and disable), blacklist, and finch entry (default off now) are used to set the GpuFeatureInfo status value. This status value is passed to gles2::FeatureInfo to enable/disable chromium_raster_transport in the raster decoder if needed for oop raster. The command line flags no longer need to be piped to the renderer or the gpu process. The renderer also uses the GpuFeatureInfo to figure out whether to use oop-r. If it says it is supported, then it should be used. Bug: 847684 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ifecda890216e573745ae1c823294b9bbc1962cab Reviewed-on: https://chromium-review.googlesource.com/1083115 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#565061}
-
Sky Malice authored
Change-Id: I35da57c3825753bf348b8388c087249bdc928834 Reviewed-on: https://chromium-review.googlesource.com/1089639Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#565060}
-
Matt Wolenetz authored
This change makes the web-visible SourceBuffer.mode attribute compliantly set initially to 'sequence' and forced to remain 'sequence' for byte streams which have their 'Generate Timestamps Flag' set in the MSE Byte Stream Format Registry [1]. Prior to this change, for affected byte streams (audio/mpeg and audio/aac), we would generate timestamps, but allow the SourceBuffer.mode to vary among 'segments' and 'sequence'. We also would not initialize the mode correctly to 'sequence' for those streams. This should not be a breaking change, since generated timestamps mimic 'sequence' mode logic already, unless there is a pre-existing bug causing discontinuities in those generated timestamps. But it does compliantly set and restrict the SourceBuffer.mode attribute. This change is useful also as a prerequisite for the 'changeType' work, which will also need to conditionally set and constrain SourceBuffer.mode based on the new MIME type's byte stream format. [1] https://www.w3.org/TR/mse-byte-stream-format-registry/ BUG=607372 TEST=Related wpt layout FAIL expectations removed and tests pass locally with proprietary codecs. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib5ac4e0430c75bd4c6fa00e76073dc83a9b987dc Reviewed-on: https://chromium-review.googlesource.com/1086356 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#565059}
-
Makoto Shimazu authored
When NetworkService is off, URLLoader should not be used when the network request is coming from the renderer. This CL is to use URLLoaderFactoryImpl, which internally routes requests to ResourceDispatcherHost, for ServiceWorkerScriptLoaderFactory. Bug: 846237 Change-Id: Ie656f55c22bcd27a7564cdb68bc448ca24e7176e Reviewed-on: https://chromium-review.googlesource.com/1075926Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#565058}
-
Ryan Hansberry authored
BLE advertisement logic like generating an advertisement and inspecting it are factored into BleServiceDataHelper, allowing BleScanner and BleAdvertiser to be agnostic of whether the new DeviceSync Mojo API is being used. This CL completes Magic Tether's integration with the DeviceSync Mojo API; a user can enable use of the API by enabling the kMultiDeviceApi flag. This CL refactors BleAdvertisementGenerator and BackgroundEidGenerator to accept RemoteDeviceRef lists with BeaconSeeds inside them, instead of accepting a RemoteBeaconSeedFetcher. This removes the need for RemoteBeaconSeedFetcher; it will be removed in a subsequent CL. Bug: 824568, 752273 Change-Id: Ibfc8328ae979e176f438aa53b8258839133068b8 Reviewed-on: https://chromium-review.googlesource.com/1088311 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
-
Stephen Martinis authored
Bug: 782863 Change-Id: I6f4fb63fe1ed9c56a4f5238f1b0ca37c1c3a0715 Reviewed-on: https://chromium-review.googlesource.com/1087762Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#565056}
-
James Cook authored
It was previously defaulting to the primary display, which is wrong. Bug: none Change-Id: I827424b0e5a8dbb1725fe2741402c069afeb4fa3 Reviewed-on: https://chromium-review.googlesource.com/1089202 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#565055}
-
khmel@google.com authored
for Activity manager and Play Store is not closed after initial start. Test: Locally, confirmed that configuration changed is called only once Bug: b/67734479 Bug: b/76398711 Change-Id: I121243c03704587454516393467df08f9981f0c9 Reviewed-on: https://chromium-review.googlesource.com/1079457 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#565054}
-
Saman Sami authored
This should make it easier to have an Android implementation where ui::Compositor is not available. Bug: 848881 Change-Id: Ib7838f53b0935bf178954f1aa64bbf777cae3b6d Reviewed-on: https://chromium-review.googlesource.com/1087807Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Sahel Sharifymoghaddam <sahel@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#565053}
-
Weidong Guo authored
Changes: Make apps grid view in folder handles all scroll event if folder is opened to avoid closing app launcher via scrolling up in 1st page of folder. Bug: 847800 Change-Id: I5ec3744686202d519b421044d810857a3a5020d5 Reviewed-on: https://chromium-review.googlesource.com/1088148 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
-
Klaus Weidner authored
When ARCore loses tracking, continue providing camera images, but send null poses. This allows JS applications to handle tracking loss, i.e. by displaying a pose-independent info message. BUG: 837116 Change-Id: I92238f1bf158ca2714a4068ddba8ac5bbdb123fc Reviewed-on: https://chromium-review.googlesource.com/1043207Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#565051}
-
Xianzhu Wang authored
This reverts commit e2d97e7a. Reason for revert: Reland with the null pointer issue fixed. LayoutSVGEllipse and LayoutSVGRect override LayoutSVGShape methods not to create paths in case that optimized algorithm can be used. However, the original condition in their ShapeDependentStrokeContains() might call LayoutSVGShape::ShapeDependentStrokeContains() without use_path_fallback_ in some cases (e.g. when the shape is invalid). Now ensure ShapeDependentStrokeContains() is called only if use_path_fallback_ is set. Also ensure that use_path_fallback_ is set whenever we need it. Original change's description: > Revert "[PE] Ensure update of LayoutSVGShape::NoScalingStrokeTransform" > > This reverts commit 85b96ea9. > > Reason for revert: crbug.com/849968 > > Original change's description: > > [PE] Ensure update of LayoutSVGShape::NoScalingStrokeTransform > > > > In Pre-SPv175 we forced subtree paint invalidation on non-composited > > transform change. SPv175 no longer does that, causing > > NonScalingStrokeTransform not updated on ancestor transform change. > > > > We also had a non-obvious bug that LayoutSVGShape::StrokeBoundingBox > > didn't get updated on ancestor transform change. > > > > Now always explicitly update non-scaling-stroke data during layout. > > > > Bug: 849080 > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Change-Id: Ia61eb94f43e53a71a80e1102e4d605e4331f44b1 > > Reviewed-on: https://chromium-review.googlesource.com/1086715 > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Reviewed-by: Fredrik Söderquist <fs@opera.com> > > Cr-Commit-Position: refs/heads/master@{#564584} > > Change-Id: Ifbdd23b74dc45b5c8bc66c3d64bff580d5306f78 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 849080, 849968 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Reviewed-on: https://chromium-review.googlesource.com/1087332 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564793} Bug: 849080, 849968 Change-Id: I15c2f80a2f80d11ccf356328ad41e8ab9d8de72f Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/1089090 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#565050}
-
Amy Qiu authored
Move tough_image_decode_cases into the rendering folder and refactor classes to inherit from RenderingStory Bug: 849392 Change-Id: I888b1226bc8663c28d79e5871215547af1052b4a Reviewed-on: https://chromium-review.googlesource.com/1089203 Commit-Queue: Amy Qiu <amyqiu@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#565049}
-
Justin Novosad authored
This is a step in unifying canvas and OffscreenCanvas code paths BUG=788439 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I6f3a3f7bed8b36f502bc7ce138b4bf21920629f7 Reviewed-on: https://chromium-review.googlesource.com/1089582Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#565048}
-
Xi Cheng authored
Change-Id: I4121159c9326842a2e868a58e34a00359b1756c9 Reviewed-on: https://chromium-review.googlesource.com/1088312Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#565047}
-
Dan Beam authored
How I generated this: https://gist.github.com/danbeam/d5fe7b1bcfebc9a94d60c9975b842e97 R=dpapad@chromium.org BUG=none Change-Id: Ic8d85539990d9ccc4a2e0faa8a3928ee2c878adf Reviewed-on: https://chromium-review.googlesource.com/1089716 Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#565046}
-
