GitLab

This CL prevs OffscreenCanvasAccelerated2D* before reenabling them in
crrev.com/c/1303097. The tests are already marked as failing
unconditionally.

Bug: 805031
Change-Id: Iae9af1f4a21db545578c67e38eb66e57d83d2e19
Reviewed-on: https://chromium-review.googlesource.com/c/1305400Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603714}

Adjust overflow menu and track list width
to 260px so it won't truncate exit PiP text.

Bug: 863551
Change-Id: Ie12c79eb15a06554a63fbb082d82e1ab523869a2
Reviewed-on: https://chromium-review.googlesource.com/c/1302574Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603713}

Merge its contents into chrome/browser/ui/BUILD.gn to reduce build
dependency complicity.

Change-Id: I046775c1b2bd7f37abc0c9786c5b70baae256255
Reviewed-on: https://chromium-review.googlesource.com/c/1306834Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603712}

Work will be needed to make ui_devtools work in multi-process Mash.
(otherwise it will only handle events sent to Chrome-owned windows)

Bug: 896977
Change-Id: Ie2487aed095ee9f62e2e9c85e56bc056b789e0ed
Reviewed-on: https://chromium-review.googlesource.com/c/1300056Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603711}

This reverts commit 4e8eb7fb.

Reason for revert: Causes crashes, see 898668

Original change's description:
> [BlinkGenPropertyTrees] Promote BGPT to experimental
> 
> BlinkGenPropertyTrees (BGPT) is an incremental step towards making
> compositing decisions after the paint lifecycle phase. The primary
> changes are to build property trees in blink and send a layer list to
> the compositor, rather than building property trees in cc from a layer
> tree. This patch marks the project as experimental which will give us
> test and perf coverage on the bots.
> 
> Sheriffs: This shifts time (e.g., we now run PaintArtifactCompositor
> and no longer run the cc property tree builder) and will likely change
> performance benchmarks. Because this is an initial trial, feel free to
> roll this patch out.
> 
> Bug: 836884
> Change-Id: Ib867beebbead940162db0801822389f76e8eb8dc
> Reviewed-on: https://chromium-review.googlesource.com/c/1294204
> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> Commit-Queue: Philip Rogers <pdr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#602150}

TBR=wangxianzhu@chromium.org,pdr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 836884, 898668
Change-Id: I95698da07a0015369748a5fb9a98cd3d85399d9c
Reviewed-on: https://chromium-review.googlesource.com/c/1305819Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603710}

This is a low-frequency check that needs disk
access.

Change-Id: I0b6448b401c9c0176a98e7eff8c3f46d9956790f
Reviewed-on: https://chromium-review.googlesource.com/c/1298743
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603709}

https://android.googlesource.com/platform/external/perfetto.git/+log/acda68b0292e..dc38c5209303


git log acda68b0292e..dc38c5209303 --date=short --no-merges --format='%ad %ae %s'
2018-10-29 taylori@google.com trace_processor: Allow sqlite to handle string filtering


Created with:
  gclient setdep -r src/third_party/perfetto@dc38c5209303

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I129335de9ed5b2dadbe748bf7d199b872625062e
Reviewed-on: https://chromium-review.googlesource.com/c/1305895Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603708}

BOOKMARK_BAR_HEIGHT gives the height of the bookmark when attached so
giving an additional pixel here to the vertical margin of the bookmark
bar.
This makes it so there are the same number of pixels above and below
each button on the bookmarks bar when the bookmark is attached.

Bug: 865555
Change-Id: I271bfb7f48ef2faa390a8c9ae595c165dbc0bde9
Reviewed-on: https://chromium-review.googlesource.com/c/1280928Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603707}

This div needs min-height: 0 after crrev.com/c/1269235

R=rdevlin.cronin@chromium.org

Bug: 899177,899178
Change-Id: Ia000eb4f22b21247743986b81ae3190322d2c63e
Reviewed-on: https://chromium-review.googlesource.com/c/1306033Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603706}

Introduce a new $mixin_append key to mixins. Values in the $mixin_append
dictionary must be lists, and will be appended to any existing items in
the corresponding key of the test specification.

Bug: 879806
Change-Id: Ibd51c679df1944bcc9f34a4acba47ee39a5f871d
Reviewed-on: https://chromium-review.googlesource.com/c/1306352
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603705}

We added some logs to analyze the crash, and the newly added crash dump verifies
the issue is caused by duplicate download Ids.
This CL works around the issue by skiping downloads with existing ids, and
reverts the crash dump change. This should only impact canary/dev channel,
and another CL to fix duplicate Id generation is in progress

BUG=898859

Change-Id: Iab5cf36bee1cdb97566872916a6b010d6be2ac3d
Reviewed-on: https://chromium-review.googlesource.com/c/1306241Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603704}

This reverts commit bbe71c7f.

Reason for revert: Caused win-asan test failure. See crbug.com/900041

Original change's description:
> [base] Harden base::JSONWriter::BuildJSONString
> 
> This change simplifies and hardens base::JSONWriter::BuildJSONString().
> It replaces the old base::Value API with the new one, thus implicitly
> replacing DCHECKs with CHECKs.
> 
> Bug: 859477
> Change-Id: I5aa68cbc1e5e241d7b7061da2fe7078ac2904ec8
> Reviewed-on: https://chromium-review.googlesource.com/c/1304477
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603508}

TBR=rsesek@chromium.org,jdoerrie@chromium.org

Change-Id: I526bc8497110b99c5904ae61e4672514047f7412
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 859477
Reviewed-on: https://chromium-review.googlesource.com/c/1306954Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603703}

BUG=internal b/117626741

Test=Cast from Google Play Movie to nexus player.

Change-Id: Ibd4e50dd10f6abf538f2f5a76cb50b802aa47f62
Reviewed-on: https://chromium-review.googlesource.com/c/1297355
Commit-Queue: Ziyang Cheng <ziyangch@chromium.org>
Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603702}

Converting databases() wpt tests to promise_tests to fix flakiness

Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=899085
Change-Id: I91848796d7508408bb3e5b9fb05f725564fa9971
Reviewed-on: https://chromium-review.googlesource.com/c/1299959Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Chase Phillips <cmp@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603701}

Changes TestBluetoothAdapterClient::Properties to save Set callbacks if
there is no next response set. Just like in real devices, these
callbacks are run after the adapter gets removed.

Also adds a test to make sure that when the adapter gets removed during a
SetPowered call the state is correctly updated and there are no extra
State Changed events.

Bug: 896113
Change-Id: Iecc55cc2a8f4b2ff4d93fcacfd5e1a64095b2b7d
Reviewed-on: https://chromium-review.googlesource.com/c/1304033
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Ovidio Henriquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603700}

Bug: 838290
Change-Id: I60e56e959e22a67018d200f8158e837ec8e9a3c8
Reviewed-on: https://chromium-review.googlesource.com/c/1305202Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603699}

This reverts commit 37618e14.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 603544 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMzc2MThlMTQyMDg1MzMxYTc5MmI4M2JkYzE0ZmNjMDcxNzZmNWU5Mww

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.13%20Tests/6189

Sample Failed Step: browser_tests on (none) GPU on Mac

Sample Flaky Test: PictureInPicturePixelComparisonBrowserTest.VideoPlay

Original change's description:
> Reland "Enable the pixel by pixel comparison test for Mac OS."
> 
> This is a reland of 01ccf727
> 
> Original change's description:
> > Enable the pixel by pixel comparison test for Mac OS.
> > 
> > 1. Tested on Mac and verify everything works as expected.
> > 2. Removed the unnecessary call of GetNativeWindow().
> > 
> > Change-Id: I377e6bfb004548887b9623b0094da91fa36b4d1c
> > Reviewed-on: https://chromium-review.googlesource.com/c/1279301
> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> > Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#601879}
> 
> Change-Id: Ib6fa1c1d9b3487c88b240ea9262042db8af0c19a
> Reviewed-on: https://chromium-review.googlesource.com/c/1296811
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603544}

Change-Id: Ic8b96d7904653b5f68c5660f045dca15206ac2fe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 900035
Reviewed-on: https://chromium-review.googlesource.com/c/1306785
Cr-Commit-Position: refs/heads/master@{#603698}

Part of a bigger refactor to change how tests work. Currently tests
perform the following steps:

1. Set the next response to a BlueZ method call
2. Call a method that will call the BlueZ method
3. Check that the BlueZ method was called the right number of times
4. Apply the values that were passed to the BlueZ method

With this approach, we have no control over when BlueZ replies and
we don't know what values were passed to BlueZ until after we apply
them.

This CL address the second problem by exposing a GetSetValueForTesting
method in dbus::Property and adding a GetLastSetPoweredValue() method
to tests that use GetSetValueForTesting to test that the BlueZ method
was called with the right value. Now that we don't need to apply the
`set_value` to know what it was, we can remove
SimulateSetPoweredCompleted.

A follow up CL will address the first problem. In the end tests should
perform the following steps:

1. Call a method that will call a BlueZ method
2. Check that the BlueZ method was called the right number of times
3. Check that the BlueZ method was called with the right value
4. Simulate the BlueZ method replying

An added benefit of this approach is that we can simulate other
operations, like the adapter getting removed, between steps 1.
and 4., something that happens often in real devices.

Bug: 870192
Change-Id: I0c2cfc90a84d6d79b158804264c0e93664310a08
Reviewed-on: https://chromium-review.googlesource.com/c/1298818Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Ovidio Henriquez <odejesush@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603697}

Bug: 897502
Change-Id: If4e9c315c5742be40764e9a13f0d002acb96a43e
Reviewed-on: https://chromium-review.googlesource.com/c/1305821
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603696}

This way, if a client is too slow we'll inject the next event. I have no
doubt we will need more sophisticated things, but this is a start to ensure
we don't get entirely wedged.

BUG=none
TEST=covered by test

Change-Id: If4c233431be3239476227fc0271a5bc18cfff479
Reviewed-on: https://chromium-review.googlesource.com/c/1303353
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603695}

This reverts commit 86259392.

Reason for revert: Breaks webview https://crbug.com/899656

Original change's description:
> [Android] Remove most resource names in resources.arsc
>
> resource names are stored in the resources.arsc file to allow for
> getIdentifier with the string name of the resource to work. This cl
> obfuscates all of those resources to one name (and thus stored only
> once) for all resources that are not accessed via getIdentifier.
>
> This improves binary size by about 200KB.
>
> Bug: 894208
>
> Change-Id: I28c440c22b90cd045f53017073fdb88c7410d530
> Reviewed-on: https://chromium-review.googlesource.com/c/1265897
> Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
> Reviewed-by: Richard Coles <torne@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603229}

TBR=torne@chromium.org,tedchoc@chromium.org,agrieve@chromium.org,mheikal@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Binary-Size: This is a revert. A reland is coming soon (TM).
Bug: 894208
Change-Id: I29e9dc851fcd45e4ad657d055ac2db0514a9563d
Reviewed-on: https://chromium-review.googlesource.com/c/1305693
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603694}

This reverts commit 03b56190.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 603619 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMDNiNTYxOTBmZjU1Yjg3NmRjMWI0YTEzOTg5MzAxNTQyNDBhMzE3MAw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20%281%29/44916

Sample Failed Step: network_service_interactive_ui_tests

Sample Flaky Test: NativeWindowOcclusionTrackerTest.SimpleOcclusion

Original change's description:
> Native window occlusion tracking for windows.
> 
> This implements native window occlusion tracking on windows, under flag/experiment control. It uses WinEvent event hooks and EnumWindows to track and calculate occlusion.
> 
> It is not yet hooked up to the code that treats occluded windows differently.
> 
> Bug: 813093
> Change-Id: Ic9b473b8cad38e7b1653566f28917164bc92e21c
> Reviewed-on: https://chromium-review.googlesource.com/c/1140752
> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603619}

Change-Id: Ib25fedcac09b39cda2b5df277febc3cfd12d6eba
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 813093, 900025
Reviewed-on: https://chromium-review.googlesource.com/c/1306841
Cr-Commit-Position: refs/heads/master@{#603693}

https://google.github.io/styleguide/cppguide.html#Namespace_Names
> Namespace names are all lower-case.

This CL has no behavior changes.

Bug: 889726
Change-Id: I3a5ba338aea36aa40c1d727862996b6706560097
Reviewed-on: https://chromium-review.googlesource.com/c/1303321
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603692}

This reverts commit 9d157bc0.

Reason for revert: New behavior is not good, see bug/thread.

Original change's description:
> Update VolumeController behavior for hardware keys
> 
> Changing behavior as requested, and updating tests:
> 1) The mute button should toggle mute (rename mojo function).
> 2) Volume up/down buttons should adjust up/down normally when muted.
> 3) Volume up/down buttons should also un-mute (if above default mute level).
> 4) Volume down will still mute if the level is below the default mute level.
> 
> Bug: 895550, 895552
> Change-Id: I353ab3124bb0375f109b96841cce6df3c9839388
> Reviewed-on: https://chromium-review.googlesource.com/c/1289990
> Commit-Queue: Michael Wasserman <msw@chromium.org>
> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#601191}

TBR=msw@chromium.org,tsepez@chromium.org,afakhry@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 895550, 895552
Change-Id: I6f4000a832bd0230f4da6a21e40b17b13b3823d2
Reviewed-on: https://chromium-review.googlesource.com/c/1306407Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603691}

This CL checks CENC-v3 instead of CENC-v1. See Bug for more details.

Bug: 899984
Test: Tested manually.
Change-Id: I860ebae0657f76af91e7346524fdbb8b16f42f89
Reviewed-on: https://chromium-review.googlesource.com/c/1306635Reviewed-by: Rintaro Kuroiwa <rkuroiwa@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603690}

This reverts commit 60b53b5d.

Reason for revert: Bot is drained, can re-add to CQ. 

Original change's description:
> Remove win10_chromium_x64_rel_ng from the CQ
> 
> This bot is totally broken at the moment. Remove it so it doesn't block
> CQ.
> 
> TBR=jbudorick
> NOTRY=true
> 
> Bug: 899908
> Change-Id: Ie6eca4c1bf8a67821e5a6570a59255fc6a87f54d
> Reviewed-on: https://chromium-review.googlesource.com/c/1306396
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603611}

TBR=martiniss@chromium.org,jbudorick@chromium.org

Change-Id: I55af5ee2c7d1255f10de817a4f9a548793989a21
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 899908
Reviewed-on: https://chromium-review.googlesource.com/c/1306659Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603689}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bb933756..c3ca4c14

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I809e567e51fdcd9fca2489b355f8eeb8f358f1be
Reviewed-on: https://chromium-review.googlesource.com/c/1306340Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603688}

-Make REVERSE/FORWARD buttons have the same behavior as LEFT/RIGHT buttons.
-The internal part is in eureka-internal/187704

BUG=internal b/71719665

Test=cast movie from Google Play Movie and press the button on the remote.

Change-Id: If9ff5132851df7ac00e81fd5fcca73725b3c0307
Reviewed-on: https://chromium-review.googlesource.com/c/1150804
Commit-Queue: Ziyang Cheng <ziyangch@chromium.org>
Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603687}

Change-Id: I232f7daffacf8f6d49286336860e4251676a5afb
Reviewed-on: https://chromium-review.googlesource.com/c/1306176Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603686}

https://webrtc.googlesource.com/src.git/+log/a0677d14c17f..c640a936d166


git log a0677d14c17f..c640a936d166 --date=short --no-merges --format='%ad %ae %s'
2018-10-29 titovartem@webrtc.org Fix import of chromium into webrtc.


Created with:
  gclient setdep -r src/third_party/webrtc@c640a936d166

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:NONE
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I7fc39910d1e21a75a902a2e802d1bf2143f8e045
Reviewed-on: https://chromium-review.googlesource.com/c/1306217Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603685}

Add a custom view to use when showing a media
notification. At the moment this will just show
and hide the control buttons on hover.

BUG=897836

Change-Id: Ie6335b3fbff55e1f9d588cfbe3e95678fb0b8e1a
Reviewed-on: https://chromium-review.googlesource.com/c/1297246
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603684}

RenderProcessHost::FilterURL performs some security checks whether the
URL coming from the renderer process is a valid one. In some cases it
rewrites the URL to about:blank to avoid committing URL that is not
valid for the renderer process.

This CL adds a #blocked reference fragment to the URL, so it is easier
to spot when this logic has taken effect and distinguish it from regular
navigations to about:blank URLs.

Bug: 866549, 899788
Change-Id: I35052fdec361e18fb081bcae4a19b3bf697d46a7
Reviewed-on: https://chromium-review.googlesource.com/c/1300395Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603683}

https://pdfium.googlesource.com/pdfium.git/+log/ea08d171755b..69066ab61e2f


git log ea08d171755b..69066ab61e2f --date=short --no-merges --format='%ad %ae %s'
2018-10-29 thestig@chromium.org Do bilinear interpolation for "huge" images.


Created with:
  gclient setdep -r src/third_party/pdfium@69066ab61e2f

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:898443
TBR=dsinclair@chromium.org

Change-Id: I34c4086a0d9b8099d765464b4967ec4832da293f
Reviewed-on: https://chromium-review.googlesource.com/c/1306214Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603682}

Bug: various
Change-Id: I794e714d9aaa0c119aa339008379a9c796507d64
Reviewed-on: https://chromium-review.googlesource.com/c/1305881Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603681}

Classes outside of //net should use
Network Quality Tracker instead of
Network Quality Estimator (NQE).

Change-Id: Iaf9d940c862f322f14eacb20391354e5cc7cb9cd
Bug: 878844
Reviewed-on: https://chromium-review.googlesource.com/c/1305203Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603680}

Drag & drop worked with an external mouse but failed on touchpad
devices, specifically Eve and Nocturne.

Touchpads generate ET_SCROLL_FLING_CANCEL events at the start of
a drag. This change has the AutoclickDragEventRewriter ignore
those events, which fixes behavior on the touchpads of nocturne
and eve.

Also resolves a TODO to ensure that drag & drops are completed
rather than leaving the UI in an odd state by not including the
mouse released event.

Finally, logs UMA only once per drag-and-drop.

Bug: 894907
Change-Id: I79cc178e701894881618514a0e3aa585721a2c41
Reviewed-on: https://chromium-review.googlesource.com/c/1306295Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603679}

This changes the type in the .pdl file to binary.
Wire representation remains as is, but now the protocol
layer handles the encoding / decoding into base64,
and we use protocol::Binary instead of std::string.

Relevant prereqs:
Supporting binary in .pdl files:
https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1285695
Rolled into Chromium / v8.

Add protocol::content::Binary to protocol_string{.h,.cc}.
https://chromium-review.googlesource.com/c/chromium/src/+/1280555

Bug: chromium:891377
Change-Id: Ifc38332ce49c12bb1082ee165de04caa18a7f1ae
Reviewed-on: https://chromium-review.googlesource.com/c/1303558Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603678}

These tests where marked as Fail: ToT crashed when running e.g. [1]
with chrome://flags/#enable-experimental-web-platform-features.

- Pixel_CanvasUnacceleratedLowLatency2D: is kept disabled on Android
because software compositing doesn't work at all; this test is
changed from Fail() to Skip() and bundled with similar expectations.
Other similar android-sw-compositor expectations are updated and
gathered in the same area for better reference (there are no plans
whatsoever to make this compositor mode work on Android)

- Pixel_CanvasLowLatency2D: I landed a fix recently for a crash
(crrev.com/c/1297469), with that the test works but produces a
sliiiightly different output (see e.g. the first row of [2]), so we
have to rebaseline the reference images. For that, the first step
is to mark the test as disabled for all platforms.

[1] http://htmlpreview.github.io/?https://github.com/chromium/chromium/blob/HEAD/content/test/data/gpu/pixel_canvas_low_latency_2d.html
[2] http://chromium-browser-gpu-tests.commondatastorage.googleapis.com/view_test_results.html?868948046954e7d06d97eb10544ea3b27b320953_android_marshmallow_arm64_rel_telemetry

Bug: 865957
Change-Id: I45ccbc0a674cb6eb51f622d7c7af039162a2c071
Reviewed-on: https://chromium-review.googlesource.com/c/1294870Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603677}

We should not send out cached devices in the first place.
Double bugs involve here:

At the beginning of human history:
We call SendCachedDevicesFound() whenever we start discovery.
However, SendDevice() doesn't really send cached devices,

until I fix it in crrev.com/c/1105559......

But the problem is, in the first place, cached (inactive) devices
are not supposed to be reported in a discovery session.

Also note that DeviceFound() is completely independent from
LEDeviceFound(). If bluetooth service doesn't give an implementation for
DeviceFound() (which is not likely), it could still provide an
implementation for LEDeviceFound(), and LEDeviceFound() should still be
called in this case.

BUG=chromium:885339
TEST=manual test

Change-Id: Id97acd40fad19e4ee5a3ed64792a0598dce46ea7
Reviewed-on: https://chromium-review.googlesource.com/c/1303253Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Qiyu Hu <qiyuh@google.com>
Cr-Commit-Position: refs/heads/master@{#603676}

NOTRY=true
TBR=perezju@chromium.org
CC=perezju@chromium.org
BUG=899856

Change-Id: Idc6765a377b206722600f42b8127665bd524be51
Reviewed-on: https://chromium-review.googlesource.com/c/1306775Reviewed-by: Paul Miller <paulmiller@chromium.org>
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603675}