- 30 Dec, 2019 40 commits
-
-
Chris Harrelson authored
Change-Id: I2f3666162db095bcef150bc85f1a84ab338d9c79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979630Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#727786}
-
Kurt Horimoto authored
InfobarBannerOverlayCoordinator is a coordinator that will be shared amongst all infobar banners. InfobarBannerOverlayMediator is a superclass that implements behavior shared amongst all InfobarTypes, such as setting the consumer, dispatching responses for user interaction events, and setting up the overlay completion response. This CL also introduces the response infos necessary for banners: - InfobarBannerConfirmButtonTapped is dispatched to notify the model layer that the main button on a confirm infobar banner was tapped. - InfobarBannerModalButtonTapped is dispatched to notify the model layer that the modal button was tapped. - InfobarBannerCompletion is used a completion response and stores whether the dismissal was user-initiated. Bug: 1030357 Change-Id: Ic08d76cb6b65638ebf26986116f5afd960251277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970551 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#727785}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dc5a6b58d2c1..576e75e99e18 Created with: gclient setdep -r src-internal@576e75e99e18 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ia2faf1f39a4f7b38a531a669454316d4b58a3272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984343Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727784}
-
Xiaocheng Hu authored
Test failed on https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-full-configs/21231 Bug: 1037651 Change-Id: I982f6e49cccb46df2798fba5a89a77fea818ab37 NoTry: True Tbr: stkhapugin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984499Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#727783}
-
Shahbaz Youssefi authored
A change upstream required the presence of build_overrides/vulkan_headers.gni to determine the use of X11. This file already exists in ANGLE, but not in Chromium, which is added in this change. Bug: angleproject:4116 Change-Id: I387deaa26f3f97a66ba90e5e93b8151b999ad30b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981097 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#727782}
-
Andrew Grieve authored
Bug: 1036426 Change-Id: Id036e44db06732a837eae7f6d98c1c596a11fe5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984173 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#727781}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 81-3987.0-1577099071-benchmark-81.0.4005.0-r1 to 81-3987.0-1577099071-benchmark-81.0.4009.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ifce685f51b9bae6a832676ad9b3c8b8e672c8a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984459Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727780}
-
Sophie Chang authored
This change adds support for URL-keyed requests and hints to be provided by the optimization guide. Bug: 1036490 Change-Id: Ic261c776a9b8ec54158faff2ac90be81d5f8cd07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979350Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#727779}
-
Kaustubha Govind authored
This change adds a non-hermetic manual browser test to verify Chrome's DoH implementation against a handful of external DoH servers. The test loops through each server, and attempts to load a test URL. Fallback to Do53 is disabled, so a successful navigation indicates that DoH passed. A new setter set_allow_network_access_to_host_resolutions has been added to BrowserTestBase to allow browser tests to opt-in to using the full host resolver stack (instead of the mock host resolver). This mode then invokes SetAllowNetworkAccessToHostResolutions() on the NetworkServiceTest interface to disable the test host resolver. Bug: 1032710 Change-Id: I8e9e029e69a9e8281adb23e55179d9dd94707ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961006 Commit-Queue: Kaustubha Govind <kaustubhag@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#727778}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bf6e7836. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib5e78d0eaca596ecaf8d04d5f50552c15901aced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981098Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727777}
-
Xiaocheng Hu authored
Bug: 1038354 Change-Id: I03c38410a2bc277cd9a2083c26f32f508c7510fa Tbr: xiaochengh@chromium.org NoTry: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984461Reviewed-by:
-
David Bokan authored
This CL is a first step in making scroll offset animations work sensibly with the scroll latching logic of the compositor. In this CL we stop calling ScrollEndImpl from ScrollAnimated, ScrollAnimatedBegin and ScrollOffsetAnimationFinished so that animations don't clear the latched scroller (the |CurrentlyScrollingNode|). We inline the only remaining callsite into ScrollEnd. As a result of this change, we can now simplify the state of several scroll element id tracking variables. Since we no longer clear the latch at the end of a scroll animation, we can set these variables at a scroll begin and assume they will survive unchanged until a ScrollEnd is received. These are: |last_scroller_element_id_| is used to determine which scroller to send a scrollend event to. |scroll_animating_latched_element_id_| was previously used to relatch to the same scroller after an animation ends and another GSU arrives. This is now likely redundant and will be removed in a future CL. Similarly, |scroll_animating_overscroll_target_element_id_| was needed to know which element to send overscroll events to since they're sent when no scrolling is possible and thus the latch is cleared. Since we no longer clear the latch this can also probably be removed. For now, this CL keeps the above variables but simplifies their lifetimes. We also keep the re-latching logic in ScrollAnimated but ensure it re-latches to the same node if we're already latched. A future CL will clean this up so that ScrollAnimated can assume a node is already latched. Bug: 996537,940508 Change-Id: I84d5e74ab174043576e829f85b60f269ae21966b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981066Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#727775}
-
Jérôme Lebel authored
Second part of crrev.com/c/1967491 Moving all accessibility identifiers in ui/settings/google_services into ":constants" target. Bug: 866147 Change-Id: I4eda0aeeb77f54e89e9db8dcb329b2660437d4f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967190 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#727774}
-
Xiaocheng Hu authored
Bug: 1038351 Change-Id: I22dcbecad69c604136d0fccf4372238556ce2559 Tbr: tienmai@chromium.org NoTry: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984353Reviewed-by:
-
Caleb Rouleau authored
performance test suite is failing here https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/80918 the issue is that we assume that the file will be named .exe, but it isn't sometimes. I revert the changes that were made to the shard map in this change and turn off the unittests that depended on the old version. R=adithyas@chromium.org Bug: 1024767 Change-Id: I0a732dd7c3c35a096ea40b65d43f246513a8913a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984175Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#727772}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I98867c7ae88b31e35a56f1585a98a80d4ccdabc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982148Reviewed-by:
-
haozhe authored
Chrome passed all tests Firefox passed all tests other than background-size-composition Bug: 1034538 Change-Id: I0588c7e06c4ef1d545a88098e6dd4af74eb906d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972812Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Hao Sheng <haozhes@chromium.org> Cr-Commit-Position: refs/heads/master@{#727770}
-
haozhe authored
Chrome pass all tests Firefox does not support hanging: https://bugzilla.mozilla.org/show_bug.cgi?id=784648 Bug: 1034538 Change-Id: Ic60846b2e439eb325c682b01376ac0805f0b6a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976494Reviewed-by:
-
Boris Sazonov authored
This CL revises how ProfileOAuth2TokenServiceDelegate is keeping track of the list of accounts that have been advertised to the native code by OnRefreshTokenAvailable. Before, the persistent storage on the Java side was used. Now, a simple instance variable on the C++ side is used instead. Bug: 1006772 Change-Id: I4bb7ddec56f387d332abdef6d1b5c43add617207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983225Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#727768}
-
haozhe authored
Chrome passes all the tests Firefox failed the offset-position composition(https://bugzilla.mozilla.org/show_bug.cgi?id=1559232) Bug: 1034538 Change-Id: I245a6d8e9da8252aed7f5d76ddfbadd052813fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974690Reviewed-by:
-
Evan Stade authored
Convert a condition/early out to a DCHECK. There should always be a URL pattern, because an extension that has a content script but no URL pattern ("matches" in the manifest) fails to load. This conditional has been there since user_script_listener.cc was added ~10 years ago, but I don't think it's possible to fail. That said, this check failing is the only logical way I can see the other DCHECK (the one causing the bug) might fail, so adding it might shed light on the cause of the bug. Bug: 1036028 Change-Id: Id91dcf66cb0d02f134cc2a7de7b2003d20b4e621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977240Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#727766}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f04938adfc40..7449dc8a7f22 git log f04938adfc40..7449dc8a7f22 --date=short --first-parent --format='%ad %ae %s' 2019-12-30 lalitm@google.com trace_processor: remove RowId type from trace_processor Created with: gclient setdep -r src/third_party/perfetto@7449dc8a7f22 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0bf5c14651b64097e0a7c211d8b71c5380aedebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982147Reviewed-by:
-
Xiaocheng Hu authored
[Sheriff] Mark virtual/gpu-rasterization/images/exif-orientation-image-document.html as flaky on Mac Sample flake: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Mac10.13%20(retina)/23669 Bug: 1037798 Change-Id: I686ecb3eb070277ff755c44d20a089197d343e25 NoTry: True Tbr: xiaochengh@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984419Reviewed-by:
-
Adithya Srinivasan authored
Bug: 1038342 Change-Id: I9189f756a00b8f5a170c5c76a956340e4aef4968 Tbr: jamescook@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984174Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/96464fc25283..fe2d3c73348b git log 96464fc25283..fe2d3c73348b --date=short --first-parent --format='%ad %ae %s' 2019-12-30 reed@google.com SkBlurMaskFilter.h is only needed for (deprecated) emboss Created with: gclient setdep -r src/third_party/skia@fe2d3c73348b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I3e16961be7be1186168d4bc4281e25830663103f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982145Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5b94048566ab..471dda709844 git log 5b94048566ab..471dda709844 --date=short --first-parent --format='%ad %ae %s' 2019-12-28 fqj@chromium.org config: build betty-arcvm-master for vmmst-android-pfq 2019-12-28 chrome-bot@chromium.org Update config settings by config-updater. 2019-12-28 saklein@chromium.org query_build_logs: fix builder link and row order. Created with: gclient setdep -r src/third_party/chromite@471dda709844 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I589d9c01e995146da794e2eb5f6059675a7ba4b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984341Reviewed-by:
-
Kaustubha Govind authored
This method is needed to allow tests to exercise the full host resolution manager stack. Bug: 1032710 Change-Id: Ib302caa9e1eb2438e63a5a144a8e50a51eb094e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980759Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
-
Caleb Rouleau authored
R=adithyas@chromium.org NOTRY=true Bug: 1024767 Change-Id: I722ea30fe7b9d32f24cb6325102144ea455879d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984172Reviewed-by:
-
Tricia Crichton authored
The tests for javascript atoms in chromedriver/js have not been part of any automated test script. This cl adds them to the python test script. Bug: chromedriver:3280 Change-Id: I8b1292212df9c7c096489d17dffe312dea14168f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970552 Commit-Queue: Tricia Crichton <triciac@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#727758}
-
David Bokan authored
Currently, when a scroll offset animation is created, we set the currently scrolling node to the node we're animating (i.e. we "latch" it). Conceptually, the latch should be controlled by the gesture events sent by the browser. This CL removes this latching from the animation system. As a side effect, this means animations on the inner viewport scroll layer no longer latch to the inner viewport but the outer (hence the removed DCHECK). This was actually a bug since any scrolling against either viewport should latch to the outer viewport but I'm not sure if this manifests in any real way. See the comments in LTHI::GetNodeToScroll for how viewport scroll nodes are typically latched. This was broken off from the followup https://crrev.com/c/1981066 where we stop calling ScrollEndImpl to unlatch at the end of scroll animations. Without this change we would incorrectly remain latched to the inner viewport layer and causes a failure in the unit test: LayerTreeHostImplTimelinesTest.ImplPinchZoomScrollAnimated Bug: 996537,940508 Change-Id: I18f39bb6d2cfe6e2821f69315b08bd24e56a0882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981065 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
-
Tricia Crichton authored
Enable 2 selenium tests that are marked as not implemented but that pass in our environment. Bug: chromedriver:3199 Change-Id: I9968f64ae5613992f2652ae8a6ef21af2c1acc9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982715Reviewed-by:
-
Andrew Grieve authored
Follow-ups from fe1d5a12. * Added missing flush() * Fixed apk / arch being swapped in regex * Fixed index.html .value vs .checked mixup * Mark --platform as obsolete as well. TBR=agrieve Bug: None Change-Id: Id913e47fa6ba0711c1e4292a724c3a04efa52729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984171Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7c095dc67ce6..96464fc25283 git log 7c095dc67ce6..96464fc25283 --date=short --first-parent --format='%ad %ae %s' 2019-12-30 benjaminwagner@google.com Update Linux Vulkan SDK Created with: gclient setdep -r src/third_party/skia@96464fc25283 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I13580ace848bc2429c8138deb5b15be253dc8d94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984340Reviewed-by:
-
Adithya Srinivasan authored
Bug: 1038339 Change-Id: I9c881ec52be131d63923221737a86e8adb5eedbf Tbr: tienmai@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984169Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/10380c17f672..dc5a6b58d2c1 Created with: gclient setdep -r src-internal@dc5a6b58d2c1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: If005e9cae8a8edc044b8bbe86c1f3243068ce540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984339Reviewed-by:
-
Boris Sazonov authored
Fixes "add account" flow in AccountManagementFragment that was broken by https://crrev.com/c/1817607. Before: Activity is finished right after the preference is clicked. Thus, isResumed check in createAddAccountIntent returns false and the intent is not started. After: Activity is finished from createAddAccountIntent callback, so isResumed check passes. Bug: 1036777 Change-Id: Ieaf443adf586eb1dd5949eca021ee9b499201bb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982556 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#727751}
-
Dominick Ng authored
This CL moves infobar listener registration earlier, and makes it complete on all animation completions to try and deflake testBlockedAmbientBadgeDoesNotAppearAgainForMonths. BUG=1036413 Change-Id: I52cb9a621930c9668dacdb8a746e735203ca9560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980249 Commit-Queue: Peter Conn <peconn@chromium.org> Auto-Submit: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#727750}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3b53da373457..10380c17f672 Created with: gclient setdep -r src-internal@10380c17f672 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I1ed726b2e0ab373feda5560cafe2aae81b7452f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983517Reviewed-by:
-
Yuki Shiino authored
Fixes trivial bugs. - Wrong assertion in blink_v8_bridge.py - Support [Global=(Worklet, PaintWorklet)] - Enumeration type is included in "string types" Bug: 839389 Change-Id: Idaea55a6d827a4b816c4e844062eda6f253efb40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983113Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#727748}
-
Yuki Shiino authored
Reuses the same Mako template as long as the template text is the same. This patch reduces code generation time by around 20%. Bug: 839389 Change-Id: If8241ba70c2d572f5b6fd963f662193cc71450ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983115 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
