- 30 Jan, 2018 40 commits
-
-
Owen Min authored
This test verifies the policy value is read and copied to local_state properly in the early stage of browser launch on Windows. It's a test for the patch: crrev.com/615e458c. Bug: 806538 Change-Id: I5b150f7429f968312692123d5d40525c3ddbd9c6 Reviewed-on: https://chromium-review.googlesource.com/892043 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#533083}
-
Misha Efimov authored
Bug: 807283 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia61bdc85b5f700d58f88cc3093826d0a7e0ce014 Reviewed-on: https://chromium-review.googlesource.com/893681 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#533082}
-
Scott Graham authored
Per discussion on https://chromium-review.googlesource.com/884822, this is easier to work with for V8. Bug: 707030 Change-Id: Ida09715f35280652408e209a408c2012a5648479 Reviewed-on: https://chromium-review.googlesource.com/894042 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#533081}
-
Tien-Ren Chen authored
The contents clipping mask layer on the main graphics layer needs to be updated unconditionally because otherwise we can have dangling pointer to a destroyed mask when both the mask and the contents layer are destroyed at the same time. BUG=807240 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ica51387507232c20f1deacf9572546490f587eb9 Reviewed-on: https://chromium-review.googlesource.com/894194 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#533080}
-
Tetsui Ohkubo authored
Previously, |icon_view_| was created even if the notification does not have an icon, and changing is visibility by icon_view_->SetVisible(). However, ProportionalImageView always returns the fixed image size and FillLayout does not take visibility into account. As a result, |right_content_| always occupied the right side even if there is no icon. By this CL, the behavior is changed as follows: * When icon is available, * icon_view_->visible() always returns true. * right_content_->visible() may return false. (in case of use_image_for_icon) * When icon is not available, * icon_view_ is null. * right_content_->visible() always returns false. Before: http://screen/5KwSgEQQBaH After: http://screen/ym6upUfc1qc (Pressing Shift-Esc to show the notification) TEST=message_center_unittests BUG=785589 Change-Id: Ie3c133c82947681565cd07ddfada0c17a87dc591 Reviewed-on: https://chromium-review.googlesource.com/891079 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#533079}
-
Sergey Ulanov authored
The new port allows to run layout tests on Fuchsia. It starts QEmu with Fuchsia and then connects to it over SSH to execute content_shell. Bug: 778467 Change-Id: If14317553c7e605b3d1c693d006faf0120d214fc Reviewed-on: https://chromium-review.googlesource.com/876932 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#533078}
-
Hwanseung Lee authored
rename attributeStyleMap to styleMap at CSSStyleRule https://github.com/w3c/css-houdini-drafts/issues/572 https://github.com/w3c/css-houdini-drafts/pull/596 Bug: 807008 Change-Id: I8e5f140914783c074f73f75ed94312989e90e0ef Reviewed-on: https://chromium-review.googlesource.com/893239Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#533077}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/adcf8626..bde04194 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I4bca4066112a7b80bb7adf8e7596308690b8adac Reviewed-on: https://chromium-review.googlesource.com/894082Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#533076}
-
Bret Sepulveda authored
TBR=wjmaclean@chromium.org Bug: 807446 Change-Id: Icc31a390ab51e2b0819c55cd6336df779ffda2c4 Reviewed-on: https://chromium-review.googlesource.com/894501Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#533075}
-
Jeremy Roman authored
If so, the exception stack trace is printed (this is identical to JNI ExceptionDescribe, which also looks up and calls printStackTrace). Exceptions which indicate a bug in the browser-side implementation are rethrown as runtime exceptions. Bug: 794320 Change-Id: Ib33a17aae5e5a77cf45c24e055bfb6a097094324 Reviewed-on: https://chromium-review.googlesource.com/893542Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533074}
-
Kyle Horimoto authored
Before this CL, we allowed 3 retries for the entire connection flow, which includes advertising, scanning, creating a GATT connection, and exchanging messages. However, it makes more sense to think of this as a two-part process: (1) Advertising and scanning. This portion always occurs when attempting a BLE connection, even if the device we're trying to contact is not nearby and cannot respond. (2) Creating a GATT connection and exchanging message. This portion only occurs when an Android host is nearby to respond to the Chromebook. Connection attempts which fail in part (2) above indicate that the device actually is nearby and can potentially connect; additionally connection failures during this part of the connection often will succeed on a retry. Thus, this CL adds extra connection retry attempts if a previous attempt failed in part (2). Bug: 805218, 672263 Change-Id: Ifbedc004b96905d3f77662c45bcf2a9210b06c57 Reviewed-on: https://chromium-review.googlesource.com/889991Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#533073}
-
Christopher Cameron authored
Fullscreen low power mode (which is triggered by use of AVFoundation) is causing 10.11's WindowServer to crash. Bug: 806506 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I40cfdfbd932be56cf0078c91cad824ee6895f9b6 Reviewed-on: https://chromium-review.googlesource.com/892097Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#533072}
-
Eugene But authored
ExabyteResponse is almost never ending response (with an Extabyte content-length). This response will be used in iOS tests, so it is useful to make it default. Bug: 614168,789585 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie0edb7bbfc427bb83dc8bfbc9e143d1cd0e890e7 Reviewed-on: https://chromium-review.googlesource.com/890300 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#533071}
-
Alexander Timin authored
Require an enum to be passed to Platform::CreateThread specifying the type of thread which is requested to be created. This allows recording metrics around thread cpu usage. R=haraken@chromium.org,hajimehoshi@chromium.org,nhiroki@chromium.org BUG=776416 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ie1855c52ab2259738fdc91ad3af89c476904c7bf Reviewed-on: https://chromium-review.googlesource.com/888920 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#533070}
-
Stephen McGruer authored
These cases were discovered whilst adding a deprecation warning for the use of '#' symbols in data URI bodies. For a '#' to exist inside the body, it must be escape as '%23'. Bug: 123004 Change-Id: If2e52db6c86d2610ecd0d4e175644494e18f47fc Reviewed-on: https://chromium-review.googlesource.com/889718Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#533069}
-
Jinsuk Kim authored
This CL moves Java TextSuggestionHost to be managed by WebContentsUserData so ContentViewCore doesn't have to keep a reference to the object, and the object can be obtained easily by TextSuggestionHost.fromWebContents(). It helps decouple the class from CVC. Bug: 789000 Change-Id: Iefdeb0a727fc975323b7f8f24d4eb187ad38601b Reviewed-on: https://chromium-review.googlesource.com/892180Reviewed-by:
Ryan Landay <rlanday@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#533068}
-
Jérôme Lebel authored
With a MDCButton, the font should not be set on the title label, but on the button itself, using: -[MDCButton setTitleFont:forState:] Bug: 803767 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4232f2d080daca4e8fc2e585d51c24c1b10ab1ac Reviewed-on: https://chromium-review.googlesource.com/891221Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#533067}
-
Anna Offenwanger authored
Adding the line to enable automatic bug filing for when WPTs are pulled from upstream into the xr folder and are failing. Change-Id: Idc24b4d610ceaa706c7d7fe12a35a8ff39775b43 Reviewed-on: https://chromium-review.googlesource.com/875249Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Cr-Commit-Position: refs/heads/master@{#533066}
-
Misha Efimov authored
- Use base::BindOnce instead of base::Bind. - Add ShutdownQuicTestServerDispatcher to trigger network errors without shutting down the server. - Don't spam test log with bidirectional_stream state. - Fix lint warnings. Bug: 714018 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4baf1f1e8718d4b5cc21f5664ee2dd1cc0bfa83d Reviewed-on: https://chromium-review.googlesource.com/890058 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#533065}
-
Jungshik Shin authored
Bug: 734093 Test: None Change-Id: I49be629d3d0afe2e329fd4fada263d7746e23e5e Reviewed-on: https://chromium-review.googlesource.com/892287Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533064}
-
Jeremy Roman authored
This doesn't require special support, since the java.lang.reflect API allows calling static methods the same way as instance methods. Bug: 794320 Change-Id: Id9064ec69b6cbdbe23576fa1f3e5d5e0e2c30677 Reviewed-on: https://chromium-review.googlesource.com/894465Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533063}
-
Theresa authored
- Update the toolbar shadow and use alpha animation instead of transition drawable for url focus - Fix composited url bar alpha to prevent C++ url bar background from being drawn - Remove top padding in suggestions list when modern is enabled BUG=803088,803618 Change-Id: I848c1168ef26955a2eeb9b81738941f5fa886dd4 Reviewed-on: https://chromium-review.googlesource.com/893530 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#533062}
-
Matt Menke authored
Also convert net::FileStreamContext to use it, as a sample use case with few consumers. This CL does not add a OnceCallback version of TestCompletionCallback, as the repeating version works for use with methods that take OnceCallbacks. I think not creating a new test class will make updating interfaces take a lot less effort. Also, I expect that all net::CompletionCallbacks are effectively used as OnceCallbacks, so we can make TestCompletionCallback return OnceCallbacks when/if we ever finish converting all of net to use CompletionOnceCallbacks. Bug: 714018 Change-Id: Iec76deae075b32fe0c65eb18596859f5e6413647 Reviewed-on: https://chromium-review.googlesource.com/853092 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Randy Smith <rdsmith@chromium.org> Cr-Commit-Position: refs/heads/master@{#533061}
-
Tien-Ren Chen authored
The DCHECK in SVGElementProxy::IdObserver::ContentChanged() is too restrictive. The document is only vulnerable to mutation during paint or pre-paint, but should be safe to mutate once the update is done. BUG=807159 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: If9f795e0ac55d204d5f165221af2453b54eda6a5 Reviewed-on: https://chromium-review.googlesource.com/894189Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#533060}
-
Carlos Knippschild authored
This change adds new and improves existing code instrumentation for tracing reports. They should help both with performance tracking and memory usage investigation. Bug: 806137, 793109 Change-Id: I45fd4ef567e83c174d09cf41424a961c13adaf23 Reviewed-on: https://chromium-review.googlesource.com/888087 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#533059}
-
xlai authored
As a follow-up CL to the hot fix https://chromium-review.googlesource.com/876528, this newly added unit test verifies whether canvas restores its matrix clip stack after the image is drawn from old canvas2d bridge to the new canvas2d bridge. Bug: 803950 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I129525cad9835f415ac594351ba720d48c63979d Reviewed-on: https://chromium-review.googlesource.com/888093 Commit-Queue: Olivia Lai <xlai@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#533058}
-
Artur Khachatryan authored
Bug 764519 was fixed so relevant disabled tests are now enabled by this commit. Bug: 764519 Change-Id: I1af80b6ecbbf9548aeae8d5ab08641180dde9f2c Reviewed-on: https://chromium-review.googlesource.com/894263Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#533057}
-
Trent Apted authored
This CL just removes some includes that aren't used. CrOS-style shadows are planned for more parts of the Chrome UI - parts the window manager doesn't have good control over. So some files may need to move. Bug: 801583 Change-Id: I1a5a31908ae74ce373198e16dfa2809d4d60023a Reviewed-on: https://chromium-review.googlesource.com/892585Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#533056}
-
https://chromium.googlesource.com/angle/angle.git/+log/13fd988cf71d..bd6ae4aa145d $ git log 13fd988cf..bd6ae4aa1 --date=short --no-merges --format='%ad %ae %s' 2018-01-29 geofflang Vulkan: Don't create zero-sized textures. 2018-01-29 geofflang Vulkan: Allow dEQP to create Vulkan displays. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Id9edf6124da72fb34024573b59d68f20311f7d54 Reviewed-on: https://chromium-review.googlesource.com/894266Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533055}
-
Sammie Quon authored
Test: unit_tests AboutFlagsHistogramTest.CheckHistograms Bug: 782320 Change-Id: I9b75d6e9b9e018b86a8d011653f02887e2a68f1e Reviewed-on: https://chromium-review.googlesource.com/889920 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#533054}
-
Chris Harrelson authored
This may happen if children acquire scrollbars. Change-Id: Iafd48e0f1afc927e8723f3a2f57b6dddf3157fd1 Reviewed-on: https://chromium-review.googlesource.com/889904Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#533053}
-
Dave Schuyler authored
This CL fixes a comment about scaling. In the process of making that several presub/lint adjustments were also made. (code health) Bug: None Change-Id: I29b2f8ad2260aa303be22135248978f97ff5abc8 Reviewed-on: https://chromium-review.googlesource.com/889990Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#533052}
-
Darren Shen authored
Removes .tentative extension from CSSUnparsedValue WPT. Also adds a interface IDL test, which is currently failing because Blink doesn't implement Array.values. Bug: 774887 Change-Id: Ia59af546f72a1a664e16cb708dce3e97dfec75ea Reviewed-on: https://chromium-review.googlesource.com/892583Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#533051}
-
Istiaque Ahmed authored
The delegate used to create separate code paths in ContentVerifyJob, which makes the code harder to read and also creates a parallel reality in tests. Remove it entirely since tests using the delegate can work with the TestObserver in ContentVerifyJob. Remove two tests: ContentVerifierTest:FailOnRead/FailOnDone, that heavily used the TestDelegate. These tests were *artificially* (different from how production code does) creating error conditions from ContentVerifyJob::BytesRead and ContentVerifyJob::DoneReading. Extract test utilities related to content verification to a separate file (e/b/content_verifier/test_utils.h) Bug: 796395 Change-Id: Ib59e9f0c7a4aac9b6a883d7f42647cecc603fa79 Reviewed-on: https://chromium-review.googlesource.com/888327 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533050}
-
Alexei Svitkine authored
Previously, it was querying the StatisticsRecorder directly, which is not recommended. Use the HistogramTester helper class which is exactly for this purpose. Bug: None Change-Id: I820716f31a96c31540cea14576db616361c63f96 Reviewed-on: https://chromium-review.googlesource.com/894489Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#533049}
-
Penny MacNeil authored
Remove using very specific names like whitelist/blacklist. Make file and code names more generic where it should be. TBR=dcheng@chromium.org TEST=chrome_elf_unittests.exe, ThirdParty* BUG: 769590 Change-Id: I9f4d43825b1ba256ff18061b69ecba070d62c975 Reviewed-on: https://chromium-review.googlesource.com/890118 Commit-Queue: Penny MacNeil <pennymac@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#533048}
-
Mike Wasserman authored
Remove and destroy reflectors before closing and deleting hosts. (roughly: hosts own the surface that reflectors use for painting) Bug: 806353 Change-Id: Idcbfad0da19f1ccdeabb5d6851e6d55602fdaed1 Reviewed-on: https://chromium-review.googlesource.com/892054Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#533047}
-
Matthew Jones authored
Previously, the utility that tried to determine if the keyboard was showing used a magic number (100 dp). Despite what the code implies, this number accounts for both the top and bottom Android controls on screen -- status bar and bottom navigation controls. On notched phones the status bar is considerably larger; when added to the bottom controls, the logic breaks. This change updates the logic to determine the height of the status bar and does a best-effort to get the height of the bottom Android controls. If the difference in height of the app's viewport and window size is greater than the combined height of the controls, the keyboard might be showing. BUG=805030 Change-Id: Ie923549a0c6bcc0067f8d784250fbf273125bff9 Reviewed-on: https://chromium-review.googlesource.com/884829 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#533046}
-
Miguel Casas authored
This CL allows XR30 for GpuMemoryBufferVideoFramePool output format in Linux (not CrOs yet), and teaches GLImageMemory how to manipulate this format. Unittests are extended, tested also with high bit depth videos e.g.: 'http://crosvideo.appspot.com?codec=vp9.2&loop=true' and media/test/data/... - bear-320x180-hi10p-vp9.webm - bear-320x180-hi10p.mp4 (this is an H.264 part 10, 10bpc) - blackwhite_yuv420p_hi10p.mp4 - bear-320x180-hi12p-vp9.webm Bug: 803975 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie5fb3fa60036591fabdfcf774fcb0878b1ebca07 Reviewed-on: https://chromium-review.googlesource.com/881665 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#533045}
-
Mike Wittman authored
Change-Id: If1376c69b262c9112f8c3653feffebe961bd92b6 Reviewed-on: https://chromium-review.googlesource.com/894487Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533044}
-