GitLab

This CL limits the no. of rules that an extension can provide to 30000. If an
extension provides more rules than this limit, those rules will be ignored and
an install warning will be surfaced to the user upon installation on the
extensions page. These won't re-surface once the browser restarts for packed
extensions.

BUG=767977

Change-Id: I95c824f4233dd7c0b77393fa817522b9b1c70681
Reviewed-on: https://chromium-review.googlesource.com/1198010
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588257}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: I4912261d75761c9b914ba8cf4952d27a0b2f42bd
Reviewed-on: https://chromium-review.googlesource.com/1200586Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588256}

This patch creates file_manager_strings.grdp as collecting file
manager strings from chromeos_strings.grdp to manage
independently.

It also moves sha1 for file manager already added at
chrome/app/chromeos_strings_grdp to
chrome/app/file_manager_strings_grdp

It's wrapped in <if expr="chromeos"> at generated_resources.grd.

TEST=tested manually

Bug: 845818
Change-Id: I3741871b2fe9e0d0aec8da10caa7f4ab3f20363a
Reviewed-on: https://chromium-review.googlesource.com/1195173Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#588255}

Zero-copy NV12 will have to skip VideoProcessorBlt so split it out, and
cleanup some of the color space calculation logic as well.

Bug: 848093
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I260d2f060a957383054b46bdffdd2105baf2a896
Reviewed-on: https://chromium-review.googlesource.com/1171842Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588254}

When loading app_icon.png on Android P, upscaling doesn't occur until
after the image is drawn. As a result, if we try to show a lower DPI image
such as the mdpi icon, the Bitmap#getWidth/Bitmap#getHeight values will
only return the original image size on Android P. What we actually want is
the scaled image size. To do so we use
Bitmap#getScaledWidth/Bitmap#getScaledHeight which return the scaled image
size in pixels. This wasn't a problem on O and earlier since this scaling
occurred when the bitmap was loaded into memory (prior to rendering).

This CL is a follow up to https://chromium-review.googlesource.com/1148815

Bug: None
Change-Id: Ief90e97ad9f618db3e866222dc486a468e14bdfd
Reviewed-on: https://chromium-review.googlesource.com/1199494
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588253}

https://chromium.googlesource.com/angle/angle.git/+log/253038d8d13b..88fc6da3e28c


git log 253038d8d13b..88fc6da3e28c --date=short --no-merges --format='%ad %ae %s'
2018-08-31 jmadill@chromium.org Vulkan: Mega-refactor to VertexArrayVk.


Created with:
  gclient setdep -r src/third_party/angle@88fc6da3e28c

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: I54a50a240f08e58f74a8b429efbdd5be20b0db50
Reviewed-on: https://chromium-review.googlesource.com/1200168Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#588252}

This cleanup refactors content::ParseManifest(). The main outcome is
separating low-level string manipulation (previously using C-style
pointers) from the higher-level logic for interpreting manifest data.
The desired benefit is being able to easily reason about the (standard
and proprietary) AppCache features that Chrome supports.

The CL relies heavily on base::StringPiece for string parsing, which
uses a (start, length) representation. Updating this requires more work
than the previous (start, end) representation. The extra work should be
outweighed by the performance savings of the new approach.

* URLs are not re-encoded from std::wstring to UTF16.
* Keywords are encoded as static base::StringPiece instances, avoiding
  some strlen() calls.

Bug: 879224
Change-Id: Ia8ecdb9453a103b7c6bfed8bc80ecf159095afc5
Reviewed-on: https://chromium-review.googlesource.com/1192985
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588251}

This CL adds RecordHitTestData in LayoutReplacedPainter. Two layout
tests are added for SVG root and HTML image element cases.

Bug: 876468
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iea6a2318bcd7029b252ebccc92d62d93ad0b6c23
Reviewed-on: https://chromium-review.googlesource.com/1196914
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588250}

It's much easier to write:
  base::Erase(container, value);
  base::EraseIf(container, ...);
than:
  container.erase(std::remove(container.begin(),
      container.end(), value), container.end());
  container.erase(std::remove_if(container.begin(),
      container.end(), ...), container.end());

Bug: 875665
Change-Id: Iadfcce0915d215085d515e13b6faa745462d11b8
Reviewed-on: https://chromium-review.googlesource.com/1190403
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588249}

https://skia.googlesource.com/skia.git/+log/554ad9846a8b..6487e5ca6f10


git log 554ad9846a8b..6487e5ca6f10 --date=short --no-merges --format='%ad %ae %s'
2018-08-31 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/skia@6487e5ca6f10

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stephana@chromium.org

Change-Id: I19a7e711f429b039e23b305b1124983e626c3b36
Reviewed-on: https://chromium-review.googlesource.com/1199877Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#588248}

This CL is a follow up to https://chromium-review.googlesource.com/c/chromium/src/+/1195346
to clean up old "slide" names and move shared timing constants into
the HostedAppButtonContainer class instead of needing them to be
synchronised/passed around.

Change-Id: I717e4972b47ae8d0a0336c675b8a733efa2e2a22
Reviewed-on: https://chromium-review.googlesource.com/1198707
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588247}

Tremplin is the new way to start the crostini container. It provides
more feedback on the install progress of the container itself.

The old StartContainer stage of CrostiniRestarter is now replaced by
CreateLxdContainer, StartLxdContainer, SetUpLxdUserName in sequence. These
calls all have to wait until the Tremplin service itself has started in a vm.
As a result, StartTerminaVm now waits for Tremplin to start before calling the
callback.

Bug: 860094
Change-Id: If55406c2b665897aff97bebb5f3cbae2205d5550
Reviewed-on: https://chromium-review.googlesource.com/1170449Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588246}

Authorization via policy settings will be added in a follow-up CL before
enabling by default.

Bug: 860311
Change-Id: Ifadaa08b1a312f750654ebe51b862a8733b998a5
Reviewed-on: https://chromium-review.googlesource.com/1183195
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588245}

- Add a ShouldUseCompositor() helper function.
- Reduce the number of GetPrintPreviewUI() calls in the non-compositing
  path.
- Call PrintPreviewUI::ShouldCancelRequest() before compositing, to
  avoid doing work if the results are not useful.
- Make NotifyUIPreviewPageReady() and NotifyUIPreviewDocumentReady()
  check the data in a consistent manner.

Change-Id: Ia357e6ab1a7bf41a849445cf113aff071cae1b1c
Reviewed-on: https://chromium-review.googlesource.com/1188030
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588244}

This CL only handles the files in //content. The files in //net were
tackled in https://crrev.com/c/1188959. Parallel CLs will tackle other
directories.

net::IOBuffer is (thread-safe) ref-counted. Asides from improving the
ability to reason about instance ownership locally, creating instances
via base::MakeRefCounted makes it possible to use 1-based ref-counting
in the future (see base/memory/ref_counted.h).

This CL is mechanical, to avoid introducing any behavior changes. The
difficult cases will be tackled by follow-up CLs. The following
transformations were performed.

* new IOBufferType(args) => base::MakeRefCounted<IOBufferType>(args)
* new IOBufferType => base::MakeRefCounted<IOBufferType>()
* scoped_refptr x(base::MakeRefCounted<IOBufferType>(args)) =>
  scoped_refptr x = base::MakeRefCounted<IOBufferType>(args)
* scoped_refptr<IOBufferType>(base::MakeRefCounted<IOBufferType>(args)) =>

  base::MakeRefCounted<IOBufferType>(args)
* In comments: creates a new IOBufferType => creates an IOBufferType
  (so it wouldn't trigger future searches for "new BufferType")
* Instantiated static members in HttpResponseBodyDrainer,
  HttpNetworkTransaction, HttpProxyClientSocket, WritersTest,
  UDPSocketTest, TestDelegate, UDPSocketPerfTest
  (needed to fix linker errors)
* arraysize -> base::size (where needed to pass presubmit checks)
* git cl format

Change-Id: Ib3f9965fe92b84be3db88d0143a398079b812efd
Reviewed-on: https://chromium-review.googlesource.com/1200525Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588243}

The duplex setting is stored as bool, but the preset options are
setting it as if it is an enum. Fix this mismatch.

Bug: None
Change-Id: Ie2624f352b9e57d7946da2d58903dd606d7266db
Reviewed-on: https://chromium-review.googlesource.com/1199600
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588242}

Listen on the tile's keyup event instead of keydown event to prevent
opening "Add shortcut" dialog before releasing the spacebar.

Bug: 879167
Change-Id: Id7668562db1f3db47f5f484670f06b9080b34c6d
Reviewed-on: https://chromium-review.googlesource.com/1200403
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588241}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4259762b3597..e323bd9d2263


git log 4259762b3597..e323bd9d2263 --date=short --no-merges --format='%ad %ae %s'
2018-08-31 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-08-31 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-08-31 nodir@google.com [bot_update] Untie revision and repository properties


Created with:
  gclient setdep -r src/third_party/depot_tools@e323bd9d2263

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:877161,chromium:694348
TBR=agable@chromium.org

Change-Id: I2435f620a6af4d970ed09912de690acbafa7523a
Reviewed-on: https://chromium-review.googlesource.com/1199875Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#588240}

This follows up http://crrev.com/c/927701, mentioning that not all
requests have their priority pushed down to the lowest, but that
there is more granularity.

R=kinuko@chromium.org, tbansal@chromium.org

Bug: N/A
Change-Id: I6112d8fdf8948552acc0a188c75b89aa2ef8f425
Reviewed-on: https://chromium-review.googlesource.com/1200583Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Dominic Farolino <domfarolino@gmail.com>
Cr-Commit-Position: refs/heads/master@{#588239}

Appending entries to visible_rect_history was a hotspot in profiling.
Changing to std::deque, and re-ordering the update code so the deque
only grows to 2 entries rather than 3.

BUG=879668

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I576ba0ae278a04a0e7336b3b1cd589fadd25b177
Reviewed-on: https://chromium-review.googlesource.com/1200466Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588238}

This makes Consoles messages focusable and navigable using:
ArrowUp/Down/Left/Right, Home, End

Screenshot: https://imgur.com/a/6JWY0iU

Bug: 865674
Change-Id: I4166bf4d8d57856c6d1f7d51ef29e2dea0c088eb
Reviewed-on: https://chromium-review.googlesource.com/1144453
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588237}

https://chromium.googlesource.com/catapult.git/+log/b8e60f98418e..5167fb3f6694


git log b8e60f98418e..5167fb3f6694 --date=short --no-merges --format='%ad %ae %s'
2018-09-01 chiniforooshan@chromium.org Telemetry: latency metrics in TBMv2


Created with:
  gclient setdep -r src/third_party/catapult@5167fb3f6694

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:760553
TBR=sullivan@chromium.org

Change-Id: Ifa1bc9ed82007576631a28271769ef7b3a667cf9
Reviewed-on: https://chromium-review.googlesource.com/1200169Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#588236}

https://pdfium.googlesource.com/pdfium.git/+log/ca3a100e7dcf..a38996be8593


git log ca3a100e7dcf..a38996be8593 --date=short --no-merges --format='%ad %ae %s'
2018-08-31 tsepez@chromium.org Remove avail_buf out argument from GetAvailInput() methods.


Created with:
  gclient setdep -r src/third_party/pdfium@a38996be8593

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ibf88905a34a202949c3c4035930e72224a308708
Reviewed-on: https://chromium-review.googlesource.com/1199874Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#588235}

Changing the CSS setting and manually changing font family to Segoe UI
on Windows instead of depending on the automatic fallback on CSS.

Bug: 867778
Change-Id: I3c2fed3453639c6a8d1a4cb61cb88af3af33354b
Reviewed-on: https://chromium-review.googlesource.com/1200310Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588234}

This allows chrome://settings/inputMethods to show up-to-date IME
information without closing and reopening the settings window. For
example, when the language X is enabled on the device and a new
Chrome OS IME extension for the language X is installed, it'll
instantly show up in chrome://settings/inputMethods. The same happens
for Android IMEs installed via Play Store too.

BUG=867795,845079
TEST=Add 'Japanese' to the language list, open chrome://settings/inputMethods,
 install 'SKK Japanese Input' (extension IME) from Chrome Web Store, verify
 the IME entry ('SKK') shows up in the settings page immediately.
TEST=Go to extensions page, disable the SKK IME, verify 'SKK' disappears
 immediately.

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I20f7586cd58e7d6c6f92f37c1f0b697d57d17d32
Reviewed-on: https://chromium-review.googlesource.com/1198106
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588233}

Bug: 846740
Change-Id: I391e6d3d9eb7999be5c35bfccec39e36ada9812f
Reviewed-on: https://chromium-review.googlesource.com/1200317Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588232}

1) Do not show offline indicator UI on offline page
2) If the page is still being loaded, wait until it is done and
   then decide whether to show offline indicator UI.

Bug: 879705
Change-Id: I31f3df33ca19544b846e8cb60d2d1bc87c9b2439
Reviewed-on: https://chromium-review.googlesource.com/1138987
Commit-Queue: Jian Li <jianli@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588231}

This can occur if an error occurs before FFmpegGlue has been
created by the demuxer.

BUG=879400
TEST=none

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I35349e94ab7c8d164210f91073e05b50d3c58482
Reviewed-on: https://chromium-review.googlesource.com/1199772Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588230}

base: :MappedReadOnlyRegion is simpler to use than
base: :SharedMemoryHandle.
Change-Id: I3d00fdc56dc796f0a20724133cad8ade78107edf
Reviewed-on: https://chromium-review.googlesource.com/1186272Reviewed-by: Wei Li <weili@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588229}

Changes MediaSource's |attached_element_| from WeakMember to
Member, preventing collection of an element that is still attached by
MSE when either of them are still reachable by GC Trace.

This change also removes CloseMediaSource() from prefinalization of
HTMLMediaElement, since any still-attached MediaSource during
HTMLMediaElement's prefinalization is also not referenced by anything GC
Trace can reach.

BUG=856022
TBR=keishi@chromium.org,haraken@chromium.org

Change-Id: I464b89d67323bc6527aa6b7b5b11ce5cdf774756
Reviewed-on: https://chromium-review.googlesource.com/1199780
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588228}

There is no guarantee that the DocumentLoader is always attached [1],
so let's introduce null checks in StateInternal and setScrollRestoration.

[1] The DocumentLoader may be detached while FrameLoader::PrepareForCommit.

BUG=879477, 872672

Change-Id: I048ad8ff3787fcead262c19fcdb485e9e5a5e3bf
Reviewed-on: https://chromium-review.googlesource.com/1200075
Commit-Queue: Charlie Reis <creis@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588227}

Also remove legacy /WD4267 and replace with the compiler config.

Warnings being suppressed are here: https://pastebin.com/raw/QkwwCZLb

BUG=879657

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If145532f415cdcc4c52a48dc11f421171538b25d
Reviewed-on: https://chromium-review.googlesource.com/1199869Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588226}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/68de241167e0..ee3f5c44326d


git log 68de241167e0..ee3f5c44326d --date=short --no-merges --format='%ad %ae %s'
2018-08-31 ayatane@chromium.org sysmon: Fix name for lucifer process metric
2018-08-31 chingcodes@google.com signing: add Shellball extract and repack operations


Created with:
  gclient setdep -r src/third_party/chromite@ee3f5c44326d

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I2f8405f4c7ffce97fc371de76598a68cf35b8751
Reviewed-on: https://chromium-review.googlesource.com/1200373Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#588225}

We suspect the problem in issue879672 is caused when ComThread callback
for UWP device enumeration happens after VideoCaptureDeviceFactoryWin
instance is destroyed.
This cl is to try to stop running ComThread for UWP enumeration in the
dtor.

Bug: 879672
Change-Id: I622ff15815a0844833f87a5ba5390fc7c0e5ebd1
Reviewed-on: https://chromium-review.googlesource.com/1200465Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588224}

This CL updates the opening animation for hosted app titlebars to
match recent UI mocks by:
 - Removing the slide motion but retain the fade animation of the
   origin text.
 - Making the origin text bold.
 - Synchronising the fade durations of the origin text and app menu
   button highlight.

Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355048&signed_aid=mI6IiKwlkm5uzn4Cv6Asxg==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355049&signed_aid=bfJDeHt7BMIqsW1SYf3DRg==&inline=1

This CL only includes the minimal changes needed to update the
animation to be suitable for merging to M70. Further code clean
ups have been moved to: https://chromium-review.googlesource.com/c/chromium/src/+/1198707/1

Bug: 878187
Change-Id: I0938f124e39ebf113843e62d63d6a0b9dc4417cc
Reviewed-on: https://chromium-review.googlesource.com/1192463Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588223}

Form a recent crash report, it looks like the IAsyncOperation:GetResult
may return a null pointer. So add a null check for the result.

Bug: 879669
Change-Id: I9ab31df7b1ec165123a4f98683970f48f2bf3454
Reviewed-on: https://chromium-review.googlesource.com/1200318Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588222}

Bug: chromium:869747
Test: Unit tests pass
Change-Id: I40512bee8b797d2861e6492876e75bd36668fd58
Reviewed-on: https://chromium-review.googlesource.com/1199777Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Cr-Commit-Position: refs/heads/master@{#588221}

Replace the logic in ShelfView's overridden OnPaint with a simpler
view and rounded corners.

You can see a screenshot in comment #17 of the linked bug.

Bug: 874161
Change-Id: I416e670ca578e6fd5d4e7681c8c19acf2fa17c3a
Reviewed-on: https://chromium-review.googlesource.com/1198525Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588220}

This also rewrites some of the args logic in generate_buildbot_json.py
and allows for callers to supply additional keys containing args they'd
like to pull in (e.g. "gtest_args" for args that should apply only to
gtests).

Bug: 878321
Change-Id: I2314c90d5959f3cfdaa3898a2de1af2331d07002
Reviewed-on: https://chromium-review.googlesource.com/1197407Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588219}

Follow up to crrev.com/c/1189058, there were checks for
IsUnifiedConsentFeatureEnabled that were redundant, they were now
removed.

Change-Id: I388b738d2ab65f12556fa4595f7a93266250205f
Reviewed-on: https://chromium-review.googlesource.com/1199571Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588218}