GitLab

This CL addresses a leftover review comment from
crrev.com/c/2292868

Bug: 1093103
Change-Id: I8012c60f9a23108763e7da362a551e3c77e6d7a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300090
Commit-Queue: Carlos IL <carlosil@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Auto-Submit: Carlos IL <carlosil@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788881}

This CL:
- Re-enables the 'AndroidNullableCheck' and
'NoRedundantFieldInitCheck' errorprone compiler plugins
- Switches javax.annotation.Nullable imports to
androidx.annotation.Nullable
- Removes redundant member variable initializations

BUG=1104558
TEST=errorprone_plugin:tests

Change-Id: Id6196c7d89795fab490b7931f079f0cd03bbe71b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291984
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788880}

Change-Id: I8c25d4aa54853d67017d04e9e03c0cf955902a0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301179
Commit-Queue: Ender <ender@google.com>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Auto-Submit: Ender <ender@google.com>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788879}

A couple of notification related prefs are moved to
//components/content_settings. Their registration remains in //chrome
since other embedders don't use them yet.

Bug: 1071603
Change-Id: Ic43ea701619c3764db899b4965db6e414638f016
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288310
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788878}

Bug: chromium:1105298
Test: manual
Change-Id: I521b8a28b75a1419848417885bfcc5e710413657
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297070
Auto-Submit: David Munro <davidmunro@google.com>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788877}

DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the
case where nullptr is passed for the output argument, Value::RemoveKey()
is a trivial replacement.

Mostly done with the following command line, plus a bit of finesse:
% git grep -l RemoveWithoutPathExpansion | \
  xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g'

Bug: 646113

This CL was uploaded by git cl split.

R=mfoltz@chromium.org

Change-Id: Ic97ced471c5b8eee49b4aed96ffb776507cfec29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297213
Auto-Submit: Anand K Mistry <amistry@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Anand K Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788876}

Change-Id: Ifb00f645073821a1754c2bf8024c3e98368c098a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299939Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788875}

Roll Chrome Mac PGO profile from chrome-mac-master-1594835994-5147b08f1c93c88abb9731970c5f21d575c9bbcd.profdata to chrome-mac-master-1594857570-508aa514a52515f9e9dfbe5d476e51f86a549527.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome
Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com
Change-Id: Iae6bdc4cd642ff94f9574bbc6ef8b2f8b097b559
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301086
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#788874}

Link Doctor was a service that fetched suggestions on certain navigation
errors (e.g., typos in URLs, navigate to version in Google's cache,
etc). The feature has been disabled for some time now, and the
server-side service has been shut down. The disabled code is also using
an API that needs to be removed to deploy the backward/forward cache.
So it's time to remove the code.

This CL removes all the remaining Link Doctor code in Chrome.

TBR=estark@chromium.org (who actually signed off on it already)

Bug: 1030281
Change-Id: I7346ea116356d1955fd7774a6a0e945d3e1de249
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285324
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Edward Jung (EMEA) <edwardjung@chromium.org>
Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788873}

This matches the unique_ptr<> API better. While the API is not safe by
default, there are cases when it really is needed. Not having it then
causes a lot of awkward code contortions.

Bug: 1083392
Change-Id: I67d329533d1e01c86deeb7c1ba63f179032cf827
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300406
Commit-Queue: Albert J. Wong <ajwong@chromium.org>
Auto-Submit: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788872}

https://crrev.com/c/2241955 refactored how QuotaManager reasons about
QuotaClients. The new setup maintains separate lists of clients for each
StorageType (kTemporary, kPersistent, kSyncable).  Unfortunately, the CL
did not correctly migrate all the QuotaManager helpers to iterate over
the per-StorageType lists instead of the global list.

This CL migrates QuotaManager helpers, and adds testing coverage to
prevent future regressions.

Bug: 1100260
Change-Id: Ie788fc08ffc24cb1bb9d2b83524c21a9d9e296d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299466
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788871}

This change adds a test to exercice the persistent-usage-record path
for EME. The new test create a PUR session and wait for the video to
end and verify that the license-release message contain the usage
record.

Bug: 1091502
Change-Id: I2d6347f39981d9eb1025d37ced254eb6aae766b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285250Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Alex St-Onge <alstonge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788870}

Change-Id: I3fc9bf74d7ef438634a9a675e2b75f3a6f834887
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296622Reviewed-by: Wei Li <weili@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788869}

BUG=842296

Change-Id: Ia27b79b64f1e9ad6c3d63409a5b3bbe921649f5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292792Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Auto-Submit: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788868}

RedirectInfo is the main consumer of this field, so currently has to
include url_request.h. RedirectInfo is sent across processes via Mojo
messages, which means the Network Service's Mojom files have to include
url_request.h. As a result, ~8,000 build steps are indirectly depending
on url_request.h. Not only do almost all of them not actually need
url_request.h, but this means they also include a fair number of net/
header files, which slows build time and makes rebuilding chrome after
modifying any of a number of files slow.

Moving FirstPartyURLPolicy to RedirectInfo solves this problem.

Bug: 1103784
Change-Id: I91db5ecefedf63913986be052dc674d615f54f36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293654
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788867}

When matching pushed streams against incoming requests, SpdySession
attempts to handle aliased streams. Unfortunately, it duplicated the
stream alias matching in SpdySessionPool, instead of using a common
function. As a result, the matching code has become outdated, and
ignores a number of fields (NetworkIsolationKey, socket tags,
is_proxy_session, disable_secure_dns).

This CL fixes the issue by making both aliasing paths use a
helper method of SpdySessionKey, which is hopefully less likely to
become outdated.

Bug: 1105544
Change-Id: I2d88a4a15d0e260fb5049a533ba52693c09bfc0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300270Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788866}

PDF Viewer does not yet fully support light and dark mode versions.
Instead it appears dark(ish) in all cases, which necessitates some
manual color overriding, for the newly added cr-action-menu instances.

Bug: 1084620
Change-Id: Ide93c78d6fb4b1d666018a83b3231f9e43d4bf01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291250
Commit-Queue: dpapad <dpapad@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788865}

https://chromium.googlesource.com/chromium/deps/nasm.git/+log/4fa54ca5f7fc..19f3fad68da9

$ git log 4fa54ca5f..19f3fad68 --date=short --no-merges --format='%ad %ae %s'
2020-07-15 dalecurtis Remove config-win.h from BUILD.gn
2020-07-14 dalecurtis Fix a couple build issues on Windows.
2020-07-13 dalecurtis Update macOS configuration files.
2020-07-13 dalecurtis Update windows configuration and buildables.
2020-07-12 gorcunov travis: weirdpaste -- add nil dereference test
2020-07-11 gorcunov BR 3392696: nasm_quote -- fixup callers
2020-07-10 hpa NASM 2.15.03rc6
2020-07-10 hpa preproc: saner handling of cpp-style line directives
2020-07-10 hpa test/winalign.asm: simple test for COFF alignment
2020-07-10 hpa outcoff: don't drop align= option alone on a section line
2020-07-10 hpa ppindirect.asm: make it possible to assemble to a binary
2020-07-10 hpa preproc: preserve %[...] in listings
2020-07-10 dalecurtis Update Windows, Linux configuration files for nasm 2.15.03rc5
2020-07-10 hpa preproc: add a %null directive for the masm macro package
2020-07-10 hpa NASM 2.15.03rc5
2020-07-10 hpa changes.src: document LEA fix
2020-07-10 hpa %use masm: much better documentation
2020-07-10 hpa assemble: use proper rel/abs state for lea reg,imm
2020-07-10 hpa NASM 2.15.03rc4
2020-07-10 hpa changes.src: document %00 fix
2020-07-10 hpa test/Makefile: fix command line for .obj format
2020-07-10 hpa preproc: correctly handle %00 capturing a label
2020-07-09 hpa NASM 2.15.03rc3
2020-07-09 hpa debug: don't call dfmt->linenum without a filename
2020-07-09 hpa debug: invoke dfmt->linenum when the segment number changes
2020-07-09 hpa changes.src: update 2.15.03 release notes
2020-07-09 hpa NASM 2.15.03rc2
2020-07-09 hpa configure.ac: also try -std=c99
2020-07-09 hpa pa_c_typedef.m4: also test for __typeof and __decltype
2020-07-09 hpa autoconf: use -std=c17 or -std=c11 if available
2020-07-09 hpa autoconf: add success/failure code options to PA_ADD_*FLAGS
2020-07-09 hpa configure.ac: if we have a C17/C11-compatible compiler, use it
2020-07-09 hpa configure.ac: better tests for typeof, snprintf, vsnprintf
2020-07-09 hpa vsnprintf.c: fix printing of a size_t variable
2020-07-08 dalecurtis Update patches for cherry-pick for Windows fix.
2020-07-06 hpa BR 3392692: outcoff: allow user to reduce the default alignment
2020-07-08 hpa asm: fix pass_type()
2020-07-08 hpa k_test.asm: comment out %pragma list options
2020-07-08 hpa config/unconfig.h: still needs to be in the repository
2020-07-08 hpa test/Makefile: allow overriding -L+
2020-07-07 hpa changes.src: update with current state of 2.15.03
2020-07-06 hpa NASM 2.15.03rc1
2020-07-06 hpa BR 3392692: outcoff: allow user to reduce the default alignment
2020-07-06 hpa compiler.h: safer/more portable version of offsetin()
2019-10-04 sezero rdflib.c (main): change incorrect break statement to /* fall through */
2019-10-04 sezero rdflib.c: add back timestamp size to header in library creation.
2019-10-04 sezero portability: Watcom C portability updates
2020-07-06 hpa compiler.h: add missing #endif
2020-07-06 hpa offsetin(): use typeof() if the compiler supports it
2020-07-06 hpa configure.ac: -enable-... breaks other compilers, so hope for clang 10
2020-07-06 hpa config/unconfig.h: generate by Makefile, not autogen.sh
(...)
2018-11-04 gorcunov test: nasm-t -- Add popcnt test
2018-11-04 gorcunov test: nasm-t -- Add crc32 test
2018-11-04 gorcunov test: nasm-t -- Add riprel test
2018-11-04 gorcunov test: nasm-t -- Rework data read procedure
2018-11-04 gorcunov test: nasm-t -- Add binexe test
2018-11-04 gorcunov test: nasm-t -- Add bcd test
2018-11-04 gorcunov test: nasm-t -- Add avx512f test
2018-11-04 gorcunov test: nasm-t -- Add avx512pf instruction
2018-11-04 gorcunov test: nasm-t -- Add avx512err instructions
2018-11-04 gorcunov test: nasm-t -- Add avx512cd test
2018-11-04 gorcunov test: nasm-t -- Add avx005 test
2018-11-04 gorcunov test: nasm-t -- Add avx test
2018-11-04 gorcunov test: nasm-t -- Add aouttest
2018-11-04 gorcunov test: nasm-t -- Add json template
2018-11-04 gorcunov test: nasm-t -- Add gotoff64 test
2018-11-04 gorcunov test: nasm-t -- Add aoutso test
2018-11-04 gorcunov test: nasm-t -- Add mpx test
2018-11-04 gorcunov test: nasm-t -- Add mpx-64 test
2018-11-04 gorcunov test: nasm-t -- Add movnti test
2018-11-04 gorcunov test: nasm-t -- Add movd test
2018-11-04 gorcunov test: nasm-t -- Add radix test
2018-11-04 gorcunov test: nasm-t -- Add r13 test
2018-11-04 gorcunov test: nasm-t -- Add prefix66 test
2018-11-04 gorcunov test: nasm-t -- Add pushseg test
2018-11-03 gorcunov test: nasm-t -- Update _version test
2018-11-03 gorcunov test: nasm-t -- Add test67
2018-11-03 gorcunov test: nasm-t -- Add testnos3 test
2018-11-03 gorcunov test: nast-t -- Add smartalign test
2018-11-03 gorcunov test: nasm-t -- Add vmread test
2018-11-03 gorcunov test: nasm-t -- Add testdos test
2018-11-03 gorcunov test: nasm-t -- Add uscore test
2018-11-03 gorcunov test: nasm-t -- Add struc test
2018-11-03 gorcunov test: nasm-t -- Add sha test
2018-11-03 gorcunov test: nasm-t -- Add sha-64 test
2018-11-03 gorcunov test: nasm-t -- Add xchg test
2018-11-03 gorcunov test: nasm-t -- Add xcrypt test
2018-11-03 gorcunov test: nasm-t -- Sort tests by name
2018-11-03 gorcunov test: nasm-t -- Add zerobyte test
2018-11-03 gorcunov test: nasm-t -- Add andbyte test
2018-11-03 gorcunov test: nasm-t -- Add align13s test
2018-11-03 gorcunov test: nasm-t -- Write text data in utf8 form
2018-11-11 gorcunov output: obj -- Fix nil dereference if no deps needed
2018-11-07 hpa NASM 2.14
2018-11-07 hpa nasmdoc.src: fix compound word
2018-10-29 changseok.bae doc: Add a description for a useful case of mangling symbols
2018-10-29 gorcunov preproc: Don't access out of bound data on malformed input
2018-10-29 gorcunov rdstrnum: Make sure we dont shift out of bound
2018-10-28 gorcunov preproc: Fix out of bound access on malformed input
2018-10-25 gorcunov doc: Clarify %include search directory semantics
2018-06-15 hpa eval: add spaceship operator <=>

Created with:
  roll-dep src/third_party/nasm

TBR=davidben

Fixed: 1105391, 1105548, 1100411
Change-Id: I87b056e34792642a54afa7eb42fdeb7885f65f02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300268Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788864}

This is a reland of c615367a

Original change's description:
> Portals: Fix flakes in testTouchTransferAcrossReactivation
> 
> The flakes were caused by crbug.com/1098773. As a workaround until the
> issue is fixed, this wraps the activate call in a setTimeout.
> 
> Bug: 1024850
> Change-Id: I36e2b948818d81578acc97a9a60758b281ff6764
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264856
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#782379}

Bug: 1024850
Change-Id: Ie6ad8a764f493de62cc2ab25f8b48b5d3c22375b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295835Reviewed-by: Lucas Gadani <lfg@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788863}

Said https://crrev.com/c/2292780 inadvertently restored VP9.1 and .3
entries in the test and removed a const. Having those profiles is
harmless but I expect it to be confusing, so let's remove them.

Bug: 1105103
Change-Id: I601edb3e9534cec12245058a10ad1f7b01aa8e0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300920
Auto-Submit: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788862}

This adds a helper, UpdateButtons(), to set all buttons' visibility,
text, and enabled state based on the current mode; this replaces the
scattered pieces throughout other functions.

This also removes the places that set |dropdown_state_| to NORMAL.
Since this is supposed to track the actual button state, it only makes
sense to toggle it in places like ButtonPressed() and ReleaseDropdown().
It also doesn't make sense to change this variable directly instead of
going through SetDropdownState(), since then the state and the visual
appearance could be out of sync.

Bug: none
Change-Id: I444fd3b14ab1ec8a4b0aed37ce2d80539d54f199
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299139
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788861}

https://chromium.googlesource.com/catapult.git/+log/f4db4dad69d7..0ea0cd51026f

2020-07-15 cduvall@chromium.org Set WebView implementation for any WebView APK

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC skyostil@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1105096
Tbr: skyostil@google.com
Change-Id: I4cb375c28570c91da606b71c3031b2c22ae02d72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300941Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#788860}

The builder's machines were restored to n1, but with the goma outage,
compiles are still taking a long time. A temporary boost to the timeout
will allow for getting some results in the meantime.

Bug: 1106029
Change-Id: I6148d08455f66ebabed1f3f1e0f1415b826b7c33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301199
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Michael Moss <mmoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788859}

AX-Relnotes: n/a.
Bug: None
Change-Id: I22b14c4c8ffaab00f5544aff48f28de43851edfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295932Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#788858}

The ultimate goal here is to eliminate duplication of code and work and
make the actual effects of state transitions obvious.

This CL combines the various TransitionTo...(), Show...(), Clear...(),
and SetMode() functions into a single UpdateMode() function and does
some initial basic combining of shared code.  It makes the following two
assumptions:

* The item does not transition from one warning state to the other, or
  from one mixed content state to the other; it transitions into or out
  of one of these states from an unrelated state (most commonly
  kNormal).  This seems true from my reading of the various model-side
  state transitions, and the existing code would not have properly
  handled such state changes anyway (e.g. |mode_| would never have been
  updated).

  Making this assumption lets us do conversions akin to this:

  OLD: if (is_mixed_content(mode) && !is_mixed_content(mode_)) { ... }
  NEW: if (is_mixed_content(mode)) { ... }

* It's undesirable to trigger LoadIcon()'s functionality again when the
  file path hasn't actually changed.  While only one call chain actually
  checked for this, it seems correct in principle in all cases (such
  repeated calls would just be extra work).

  Making this assumption lets us put that check in LoadIcon(), and then
  call it unconditionally at the end of UpdateMode() instead of in many
  other places.

The UpdateMode() function here is far too sprawling, but even making
fairly few actual logic changes, this CL already pushes the bounds of
what a reviewer can verify is still correct.  Further refactoring to
turn this into something shorter and more comprehensible will come in a
subsequent patch.

Bug: none
Change-Id: I6b0e6dfcfef5c1057c4e59e593adcee27e537950
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296271
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788857}

AX-Relnotes: n/a.
Bug: None
Test: AXTreeSourceArcTest.*, AccessibilityNodeInfoDataWrapperTest.* passes
Change-Id: I97ef734a8770c68a4245e40dad25d897062e8ede
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294502
Commit-Queue: Sara Kato <sarakato@chromium.org>
Reviewed-by: Hiroki Sato <hirokisato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788856}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: Ie039eecf251930d107ba65fcea4a64a12eeb0506
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300859Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#788855}

https://chromium.googlesource.com/external/github.com/AOMediaCodec/libavif.git/+log/f48a33827db6..01ee4caa5ab5

$ git log f48a33827..01ee4caa5 --date=short --no-merges --format='%ad %ae %s'
2020-07-14 jdrago v0.8.0
2020-07-14 jdrago Update CHANGELOG
2020-07-14 jdrago Fix usages of rgb in README
2020-07-10 wtc Set encoder chroma sample position
2020-07-10 wtc avifenc: add --tilerowslog2 and --tilecolslog2
2020-07-10 jdrago Build nasm from source in GitHub the way it is built in Travis
2020-07-09 wtc Update avifBitsReadUleb128 with latest dav1d code
2020-07-09 wtc Do not set cfg.kf_mode = AOM_KF_DISABLED
2020-07-09 jdrago Remove monochrome from this new check
2020-07-09 jdrago Fix lossless monochrome checks; this needs another pass
(...)
2020-06-22 wtc avifImageRGBToYUV() cleanup
2020-06-22 jdrago Stub out a contrib directory for future PRs
2020-06-22 wtc Build LIB_FILENAME from CMake variables
2020-06-22 wtc avifRWStreamWriteFullBox() cleanup
2020-06-22 jdrago Avoid known crash in libaom's monochrome encoding, and simulate it with YUV420 as a fallback
2020-06-22 wtc Remove yShift out param from avifImageCalcAOMFmt()
2020-06-22 E.M.terHoeven Changelog.md: Add line for dav1d 0.7.1 update
2020-06-22 E.M.terHoeven Ext: Update to dav1d 0.7.1
2020-06-19 jdrago Partially fix my grammar in my run-on sentence
2020-06-19 jdrago Add some additional comments explaining the usage of ID 0 when calling avifDecoderDataFindMetadata()

Created with:
  roll-dep src/third_party/libavif/src
R=dalecurtis@chromium.org

Bug: 1105148
Change-Id: I79ff72c7533a2b6228336663388af997056eef41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300629Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Wan-Teh Chang <wtc@google.com>
Cr-Commit-Position: refs/heads/master@{#788854}

This code was used in the initial download implementation, prior to
Chromium becoming open source. The caller to
SaveFileManager::DeleteDirectoryOrFile() got removed at some point, so
this code has been dead ever since.

Make save_file_manager.* lint free as well.

Change-Id: I09768c555cc3447539d67f98ca83ca8ea57f0787
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296864Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788853}

With the default HeapMojoRemote setting there was a bad
interaction between service_ and the GATTServer cleanup. service_
would get cleaned up in its own OnContextDestroyed method but
then the GattServer would try to access it in Dispose. This
was worked around by using kForceWithoutContextObserver.

In BluetoothGATTServer there should not be any need for manual
cleanup: service_ can use the OnContextDestroyed method and the
other object being cleaned up, active_algorithms_, is a HeapHashSet
with its own associated garbage collection.

Bug: 1049056
Change-Id: Ia81e99743c1f8bdccf37b54d0761258571a3ad4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275515Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#788852}

This flag was verified last week, and was then set
`chrome_value: false` because it was breaking tests.
After digging further, I realized that the failing
test was incorrect: it would create a dispatcher with
no versions, which triggers a DCHECK. This used to pass
because draft-25 was a version that could support
WebTransport but wasn't part of the origin trial
versions. I don't think this test adds much value,
because if there are no versions on the server we don't
really care about validating that everything fails. So
this CL removes that test, and flips the flag back.

Change-Id: I80bc8bd3ee76238311d3ac21b034b5a526e6202a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297964
Auto-Submit: David Schinazi <dschinazi@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788851}

TBR=tkent@chromium.org

Bug: 1104381
Change-Id: I7512014896786a50469d9eaf65a3090d0030ea83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300030Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788850}

This CL adds some deps and reenables gn check for
chrome/browser/image_decoder.

Bug: 1106053
Change-Id: I6a424059a39bb02880d13a6e916198615e1f4582
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299850Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788849}

Moves ReportRequestQueueGenerator from chrome/browser/enterprise to
components/enterprise so it can be reused in iOS code.

Note that the associated unit tests are harder to move because of their
extensive use of TestProfileManager, which is in chrome/browser. They
will be reworked and moved in a separate CL. crbug.com/1103732 has
been created to track that, with a TODO in the code.

Bug: 1091938
Change-Id: I24a2c2e258eb772e3910cdf99e8e1e7a83eb57a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290250Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Guillaume Jenkins <gujen@google.com>
Cr-Commit-Position: refs/heads/master@{#788848}

Bug: 1072012,1103490
Change-Id: Ieb61903d53e527c4cedee12d099668e96503f68b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300838Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Stephanie Kim <kimstephanie@google.com>
Cr-Commit-Position: refs/heads/master@{#788847}

Pass by constref and only copy up to the first 1000 characters, rather
than copying it all and inserting a nullptr and ellipsis

Also removed the old definition of kMaxUrlLength from media_log.h and
the old truncate method definition

Bug: 1090752
Change-Id: I6665f010937c802b94da9fd344ab3baf6af88a99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299195
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788846}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I26c6fc435b301179a125fd2b0cda42c4252d7d59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300665Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#788845}

Since r786851, the docserver integration test is hanging causing
presubmits to fail. Also, the cron script which we use to update the
docserver is hanging. This is because r786851 added dependencies on
behavior features. However behavior features are not accounted for in
features_bundles.py which is used to resolve feature characteristics
like channel, platform etc. Since the code in the file expects that all
features will eventually be resolved, it keeps running indefinitely.

To fix:

- Ensure behavior features are ignored for the purpose of evalauting
feature characteristics for the docserver.

- Break out of the loop in GetFeatures if no new features are resolved
after a top level iteration. This'll ensure that the script terminates
eventually. Also, log an error if any features are left unresolved.

Other fixes:

- Delete cloudPrintPrivate.html. It was causing presubmit to fail since
beginning r785624, cloudPrintPrivate is disabled for extensions.

- Disable pylint checking in
chrome/common/extensions/docs/server2/PRESUBMIT.py. There are multiple
failures there already and it is causing the presubmit step to timeout.

BUG=1103846, 1105211
TEST=python
chrome/common/extensions/docs/server2/integration_test.py --
apps/developerPrivate doesn't hang

Change-Id: I640ea35a66ecd863e39ca7b9b2e3e5469bfae2a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296866Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788844}

This CL refactors AutofillHandler::OnFormsParsed() to take a vector
of FormData pointers instead of a vector of FormStructure pointers.
That way, refilling still has access to the seen FormData and does not
need to use the cached form for that purpose, which would mix up the
last-seen values with the initial values.

Bug: 966873, 949094, 1075533
Change-Id: Iba0e030b4dfa58edc05d125550e4a8ee56413f7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291070
Commit-Queue: Christoph Schwering <schwering@google.com>
Reviewed-by: Matthias Körber <koerber@google.com>
Cr-Commit-Position: refs/heads/master@{#788843}

- Adds WebBundleLoader class which loads a WebBundle resource using
  ThreadableLoader, and creates a WebBundleSubresourceLoaderFactory.

- LinkWebBundle is registered in ResourceFetcher, and used to forward
  subresource requests that match the corresponding <link>'s resources=
  attribute to the WebBundleSubresourceLoaderFactory. This is done via
  the SubresourceWebBundle interface.

Bug: 1082020
Change-Id: I3f26bd6b1fbd5855caa5175cdcb3db0fe103a093
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291809Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788842}