- 05 Jun, 2020 40 commits
-
-
James Cook authored
Creates a field trial to control the SplitSettingsSync feature. The trial is client controlled because SplitSettingsSync controls the out-of-box experience (OOBE) sync consent dialog, which shows up before a variations seed is available. The trial group chosen on first run is persisted to local state prefs and reused on subsequent runs. This keeps the in-session sync settings UI stable between runs. Local state prefs can be reset via powerwash, which will result in re-randomization, but this also sends the user through the first-run flow again and they will see the appropriate consent flow. Bug: 1090989 Test: Went through OOBE, verified trial group is random then persists Change-Id: I241407a47179ddeed1da06f2aa1189fac936c70f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230771 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#775709}
-
Nate Fischer authored
No change to logic. This componentizes ReportAboutFlagsHistogram (which is responsible for logging the Launch.FlagsAtStartup and Login.FlagsAtStartup histograms). This will be used later by Android WebView to log a similar histogram. This does not componentize AboutFlagsHistogramTest because this still depends on iterating over Chrome's kFeatureEntries list. Bug: 1084178 Test: unit_tests -f 'AboutFlagsHistogramTest.*' Change-Id: If9f0f844d1e3b8e9dd7b4b7207b6c82996d88d86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231446 Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#775708}
-
Oriol Brufau authored
The 'list-style-image' property accepts an <image> value to be used as the marker image for the list item. The problem was when specifying a linear-gradient(), which has no intrinsic sizes. It would initially be sized using half of the font ascent, but when dynamically changing the 'zoom' property, it would become 300x150. This patch fixes it by changing LayoutImageResourceStyleImage::ImageSize to use custom default sizes for list markers. BUG=1091289 TEST=external/wpt/css/css-lists/list-style-image-zoom-dynamic.html Change-Id: I746e2421ffb329df884457f0f973b30280fb23b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230475 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#775707}
-
Prashant Nevase authored
The is_svg was added to separate out svg image classification. But svg images are classified using same mechanism which is used for other image types. Current usage of is_svg is just set and check in tests. As this not the extracted feature, in image classification, it is neither used in decision tree nor in NN model. This patch removes it. Bug: 1091095 Change-Id: I6e4cdc49e1d5f54278e16194fa505f4d24d38acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170748 Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#775706}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/73c5db6dfb0c..e32669d4cb17 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yigu@google.com,tbansal@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yigu@google.com,tbansal@google.com Change-Id: If7607fb106560853b319866406fb3feac6f4693e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232782Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#775705}
-
Rakesh Soma authored
Bug: 1091161 Change-Id: I1ea622b856df81f4bf3c302a0399a39adb9d588e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230919 Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#775704}
-
Aaron Leventhal authored
R=tommycli@chromium.org TBR=kenrb@chromium.org AX-Relnotes: n/a Bug: 1091504 Change-Id: Ibc0b2aedd36f86f9f45cbece0e7ae7cdaf383e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231709 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#775703}
-
Ella Ge authored
This reverts commit 0ea86868. Reason for revert: reland with fix Original change's description: > Revert "Update AndroidX.Browser dependency" > > This reverts commit 28b4bf48. > > Reason for revert: Compile failure on https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/12150? > > Original change's description: > > Update AndroidX.Browser dependency > > > > > > Bug: 1069506 > > Change-Id: I6e6fd53dcb6d8bae3022c1d5d4c5834723156ba0 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230159 > > Commit-Queue: Ella Ge <eirage@chromium.org> > > Reviewed-by: Peter Conn <peconn@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#775573} > > TBR=peconn@chromium.org,eirage@chromium.org > > Change-Id: Ib0c067f24efe4def48a42e47656bcae759206dc1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1069506 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231823 > Reviewed-by: Yi Gu <yigu@chromium.org> > Commit-Queue: Yi Gu <yigu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#775585} TBR=peconn@chromium.org,yigu@chromium.org,eirage@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1069506 Change-Id: Ia8d51c97613028798db4c192979f17afee837fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232740Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#775702}
-
Maxim Novikov authored
Test: N/A Bug: internal b/156356791 Change-Id: I6852905a2bb2bb51d47535bd83903766c585601a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232802Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Maxim Novikov <csbubbles@chromium.org> Auto-Submit: Maxim Novikov <csbubbles@chromium.org> Cr-Commit-Position: refs/heads/master@{#775701}
-
Yi Gu authored
Please see linked bug for details. TBR=hta@chromium.org NOTRY=TRUE Bug: 1091885 Change-Id: I13b7ee2dfbeef2f86a33748f64140f6a9d13712d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232755Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#775700}
-
George Burgess IV authored
This includes an example evaluation doc, as well as information about how to actually run clang-tidy across Chromium using the same machinery that Tricium does. Bug: None Change-Id: I44633f5165b553cbb74a4e88055be94f446c3743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230914Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#775699}
-
Brian Sheedy authored
Restricts the recent test disable on some WebXR VR permission tests to only Android L, as that is the only failing OS version. TBR=alcooper@chromium.org Bug: 1091800 Change-Id: I15e0dbe2d970c6d9a10a3cdf09561bbac33da044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232763Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#775698}
-
Robert Ogden authored
Simple refactor to allow running the same eligibility checks for subresources in a future CL. Bug: 1082505 Change-Id: I367f9ffe69d0442806f5f70a310772e2813220b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232764Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#775697}
-
Yi Gu authored
TBR=bokan@chromium.org Bug: 1091829 Change-Id: Ib5aec1308f610bb14108ccee3f90a4e7984bef03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232803Reviewed-by:
-
Yi Gu authored
http/tests/inspector-protocol/network/navigate-iframe-out2in.js is flaky probably due to the same issue as in the bug. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests%20(with%20patch)&tests=http/tests/inspector-protocol/network/navigate-iframe-out2in.js TBR=petermarshall@chromium.org Bug: 1046784 Change-Id: Iae77bf2e430902ab705c90f576958b3d61f92a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232808Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I500553b1190878f92463c74d136890c0ae478598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233002Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#775694}
-
Matt Menke authored
In particular, a user assumed it would only include information from incognito (which is a pretty reasonable assumption) and chose to enable byte logging. Seems like we should make clear that's not the case. Bug: None Change-Id: I699784b34af9d28c48679fdcd1abc730936908f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232699 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#775693}
-
Aya ElAttar authored
1. Changed the type of value_ member in PolicyMap from unique_ptr to base::Optional. 2. Updated its setter & getter accordingly. Bug: 1083984 Change-Id: I6c015a05254a0d52aad9b4bbf859f2fee1f26562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230479Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@google.com> Cr-Commit-Position: refs/heads/master@{#775692}
-
Yngve N. Pettersen authored
Change-Id: I495d0e0a151e6869c2eada7b949fc99c18f85a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232363Reviewed-by:
-
Koji Ishii authored
|WritingMode| is very often used with |TextDirection|, whose base type is |uint8_t|. Changing |WritingMode| to 1 byte helps packing better without paying the cost to read/write bit fields when the performance or the readability is more important than saving a few bits. This also helps |WritingDirection| being discussed in <crrev.com/c/2232311>. Bug: 1091797 Change-Id: I3169f8071fcd39b11f4bf7c7ccf18396090f80f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233098Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#775690}
-
Yue Zhang authored
Bug: 1090685, 1090655 Change-Id: I5ad408f203c651c5f6863e6ce0d353d1c733e38d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229418 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#775689}
-
danakj authored
The test seems to not be flaky any more with improvements made to the web test harness for site isolation. If wrong.. we can revert and investigate. Local run of 22 runs had 0 failures and TestExpectations claims it was very flaky. R=vmpstr@chromium.org Bug: 564109, 891427 Change-Id: I586050f484f1d0b747ea4265b35dd1602b09064d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232744Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#775688}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0ea86868. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I3e3093489b65ce41589ffd88b351f7645724414f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232958Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#775687}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/597115926cf7..81de8dd83064 2020-06-05 patrick.brosset@microsoft.com DevTools: Use the new grid highlight overlay behind an experiment. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1047356 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7e68d3830488447e04f2c6ff2d02eb4ab1ae206c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232784Reviewed-by:
-
Liquan (Max) Gu authored
original CL: crrev.com/c/2227512 revert CL: crrev.com/c/2231122 revert reason: showPaymentHandlerUi was flaky. It's very likely because the animation took so long to finish that that it hits the timeout. Many screenshots prove that because the payment sheet still had a thin scrim on it. change: Compared to the original CL, the new one removes the animation. Bug: 1042892, 1084705, 1084707, 1084708, 1084711, 1084721, 1068741 Change-Id: Ib3401e3e422e37a733f85eb56e6d08598d3ade1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232679Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#775685}
-
Evan Stade authored
This will allow us to remove the centralized declaration of prefs in //chrome, later permitting componentization of PrefServiceBridge. PrefServiceBridge.java and PrefRegistrar.java are updated to use the preference string keys from C++ instead of an integer that is mapped to the string in C++. This uses java_cpp_strings with the relevant prefs files to generate the java string definitions. These pref files include both //chrome and //components prefs. Later, some or all of the //components prefs can be moved to a different java_cpp_strings target. Bug: 1071603 Change-Id: Ia8fd53a3a4ec6ff73f2b2ca5397adf5cbb056825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227849 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#775684}
-
Adrienne Walker authored
This is a preliminary fix for this patch to require tokens: https://chromium-review.googlesource.com/c/chromium/src/+/2225477 This disables the normal appcache web tests and runs the entire suite with the require token flag on. This will allow the flag to be flipped on or off without affecting web tests while still retaining all of our tests. Bug: 582750 Change-Id: I34025fbf39936e26f576e92268c421ff36ba1b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231464 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#775683}
-
behdad authored
For reducing the time of representative perf test, we only rerun the failed stories and update the results of the initial run based on the reruns. If the failed stories pass in rerun, the output will be updated to report all tests as passing. The current bug in these tests is that it would report values before considering the rerun results. So even if the failed tests pass after rerun, the output is still reporting the failures. This would cause the return_code to be set as 1 (Failed/Interrupted) while the tests has already passed via rerun. Bug: chromium:1091743 Change-Id: I9eef7250bc2dad649fef49cf9a5ccd8195190f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232603Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#775682}
-
Steven Bennetts authored
While swapping SIM cards a Cellular Device may not be available, but Shill will start persisiting the Service while the Device resets. This removes the requirement that all Cellular Network mojo instances have an associated device. Bug: b:154014577 Change-Id: Id9c982f3752dbccce38201cb4acd221e5d0cc6b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227066Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#775681}
-
Collin Baker authored
The previous behavior was to autoclose for any tap outside of the tab strip, or its control buttons. In addition, now only one tap is required to close the tab strip and focus the Omnibox. Change-Id: Iaef938fc073f26db8bedec9b9f0e5f1f10678ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216603 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#775680}
-
Travis Skare authored
Matches Send-Tab-To-Self behavior. Prevent losing ink drop or a hide/show cycle on instantiation. Bug: 1082829 Change-Id: I8189cefd4bf7269df4303ff6aa328093698145de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229002 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#775679}
-
Yoshifumi Inoue authored
This patch makes |CompositeEditCommand::DeleteInsignificantText()| to work with LayoutNG for preparation of implementing EditnigNG. Bug: 707656 Change-Id: Iaccd51f60a555175a3f758ee8abac63529cdd265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230549 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Maksim Ivanov authored
Extend the policy_fuzzer to also cover the functionality that converts from the raw device policy proto (ChromeDeviceSettingsProto) to CrosSettings. Bug: 811690 Change-Id: I5193b21c0045bb0a88e83aeb46885ed13721d0ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218027 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#775677}
-
Yoshifumi Inoue authored
This patch makes deleting   in pre-wrap to work instead of crash. Change-Id: Ifb32315ac2d162cc108162bcf7fb06ea9268d08e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230551 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Mike Klein authored
Change-Id: Ic29cf6d4eba3379899461e7203c4861df6c40a6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232821 Commit-Queue: Mike Klein <mtklein@google.com> Commit-Queue: Herb Derby <herb@google.com> Auto-Submit: Mike Klein <mtklein@google.com> Reviewed-by:
Herb Derby <herb@google.com> Cr-Commit-Position: refs/heads/master@{#775675}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/cb44c86c1aaf..4fe018038f87 2020-06-05 dmauro@google.com Googletest export 2020-06-05 rogeeff@google.com Merge pull request #2742 from kuzkry:c++17-type-printers 2020-06-05 absl-team@google.com Googletest export If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/googletest-chromium-autoroll Please CC isamsonov@google.com,pwnall@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng;luci.chrome.try:win-chrome Tbr: isamsonov@google.com,pwnall@chromium.org Change-Id: I673f5e142b677bca11b46231f9698c5996e6dda4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232229Reviewed-by:
-
chrome://settings/passwords/deviceVictor Hugo Vianna Silva authored
Screenshot of chrome://settings/passwords/device: https://screenshot.googleplex.com/Ox5jLPWSoAs Screenshot of chrome://settings/passwords (not changed): https://screenshot.googleplex.com/bUgjeiyHSvh We also profit of the occasion to modernize the code of a helper in passwords_section_test that is now also used in the tests for the new page. Bug: 1049141 Change-Id: I9ff66231b7fc8ed888599842067bfe4760f1595a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228159Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#775673}
-
Andy Paicu authored
https://testtracker.googleplex.com/testplans/details/33023?revision=10 The link above describes the currently existing manual tests related to the permission prompts. As part of the review process, I've implemented the tests from section 1.1 which could be automated, which turned out to be most of them. Bug: 1063164 Change-Id: I320976b642b814f2aa83191bf12bdb58312d647b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207181 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Reviewed-by:
-
James Cook authored
This reverts commit 04e524c7. Reason for revert: I got the "behavior" metric wrong - we need to capture the exact skip reason. We also need the final end-state for sync enabled vs. disabled. Since this has not yet rolled out to any users I'm going to revert the CL instead of obsoleting the metric. I checked with metrics-team and they said it was OK to do it this way. Original change's description: > chromeos: Add metrics to sync consent screen for SplitSettingsSync > > For the new SplitSettingsSync version, which has both an accept and a > decline button, track which button the user clicked. > > For both the old and the new version, track whether the screen was > shown, skipped, or skipped with sync force-enabled. > > Bug: 1090989 > Test: added to browser_tests > Change-Id: I1697c82728b8f183bd807f910255d3820bd06587 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229720 > Auto-Submit: James Cook <jamescook@chromium.org> > Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> > Reviewed-by: Roman Aleksandrov <raleksandrov@google.com> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#775508} TBR=jamescook@chromium.org,isherman@chromium.org,rsorokin@chromium.org,raleksandrov@google.com Change-Id: Ida1d30ff223b80a79a7aeab1daaaa1271a6495a7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1090989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232751Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#775671}
-
Thomas Guilbert authored
HTMLVideoElement::CreateImageBitmap is currently rejecting valid calls, when we have an available first frame, but the ready state hasn't been updated. This CL updates CreateImageBitmap to check for a valid frame, which amounts to having a first frame available. This CL also updates some WPTs to use preload=auto, to allow video elements to load without being visible, and yield expected results when calling CreateImageBitmap. Bug: 1090960 Change-Id: I21302a9c3433bf8218a75c3f6918bc20f4d36ca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231453 Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#775670}
-
