- 05 Aug, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8c1079cc71d7..a5468613faff git log 8c1079cc71d7..a5468613faff --date=short --no-merges --format='%ad %ae %s' 2019-08-05 perezju@chromium.org [Telemetry] Write 'benchmark/story' test paths in LUCI format Created with: gclient setdep -r src/third_party/catapult@a5468613faff The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:966835,chromium:983993 Change-Id: I48166ba007ed9b5853e2a06e0206376d9bb6243e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734762Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683981}
-
Bence Béky authored
See https://crrev.com/c/1704282 for context. Change-Id: Ifcfd3b7b9b7867176a90a092056f453fb74124c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736692 Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#683980}
-
Guido Urdaneta authored
This reverts commit 75b38795. Reason for revert: Adding expectation to address Linux Leak failure Original change's description: > Revert "Add web tests virtual suite for audio service - Take 2" > > This reverts commit 8d648953. > > Reason for revert: Causing failures on WebKit Linux Leak > > Failure output: > 06:31:06.621 2998 worker/6 virtual/audio-service/media/autoplay/document-user-activation.html failed: > 06:31:06.621 2998 worker/6 leak detected: ({"numberOfLiveContextLifecycleStateObservers":[0,2],"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,135],"numberOfLiveResourceFetchers":[1,2],"numberOfLiveResources":[0,2]}) > > Original change's description: > > Add web tests virtual suite for audio service - Take 2 > > > > Adds extra expectations with respect to reverted > > https://chromium-review.googlesource.com/c/chromium/src/+/1715811 > > > > Bug: 976696 > > Change-Id: If36df0fd21b059c2eb212a0d1869c9ff82951c66 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732088 > > Reviewed-by: Armando Miraglia <armax@chromium.org> > > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#683565} > > TBR=guidou@chromium.org,armax@chromium.org > > Change-Id: I15488e069bee7e6e1282bcc78dfe2088339b7036 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 976696 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733508 > Reviewed-by: Chris Sharp <csharp@chromium.org> > Commit-Queue: Chris Sharp <csharp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683600} TBR=csharp@chromium.org,guidou@chromium.org,armax@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 976696 Change-Id: I9172e204adef935eb4ae4a60045a54b6c9c157f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735378Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#683979}
-
Stephane Zermatten authored
With this change, tests that wait for onboarding systematically call AutofillAssistantUiTestUtil.waitUntilViewMatchesCondition, which waits longer than expresso normally does. Bug: 990118 Change-Id: Ie6ae12786eec2d4fab04b49aa13cdbfa6088e943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736706Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#683978}
-
Peter E Conn authored
Bug: 988068, 984945 Change-Id: Ia095904e4d07ded1814af0d35ed2cff3c50b6946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736669Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#683977}
-
Carlos Caballero authored
MessageLoopForIO will go away soon use ScopedTaskEnvironment instead. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=miu@chromium.org Change-Id: I692e8ce91f43e17c5d0ad58dc1b194145490a4d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733613 Commit-Queue: Carlos Caballero <carlscab@google.com> Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#683976}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/12af46b649fd..ad3443c93121 git log 12af46b649fd..ad3443c93121 --date=short --no-merges --format='%ad %ae %s' 2019-08-05 wl@gnu.org Minor documentation improvement. Created with: gclient setdep -r src/third_party/freetype/src@ad3443c93121 The AutoRoll server is located here: https://autoroll.skia.org/r/freetype-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: I93ee5bf566c0c5cc87149069120e121300592ad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735999Reviewed-by:
-
Mark Cogan authored
WKWebView's -takeSnapshotWithConfiguration:completionHandler: may call its completion handler more than once under some circumstances. Since we typically embed a callback bound with BindOnce into this callback, repeated calls will CHECK() and crash. This CL changes the snapshot callback to be a repeating callback. The callback will remain owned by the block passed into WKWebView, and will be destroyed only when WKWebView discards the block. Bug: 981893 Change-Id: I9ae72fd8ca42ca4ac704b23df942931a3afd1310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728553 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#683974}
-
Hajime Hoshi authored
This CL implements page eviction. When JavaScript is executed on one document in the back/forward cache, the full page is evicted. This uses V8's SetAbortScriptExecution, which aborts execution and instead executes the registered hook. In the hook, eviction is triggered via mojo. In the current implementation, the page is evicted even when the frame is frozen not by bfcache, but this eviction works only when the feature flag is set. Detecting the reason why the frame is frozen is a remaining task. Design Doc: https://docs.google.com/document/d/1E6efB594SqODZX5_PRxmv8eZ9YsmheqhKFg3KoDh3vs/edit?usp=sharing This CL includes the change: * Browser-side implementation https://chromium-review.googlesource.com/c/chromium/src/+/1614163 Bug: 980111 Change-Id: I7d2779441aab118612a666304ff2366cffeffc75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654739 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#683973}
-
Juan Antonio Navarro Perez authored
The CL introducing the results processor [1] broke reporting of Telemetry's return_code when called via run_benchmark. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1692986 This is a quick fix for that. Adding tests to make sure we don't break this again in the future as follow up CLs. TBR=crouleau@chromium.org Bug: 990472 Change-Id: I4139d4b7503bad6555b5ee8d919499dd32fbff37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735581Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#683972}
-
Ross McIlroy authored
BUG=894773 Change-Id: I57c5c7cea3effd7a09bc72b3fe4893bb094eebb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731908Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fedd625e0cc6..ad5c4accad00 git log fedd625e0cc6..ad5c4accad00 --date=short --no-merges --format='%ad %ae %s' 2019-08-05 srte@webrtc.org Adds PeerConnection scenario test framework. 2019-08-05 asapersson@webrtc.org QualityScaler: Add option to try fast adapt down at start up based on initial bw estimates. Created with: gclient setdep -r src/third_party/webrtc@ad5c4accad00 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:none Change-Id: I2fa0da36342295598e1d0a82b4dbba6d33d0e6c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734760Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/73ec5b06ff9e..b8a27c5e6bb1 git log 73ec5b06ff9e..b8a27c5e6bb1 --date=short --no-merges --format='%ad %ae %s' 2019-08-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src a0eb5efd2bad..3cea2e5882e3 (1 commits) Created with: gclient setdep -r src/third_party/angle@b8a27c5e6bb1 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Bug: chromium:None Change-Id: I351cf6e75d5e0593f6f97786b4e3f94af9454b1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734761Reviewed-by:
-
Javier Ernesto Flores Robles authored
Removes the blur effect in the background view, which is not required anymore. Bug: 976645 Change-Id: Ic2d120dc163c471a67cf47451f1381dde495ec93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735375Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#683968}
-
Eugene But authored
Replaced code which waits for Quick Look UI presentation for EG2. EG1 still relies on checking for presented UIViewController, while EG2 can use XCUITest API to test that "good" static text is displayed. Bug: 987646 Change-Id: I7394c7b49249307cecf60617bf99250353022638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733461 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#683967}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/93ee550c1fe8..8c1079cc71d7 git log 93ee550c1fe8..8c1079cc71d7 --date=short --no-merges --format='%ad %ae %s' 2019-08-05 taylori@google.com Update systrace to use traceconv Created with: gclient setdep -r src/third_party/catapult@8c1079cc71d7 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: None Change-Id: Ic9663d9d7645e4017f21fd4089eb62dda590a5a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734758Reviewed-by:
-
Matthew Cary authored
This change upgrades RTCVideoEncoder output_buffers_ from base::SharedMemory to the new API base::UnsafeSharedMemoryRegion. The only functional difference is that the region is mapped for each BitstreamBufferReady() rather than only once when the shared memory is allocated. Bug: 849207 Change-Id: I6404b395d3b676f677ff9e9d6ccab3ff206e4099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697642 Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#683965}
-
Peter Marshall authored
Ongoing effort to deprecate this API Bug: chromium:913887 Change-Id: I01f1390d0006d8a8ffc5271f722c5d12dd39931a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736352Reviewed-by:
-
Stephane Zermatten authored
on_terminate_prompt_ is left over from a previous refactoring. It was checked but never actually set. This change removes it completely. Bug: 981363 Change-Id: I8ca8142b6bfe66f0e36d186b8559a31fcbf92313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735151Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#683963}
-
Daniel Vogelheim authored
Currently, Trusted Types are enforced also in extensions' worlds, which is unintentional. Bug: 986209 Co-Authored-By:
koto <koto@google.com> Change-Id: I5c4bbb03b715d1d0d3c3bfbcd7dbdb05caa88d71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712683 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#683962}
-
Eldar Rello authored
Bug: webrtc:3098 Change-Id: I58b1b22d13259102294a00914e05b42b2b41b36e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731931 Commit-Queue: Eldar Rello <elrello@microsoft.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#683961}
-
Rune Lillesveen authored
We started not marking Document with ChildNeedsReattach() in [1], hence the common ancestor for LayoutTreeRebuildRoot would be null instead of Document when marking documentElement(). That caused an issue with documentElement() not becoming a common root. The plan is to always use documentElement() instead of Document as the top-most root node for all traversal roots and simplify this again. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1727290 Bug: 989659 Change-Id: Id6f71d98f130e3f9d84930e28e90f14175f44718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733527Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#683960}
-
Juan Antonio Navarro Perez authored
We need some test coverage for benchmarks still using the legacy Telemetry value system. Bug: 990036 Change-Id: I597a1c0149031adf6ec65353634beab6ca5ae48f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731840Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#683959}
-
Marc Treib authored
Bug: 983940 Change-Id: I5a64cdec49eec883d2ac1d9933c101d05ee8a47d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724513Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#683958}
-
Himanshu Jaju authored
Bug: 982229 Change-Id: I2000e18b7e5bfe3a9ec7d9b8906251bec68d2937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735450 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#683957}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=braveyao@chromium.org, wez@chromium.org Bug: 968047 Change-Id: I5223612c9d4bf031e86a570bec68bd75c68dbcd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729163 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: -
Dominic Farolino authored
This CL introduces the PrefetchRedirectError flag. When enabled, prefetch requests get a redirect mode of kError, instead of the default kFollow. Consequently, prefetches that redirect are "cancelled", however the corresponding redirect responses are not evicted from cache, and can be matched later, which is our goal. The current proposal mentions that redirect mode should be manual, with the goal being: - To not follow redirects - Store redirect responses in the HTTP cache In Chromium, to satisfy the above conditions with kManual redirect mode, we'd have to implement extra behavior to treat kManual requests differently. We can satisfy the above conditions with kError in Chromium, and avoid the extra special-handling work. This is sufficient for initial experimentation. This CL also includes prefetch browsertests ensuring this behavior is both correct, and tied to the flag. R=kinuko@chromium.org, yhirano@chromium.org Bug: 988956 Change-Id: I449be39a02b3806d3ab14c45a6cb491fcab9bb66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725554 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#683955}
-
Lowell Manners authored
This CL updates the logic when a page is restored from the back-forward cache to more closely resemble a normal navigation. The over-arching goal here is to share as much logic with normal navigations as is feasible, to limit the maintenance cost of back-forward cache navigations. This code should only be run when the back-forward cache experimental option is enabled, and should not have any effect on Chrome's behavior by default (back-forward cache is disabled by default). Change-Id: I9c800e707a1cfd0289572404428f64d1fb6605e3 Bug: 976697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667452Reviewed-by:
-
Arthur Hemery authored
The current behavior is to have the NavigationSimulator handle only the navigation itself and leave the loading to unit tests. In practice a lot of code works by "accident", never stopping load between different navigations, etc. To make the overall approach about loading more manageable, we switch the paradigm to finish loads by default. This CL is mostly about maintaining tests that rely on the load being ongoing after a navigation. For these, we introduce explicit parameters in the NavigationSimulator. Bug: 979200 Change-Id: I50bf458c487023843d01f753bc5a5c309dc094b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709582Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#683953}
-
Arthur Hemery authored
This CL removes all of the references to PlzNavigate in the comments of components/. Change-Id: I5ab774c0c1f5c5ed4d803f64c08b8611404e8073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729084Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#683952}
-
Xiang Ji authored
Change-Id: I1b5d4a9abe48084a919febc3398849b2be2b1042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728179 Auto-Submit: Xiang Ji <jxiang@google.com> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#683951}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dc2c5c5a419e..73ec5b06ff9e git log dc2c5c5a419e..73ec5b06ff9e --date=short --no-merges --format='%ad %ae %s' 2019-08-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 0b70972a29c7..4f14b4c8cc25 (1 commits) Created with: gclient setdep -r src/third_party/angle@73ec5b06ff9e The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Bug: chromium:None Change-Id: I5ad084d04fd556c7cb2c908970f11c0ab61eb156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735895Reviewed-by:
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I43d33469da6f95e9a997f154433a84d0b3aefc0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700849Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
-
Himanshu Jaju authored
Bug: 982229 Change-Id: Ibb2303765ebcffca2d572d89b0a9508ec87e34e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731896 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
-
Jazz Xu authored
Bug: 986231 Change-Id: I621b1309ad0920f57ca338ee607a518f2843263e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731924Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#683947}
-
Pavol Marko authored
In the context of https://crbug.com/939344, it will be possible to specify that some policy-provided certificats only apply in some scopes. Passing a list of certificates to PolicyCertificateProvider::Observer implementations is not very meaningful then anymore. Instead, Observer implementations should retrieve the list of certificates they need from PolicyCertificateProvider explicitly. Also, many of the observer implementations already don't care about the passed list. Bug: 939344 Test: browser_tests and unit_tests still pass Change-Id: Icce961c8688fa05ed78cd4d2bad5fe43fc2549b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729263Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#683946}
-
Sylvain Defresne authored
Inject dependencies into AdvancedProtectionStateManager instead of passing a Profile* and letting the class access to its dependencies internally (this allow for easier injection in tests). Change AdvancedProtectionStatusManagerFactory to return the same instance for off-the-record Profiles as for regular Profile (thus eliminate static methods on AdvancedProtectionStateManager) and fix the getter to take a Profile* as parameter. Add unit test for AdvancedProtectionStatusManagerFactory to ensure the correct instance is returned for off-the-record Profiles (and remove uses of TestingProfile in AdvancedProtectionStatusManagerTest). Change RequestsAdvancedProtectionVerdicts() method to not be static (as the code to get the correct Profile is now in the factory) and remove IsUnderAdvancedProtection() static method as the getter can be used instead. Since the AdvancedProtectionStateManager instances are only created by the factory in production code, there is no need to check if the profile is off-the-record or not (the factory does the check) and it is possible to use a SequenceChecker instead of checking for the UI thread (since the factory will create the instance on the UI thread/sequence anyway). Fix client code to uses the factory to call the method that were previously static methods. Bug: 984487 Change-Id: I8f6a57afeee438419b6e4db59147164d5471fb9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707353 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#683945}
-
Edvard Thörnros authored
This is the second commit in the series of updating all the old svg animation tests. The usage of testharness has replaced the older SVGAnimationTest.js for all where it's suitable. No functionality should have changed and the tests should cover almost the same. In all of the animations where there is a sampling at T=0, where it was assumed that no animations had started. Which didn't work flawlessly when moved to the new system, it has thus been removed. Bug: 985335 Change-Id: If5d6d879be3ccd3b14467eebaa4c9a2c03128f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733589 Commit-Queue: Edvard Thörnros <edvardt@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#683944}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a02d5ef7..f69a6724 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I59acbf31e23e417a8c571240c405a9bbf6b5751f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735239Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683943}
-
Christopher Gunadi authored
When policy is set on server, background and foreground of FilesApp will listen to changes in pref and hide/show the "Install with Linux (Beta)" context menu option Follow up CL to http://crosreview.com/1712667 Bug: 983997, 983998, 988375 Test: compile Change-Id: I666cb79e48e876cb222a0dead3e6cf96a5a0a28a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730907Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Christopher Gunadi <chrisgunadi@google.com> Cr-Commit-Position: refs/heads/master@{#683942}
-
