GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284394 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/249171e7d29b5559f3eefe9dbd437030bfad3fda..3d533ac917eaadf2fb3561f57d7266d8c0e665fd

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=robertphillips@google.com
BUG=

Review URL: https://codereview.chromium.org/400333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284393 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284390 0039d316-1c4b-4281-b951-d872f2087c98

It was forced to unregister power handler from power profiler service when
detached, unfortunately, GetInstance() of singleton method initialized the
service without intention. This change makes the handler unregister itself
only when it has registered.

BUG=394609

Review URL: https://codereview.chromium.org/401703004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284388 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Remove deprecated extension notifications from ProcessManager (https://codereview.chromium.org/397743005/)

Reason for revert:
Suspected for Invalid Write / Unadressable / Uninitialized errors in 
Linux Tests (valgrind)(3) via ProcessManagerTest.ProcessGrouping and others starting 
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%283%29/builds/38965

Errors like

Invalid write of size 8
  ObserverListBase<autofill::PersonalDataManagerObserver>::AddObserver(autofill::PersonalDataManagerObserver*) (base/observer_list.h:162)
  autofill::PersonalDataManager::AddObserver(autofill::PersonalDataManagerObserver*) (components/autofill/core/browser/personal_data_manager.cc:225)
  ...
  extensions::ProcessManagerTest::ProcessManagerTest() (extensions/browser/process_manager_unittest.cc:39)

and a range of uninitialized reads/jumps.

Original issue's description:
> Remove deprecated extension notifications from ProcessManager and use ExtensionRegistry instead.
> 
> BUG=354046
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284366

TBR=rdevlin.cronin@chromium.org,limasdf@gmail.com
NOTREECHECKS=true
NOTRY=true
BUG=354046

Review URL: https://codereview.chromium.org/407883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284387 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284386 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178526:178529&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/407863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284385 0039d316-1c4b-4281-b951-d872f2087c98

The `const` was removed in http://crrev.com/283945 for the other
native widget types.

BUG=366007, 382301

Review URL: https://codereview.chromium.org/399133008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284384 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
NOTRY=true

No-try since it's the presubmit bot complaining about monsoon.py, which I didn't change.

Review URL: https://codereview.chromium.org/400873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284383 0039d316-1c4b-4281-b951-d872f2087c98

Disabled in r283311 to get a measurement on the effect on the bots.
Re-Enabling because we've collected the data we need.

BUG=356804

Review URL: https://codereview.chromium.org/408753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284382 0039d316-1c4b-4281-b951-d872f2087c98

BUG=84556
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/398083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284381 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284380 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/3f376a55002c205aacacc4cb16ed745e3afbad31..249171e7d29b5559f3eefe9dbd437030bfad3fda

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=robertphillips@google.com
BUG=

Review URL: https://codereview.chromium.org/403293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284379 0039d316-1c4b-4281-b951-d872f2087c98

This contains fixes for the following sorts of issues:
* Signedness mismatch
* Possibly-uninitialized local variable

These are the warnings that have appeared in the codebase since I began
uploading my first cleanup pass a few weeks ago.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/400313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284378 0039d316-1c4b-4281-b951-d872f2087c98

Include bold and italic styles in Fontconfig queries.

BUG=125235,395313

Review URL: https://codereview.chromium.org/403923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284377 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284376 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178525:178525&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/403283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284375 0039d316-1c4b-4281-b951-d872f2087c98

BUG=388016
TBR=armansito@chromium.org

Review URL: https://codereview.chromium.org/395633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284374 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/292463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284373 0039d316-1c4b-4281-b951-d872f2087c98

Temporarily disable -Werror on linux, since the gn build isn't yet
warning-free with clang. Since gn doesn't use -Werror for all targets yet
anyways (http://crbug.com/393046) that seems acceptable.

BUG=360311,393046
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/387693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284372 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284371 0039d316-1c4b-4281-b951-d872f2087c98

1952: Add test files for https://codereview.chromium.org/406523005/
1953: ninja/win: Put common msvs_system_include_dirs into %INCLUDE%

BUG=395405
R=scottmg@chromium.org
TBR=scottmg

Review URL: https://codereview.chromium.org/393033009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284370 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Copy the PGO runtime library to the release directory (https://codereview.chromium.org/402993002/)

Reason for revert:
pgort120.dll isn't present in the express version of VC.

Original issue's description:
> Copy the PGO runtime library to the release directory
> 
> BUG=395183
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284261

TBR=scottmg@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=395183

Review URL: https://codereview.chromium.org/401173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284369 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284368 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/402903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284367 0039d316-1c4b-4281-b951-d872f2087c98

BUG=354046

Review URL: https://codereview.chromium.org/397743005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284366 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284365 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178521:178524&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/407803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284364 0039d316-1c4b-4281-b951-d872f2087c98

OBJECTIVES

This change is to refactor RTCP handling in media/cast such that RTCP
message parsing is done in CastTransportSender.

This side effect of this refactoring is much cleaner code: RTCP handling
code are grouped under one module. VideoSender and AudioSender do not
handle packets directly.

This also affect the architectutre in Chrome that RTCP message parsing
is now done in the browser process. A parsed RTCP message is passed to
the renderer instead of raw packets.

REATIONALE

RTCP is used as a feedback mechanism in Cast Streaming. It used to be
parsed and handled by VideoSender and AudioSender in the render process.
This was very ineffective because packetization and sending is done in
the browser process. This created inefficiencies in packet
retransmission. It also made improvement to the transport protocol /
algorithm much more difficult. A side effect is very messy code.

DETAILS

Rtcp - This class is responsibile for maintaining a bi-directional RTCP
session. It is now owned by CastTransportSender.

CastTransportSender - It now performs packetization and also parsing of
incoming RTCP packets. RTCP packets are small UDP packets for signaling
only. Eventually retransmission can also be moved to this class. It will
handle all packet level send transport.

AudioSender / VideoSender - They don't handle packet directly any more.
Which means render process doesn't see raw packets.

FrameSender - Base class for AudioSender and VideoSender to share code
for RTCP message handling. Eventually AudioSender and VideoSender will
merge here but it is not the point of this change.

RtcpBuilder - Removed and merged with RtcpSender.

Net deleted 400 lines of code and simulation shows the same results.

BUG=393042

Review URL: https://codereview.chromium.org/387933005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284363 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284360 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284358 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284357 0039d316-1c4b-4281-b951-d872f2087c98

Negate the vertical glyph offset in RenderTextHarfBuzz.
Also restores the hb_buffer_set_language call and comment.
These were victims of merge errors in r284297.

BUG=391203
TEST=Arabic diacritics are drawn correctly.
R=ckocagil@chromium.org
TBR=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/408733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284356 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284355 0039d316-1c4b-4281-b951-d872f2087c98

This patch fixes a past-the-end iterator and relands
https://crrev.com/284335, which was reverted in
https://crrev.com/284340.

TBR=estade@chromium.org,aruslan@chromium.org
BUG=270261

Review URL: https://codereview.chromium.org/403923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284354 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393677
TEST=Ran on Linux. The file loaded and all tests passed.

Review URL: https://codereview.chromium.org/404713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284353 0039d316-1c4b-4281-b951-d872f2087c98

This type has subclasses and is destroyed polymorphically, so the destructor
needs to be in the vtable. Found by clang.

Follow-up to https://codereview.chromium.org/252513004/

BUG=347693,82385
R=sky@chromium.org

Review URL: https://codereview.chromium.org/407653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284352 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394491

Review URL: https://codereview.chromium.org/407683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284351 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338338
TEST=content_unittests
R=jam@chromium.org,jamesr@chromium.org
TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/403453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284348 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284347 0039d316-1c4b-4281-b951-d872f2087c98