- 20 Jan, 2020 40 commits
-
-
Koji Ishii authored
Following bot results are included. 1021 1022 1023 1029 1030 1031 1032 1040 1041 1048 1049 1050 1051 1052 1054 1056 1058 1059 1061 9 lines were removed and 75 lines were deflaked by consecutive results since 1029. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I4d54ae0146447e1fe2052bee226721d24c92ff55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007325Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#733342}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=olivierrobin@chromium.org Bug: 1042208 Change-Id: I42f47878447b96d7cc58d1d754b6f265248e913f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007425 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#733341}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/11c11a1a891c..5d3c6c53932a git log 11c11a1a891c..5d3c6c53932a --date=short --first-parent --format='%ad %ae %s' 2020-01-20 eseckler@google.com build: Remove dep on client lib from Chrome's libperfetto 2020-01-17 lalitm@google.com Merge "trace_processor: allow selecting rowmaps with smaller rowmaps" 2020-01-17 buss@google.com Merge "Fix compilation on Windows/VSC." 2020-01-17 hjd@google.com Merge "ui: Remove small gap in pinned track container" 2020-01-17 fmayer@google.com Merge "Cleanup of profile related trackers." 2020-01-17 eseckler@google.com Merge "client lib: Add an EventContext constructor for Chrome" 2020-01-17 lalitm@google.com Merge "bazel: Disable warning about unused system_header pragma" 2020-01-17 lalitm@google.com Merge "trace_processor: fix overflow in bitvector" 2020-01-17 taylori@google.com Merge "Make selection default behaviour" 2020-01-17 treehugger-gerrit@google.com Merge "GTEST_EXECUTE_STATEMENT_ is not available on iOS execute the statement directly instead." 2020-01-17 eseckler@google.com Merge "processor: Only fall back to legacy tracks for legacy events" 2020-01-17 treehugger-gerrit@google.com Merge "TrackEvent: Add initial legacy macro support" 2020-01-17 fmayer@google.com Merge "Function for on-demand flamegraph for heap graph." 2020-01-17 treehugger-gerrit@google.com Merge "Turn ingestion DFATALs into DLOG." 2020-01-17 khokhlov@google.com Merge "Exclude targets depending on sqlite from embedder builds" 2020-01-16 ilkos@google.com Merge "Remove symbols that are definitely not obfuscated" 2020-01-16 eseckler@google.com Merge "processor: Export pid/tid as signed integers into JSON" 2020-01-16 lalitm@google.com Merge "trace_processor: fix compile and build on fuzzer" 2020-01-16 joelaf@google.com Merge "Fix precision errors by explicit casting" 2020-01-16 lalitm@google.com Merge "Revert "GTEST_EXECUTE_STATEMENT_ is not available on iOS execute the statement directly instead."" 2020-01-16 chiur@google.com Merge "Add VulkanApiEvent.VkQueueSubmit message" 2020-01-16 khokhlov@google.com Merge "trace_processor: Run metrics on Windows" 2020-01-16 primiano@google.com Merge "gn: Fix issue with finding llvm when using python3" 2020-01-16 hjd@google.com Merge changes Ic6800bd0,I29636316 2020-01-16 treehugger-gerrit@google.com Merge "processor: Fix handling of 0 timestamp in TrackEventTokenizer." 2020-01-16 rsavitski@google.com Merge "heapprofd producer: use sigqueue(si_value: 0) instead of kill" 2020-01-16 taylori@google.com Merge "perfetto-ui: Toggle sidebar on ctrl/cmd + b" 2020-01-16 eseckler@google.com Merge "client lib: Support building in Chrome using a fake platform" 2020-01-16 eseckler@google.com Merge "processor: Translate duplicate pids/tids during json export" 2020-01-16 buss@google.com Merge changes I1bb0e215,I498ed990 2020-01-16 treehugger-gerrit@google.com Merge "processor: Support pid reuse in ProcessTracker without Start/EndThread" 2020-01-16 primiano@google.com Merge "GTEST_EXECUTE_STATEMENT_ is not available on iOS execute the statement directly instead." Created with: gclient setdep -r src/third_party/perfetto@5d3c6c53932a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1043279 Tbr: perfetto-bugs@google.com Change-Id: Ib1a9809a448d04bf1f51a07b80a24f9402ca4db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009831Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733340}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=gambard@chromium.org Bug: 1042208 Change-Id: I1b8e0708a07ca1947843688c953e802ff9c663d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010823 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#733339}
-
Olivier Robin authored
On google branding builds, the official keys are used. Make sure that the logic is the same in BUILD.gn files. Bug: 1043599 Change-Id: I4b603c467418094b5ff6ce1e7c573d7c89423a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007467Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#733338}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=gambard@chromium.org Bug: 1042208 Change-Id: I15d33299b50bc703ca8c00744771a610008a0dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007426 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Swapnil authored
installed extensions This is to get number of sessions where either everything is good or all failures are admin-side misconfigurations. Misconfiguration failure includes KIOSK_MODE_ONLY error when force installed extension fails to install with failure reason CRX_INSTALL_ERROR_DECLINED. There may be more misconfigurations, but for now we start with KIOSK_MODE_ONLY error. Following histogram is added: Extensions.ForceInstalledNonMisconfigurationFailures. It records true if at least one force installed extension failed to install with a non-misconfiguration failure. Bug: 981891 Change-Id: I637c48eeb7db71a01ddec4429f54c19158461942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000137 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#733336}
-
Internal Frameworks Autoroller authored
TBR=eugenebut@google.com Change-Id: Id64973baee918586b4d53165dabb00ee18d26a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007671Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733335}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 99b74338. With Chromium commits locally applied on WPT: 62f8d5f0 "Enable Scroll To Text by default" 363313c0 "Sort the registrations returned by getRegistrations() by registration ID." 8a985066 "[Trusted Types] Implement require-trusted-types-for" 0f8fd66b "[WPT/common/security-features] Support sub projects and split referrer-policy 4K tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib1d7d9fc96be1901ed073e6893284595fc4883fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009141Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733334}
-
Kamila authored
The flag mac-system-media-permissions-info-ui is still needed while the experiments are running, and during the roll out. Bug: 1043630 Change-Id: I990832e6f3d8e06a5dd931e5b2ce0dd7b667e584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010824Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@google.com> Cr-Commit-Position: refs/heads/master@{#733333}
-
Pâris MEULEMAN authored
This updates the timeout to long and splits into smaller tests the flaky COOP web-platform tests. Bug: 1042199, 1043401 Change-Id: I6295496a43b713efc4ba689d3cac01f8ae989262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003172 Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#733332}
-
Elad Alon authored
Bug: None Change-Id: I2d054bcd626237c9144385bf8cb523539a628d69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007756Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#733331}
-
Alexander Timin authored
Record calls to generate V8 bindings in traces — this allows to easier understand what the page is doing when looking at a trace. Because this has obvious binary size implications, this is hidden behind a gn flag and intended to be used only for local debugging. R=haraken@chromium.org,yukishiino@chromium.org BUG=1043618 Change-Id: Id21926fb93dbdb107d3c7d874795c5f4413a9d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006149 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#733330}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5029dac177fc..bcf142a3e122 git log 5029dac177fc..bcf142a3e122 --date=short --first-parent --format='%ad %ae %s' 2020-01-20 tvanderlippe@chromium.org Update TypeScript to latest version Created with: gclient setdep -r src/third_party/devtools-frontend/src@bcf142a3e122 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4e058ea28c801cf2788df13c9f948bc1c872a44f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009829Reviewed-by:
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=olivierrobin@chromium.org Bug: 1042208 Change-Id: Id8097e1b29d40d98fb0cef10227d6bf6735a44a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007758 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=droger@chromium.org Bug: 1042208 Change-Id: I62ff45d28f228e1db14f013d511e7a334062272c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010762 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#733327}
-
ewannpv authored
- Converts MobileDownloadFileUIShown MobileDownloadFileUIInstallGoogleDrive metrics to histogram - Makes IOSDownloadInstallDrivePromoShown histogram obsolete - Replaces UMA_HISTOGRAM_*() with base::UmaHistogram*() Bug: 1027570 Change-Id: I4fff49d5d610379014fb392557a9c35199ff97da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944351 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#733326}
-
Henrique Ferreiro authored
Move //third_party/blink/public/common/README.md into //third_party/blink/public/README.md, putting it together with the public/web and public/platform documentation. Bug: None Change-Id: I560e1c419939ae026f1704d0b1fa0597069cfb95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007746Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/52c3688f08ac..73387823a715 git log 52c3688f08ac..73387823a715 --date=short --first-parent --format='%ad %ae %s' 2020-01-20 srte@webrtc.org Cleanup: Removes MessageQueue header and alias Created with: gclient setdep -r src/third_party/webrtc@73387823a715 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I62b60aa0e28365f56d3cf2647c6643be52054f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009827Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0aba975494ce..0c10c9522a3b git log 0aba975494ce..0c10c9522a3b --date=short --first-parent --format='%ad %ae %s' 2020-01-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src b6ac1e60cd3a..ca9b61a4455f (1 commits) Created with: gclient setdep -r src/third_party/angle@0c10c9522a3b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: timvp@google.com Change-Id: Ic526e5e0007e58a2a208aab56925a2401356e37c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010166Reviewed-by:
-
Vasilii Sukhanov authored
- PasswordManager.InaccessiblePasswords - PasswordManager.LoginDatabaseInit Bug: 1037193 Change-Id: I8a5312c8a59caf547568cfdd41bbcebb6a518dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007708Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3903ed28c1bc..d1608370012b Created with: gclient setdep -r src-internal@d1608370012b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I126f61704cdcc642e8aeef1534afbbbef2b22a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009826Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733321}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=ioanap@chromium.org Bug: 1042208 Change-Id: Ide0309af716e265046f44128eef5f886bd6ce6ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007461 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#733320}
-
Colin Blundell authored
This CL prepares BlockedInterceptionBlockingPage as part of the preparation for componentizing //chrome's SSLErrorHandler. There are no //chrome-level dependencies after a predecessor CL, so the componentization is trivial. Bug: 1030692 Change-Id: Ica21033a720d26ec2ae47c6f3059a064d8bea414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000762 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#733319}
-
Colin Blundell authored
Currently SSLErrorHandler internally checks for whether the app is enterprise-managed as part of showing a man-in-the-middle interstitial. However, this check involves //chrome-level concepts and hence cannot be brought down into //components when SSLErrorHandler is componentized. This CL moves the check into ChromeSecurityBlockingPageFactory, which *is* the //chrome-level configuration for this interstitial. As part of this change, the infrastructure for overriding the value for tests is made significantly simpler. We also eliminate unittests of SSLErrorHandler that overrode the value and checked that the overridden value was honored; these tests are no longer relevant as those unittests don't use ChromeSecurityBlockingPageFactory, and the browsertests that remain provide a superset of that coverage in any case. Bug: 1030692 Change-Id: If1c8ed4813d80ba4bde5c83503ebcaa5d57858ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007211 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Md. Hasanur Rashid authored
Changes GetAccountsForDicePromos to return all accounts that have a token. Implement separate function GetSingleAccountForDicePromos to retrieve single account to use. Fixed: 1006167 Change-Id: I0b801216fe7bcd033bb8eabc6ab77ab5dc9ea9b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007309 Commit-Queue: Md. Hasanur Rashid <hasanur.r@samsung.com> Reviewed-by:
-
Himanshu Jaju authored
Previously we were renaming the devices and then filtering them based on enabled features and updated time. The updated version first filters the devices and then renames them for a better UX. Bug: 1042243 Change-Id: I65d6de664cc0570ff6278335abbc22f5514f1624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007712 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#733316}
-
Roman Sorokin authored
Fixed: 1024239 Change-Id: I7685dcf0177213fa27262759b2c6af961d6d13d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002869Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#733315}
-
Denis Kuznetsov authored
In multi-user session, only the primary user can use fingerprint authentication. Fix code that was using Active user instead. Bug: 1043283 Change-Id: I2d5b796838def792e1ee85d9533f225cb1e9fe54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007634Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#733314}
-
Simon Zünd authored
This is a reland of 61f91381 Tentative reland of the CL as-is because: - in the same time there was a general issue with crashing layout tests (especially on Mac) - the issue is not re-producible locally Original change's description: > Remove event races in two breakpoint decoration tests > > This CL changes two layout tests to follow the pattern of: > 1. Install an instrumentation promise > 2. Run and await an async action > 3. Await that the instrumentation is called > 4. Dump breakpoint information > > This CL is also in preparation for asyncification of source mapping, > hence making the "action" async. > > Drive-by: Re-baseline one of the layout tests that seems to be fixed > now. > > Bug: chromium:1032016 > Change-Id: Ibad4160fe9ab32aa3f818cdd4937112c3f4e6f08 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000023 > Commit-Queue: Simon Zünd <szuend@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#731171} Bug: chromium:1032016 Change-Id: I34ec151749a56a1820330546cd0214b0c22c9eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007458 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#733313}
-
Ali Juma authored
This CL makes components/safe_browsing/core/db buildable on iOS, and makes unit tests in this directory along with unit tests in components/safe_browsing/core/common run on iOS as part of components_unittests. Change-Id: I1c973eb9b9427ec82d48945d5a26d9d10d178c2b Bug: 1028755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001580Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#733312}
-
Shobhit Goel authored
Move the surface management code used in ContentViewRenderView ctor and onNativeLibraryLoaded() to separate and protected functions, so that subclasses can have finer control over surface management. BUG: None Change-Id: I04e7c83215af9b091ef85ea234b5f87680761243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895270Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Prashant Nevase <prashant.n@samsung.com> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#733311}
-
Finnur Thorarinsson authored
Use PostDelayedTask instead of a Timer, and only update the duration while the fade out animation hasn't completed. Bug: 895776, 656015 Change-Id: Id8c668bf89552cbd6c00c6cde0f002b0009c00c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007632 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#733310}
-
Kazuki Takise authored
IT's pretty dangerous to access an iterator in a function where the item is erased from the container. BUG=b:147640138 TEST=Closed a few ARC apps and confirmed the apps didn't crash. Change-Id: I6d66c2f7b5d2c77393681208e378fd6abd817a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006899Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Cr-Commit-Position: refs/heads/master@{#733309}
-
Jan Krcal authored
Some of the the single client wallet tests used imprecise and possibly flaky waiting routines -- waiting for PDM to trigger OnPersonalDataChanged() once. This can signify that it has reloaded new data from the WebDB but this notification is also triggered in various other situation so it can mean nothing. This CL removes this approach from all remaining tests (except for one where there's no better solution and where it arguably cannot cause flakiness) The CL replaces the previous approach with a more robust waiting loop that waits for such notifications until PDM has provably loaded new data. This CL also cleans up various helper functions. The CL only re-enables one disabled test, other tests will be enabled by follow-up CLs provided we see no new flakes. Bug: 1001975 Change-Id: I555a72ec07f0884285a39f0bdb5d184f70147fd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998520 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
-
Kamila authored
Fieldtrial config for enabling MacSystemMediaPermissionsInfoUI feature. Change-Id: I488af1efd8e977a8cea94cc095282b300d366052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005148Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
-
Swapnil authored
If the force installed extension fails to install after 5 minutes, report the session type using UMA histogram. A new histogram is created: Extensions.ForceInstalledSessionType Existing user manager returns the session type for sessions like: guest, kiosks, regular etc. using the GetType() method. Additional check is required in case of new regular users to differentiate sign-ins into existing profiles and new ones. Unit tests are added in InstallationTracker for checking Managed Guest Session and Guest Session. Bug: 981891 Change-Id: I27e1a30e450de09ddf534d3d2383ec53e45caede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970992 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/20775957bc71..3903ed28c1bc Created with: gclient setdep -r src-internal@3903ed28c1bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: If6f48af779d0455340a08e3a7cff3cecf578a99e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010210Reviewed-by:
-
Eriko Kurimoto authored
This CL implements static import for module script. The feature is still behind the flag. This CL also adds SharedWorker with type 'module' Web Platform Tests. Dynamic import is not yet supported, so WPTs which include dyamic import is expected to fail. Bug: 824646 Change-Id: I3b4a239f392736d226a736c011e3f5eb0a3e0d78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006995 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#733304}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/89e4a3082402..5029dac177fc git log 89e4a3082402..5029dac177fc --date=short --first-parent --format='%ad %ae %s' 2020-01-20 sigurds@chromium.org Provide frameId getter on Script 2020-01-20 sigurds@chromium.org [karma-tests] Add more tests for TextRange Created with: gclient setdep -r src/third_party/devtools-frontend/src@5029dac177fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1032561,chromium:1043120 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I475e2c1c94ee301cf25687c250dd11334ec2452e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010209Reviewed-by:
-
