- 03 Oct, 2019 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 452a3be9. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" c19433ef "Reland "[ChromeDriver] Stop using --ignore-certificate-errors"" afc509ca "[WPT/common/security-features] Fix typo" df884b61 "[WPT/referrer-policy] Add worker subresource tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio skobes@chromium.org: external/wpt/css/css-scroll-anchoring NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I2d1942a69b2bf0d8f1983aa1959da3ff17ada180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836314Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702532}
-
Jamie Madill authored
conformance/glsl/samplers/glsl-function-texture2dproj.html Bug: 1010942 Change-Id: I3abfc1d0abbf948842836f3921413f153907e991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837374Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#702531}
-
behdad authored
Instead of terminating reporter on DidNotProduceFrame, reporter should stay alive until later. It will be terminated if a frame is submitted, or will be overwritten if another activation happens before a frame is submitted. Bug: chromium:1010639 Change-Id: I44c36db0341de1126d2734718e48fcc904c61b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837652Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#702530}
-
Samuel Huang authored
This reverts commit 3f9553e2. Reason for revert: Consistent timeout in browser_tests: EditDictionaryA11yTest.EDIT_DICTIONARY_hidden_content on Linux CFI. Original change's description: > A11y: Label "delete word" button in setting's custom dictionary. > > Bug: 1008556 > Change-Id: Ib07aacbba4c611620e64228ae538e02d58aecd75 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827384 > Commit-Queue: Hector Carmona <hcarmona@chromium.org> > Auto-Submit: Hector Carmona <hcarmona@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702285} TBR=dpapad@chromium.org,hcarmona@chromium.org Change-Id: I3a7ea9fc5e045da47624652c9f4518f8f9ecd989 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1008556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838378Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#702529}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ab5d4d490562..f585476f768e Created with: gclient setdep -r src-internal@f585476f768e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I04b653b2bb5cf9780f4c28751370e183ad8141d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836515Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702528}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/880a3f812b03..a5afaefee543 git log 880a3f812b03..a5afaefee543 --date=short --no-merges --format='%ad %ae %s' 2019-10-03 lamontjones@chromium.org Revert "PRESUBMIT.cfg: verify that we work with signer." Created with: gclient setdep -r src/third_party/chromite@a5afaefee543 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I0e7d51b8120d1d330f9ddac42dfb4cb1aa3385bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838291Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702527}
-
Koji Ishii authored
This patch fixes bidi reordering sometimes confused by empty inline boxes. These items do not have resolved bidi levels. Before this patch, |NGInlineLayoutAlgorithm| reordered ignoring such items. This patch changes it to assign bidi levels to such items by copying from adjacent items and let reordering to handle them. Bug: 1010662, 1010641, 998872 Change-Id: I5d074143970b83b64bddbb83cd03b17551e3f521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837435Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#702526}
-
Aleks Totic authored
Using empty Optional<MinMax> to indicate that MinMax value should not matter caused trouble with ng_length_utils ResolveInlineLengthInternal, when max-width was fit-content. Use MinMax(0, LayoutUnitMax) to indicate intrinsic size does not matter instead. It accomplishes the same goal, computed size does not get clamped by intrinsic. I've also tested running it with width:max-content out of fear that we might end up with too wide OOF, but that did not happen. Bug: 1010798 Change-Id: Ife11b3d9637be91cc0648b7f8485af51f07108bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837118 Commit-Queue: Aleks Totic <atotic@chromium.org> Auto-Submit: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#702525}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8b7cc20e..563be8e7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6e4801a787f9cf852dfaa3aee65d1266060d0030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835815Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702524}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLOptionElement> and DynamicTo<HTMLOptionElement> as new downcast helper 2. Use IsA<HTMLOptionElement>(element) in place of IsHTMLOptionElement(element) Bug: 891908 Change-Id: I7a825d4ad59b9d8f5c148539b95581a964ac4634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803020 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#702523}
-
Luum Habtemariam authored
This adds correct handling of this service's failures by tacking on an http_status_code to the returned response. Any requests that fail parsing or validation generate a HTTP_STATUS_BAD_REQUEST. This involves a mojom interface uprev to MinVersion=1, first applied here and once this lands in ChromeOS will be followed by its counterpart crrev.com/c/1834650. Bug: chromium:945409 Test: tba Change-Id: Idacef1633fe6ea6d4c421f04c9dd54b4ce2fad74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834742Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#702522}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I867577b675d0357215732ccf4f835e0d425d1dd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837410Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702521}
-
Clark DuVall authored
This checks the version of the client and impl code, and throws an exception if they are not the same. Change-Id: I64b0d3a47a88d8490ac5fb1c174ad6fe4d9204a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829915Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#702520}
-
Evan Stade authored
Replace with a Shutdown() function that matches the KeyedService contract. This is called from ExtensionSystem from that class's own Shutdown(). Bug: 268984 Change-Id: If5074813e6bc3ff15c680281e865056e2b382b27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833075Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#702519}
-
Peter Boström authored
Fixes a11y checks when this experiment is enabled. The tooltip string might be replaced with different show/hide strings before launch. TEST=Turn on "WebUITabStrip" and run TopControlsSlideControllerTest Bug: chromium:1010750 Change-Id: Id2d920989a9b12645df5200e538a4d3650bb9b89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838073 Commit-Queue: Peter Boström <pbos@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#702518}
-
Rune Lillesveen authored
No need to set a recalc root initially. Change-Id: I27b0c5cd6bb0f0b50119e85b3a17b63a5619b3a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837793Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#702517}
-
Bettina authored
The change password card in the settings is not triggered from password protection so it should be removed completely. This is part 1 of the removal of the change password handler. The next CL will remove the files completely. Bug: 991764 Change-Id: I8e435d9ff517325cbca75eb41bc3a678fb282368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834950 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#702516}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b96a3118adf4..608083b66e54 git log b96a3118adf4..608083b66e54 --date=short --no-merges --format='%ad %ae %s' 2019-10-03 mirtad@webrtc.org Reset QP sum when QP is not reported on decoded frame. 2019-10-03 sprang@webrtc.org Reduces locking in RtpSenderVideo. 2019-10-03 srte@webrtc.org Removing AudioAllocationSettings moving functionality to AudioSendStream. Created with: gclient setdep -r src/third_party/webrtc@608083b66e54 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I8451962cf421fc2f1854a715d01ceccb2ef2d411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837981Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702515}
-
Tom Anderson authored
XShmImagePool did not handle cases where the shared memory segment size was limited. It put 2x frames (for double-buffering) into one segment, and reserved 1.5x space in case the window is resized larger. On modern Linux kernels (versions >= 3.16), the segment size is limited to 256MB. But a single 8K frame is 127MB. So 127*2*1.5 = 380MB exceeds this limit and will fallback to software rendering. Additionally, on kernels older than 3.16 (~5.5% of users), the size is limited to 32MB, which is just barely enough to fit a single 4K frame. To address these issues, 2 changes are made: * Each frame is put in a separate segment. * The 1.5x margin is only added if it won't exceed the max segment size. Also includes couple of bugfixes. BUG=991633,1007278 R=rjkroege Change-Id: I924f350b2ae8edeee3723d3cd9f1b3688d9e8f85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829655 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#702514}
-
Fredrik Söderquist authored
This reworks the way the interval is updated when the animation target changes. The code to handle "connect" and "disconnect" from the time container is moved into new methods AddedTo/RemovedFromTimeContainer(), which does tasks that was previously sprinkled about in SetTargetElement() and InsertedInto() and SMILTimeContainer::Schedule(). The call to ResetCachedAnimationState() in SVGAnimateElement is moved to the "removal" side since we now revalidate the animation state via SVGSMILElement::DidChangeAnimationTarget(). Bug: 998526 Change-Id: Ib6e847330cebc503cbca4a7cbd308b7a7ccc733a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837832Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#702513}
-
Nicolas Boichat authored
These bases should be treated as an internal device. (Also, reorder the list to sort by VID/PID and fix Whiskers device name) Bug: b/139521914 Change-Id: I12f58d72d4e6a30c8077ec0eb577d00cd77697ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833033Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#702512}
-
Hiroshige Hayashizaki authored
1. Previously, `@std/foo` bare specifiers are implemented by mapping them into `import:@std/foo`, but this caused allowing users to specify `import:@std/foo` URLs directly. This CL instead maps `@std/foo` to `std:foo`, and removes `import:` from the implementation, blocking any `import:` URLs. 2. Also, this CL centralizes the `@std/` URL processing into ParsedSpecifier::Create(), and plumbs a `support_builtin_modules` flag. The new plumbing code is needed because we no longer assumes built-in module support in import maps (Issue 1010751). Bug: 1010751 Change-Id: I49f8987867343542a4503d4e0446cfd49e0c4aa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836671Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#702511}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/0cd9a67ce84f..99938eab593d git log 0cd9a67ce84f..99938eab593d --date=short --no-merges --format='%ad %ae %s' 2019-10-03 digit@google.com [vulkan]: Implement VkSemaphore using Marl primitives. 2019-10-02 capn@google.com Fix integer overflow in image size calculation 2019-10-02 capn@google.com Verify the commit message has a Bug: line 2019-10-02 chrisforbes@google.com Consider all faces in TextureCubeMap::hasNonBaseLevels() 2019-10-02 chrisforbes@google.com Fix edge cases of creating EGLImages from cubemap faces 2019-10-02 sugoi@google.com Strict weak ordering for SamplingRoutineCache::Key 2019-10-02 chrisforbes@google.com Fix eglCreateImageKHR error logic for level=0 2019-10-02 swiftshader.regress@gmail.com Regres: Update test lists @ 0cd9a67c Created with: gclient setdep -r src/third_party/swiftshader@99938eab593d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/140421726,chromium:b/140421004,chromium:b/141892461,chromium:b/141916742,chromium:b/141916742,chromium:b/141916742 Change-Id: Ibe948614dc3ec2bbce3c3245602e69797df8b8c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837256Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702510}
-
Nina Satragno authored
Bug: 1011029 Change-Id: I0828fd90ad18d6233a61c9e58c600485f71eef76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838353 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#702509}
-
Fabrice de Gans-Riberi authored
This is a reland of 304c2408 Original change's description: > [fuchsia] Implement per-app remote debugging in CastRunner. > > * Handle the |enable_remote_debugging| parameter in > chromium.cast.ApplicationConfig to enable per-app remote debugging > in CastRunner. > * Set the CastRunner debugging port to 9222. > * Remove a buildflag to enable remote debugging Context-wide. > * Add a test to check remote debugging is properly enabled per-App. > > Bug: 997895 > > Change-Id: I19aced4e90790e77cc3f55b1118fbf459ae19b14 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773707 > Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702264} Bug: 997895 Change-Id: Ife9ac25676dbae1866a71cf2445899973f2e9962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837487Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#702508}
-
Ian Kilpatrick authored
Today we can end up in a state where the layout result cache for a LayoutBox contains a fragment tree which doesn't match the layout tree state. This occurs when we "abort" layout, i.e. 1) during the first pass children are positioned at a particular offset 2) a parent aborts layout due to resolving a BFC offset 3) the parent hits the layout result cache which has children at a different offset Bug: 1003558 Change-Id: Iabc5dfefd74c517222ec435cea376ad000a0372f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821674Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#702507}
-
Vladimir Levin authored
This patch adds an extra parameter to internal IntersectionObserver::Create to allow for possibility of delivering notifications via PostTask. R=szager@chromium.org Change-Id: I19bb463509e266a8f9bc68c592cd32ad6380d9c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836902Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#702506}
-
Juanmi Huertas authored
This reverts commit 71af7965. Reason for revert: We found a better solution than the revert so we are reverting the revert. Original change's description: > Revert "Fixing ShouldAccelerate to preserve acceleration" > > This reverts commit 0e20fdf5. > > This reverts a fix that will be reintroduced later on once we add > the WillReadFrequently to the creation of canvases. > > Bug: 1001845, 983642, 1008179 > Change-Id: I4e5aa58af69e1b202962eee37177e5cd0401c9a9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829794 > Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> > Reviewed-by: Fernando Serboncini <fserb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702174} TBR=fserb@chromium.org,juanmihd@chromium.org Change-Id: Ic6c7dc0b6fa30d741f8e7de00c127673933cd7f4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1001845, 983642, 1008179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838372Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#702505}
-
Yulun Wu authored
Bug: 1010724 Change-Id: If783bd10bba4157bcd5c1a18337d524eb26e62d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836276 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#702504}
-
Matt Menke authored
Also fix the LoadingPredictor tests that failed when it was enabled. Bug: 963480 Change-Id: I4c8d87d0d97bfd4e8e4e639921da4cd4f908ca5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832248 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#702503}
-
Christopher Cameron authored
This is no longer needed, as we now only do mojo over mach. TBR=rsesek Bug: 942213 Change-Id: I677e1e405dbfe47ff5917743943fcdf9995a6668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837376Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#702502}
-
Bettina authored
Expand phishguard to show warnings on saved password reuse on phishing sites. Bug: 1010764 Change-Id: I7ea4f49ab6afaac8d2229a011356d77f35d10612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837092 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#702501}
-
Tim van der Lippe authored
After converting the `ui/` folder to ESM, there was a significant performance regression in terms of file size of the `resources.pak`. It turns out that we were not minifying ESM files, but we did do that before with Closure. Update the `copy_devtools_modules` to also invoke rjsmin to minify the JavaScript source code. Before: $ du -h -B K out/Default/resources.pak 12096K out/Default/resources.pak After: $ du -h -B K out/Default/resources.pak 11752K out/Default/resources.pak Before the original CL transforming `ui/` landed: $ du -h -B K out/Default/resources.pak 11860K out/Default/resources.pak This means that after converting `ui/` to ESM, we saved 90KB. We suspect this is because we are no longer transpiling to ES5, but instead serve source ES6. Bug: 1010910 Change-Id: I7dd07ff788d014e9f9a8e25e168c58c010cd00af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837814 Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#702500}
-
Hiroshige Hayashizaki authored
This CL adds ImportMaps feature separetely from BuiltInModuleInfra, to enable import maps separately from built-in modules. This CL only does very basic migration from BuiltInModulesInfra flag to ImportMaps flag. Subsequent CLs will implement more logic to disable built-in module-related things when ImportMaps && !BuiltInModulesInfra. Bug: 1010751 Change-Id: Iec722de822750b60a7dcfbf70910338bbdd4aa9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836600Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#702499}
-
Varun Khaneja authored
See discussion here: http://shortn/_slnTdcsaT9 R=bdea, dvadym Bug: 1010158 Change-Id: Ib8c881acf825078ed0471e9a838e678ecccb15c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832408 Commit-Queue: Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#702498}
-
Tibor Goldschwendt authored
This is a reland of d205c616 Original change's description: > Add native resource to dummy module and test loading in smoke test > > * Adds a new PAK file with a dummy resources. > * Refactors the TestDummyModuleProvider to to synchronously load the > module PAK file when retrieving the impl. > * Adds a friend to ScopedAllowBlocking in order to be able to memory > map the module PAK file on the main thread. > > Change-Id: I0a3b949b83b37a7089aa410a691de6ae28f9a36a > Bug: 989646 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822847 > Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Christopher Grant <cjgrant@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Samuel Huang <huangs@chromium.org> > Reviewed-by: Fred Mello <fredmello@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702423} TBR=twellington@chromium.org,cjgrant@chromium.org,dcheng@chromium.org,agrieve@chromium.org,huangs@chromium.org,fredmello@chromium.org Bug: 989646 Change-Id: Ifab13d56aead63532ab57000e7253d0ce89f75b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837485Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#702497}
-
Matthew Jones authored
Failures as a result of https://chromium-review.googlesource.com/c/chromium/src/+/1833821 Couldn't revert offending patch because of a merge conflict. See bug for more details. TBR: mvanouwerkerk@chromium.org, alexchau@chromium.org Bug: 1010998 Change-Id: I007565f9bb8f769b4afa69ab6895b4cf07865027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836995Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#702496}
-
Jon Mann authored
TBR=treib@chromium.org Bug: 966270 Change-Id: I2a210207d19471f56295f2a7e967fdf8ac01214f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819496 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#702495}
-
Patrick To authored
OpenXR currently uses the XR_REFERENCE_SPACE_LOCAL space to send the transformation matrix back. This is incorrect because the head corresponds to XR_REFERENCE_SPACE_VIEW, and the orientation also needs to be added to the transformation matrix. This change queries the views based at the XR_REFERENCE_SPACE_VIEW space and returns the transformation matrix containing the position and orientation back to blink. Bug: 999573 Change-Id: I365b1346f15f4d48dfad85dc1df4d0039d9b8c49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828721 Commit-Queue: Patrick To <patrto@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#702494}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/448444596bbc..687249cc9ed7 git log 448444596bbc..687249cc9ed7 --date=short --no-merges --format='%ad %ae %s' 2019-10-03 primiano@google.com GN: fix cross-compilation support 2019-10-03 fmayer@google.com Merge "Alow to set BufferExhaustedPolicy in client API." 2019-10-03 taylori@google.com Merge "perfetto-ui: Go to CPU sched slice" Created with: gclient setdep -r src/third_party/perfetto@687249cc9ed7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:141319350 Change-Id: I876bd09caa1f46e7f622d4fdcaa183ec232c7036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837259Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702493}
-