- 09 Sep, 2020 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2f163ad2. With Chromium commits locally applied on WPT: de03f74d "WPT: Refactor contacts tests to use test-only-api.js" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: igrigorik@chromium.org, yoavweiss@chromium.org: external/wpt/preload yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: I7ed51e9e0ceae873cb066e5af21ac7849d9715b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401058Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805303}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ca9406bac452..b7310899f126 2020-09-09 hjd@google.com Merge "Revert "Revert "ui: Upgrade mithril 1.0.2 -> 2.0.3""" 2020-09-09 treehugger-gerrit@google.com Merge "Ensure that our join key doesn't contain "NoJank"." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1b18f384e8535efadfc1fba80f513cc7fffe4d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400883Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805302}
-
Adithya Srinivasan authored
This reverts commit 74b8ec6f. Reason for revert: Suspect that its causing ios test failures in bots, see https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-noncq/11779 Original change's description: > [Empties] Enable the IllustratedEmptyStates field trial testing config. > > Change-Id: I664fa63b5b69369cb69fb4b87463ba3bb4cfc94d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386295 > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: sebsg <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805136} TBR=holte@chromium.org,sebsg@chromium.org,sczs@chromium.org Change-Id: I5a1aa3987b4591a1a5b511df4d3834c1455ea643 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401300Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#805301}
-
Miguel Casas authored
Decoding a bitstream in VA has two steps: one, submitting the parsed parameters and encoded chunk, and two, executing the decode. For the first part, ToT VaapiWrapper submits every piece of data individually, acquiring and releasing |va_lock_| every time. This is unnecessary, so this CL refactors the SubmitBuffer() method into a new SubmitBuffer_Locked() and adds a SubmitBuffers() to bundle a couple of submissions together. This is verified via chrome:tracing and codepen.io/full/RwarYvG that plays 4 1280x572 VP9 videos at the same time. Tracing is captured for a few seconds, results are summarised in [1,2], basically: The total decode CPU time doesn't change much on neither kohaku nor Braswell(reks) but batch-submitting takes less time, specially on BSW from ~3x0.089ms= ~0.267ms to ~0.236ms [3], so about 10%. Having less contention in the Lock makes for an ancillary reduction in Execute_Locked() from 3.295 to 3.165ms. Improvements are of course extremely small, the advantages of this CL are in reducing lock/unlock churn and associated contention. This benefit grows with the amount of decodes (e.g. Meet grid scenarios). Later CLs will migrate the other decoders, and possibly avoid the call to vaCreateBuffer() that takes a good 50% of the SubmitBuffer/s() time. [1] Kohaku w/o patch https://imgur.com/a/nVuE0Nk, [2] Kohaku with patch https://imgur.com/a/xhdbqHn [3] VP9 ToT calls SubmitBuffer 3 times per incoming encoded buffer. Bug: b/166646505 Change-Id: I1b8e36bb1d7107b5367b0b41137e2dc6625e1569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393629 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#805300}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599609504-d5a4da8648bee9c45af68f0bedc0e876fcbf0d82.profdata to chrome-mac-master-1599651808-76687bf9821b87304e86bb785c30a5b3566b2da2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I91fe8486bd7bc100144bf9ce19a4e34587d45996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400277Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b820513f2f27..88a5d76f5f62 2020-09-09 tvanderlippe@chromium.org Fix auto-unittest compile target 2020-09-09 mathias@chromium.org Force accessible link color for invalid network requests 2020-09-09 tvanderlippe@chromium.org [globals] More cleanup 2020-09-09 alexrudenko@chromium.org Remove unnecessary file pattern in karma.conf.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1058320 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I774842637aaa5376c8ba79601cb942029e8c2969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400882Reviewed-by:
-
kylechar authored
The tests no longer fail under msan/tsan. Bug: 974283 Change-Id: I61c6ab9711fc9e40837d5e79e59058ae5262b827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399445 Auto-Submit: kylechar <kylechar@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#805297}
-
Francois Doray authored
Normally, Intensive JS Timer Throttling is enabled when a tab has been hidden for 5 minutes. To facilitate testing, about:flags provides an option to enable the intervention immediately when a tab is hidden. Unfortunately, this affects timers set with a short timeout from the visibilitychange event and leads to unrealistic test condition. To provide more realistic test conditions, this CL changes the about:flags entry to enable the intervention when a tab has been hidden for 10 seconds. Bug: 1075553 Change-Id: I4594e920c3214d7e335851b941acb9bbe85aac65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399305Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#805296}
-
Peter Boström authored
The specific UAF happens as a views::Checkbox callback deletes the dialog in which it was hosted. Because the client pointer is cached in InputMethodAuraLinux::ProcessKeyEventDone there's UAF after that point. The fix checks if GetTextInputClient() has changed after InsertChar() or InsertText() and returns early, stopping event propagation. Bug: 1125187 Change-Id: Id6a277858adf69011d56627893a98b5603eee503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399245Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#805295}
-
Josh Nohle authored
Use an expiration scheduler to notify the certificate manager when a public certificate has expired. Then, remove all expired public certificates from storage. Fixed: b/166117022 Change-Id: I28b019d805518e9f9520ccd427840f75bd5bee1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377070 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#805294}
-
Josh Nohle authored
Call GetDeviceState RPC in contact downloader to check in the user's contact list has changed since the last upload to the Nearby Share server. While waiting for the GetDeviceState RPC to be implemented, we assumed contacts always changed; now, we invoke the RPC. Fixed: b/166115703 Change-Id: I4954673d3ba55c335311c782ded6bc5d6360daf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399899Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#805293}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7598f4b003ea..48df087f8a86 2020-09-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 10121443c16d to ce08265ba5b7 (3 revisions) 2020-09-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 1ab52e54abfd to a715b1b40535 (2 revisions) 2020-09-09 syoussefi@chromium.org Vulkan: Free 8 bits in RenderPassDesc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I6492177b62fb30bc171ad4a70c1156cc3479577d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400274Reviewed-by:
-
Hwanseung Lee authored
Use enum class instead of enum for BoundsAnimationMode. enum class is more type safety. Bug: 940736 Change-Id: Idc09b7b7f3beec8b179a989e1f5a7e02d7d4734f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400581 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#805291}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f9d5940fef55..81c6d6eeb4cf 2020-09-09 herb@google.com move canReuse to sub runs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: Ib56349bfca12c9812cf3fe563253c773579b449c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400881Reviewed-by:
-
Kramer Ge authored
TestSubsurface has a ptr to MockSurface wl_resource which may incur use-after-free if MockSurface is destroyed first. Do the same thing we do for MockXdgSurface in MockSurface dtor to avoid it. Change-Id: Ia63c187485c39033f715f446cc724fcc4043b46a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391388Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#805289}
-
Marc Treib authored
These constants used to be defined in the factory and passed into the service. However, they're always the same, so might just as well be defined directly in the service. This avoids having to duplicate them in other factories (for iOS). Bug: 1102314 Change-Id: I518dcd04524f5a7e7e9399d66a4adc775df2aaf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400419 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#805288}
-
Ali Juma authored
This CL uses TaskShutdownBehavior::BLOCK_SHUTDOWN for the background task runner associated with an SQLLitePersistentCookieStore, matching the behavior in content/. This ensures that when an SQLLitePersistentCookieStore is destroyed, the call to SQLitePersistentStoreBackendBase::DoCloseInBackground posted to the background thread gets executed before the SQLitePersistentStoreBackendBase is destroyed, fixing an assertion failure. Bug: 1121986 Change-Id: I77c7fad335b07508fb316fc6b1a88b822692893d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398510Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#805287}
-
Antonio Sartori authored
The previous implementation returned `true` for `*.example.com` subsumes `example.com`. However, since `*.example.com` does not match `example.com`, this should not be the case. And indeed according to 2.3.3 in https://w3c.github.io/webappsec-cspee/#subsume-source-expressions in this case the subsume algorithm should return `false`. Bug: 1086857 Change-Id: I449f72d2db0a918478fc1ba4250335ae57a4ae2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210463Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#805286}
-
Henrique Ferreiro authored
Replace NullableString16 with Optional<string16> from blink::Manifest and blink::PlatformNotificationAction, the last two usages of NullableString16 in Blink. Also, remove the exception to use this type from audit_non_blink_usage.py. Bug: 604860 Change-Id: I3cbed115d887b6e17d61220d24a15a38026d263a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233060 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#805285}
-
Swapnil authored
Extensions.ForceInstalledFailureUpdateCheckStatus always returns "no update" status in case of CRX_FETCH_URL_EMPTY error. This was verified by the statistics we gathered. This histogram is no longer required. Bug: 1109934 Change-Id: I7656a40de99d83b8acfdd0b29dd202cbb64371c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380271 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#805284}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fc89f636b89f..ca9406bac452 2020-09-09 hjd@google.com Merge "Revert "ui: Upgrade mithril 1.0.2 -> 2.0.3"" 2020-09-09 ssid@google.com Merge "Remove log that spams tests" 2020-09-09 taylori@google.com Merge "perfetto-ui: New version of marking" 2020-09-09 fmayer@google.com Merge "Heap Profiling quickstart for Windows." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1fe29b00b3fe8d5e35d90a71290a6d978301ad1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400273Reviewed-by:
-
Jose Dapena Paz authored
GCC: make begin/end/empty methods of StringPiece constexpr to allow them to be called from base::ConsumeDurationNumber Compilation fails in GCC in base::ConsumeDurationNumber, as it is a constexpr but it calls methods begin/end/empty in StringPiece that are not constexpr. This change makes them constexpr. ../../base/time/time.cc: In function ‘constexpr base::Optional<base::{anonymous}::ParsedDecimal> base::{anonymous}::ConsumeDurationNumber(base::StringPiece&)’: ../../base/time/time.cc:67:63: error: call to non-‘constexpr’ function ‘const value_type* base::BasicStringPiece<STRING_TYPE>::begin() const [with STRING_TYPE = std::__cxx11::basic_string<char>; base::BasicStringPiece<STRING_TYPE>::const_iterator = const char*; base::BasicStringPiece<STRING_TYPE>::value_type = char]’ 67 | StringPiece::const_iterator orig_start = number_string.begin(); | ~~~~~~~~~~~~~~~~~~~^~ Bug: 819294, 1049498 Change-Id: If8813ac2651ac444cde7b874a1540c98c256c5b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394159Reviewed-by:Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#805282}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6c5e5870e09f..b820513f2f27 2020-09-09 sigurds@chromium.org Rewrite heap snapshot test as e2e test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1110817 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I91dfa280b949527ad7089776b56d852990c9c6be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400880Reviewed-by:
-
Egor Pasko authored
Not having csv imported causes the memory benchmark results to be reported as: "Error: global name 'csv' is not defined". Perhaps in the past the module was imported from some other file. Adding the necessary import will not fix the bug, rather will make us closer to see how bad the coverage-for-memory has been recently. When the bug gets fixed, it would be interesting to see whether it affected the memory usage. Bug: 1117184 Change-Id: I6ee502298e1d88aadbeb7a5866128743557cd753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401039 Commit-Queue: Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Auto-Submit: Egor Pasko <pasko@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#805280}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/12e97ed6a789..0a1061da0c7f 2020-09-09 aleksi@sapon.ca Fix CMake build with MSVC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I61ee9f75ede137365de6ca0fb02298842562ea9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400272Reviewed-by:
-
Saurabh Nijhara authored
Most of the unit tests only require a single requirement in the policy value and the code to create such policy value is getting repeated in all tests. Now, extracting the code to create policy value into a function. Bug: 1126163 Change-Id: Ib4bd5743420c9dc962ca37216b9c2e0d9e3adb7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398721Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#805278}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/fa82803f46aa..cb4733136992 2020-09-09 apodtele@gmail.com [raster] Introduce SMART macro. 2020-09-09 apodtele@gmail.com [raster] Improve tracing. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I1980f1f3040dfd36bc321187f67d84ec177cd9d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399884Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#805277}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/209d12c8b5b4..f9d5940fef55 2020-09-09 csmartdalton@google.com Use exp2 instead of ldexp/shifts in the middle out cubic shader If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: Ic99159c21a7cd57060dbef2cc42a7f03b5a08b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400266Reviewed-by:
-
sandromaggi authored
There are some crashes from |WebController| when resetting the keyboard state through the |AutofillAgent|. These can happen if the |RenderFrameHost| is no longer valid when the final callback to clean up the state is executed. Bug: 1119918 Change-Id: I9bcd69ae125a1ab7918bc5671cb3b95c4cc82d71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396121 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#805275}
-
ssid authored
Support stack unwinding for tracing sampling profiler, in arm64 builds. The builds always enable frame pointers, so stack unwinding can be done using frame pointers. Future work: Support module cache for arm 64. BUG=1110044 Change-Id: If98bcc5582edc75b61c5a385cd29535f4a6ee195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321230 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#805274}
-
Eric Lawrence authored
This policy controls the ability of cross-site images to trigger auth prompts when a page is loaded. The policy applies only to images, and applies to all HTTP authentication types (Basic/Digest/NTLM/Negotiate). This CL updates the policy caption for accuracy. Bug: 1124044 Change-Id: I6b6c06f3c73e524583262b623f0ea8ccd4ff5a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398893 Auto-Submit: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#805273}
-
Arnaud Mandy authored
use of test-only-api.js in preparation for launching official MojoJS support in WPT. This would not change the test results on Chromium waterfall (everything should continue to pass) or upstream WPT (tests currently fail because MojoJS isn't enabled). Bug: 1123989 Change-Id: Ib7fed092b37243b82fbbf38d871bb75728cb7744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395395 Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#805272}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9d7944292456..fc89f636b89f 2020-09-09 hjd@google.com Merge "ui: Upgrade mithril 1.0.2 -> 2.0.3" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I61c023fa0f9eaf9c5c702e6ffcd7740acb465f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400267Reviewed-by:
-
Stepan Khapugin authored
This property was replaced with the UI blocker abstracted in a protocol in crrev/2288853 but it was still used in a few places, thus that CL introduced bugs, including potentially showing sign in promo when the blocking UI is shown, and switch-to-open-window button never working. Remove this property and replace it by extending UIBlocking* protocols. Bug: 1103565 Change-Id: Ib79d2968c1fe545ef5cd87cc196802ad6097345c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398684Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805270}
-
Oleg Davydov authored
When device is suspened during the session, session length limit should apply correctly. The new test simulates suspend and resume and verifies that session will be terminated at correct time. Bug: b:160454261 Change-Id: I382d5bd3c7b5a64e49783ed97eec08e19ff91810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283591Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#805269}
-
Alex Ilin authored
The histogram will be useful for the upcoming unbundled OAuth consent launch. Bug: 1109959 Change-Id: I48aef399b3970e49aee21b23dc72f8d74d8c4cc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400499 Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#805268}
-
Christian Dullweber authored
The flag is needed outside components/page_info/android. Bug: 1077766 Change-Id: Iae87a1229eec1aa0cedf8b957b1bfb940f2d941c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400519 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#805267}
-
Arthur Hemery authored
Reuses the general check for SiteInstance compatibility regarding COOP+COEP isolation. Bug: 1107814 Change-Id: I0ec25d36a650e23a103d2d509c034d240f953b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398520 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#805266}
-
Azhara Assanova authored
1. testMergeDuplicatesAndHidden: checks that hidden crashes are removed from the returning list 2. testUploadCrashLogFileWithNewCrashInfo: checks that updates the crash JSON log file with the new crash info Bug: 1059944 Test: run_webview_instrumentation_test_apk -f *WebViewCrashInfoCollectorTest* Change-Id: Id465000b2035a4efa91b59399ca961122e8fae4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379777Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Laís Minchillo <laisminchillo@chromium.org> Commit-Queue: Azhara Assanova <azharaa@google.com> Auto-Submit: Azhara Assanova <azharaa@google.com> Cr-Commit-Position: refs/heads/master@{#805265}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/5f71fdf34b76..ce08265ba5b7 2020-09-09 capn@google.com Fix register assignment for constant arrays If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I0cbebc5b1723f429b859ddf2554bcf058387b1dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400178Reviewed-by:
-
