- 16 Jan, 2020 40 commits
-
-
Jeremy Roman authored
This is already used for determining whether ancestors are permitted. It needs to be used also for figuring out which ancestor's console to log in. A web test that reaches this code using X-Frame-Options: DENY is included. Without the change to content/, this test fails with the same stack trace as in the linked bug. Bug: 1038256 Change-Id: Iad3623d82e0b2192eab626a2184d09d9d3e7be62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002967Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#732421}
-
Rodney Ding authored
Bug: 1038837 Change-Id: Ib53707932ff3091a427bbbc1f7bad97d469f10e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995640Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rodney Ding <rodneyding@google.com> Cr-Commit-Position: refs/heads/master@{#732420}
-
arthursonzogni authored
1) Merge - content::CSPDirective::Name - network::mojom::CSPDirective::Name 2) Mojo code generation do not forward declare enum nested into a class. The file "[...].mojom-forward.h" do not contain them". To avoid slowing compilation down, this patch makes the enum to be declared outside of the class. See UnifyCSP: https://docs.google.com/document/d/1v5mJnXJ5dSVXE_rgvJnNM9bzH0ni0YzdhPQ7GLqyhao Bug: 1021462 Change-Id: I9a3166e86f00577aac78bf29d0e655e5220c754b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000025 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#732419}
-
Gauthier Ambard authored
This CL fixes the constraints used for the elements at the top of header of the NTP. Some were badly updated after changing using content inset vs resizing of the collection view. Others were broken because the SafeArea of the HeaderView is wrongly updated when the NTP is rotated after scrolling a bit. Fixed: 1041831, 1039795 Change-Id: I5ca7caf3bd41cdcf8c1b1018f32ccf6125d28788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000758 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#732418}
-
Sigurd Schneider authored
TBR=yangguo@chromium.org Bug: chromium:1030746 Change-Id: Ie9a933d7ae5423429ad46e2ed533c6ea794b9705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002522 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#732417}
-
Andrew Xu authored
The current minimization animation, which is triggered by going to home screen from in-app shelf, uses the bounds of the icon which corresponds to the active window to be minimized as the animation's target bounds. However, hotseat's bounds change due to entering the home screen. As a result, the target bounds are not the final bounds. This CL fixes the issue by providing an interface to calculate the icon's bounds according to the hotseat's target bounds instead of the actual bounds. There are four ways to show the home screen from in-app shelf: (1) Press the home button. (2) Gesture fling up on the hotseat. (3) Back gesture. (4) Tap on the shelf icon. In case (1), hotseat's target bounds have been set before starting the window scaling animation. In other cases, target bounds are not set yet. Thanks to https://crrev.com/c/1999443, case 3 and case 4 are solved. The last one, case 2, will be fixed in the following CL. Bug: 1030819 Change-Id: I63cafabe6527aba49e9f98e338f9f248284e1d0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996268 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#732416}
-
Charlene Yan authored
There is currently a border around each part of the visible circle that is part of the button and receives events. In order to have each color have equal target hit sizes, the group modifier container is made slightly larger (to contain the entirety of its children) and then the title field is inset-ted inwards by the same amount. The title field also needs its own container since views::Textfield has special logic for its borders. Bug: 1015634 Change-Id: Ia9431f125da7ee654acf0d327e15e7f1b513c9a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999104Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#732415}
-
Leonard Grey authored
This reverts commit 0593d72b. Reason for revert: Compiles failing, examples: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/1791 https://ci.chromium.org/p/chrome/builders/ci/win32-builder-perf/148062 Looks mostly like ifdefed callsites that weren't migrated. Original change's description: > [base] Migrate PostTaskAndReplyWithResult to OnceCallbacks > > This change migrates users of base::PostTaskAndReplyWithResult to > use base::OnceCallbacks. This allows removing the CallbackType template > from the API, making sure future users are required to use OnceCallbacks. > > TBR=danakj > > Bug: 714018 > Change-Id: I8453c351e406a98fc8b9fddce2637331fdbbf5c4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965664 > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732403} TBR=lambroslambrou@chromium.org,danakj@chromium.org,jdoerrie@chromium.org Change-Id: I9a417e1d289c750f5ce5e1f43972bf09c0b23e4f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 714018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004968Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#732414}
-
vitaliii authored
We want to propagate failed commit item errors all the way from server to bridge. This is first step. Propagate failed commit items from NonBlockingTypeCommitContribution to ClientTagBasedModelTypeProcessor. Bug: 1034923 Change-Id: I9599fa09907ee1e59c390559f9a1b7593a815ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985969 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#732413}
-
Annie Sullivan authored
These are obsolete now that the experiment has completed. Bug: 1041531 Change-Id: I3669019eba1fbd0b8425a02a6b2deeb0f1f05204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999771 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#732412}
-
Florent Castelli authored
Bug: 803494 Change-Id: I8e2997bae643f2b5f2f4ae82a3aff8496dd25483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002573 Commit-Queue: Florent Castelli <orphis@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#732411}
-
Pâris MEULEMAN authored
The test is flaky with timeouts not failures. Bug: 1042199 Change-Id: Ia2079d2437e7bc158841c8c7aee855aaa088dae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002621 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#732410}
-
Sebastien Marchand authored
We don't plan to ship this. This also rename the proactive discarding and tab freeze experiment to TabFreeze. Bug: 844426 Change-Id: I8cffc01036a976b40da9458ef516f8ca68bcc26a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994427 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#732409}
-
Sergey Poromov authored
https://crrev.com/c/1926146 introduced a bug that util::IsDriveEnabledForProfile() might return true for incognito profiles that are associated with Gaia user that leads to crashes. Previously such check existed in IsProfileAssociatedWithGaiaAccount() but was mistakenly treated as redundant. Bug: 1034621 Change-Id: I041b418f16204db4680645e7cd8a3321da3ebc2d Tests: Manual. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003852 Auto-Submit: Sergey Poromov <poromov@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Annie Sullivan authored
The UMA were updated in the code to version for in October, but the histograms.xml file was not updated: https://chromium-review.googlesource.com/c/chromium/src/+/1834116 These metrics are still in active use, so extending for another year. Bug: 1041530,1032114 Change-Id: I64b4bbd09d38c1d3c0695a229b964f5278102e22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997645 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Auto-Submit: Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#732407}
-
Ali Juma authored
This is a follow-up to http://crrev/c/1992353, using the utility functions added in that CL to replace direct usage of BrowserThread everywhere in components/safe_browsing/core. This is a step towards removing dependencies on content/ from components/safe_browsing/core. Change-Id: Ieafd8c27c40b3c57374596f17d8c777d38b13247 Bug: 1028755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999334Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#732406}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/849589ec..59e7ca81 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1c565baea3250b3ccdb7fb01f07d50dc9193d28f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004688Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732405}
-
Ian Vollick authored
With this change, the paint preview tracker will associate the page URL with the video rect. Bug: 1026308 Change-Id: I074639face279875e5def0bf158cb53a32f2afdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999292Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#732404}
-
Jan Wilken Dörrie authored
This change migrates users of base::PostTaskAndReplyWithResult to use base::OnceCallbacks. This allows removing the CallbackType template from the API, making sure future users are required to use OnceCallbacks. TBR=danakj Bug: 714018 Change-Id: I8453c351e406a98fc8b9fddce2637331fdbbf5c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965664 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#732403}
-
Jonah Ryan-Davis authored
Test: conformance/uniforms/out-of-bounds-uniform-array-access.html The breaking CL was reverted, this should now pass. Bug: chromium:1042252 Change-Id: I96a76566ef5020b08d61965980b5d8be7ad1cbfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002891Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#732402}
-
Jonah Ryan-Davis authored
The passthrough calls glBlitFramebuffer, so this extension should be added as required. ANGLE implements this extension on all backends. Bug: chromium:1029829 Change-Id: Iaccedfd8ae0000b06b5b8126b9c1c86679767e67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002936Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#732401}
-
Stephen Chenney authored
Adjust the exponential decay to decay more rapidly (about 3x higher exponent) to reduce the number of samples we send. ` Bug: 1035531 Change-Id: Ie6de6eaca5c6dc49cd2e674e4c9d82f30d59c294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003291 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#732400}
-
Marc Treib authored
On receiving an auth error (HTTP 401), PerUserTopicSubscriptionManager invalidates the access token and retries, based on the assumption that the access token was likely expired. That makes sense once, but if the second request fails with an auth error again, there's really no point in trying again. In some cases, it might even lead to an infinite loop of invalidating and re-requesting access tokens. This CL changes the behavior so that a request is retried exactly once on an auth error. If it fails again, it is abandoned (which already happens for all other 4xx errors). Bug: 1020117 Change-Id: I0c83d3eaa5bafcc8d9f81315921f8375661371af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000625 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Roger Tawa authored
This refactoring is a pre-requisite for hooking clipboard paste to upload content checks for enterprise users. See crbug.com/999150 for more details. Bug: 999152 Change-Id: I2ddc8d25435abff4abc00437de7a284708e5f842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877532 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
-
David Roger authored
The correct access point is always ACCESS_POINT_AVATAR_BUBBLE_SIGN_IN. Fixed: 1041469 Change-Id: Ia698fec6da8a221f36188a87f899a0bbd4a10d4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000639 Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#732397}
-
Jan Wilken Dörrie authored
TBR=akihiroota Bug: 1042673 Change-Id: Iccf2064ee5b817bc9e7f12c026cd8569e39d22b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002816Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#732396}
-
Chris Lu authored
This change caters to users that have a tendency to toggle between a different language and the original language of a page. Bug: 1014959, 1042410 Change-Id: I718124ce7791762f7311e511e2cac6d5d7d5a671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003252 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#732395}
-
Jan Wilken Dörrie authored
This change updates the mutable base::Value::GetList() to return base::Value::ListView instead of base::Value::ListStorage&. This improves both encapsulation and safety, as now all accesses to the underlying Values are bounds-checked. TBR=dcheng Bug: 646113,990059 Change-Id: Id7d61862bf7cab1f7341f2c215f07249dbadf3b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801107 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
TBR=foolip Bug: 1042681 Change-Id: I6f44287a5774774deabe7ccc35f3f2ce7e3608a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003131Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0cfd3dc2afae..5bddf6a45982 git log 0cfd3dc2afae..5bddf6a45982 --date=short --first-parent --format='%ad %ae %s' 2020-01-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-01-16 tvanderlippe@chromium.org Migrate workspace/ to ESM internally 2020-01-16 tvanderlippe@chromium.org Remove unused globals 2020-01-16 tvanderlippe@chromium.org Reland "Use typescript-eslint instead of tslint" 2020-01-16 tvanderlippe@chromium.org Migrate timeline_model/ to ESM internally 2020-01-16 szuend@chromium.org [cleanup] Remove unused {rotate} array utilities function Created with: gclient setdep -r src/third_party/devtools-frontend/src@5bddf6a45982 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib2703dc6570740947dd533d5a572dc681d642b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004502Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732392}
-
Stepan Khapugin authored
Moves the implementation of TabSwitcherDelegate "helpers" from Main to Scene controller. Moves the temporary interface from MCGuts to SCGuts. Bug: none Change-Id: Ie874e8f754cd6e38ba3aa04c6e64ea68192c95dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992084 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#732391}
-
Hans Wennborg authored
clang-cl doesn't recognize the flag as it is. CrOS doesn't know the flag. While that's not relevant for the ToT bots, it makes sense to handle it already, to make it easier when we roll Clang. Bug: 1042470 Change-Id: I3ae6476be2d2031f92a6c6613aa2138eba76fe9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003133Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#732390}
-
Raul Tambre authored
map() returns a list in Python 2. Python 3 returns an iterator and if a list is needed it's necessary to call list(). Calling list() results in the same behaviour in both. There should be no behavioural changes. Ran "git cl format". Fixes the following errors: Traceback (most recent call last): File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 556, in <module> sys.exit(main()) File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 551, in main return args.func(args, remaining_args) File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 267, in _Generate processor._GenerateModule(args, remaining_args, generator_modules, File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 238, in _GenerateModule generator.GenerateFiles(filtered_args) File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 461, in GenerateFiles self.WriteWithComment(self._GenerateModuleSharedMessageIdsHeader(), File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\template_expander.py", line 36, in GeneratorInternal parameters = generator(*args, **kwargs2) File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 438, in _GenerateModuleSharedMessageIdsHeader return self._GetJinjaExports() File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 330, in _GetJinjaExports "extra_public_headers": self._GetExtraPublicHeaders(), File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 276, in _GetExtraPublicHeaders self.module.structs + all_enums + self.module.unions) TypeError: unsupported operand type(s) for +: 'map' and 'list' Traceback (most recent call last): File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 556, in <module> sys.exit(main()) File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 551, in main return args.func(args, remaining_args) File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 267, in _Generate processor._GenerateModule(args, remaining_args, generator_modules, File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 238, in _GenerateModule generator.GenerateFiles(filtered_args) File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 461, in GenerateFiles self.WriteWithComment(self._GenerateModuleSharedMessageIdsHeader(), File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\template_expander.py", line 36, in GeneratorInternal parameters = generator(*args, **kwargs2) File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 438, in _GenerateModuleSharedMessageIdsHeader return self._GetJinjaExports() File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 342, in _GetJinjaExports "uses_interfaces": self._ReferencesAnyHandleOrInterfaceType(), File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 289, in _ReferencesAnyHandleOrInterfaceType if len(self.module.interfaces) > 0: TypeError: object of type 'map' has no len() Traceback (most recent call last): File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 556, in <module> sys.exit(main()) File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 551, in main return args.func(args, remaining_args) File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 267, in _Generate processor._GenerateModule(args, remaining_args, generator_modules, File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 238, in _GenerateModule generator.GenerateFiles(filtered_args) File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 461, in GenerateFiles self.WriteWithComment(self._GenerateModuleSharedMessageIdsHeader(), File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\template_expander.py", line 36, in GeneratorInternal parameters = generator(*args, **kwargs2) File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 438, in _GenerateModuleSharedMessageIdsHeader return self._GetJinjaExports() File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 343, in _GetJinjaExports "uses_native_types": self._ReferencesAnyNativeType(), File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 303, in _ReferencesAnyNativeType m.enums + m.structs + m.interfaces)) TypeError: unsupported operand type(s) for +: 'map' and 'list' Traceback (most recent call last): File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 556, in <module> sys.exit(main()) File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 551, in main return args.func(args, remaining_args) File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 267, in _Generate processor._GenerateModule(args, remaining_args, generator_modules, File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 215, in _GenerateModule AddComputedData(module) File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\generator.py", line 184, in AddComputedData _AddStructComputedData(True, struct) File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\generator.py", line 123, in _AddStructComputedData struct.packed = pack.PackedStruct(struct) File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\pack.py", line 130, in __init__ if (len(struct.fields) == 0): TypeError: object of type 'map' has no len() Bug: 941669 Change-Id: I8f7d3fa25a610db32446ad6b2baa6edac1723601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995335Reviewed-by: -
Gyuyoung Kim authored
As a step to convert legacy IPCs to the Mojo, this CL converts browser side's BlinkTest IPCs to Mojo. This CL introduces WebTestClient interface to replace the IPC messages to Mojo methods in web_test.mojom file. The interface starts to support the original messages as below, - InitiateLayoutDump() - PrintMessageToStderr() - SetPopupBlockingEnabled() - NavigateSecondaryWindow() - GoToOffset - Reload() - LoadURLForFrame() - CloseRemainingWindows() - ResetDone() - SendBluetoothManualChooserEvent() - GetBluetoothManualChooserEvents() - SetBluetoothManualChooser() This CL should not change any behavior. Bug: 1039247 Change-Id: Ic30f8cc0cb19ec8a306b577f3c10567d91bdccf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002047Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8013d477aeac..323a81fc5e30 git log 8013d477aeac..323a81fc5e30 --date=short --first-parent --format='%ad %ae %s' 2020-01-15 alanbaker@google.com Validate Vulkan 1.2 capabilities 2020-01-15 dneto@google.com Add basic support for Vulkan 1.2: SPV_ENV_VULKAN_1_2 2020-01-14 jaebaek@google.com Fix OpLine bug of merge-blocks pass (#3130) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@323a81fc5e30 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: If59e23feecc075d0f98777623d5c3b97927dc268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003823Reviewed-by:
-
Francois Doray authored
The expiry is the same as Browser.Tabs.TabSwitchResult and Browser.Tabs.TotalSwitchDuration. These metrics needs to be analyzed together. Fixed: 1037572 Bug: 1037572 Change-Id: I5f19e9f612361488478e7e0ff2138cae91b5cb65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003217 Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
-
Anastasiia Nikolaienko authored
Fix stack-use-after-return error by not returning a reference of local variable in RequestPrimaryAccount. This is a reland of 268d26b8 Original change's description: > ARC: Add a mojo method for getting the primary account > > ARC needs to know the identity of the primary account, but it cannot > retrieve that from Android account manager. > > Add a mojo method in ArcAuthService for returning the primary account > information from Chrome OS. > > Bug: b/141108534 > Test: browser_tests --gtest_filter="*Arc*AuthService*Test*" > Change-Id: I01ec976a330d52421ab2ddfe5155c712c81967af > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810359 > Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> > Reviewed-by: Mattias Nissler <mnissler@chromium.org> > Reviewed-by: Yury Khmel <khmel@chromium.org> > Reviewed-by: Kush Sinha <sinhak@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726738} Bug: b/141108534 Cq-Include-Trybots: luci.chromium.try:linux_chromium_chromeos_asan_rel_ng Change-Id: I3cf1d02c9dc0be5d23b7a3992747716efe576221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997128Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#732385}
-
Sami Kyostila authored
Bug: 1006539 Change-Id: Icfdd0e27aeaf98e610a2324578bf651da2f2a045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003174 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#732384}
-
Sigurd Schneider authored
..between browser and shell bindings. The interface has gotten out of sync after crrev.com/c/1951104 which introduced additional error reporting. TBR=yangguo@chromium.org Bug: chromium:1030746 Change-Id: If609eb709156e3d0b2142e631878c8821fc1f84c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000622Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1039ef14d7ad..11c11a1a891c git log 1039ef14d7ad..11c11a1a891c --date=short --first-parent --format='%ad %ae %s' 2020-01-16 treehugger-gerrit@google.com Merge "Make zlib optional" Created with: gclient setdep -r src/third_party/perfetto@11c11a1a891c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: If07a3e03a4b8d8a219d3f13f857d454fa45a5a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004501Reviewed-by:
-
