- 31 Jan, 2020 40 commits
-
-
Kent Tamura authored
This CL removes inner_block_height_, which is a cache of inner_block_'s height because: - The computation of the height doesn't look a heavy operation. - inner_block_height_ was referred only if -webkit-appearance:menulist*. This CL has no behavior changes. Bug: 1040828 Change-Id: Ic70ee31202fffaaaecfacc47c5141f52a921be55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032685Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#737195}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1edaa1d1e18f..f28d0ae61457 git log 1edaa1d1e18f..f28d0ae61457 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 kainino@chromium.org Revert "Remove VK_DEFINE_NON_DISPATCHABLE_HANDLE magic, use explicit VkHandle wrapper" 2020-01-31 kainino@chromium.org Remove VK_DEFINE_NON_DISPATCHABLE_HANDLE magic, use explicit VkHandle wrapper Created with: gclient setdep -r src/third_party/dawn@f28d0ae61457 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1046362 Tbr: cwallez@google.com Change-Id: I2d7ee0497ab58ad4c5a53883d961be757e4c7281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032619Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737194}
-
Xing Liu authored
Finch parameter is not guaranteed to be ready on first run. This may introduce unexpected behaviors, like the user see the notification on second time running Chrome. Now we always persist the first run timestamp and uses a Finch specified timestamp from the server to check if first run happens recently. If so then just skip the notification. Also address an issue that origin checks for NotificationPlatformBridgeMac is removed, now we let the empty GURL pass. Bug: 1047286,1046457 Change-Id: I59723c7d35230345ca9d77ccc810a07646d34b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032346 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#737193}
-
Yuichiro Hanada authored
Bug: None Test: ash_unittests Change-Id: I62e018e0898f032bc947862750e542c0da9f91cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025167 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#737192}
-
Md. Hasanur Rashid authored
The Chromium C++ style guide recommends that DVLOG is used as it "avoids bloating the release executable and in debug can be selectively enabled at runtime". Bug: 519010 Change-Id: I601859734234d21ae98a51539f4384ae8d94f795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026854 Commit-Queue: Md. Hasanur Rashid <hasanur.r@samsung.com> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#737191}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/04bb1f2f0353..62c4aa446733 git log 04bb1f2f0353..62c4aa446733 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 tsepez@chromium.org Avoid segv in CXFA_FFPageView::GetPageViewRect() after page is gone. 2020-01-31 thestig@chromium.org Rename CPDFSDK_FormFillEnvironment::GetPermissions(). 2020-01-30 thestig@chromium.org Clarify what CPDFSDK_FormFillEnvironment::GetPermissions() does. 2020-01-30 thestig@chromium.org Consolidate dimension checking code inside cpdf_dib.cpp. 2020-01-30 thestig@chromium.org Handle a case of colorspace mismatch with JPEG2000 images. Created with: gclient setdep -r src/third_party/pdfium@62c4aa446733 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1012369,chromium:1042915 Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ia4975786941e334f991dd674f2c6e2b12e1aaf06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032616Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7fd0c00afadd..51aa23b1aa22 Created with: gclient setdep -r src-internal@51aa23b1aa22 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1041618,chromium:1041701 Tbr: jbudorick@google.com Change-Id: I0979ff67c853b97f5763f8a6e9ac441ea3077127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032214Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737189}
-
Peter Boström authored
This makes sure the ImeWarningBubbleView can show (and not crash :)) when ExtensionsToolbarMenu is enabled. Also fixes ImeWarningBubbleTest.* when ExtensionsToolbarMenu is enabled. Bug: chromium:943702, chromium:984654 Change-Id: Idf8bdd14792201eba421547b8ccd0543817e8ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028186 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#737188}
-
Takumi Fujimoto authored
Record the above two GMC metrics in CastMediaNotificationItem. TBR=jwd@chromium.org Bug: 1042832 Change-Id: I108b8e8f13c3a1a45d514c4b345b1ce224a9ba27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005388Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#737187}
-
Chris Blume authored
When a website contains an image with a wide color gamut, it should inform the Viz process as to the widest color space being used and allow the Viz process to change its display. Bug: 955158 Change-Id: I66039294647d5d24dc47d11b66db0d280a3ab1a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978634 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Cr-Commit-Position: refs/heads/master@{#737186}
-
Patrick Noland authored
Bug: 865801 Change-Id: I4f718c8032bc6c86034a3aa867674d53837aaad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028259 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#737185}
-
Mohsen Izadi authored
We need to access ui::EventType in //cc as a part of adding event latency info to compositor latency metrics, however, //cc cannot have dependency on //ui. There is a //ui/events/types directory that's accessible from //cc. This CL moves ui::EventType to //ui/events/types so it can be accessed form //cc. Bug: 963781 Change-Id: Id1cc85ca74f2fe114942285e0c9de39944c0e175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028629Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/5fcdf4ad4909..6c109e908aa4 $ git log 5fcdf4ad4..6c109e908 --date=short --no-merges --format='%ad %ae %s' 2020-01-29 junyer Make the fuzzer use FuzzedDataProvider. 2020-01-12 junyer Tidy up a test. Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Change-Id: I46f5757eeace0104ebdef23be713b9f95a7b1d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031881Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#737183}
-
Sammie Quon authored
It's a cheaper alternative that gets the same visuals. Design doc in the linked bug. First application will be on the overview item close button. Short-term follow ups: 1) Apply on ink drops ash-wide. 2) Change ink drop highlight for ash ink drops to use solid color layer. Test: manual Bug: 1042303 Change-Id: Ia1728762fd9234304277e3bb42c12dfa03f87fef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026527 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#737182}
-
Mason Freed authored
The [1] CL combined the ElementNamespaceType bits, to save space. However, as seen in [2], this caused a performance regression, likely due to a slower IsHTMLElement(). This CL attempts to get back that performance through two optimizations: - ALWAYS_INLINE the accessors for both GetElementNamespaceType() and the IsXyzElement() accessors. - Move kHTML to a value of 0, in the hope that this operation is faster when the kConstant is zero: GetElementNamespaceType() == kConstant [1] https://chromium.googlesource.com/chromium/src/+/956931765e5969c44ad9a4641ff1c99977c8498f [2] https://crbug.com/1036543 Bug: 1036543 Change-Id: I4976829ab0b7c9d875d4d4e6b516333b44e7dddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029311 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#737181}
-
Gary Kacmarcik authored
Change-Id: I1ea23ac27a95d95491470d9a5d27713a35e5fb64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032328 Auto-Submit: Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#737180}
-
Alex Moshchuk authored
The HasSecurityState() check was introduced as a temporary workaround to eliminate crashes caused by Mojo services trying to perform ChildProcessSecurityPolicy security checks after the RenderProcessHost has been destroyed. HasSecurityState() was used to detect that the process was gone and just fail open. Now, we have a better solution in place with ChildProcessSecurityPolicyImpl::Handle, which extends the lifetime of a process's security state even after the RPH has gone away. Switch BroadcastChannelProvider to use this approach instead. Bug: 943887 Change-Id: Id83c27364506ff9a349a10c5f54193c2aa0f369b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031924Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#737179}
-
Takuto Ikuta authored
python client is deprecated, let me recommend to use go client instead. Bug: 984869 Change-Id: I93bde0a245510a178bfe5990b074211ba6f45ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029565 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#737178}
-
Gyuyoung Kim authored
Existing WebTestControl and WebTestClient interfaces have been used by |BlinkTestRunner| and |BlinkTestController| classes. So, it's better to use BlinkTestControl and BlinkTestClient interface names. - Rename WebTestControl to BlinkTestControl - Rename WebTestClient to BlinkTestClient - Rename web_test.mojom to blink_test.mojom - Rename WebTestBlinkTestClient to BlinkTestClientImpl Instead, the IPC messages defined in web_test_messages.h are going to be converted to WebTestControl and WebTestClient interfaces. Bug: 1039247 Change-Id: Ic835d03f872e67477323c48e5e5f72a69627ffa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015472 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#737177}
-
Kenichi Ishibashi authored
This CL moves ScheduleDeleteAndStartOver() call from ServiceWorkerStorage::DidWriteUncommittedResourceId() to ServiceWorkerRegistry so that we can reduce ServiceWorkerContextCore dependency from ServiceWorkerStorage. Bug: 1039200 Change-Id: If6ca49d6489fbe34a777a3b005ff1a6792e4e257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026336 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#737176}
-
chrome://media-appchrome://media-app-guestTrent Apted authored
Currently we pass an ArrayBuffer which does not work for large files such as video. Passing a File works, and doesn't require a copy. Add media/video to the list of handlers now we know it works. Tested manually with a 5GB video, and covered by existing unit and integration tests (with smaller files). Update the existing file_handler.accept map rather than adding a new handler due to https://crbug.com/1047509. BUG=996088, b/144865801 Change-Id: I46b3ba53676534e06ba039c9a52c8701b4d1d432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029532Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#737175}
-
Dale Curtis authored
https://chromium.googlesource.com/external/github.com/videolan/dav1d.git/+log/e79e5ceb2cb7..9c29f229c5aa $ git log e79e5ceb2..9c29f229c --date=short --no-merges --format='%ad %ae %s' 2020-01-24 gramner checkasm: Increase buffer alignment to 64-byte on x86-64 2020-01-28 martin arm: cdef: Add special cased versions for pri_strength/sec_strength being zero 2020-01-28 martin arm: cdef: Fix some comment typos 2020-01-28 gramner Fix crash in dav1d_apply_grain() with negative picture strides 2020-01-27 gramner Optimize the cdef_filter C implementation 2020-01-27 gramner checkasm: Improve cdef_filter test 2020-01-24 gramner Avoid redundant calls to CDEF DSP functions 2020-01-22 gramner x86: Bump nasm version requirement to 2.14 2020-01-21 thresh CI: Use a newer image to build snap packages 2019-12-12 victorien x86: add prep_8tap AVX512 asm 2020-01-17 victorien x86: replace "mov hb, Xb" by "movzx hd, Xb" in MC 2020-01-20 psilokos x86inc: save xmm_regs_used in spill_xmm for non-win64 2020-01-15 martin arm64: itx: Fix overflow/clipping in negation in idct16 2020-01-14 gramner x86: Fix overflows in SSSE3 idct 2020-01-14 gramner x86: Fix missing saturations in inverse identity asm 2019-12-21 rsbultje SSSE3 implementations of film grain Created with: roll-dep src/third_party/dav1d/libdav1d TBR=tguilbert Change-Id: I1dd1ca36e32d68a4e9ee318f2acc435fa69e61a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032413Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#737174}
-
Marijn Kruisselbrink authored
In a follow-up what used to be called BlobInfo will also be used for native file system API handles, so rename the class and various members to have a more generic name better describing its future purpose. Bug: 955193 Change-Id: I80b2a5263ad739aaceac10b0c704cf596b0fc810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027167 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#737173}
-
Charlie Hu authored
This CL adds document_policy_features.h/.cc where all document policy features can be retrieved. document_policy_features are in blink/common directory because the serialization of document policy on browser side needs feature to name mapping. Change-Id: I850c6c9c008174ee39d89f60962cee5d30a639a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014149 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#737172}
-
Peter Boström authored
This change makes ExtensionsToolbarContainer invisible by default. It turns visible when any extension is added and goes invisible if the last extension is removed. Bug: chromium:943702 Change-Id: Ia64d8db55d3cd53beff450941d1b7d2cba282ca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956186 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#737171}
-
Kurt Horimoto authored
This CL adds support for presenting the password infobar modal UI via the banner interaction handler. In order to accomplish this, the InfobarOverlayRequestInserter was converted into a WebStateUserData so that it can be accessed from OverlayRequest callbacks. Additionally, this CL updates InfobarOverlayRequestFactoryImpl to add a factory that creates requests for modal UI. If an infobar is replaced while modal UI is displayed, modal UI for the replacement infobar should not immediately be shown; it needs to be accessed via interaction with the infobar banner or the badge. In order to implement this behavior, InfobarOverlayRequestCancelHandler was refactored to be a superclass that does not perform any request replacement logic. The replacement logic is now moved to a banner- specific subclass that will show the replacement infobar's banner if the banner for the replaced infobar is visible. Bug: 1030357 Change-Id: I085110b8198029584fd94b8b55427d2e41e07bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003258 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#737170}
-
Toni Barzic authored
If scrollable shelf is enabled, the shelf view will move vertically during tablet mode transition (as part of the hotseat motion), so the lag introduced between hotseat vertical movement and shelf items horizontal movement is noticeable during the transition. In addition, make sure the shelf view layout is updated if scrollable shelf edge padding changes due to scrollable shelf bounds change. Finally, update the scrollable shelf's available bounds when shelf config changes, and coordinate the config update with the shelf view. BUG=1047304 Change-Id: Ic3fe498132ef0c81196625bd17b0ecb44c3ec300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032063Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#737169}
-
Manu Cornet authored
This is a step in the direction of letting each shelf component calculate and store its target bounds instead of having everything in the shelf layout manager. This change doesn't modify any of the actual semantics of bound calculation yet. Change-Id: Ibf08b425e9799d97f93fc9a4b17156ed15ae34d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032566Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#737168}
-
Kenichi Ishibashi authored
This CL adds a wrapper method of ServiceWorkerStorage::UpdateToActiveState(). The purpose of this change is to reduce ServiceWorkerContextCore dependency from ServiceWorkerStorage. Adding these wrappers moves ScheduleDeleteAndStartOver() call from ServiceWorkerStorage to ServiceWorkerRegistry. Bug: 1039200 Change-Id: I975db3e4aaa1cc23ce6e10ef0dabbb322288807f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026776 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Demetrios Papadopoulos authored
This allows invoking type checking for only the Polymer 3 files locally, useful during local development. Bug: 1026426 Change-Id: Id103237cb8a59ca1133f0e1695b61a3b9d28bf7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032432 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#737166}
-
Rachel Sugrono authored
|deleteMenuItem| changed to |deleteCommand|. Bug: 803259 Change-Id: Iceeb2ef11c1b74a2c4cf723dc7279e3fc26ae456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032624Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Rachel Sugrono <rsugrono@google.com> Cr-Commit-Position: refs/heads/master@{#737165}
-
Shimi Zhang authored
Currently ProxyBypassRules handles suffix matching directly, this is a platform special case on Linux only, move the logic to the platform specific code other than handling it in a general place. Bug: 1030092 Change-Id: I5c30326dc4c88f0067e3369f190c83503f54db24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025834 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#737164}
-
Carlos IL authored
This adds use counters for same origin iframe use of alert, confirm, print, and prompt. Bug: 1047451 Change-Id: Ieee5a69821be5aa8a96af897073e5b8d3deb8cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032180 Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
-
Tim Judkins authored
Changes one of the checks in ExtensionNavigationThrottle to check if the initiator origin of a navigation is empty, to more correctly handle history.back() being used to navigate a window. Adds tests to cover this case. Also adds a test for a similar case which navigates a local frame, which results in the navigation being blocked at the renderer level. Bug: 1043965 Change-Id: I63e7e6775dbc56afdf3cd96452bf59939202370e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021194 Commit-Queue: Tim Judkins <tjudkins@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#737162}
-
Theresa Wellington authored
BUG=1003939 Change-Id: I87cfb890a58d8bec992d5fe070e041b38b392b76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025882 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#737161}
-
Olya Kalitova authored
Removes ellipsis from Crostini intaller error title. Bug: 1047196 Change-Id: Id483ef37ad1c11e31e6140f680fa8d791aa6faf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030944Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#737160}
-
Rakib M. Hasan authored
This CL will replace blinkpy's test expectations logic with typ's expectations_parser module. This change will significantly reduce the amount the code used for parsing and maintaining test expectations. Typ's expectations_parser module also parses the new expectations format. Bug: 986447 Change-Id: I16842bb2fcbc8a75221f3f208ed1550523470716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918294Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#737159}
-
Tarun Bansal authored
This is no longer needed with NoStatePrefetch. Bug: 1038056 Change-Id: I7d95bb03c10115111bb6e0acafbdd7be0570d279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996125 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#737158}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c8e486b1df0d..e196bc85ac2d git log c8e486b1df0d..e196bc85ac2d --date=short --first-parent --format='%ad %ae %s' 2020-01-30 kbr@chromium.org Add driver bug workaround for rewriting row major matrices. Created with: gclient setdep -r src/third_party/angle@e196bc85ac2d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tobine@google.com Change-Id: Ibc327ee48fe7d5d737b097dba5a5894eb8d95184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032209Reviewed-by:
-
Henrique Nakashima authored
Use SharedPreferencesManager consistently instead of SharedPreferences directly. Move the usages to methods in SigninPreferencesManager. Bug: 1022108 Change-Id: I02d3ff82006722ab92420880342b26e4b6583bd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020804 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#737156}
-
