GitLab

Bug: 783991
Change-Id: I3ba066c89f8733e2b20acc71e2103f467749cae4
Reviewed-on: https://chromium-review.googlesource.com/772800Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Daniel Park <danielpark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517186}

The test harness is less flaky now, so perhaps this can run reliably.

BUG=468660
R=lazyboy@chromium.org

Change-Id: I3b1ffcc07c8c926f1d7aea92b959ab267f5ffc3e
Reviewed-on: https://chromium-review.googlesource.com/774658Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517185}

Bug: 785125
Change-Id: I018a94e0ea980c2971a8d085adf394cf13992fa3
Reviewed-on: https://chromium-review.googlesource.com/775141Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517184}

- Created a KeyedService, NotificationMetricsLogger, now called
by PlatformNotificationService to record the user actions it
was previously recording inline.

Bug: 780534
Change-Id: Icde7dbf2d141359098043c6b8745d709178e4498
Reviewed-on: https://chromium-review.googlesource.com/766792
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517183}

Also marks members as private, which was accidentally removed on a
previous patch.

Change-Id: I741d1e7013413d48e9841f0df70fe5124b3b0887
Reviewed-on: https://chromium-review.googlesource.com/774982Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517182}

Using this object for every op impacts rasterization performance.
Restrict it only to cases which need an override.

Also use StackVector in DecodeStashingImageProvider for the common case
of image shaders which have a single image.

R=enne@chromium.org

Bug: 784377
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7ee99abf890e65f3e347185fa0d53f92acf8f2fe
Reviewed-on: https://chromium-review.googlesource.com/773779
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517181}

Lock screen item data was incorrectly saved in the same value store for
all users (though, given that all data items are encrypted by a user
specific encryption key, the app can only read the current user's data
items).
This fixes the lock screen item storage to use per-user value store, and
migrates data items encrypted by the users key from the deprecated value
store to the introduces, per-user value store location.

PART 2/2: Hook up lock screen value store migrator to item storage -
    ensure data items for an extension are migrated before allowing the
    lock screen data API access to the extension's data.

Bug: 779277
Change-Id: I1cb259d272ea6cf5d4cf6263c0f03246f71f335f
Reviewed-on: https://chromium-review.googlesource.com/756327
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517180}

This CL replaces the std::string ("Set-Cookie:" HTTP header line)
argument to ContentBrowserClient::AllowSetCookie with a
net::CanonicalCookie and propagates the change throghout the codebase.
This is a prerequisite for using ContentBrowserClient::AllowSetCookie in
RestrictedCookieManagerImpl, which does not use HTTP header strings.

This CL stops propagating the change at
ChromeNetworkDelegate::OnCanSetCookie(). That will be done in a
follow-up CL, because it's expected to generate a non-trivial number of
changes, all isolated to //net.

RestrictedCookieManagerImpl is a part of the upcoming Network Service,
and is used by the Async Cookies API implementation.

Bug: 756093
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I20eb818515dbec4dfb527ce90be52b61b0a2b739
Reviewed-on: https://chromium-review.googlesource.com/771510Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517179}

These can easily affect pixel test results so it's essential that this
trybot be triggered for such changes.

BUG=785392

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I5ba69ac4cf46b843fd507b85234985915ed47c8d
Reviewed-on: https://chromium-review.googlesource.com/773560Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517178}

Minor change to keep exit prompt hidden initially and add a DCHECK to ensure
that we're not drawing the exit prompt before setting the text for the prompt.

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ia5e9a0ca83ab6ca2bac04f214b93e784d7a3ca25
Reviewed-on: https://chromium-review.googlesource.com/774198Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517177}

This CL implements DownloadTask public interface.

DownloadControllerImpl CL: crrev.com/c/758525
Design doc: http://go/ios-web-download-api

Bug: 780646
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2c508e77f3e529223499d6f2791b28011589fe90
Reviewed-on: https://chromium-review.googlesource.com/758506Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517176}

This should allow the presubmit to know that *ForTesting() functions are
okay to call from ssl_browsertest.cc

Files have been reformatted using `git cl format` to make `git cl upload` happy,
but there have been no other changes to the test files.

Bug: 770333, 785053
Change-Id: I01c4cb43ab8fea3b4ef7fe1a5f9abfccb49fe67d
Reviewed-on: https://chromium-review.googlesource.com/774118Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Lucas Garron <lgarron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517175}

Currently media remoting falls back to normal tab mirroring when
playback is continously delayed for about 750ms. This CL increased
the duration to around 2.5s to make the logic less sensitive to
noises.

Bug: 768581
Change-Id: I1cfdb9369b6a5a7d35800791de940aa768b54310
Reviewed-on: https://chromium-review.googlesource.com/773572
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517174}

This patch copies the logic for loading gzipped WebUI resources from
the non-iOS WebUI loading code and disables the exception in Grit that
prevented resources from being gzipped in the iOS build.

This reduces the size of resources.pak on iOS by 243 kB and starts to
unify more of the WebUI infrastructure between iOS and other platforms.

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I24473ea75b172210060723afa219281d0937c398
Bug: 619091
Reviewed-on: https://chromium-review.googlesource.com/770325
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517173}

Bug: 783158
Change-Id: I83f27f465828f59fa8a213b7273ab430934f5499
Reviewed-on: https://chromium-review.googlesource.com/763989
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Zhiling Huang <hzl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517172}

Bug: 784710
Change-Id: I74c7ae6edc0394224b997acd8d7e9fb34105aeba
Reviewed-on: https://chromium-review.googlesource.com/773202Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517171}

Change-Id: I92e185b74416da823d9d697de05494de3c4bd65a
Reviewed-on: https://chromium-review.googlesource.com/774689Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517170}

Because CertVerifyProcNSS dynamically resolves a pointer to the function
CERT_CacheOCSPResponseFromSideChannel(), Control Flow Integrity [1]
indirect call (cfi-icall) checking can not verify that it is the
intended target for that function pointer call site.

Since we can not use cfi-icall to check the function pointer, instead we
place the pointer in ProtectedMemory, a wrapper for keeping variables in
read-only memory except for when they are initialized. After setting the
pointer in protected memory we can use the UnsanitizedCfiCall wrapper to
disable cfi-icall checking when calling it since we know it can not be
tampered with.

[1] https://www.chromium.org/developers/testing/control-flow-integrity

Bug: 771365
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5d65b3591681f3daa917b6516eec1e5e47513d12
Reviewed-on: https://chromium-review.googlesource.com/765098Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517169}

BUG=785341

Change-Id: I23c09aba5b81386c6ebefacd4a51b9e4fc3c4f30
Reviewed-on: https://chromium-review.googlesource.com/774902Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517168}

This test became flaky after migrating it to the new test framework. Looks
like there's some sort of the race with the base tag. Will unflake this soon.

TBR=dgozman@chromium.org

Bug: 667560
Change-Id: Idbc7c298a0e9f45703586d66aff39a45c92b76cd
Reviewed-on: https://chromium-review.googlesource.com/773490
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Reviewed-by: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517167}

Bug: webrtc:8529
Change-Id: I78ae0de9078c128a7b44b12bc93aba7b9fa49a5d
Reviewed-on: https://chromium-review.googlesource.com/772918
Commit-Queue: Fredrik Solenberg <solenberg@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517166}

Swipes left and right on the toolbar are very easily triggered in the
ToolbarSwipeHandler. This causes an issue for the bottom sheet when it
is using the velocity swipe model; the page would shudder because the
toolbar swipe layout would be triggered.

This change only detects directional swipes if the initial direction
is within 25 degrees or left, right, or down. This makes accidentally
triggering a different layout more difficult.

BUG=779615

Change-Id: Ied417f3e71e79431168410d4e305fa29a2f57b9b
Reviewed-on: https://chromium-review.googlesource.com/772830
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517165}

SMS messages, notified by chromeos::NetworkSmsHandler, are encoded in
UTF-8. ash::SmsObserver incorrectly treats the received SMS messages as
ASCII, which causes incorrect characters to be shown in the notification
window.

      correctly in the notification.

Bug: 785583
Test: Verify that SMS messages with Unicode characters are shown
Change-Id: I6a4f90d4e3c01b537f8b103e8038f7ad423b7621
Reviewed-on: https://chromium-review.googlesource.com/773620Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517164}

https://chromium.googlesource.com/catapult.git/+log/a708a70f7608..a6ed3f9aee51

$ git log a708a70f7..a6ed3f9ae --date=short --no-merges --format='%ad %ae %s'
2017-11-16 dproy Add limited cpu time metric

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I5ea6984634a7bbced092eab32fd9714cb33d47ec
Reviewed-on: https://chromium-review.googlesource.com/775027
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517163}

Change-Id: Ibab32e3da920f0fb643efcd1e3807630fd62a849
Reviewed-on: https://chromium-review.googlesource.com/775180Reviewed-by: Kevin Bailey <krb@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517162}

Add a couple small optimizations too.

Change-Id: Ifaafc6486cbeb543c22348819ad71dcc736c5cc4
Reviewed-on: https://chromium-review.googlesource.com/775018Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517161}

The underlying bug was fixed and it's stable on the FYI bot.

Bug: 781391
Change-Id: I291f5b1ec376c27801c03c6217de65b9b98fd664
Reviewed-on: https://chromium-review.googlesource.com/772873
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517160}

Current rationalization logic of phone numbers runs in fields detection
phase, where the fields' is_focusable state might be obselete. The
rationalization use this state to determine if the logic will run.

Some form have phone fields initally non-focusable, then present them
dynamically, the rationalization will skip those fields. Moving the logic
to filling phase should address this issue.

Bug: 784935
Change-Id: I579a3dab6efad3c2f09a72562b8ae7ab4c376311
Reviewed-on: https://chromium-review.googlesource.com/768295Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Hui Wu <wuandy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517159}

BUG=646113

Change-Id: I0f4591d38064ca0e8f27a514fbcb633ab2c52348
Reviewed-on: https://chromium-review.googlesource.com/764955
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517158}

Sending renderer debug URLs to the network stack will result in trying
to commit an error page, which is when the debug URL will actually be
handled. This causing issues when trying to block them.

This CL also ensures that debug URLs will never commit.

BUG=776528,760732

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Iaae35029e5fcd0b66c470468a8f90ca9736fff3e
Reviewed-on: https://chromium-review.googlesource.com/731083
Commit-Queue: Charlie Reis <creis@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517157}

... by posting a weak pointer as is rather than dereferencing it
on a wrong thread.

Change-Id: I12c66a0143b2e980bff989965454def2c29092d8
Reviewed-on: https://chromium-review.googlesource.com/774018Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517156}

Clean up of stuff I missed from:
https://chromium-review.googlesource.com/c/chromium/src/+/762036

BUG=780139

Change-Id: Icc79f75e49dd9c8e2327ffee22e53cafe81bec41
Reviewed-on: https://chromium-review.googlesource.com/773503Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517155}

This CL migrates socket_dispatcher_host.h to use NetworkChangeObserver.
More details are in the following bug

Bug: 780470
Change-Id: If48f749c81272d32bfcee84ea5f5b5639157f5a0
Reviewed-on: https://chromium-review.googlesource.com/754765Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517154}

This CL updates the following parameters.
  Position of the buttons
  Background color
  Buttons colors
  The gap between the text and the icon
  Position of the audio prompt

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I9fe0f6037333c1fb3c19111157999c151faffec4
Reviewed-on: https://chromium-review.googlesource.com/772403Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517153}

Control Flow Integrity [1] indirect call (cfi-icall) checking can not
verify that dynamically resolved function pointers call their intended
function. Instead we place the LibcFunctions pointers in
ProtectedMemory, a wrapper for keeping variables in read-only memory
except for when they are initialized.  After setting the pointers in
protected memory we can use the UnsanitizedCfiCall wrapper to disable
cfi-icall checking when calling them since we know they can not be
tampered with.

[1] https://www.chromium.org/developers/testing/control-flow-integrity

Bug: 771365
Change-Id: Ib74faff066e1107293b67d11f2a1a054bbff08b5
Reviewed-on: https://chromium-review.googlesource.com/769853Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517152}

The ExtensionFrameHelper already has logic to find extension frames
matching certain criteria, which is used by custom bindings to return
the global objects for those frames. Move the logic to get the v8
global objects from the custom bindings to the ExtensionFrameHelper in
order to allow re-use with other bindings.

Bug: 653596

Change-Id: Ibb7d57e90bdb83cd574a95eb80db222456dd3e79
Reviewed-on: https://chromium-review.googlesource.com/763572
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517151}

https://webrtc.googlesource.com/src.git/+log/8b64fd8a85c1..8d9c5406c7ba

$ git log 8b64fd8a8..8d9c5406c --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I69affadf2b7890f11fdc4995249ec2bb97637d64
Reviewed-on: https://chromium-review.googlesource.com/775318Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517150}

Bug: 771028
Change-Id: I323d63f4f7b845a4d2588b385c18e673c47257e3
Reviewed-on: https://chromium-review.googlesource.com/767656Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Nathan Parker <nparker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517149}

Expanded the existing model of calling NoNotify methods, and changed
some sync only methods to return a bool representing whether a change
was made to the local data or not. RemoveNoNotify does not currently
expose if a change was actually made, so we assume that one was, fixing
this was out of scope. This allowed the sync methods (apply and merge)
to track if any changes were made, and invoke a single NotifyObservers
after all local changes had been applied.

As made evident by the unit tests, there's some complexity around
changing the default search engine that may still result in more than
one notification call.

Bug: 775049
Change-Id: Ie0b3080a60852f6cc09704feb4de8f850386353b
Reviewed-on: https://chromium-review.googlesource.com/745521Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517148}

This CL does some micro cleanups in VaapiVideoDecodeAccelerator:

- removes the member |num_input_buffers_|, which is use for TRACEing
only, and uses instead |input_buffers.size()|.  This is a change in
behaviour, since now we would also count the Flush-type InputBuffers,
but I think the change is justified since it's just for TRACEing
and they are, after all, InputBuffers as well.

  With the same logic s/Stream buffers at decoder/Input buffers/
at the TRACE_COUNTER1 statements.

- Rewrites the logic in GetInputBuffer_Locked() to avoid deep
condition layers, using instead early return.

- Rewrites Reset() to have less lines.

- Removes one of two consecutive empty lines.

- Simplifies CreateSurface() return statement.

Except for the |num_input_buffers_|, **there should be no new code**.

Nonetheless:
TEST=compiled-ran video_decode_accelerator_unittests on soraka,
all passing w/ same perf numbers. Ran standard VP9 playback,
all good as on ToT.

Bug: 717265
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id96d63f3245c04008927f94daf3ae05d48be9bbd
Reviewed-on: https://chromium-review.googlesource.com/774998
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517147}