GitLab

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/9515015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124637 0039d316-1c4b-4281-b951-d872f2087c98

The launch.mode histogram has been updated to track taskbar launches. As there was already a bucket for start menu which was never used, this is now used for the taskbar. Previously task bar launches have been recorded in the quick launch bucket.

BUG=103977
TEST=Tested with the aid of logging on Windows 7.


Review URL: http://codereview.chromium.org/9559020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124636 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/112131
TEST=none

Review URL: http://codereview.chromium.org/9535025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124635 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dhollowa
BUG=116526,79878
Review URL: https://chromiumcodereview.appspot.com/9585013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124634 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:22846
TEST=

Review URL: https://chromiumcodereview.appspot.com/9567003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124633 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/9564007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124632 0039d316-1c4b-4281-b951-d872f2087c98

This is a revival of https://chromiumcodereview.appspot.com/9288062/ which was abandoned in favor of https://chromiumcodereview.appspot.com/9298009/.

Turns out that webkitRequestFullscreen is not suitable for Chrome OS File Browser because it gives us a different kind of fullscreen mode than the one we get when pressing the dedicated Chromebook key (see the bug for details).

BUG=chromium-os:26003
TEST=

Review URL: https://chromiumcodereview.appspot.com/9565008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124631 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/9570011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124630 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None.
TEST=Manual tests.

Review URL: https://chromiumcodereview.appspot.com/9584007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124629 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116225
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/9539011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124628 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124625 0039d316-1c4b-4281-b951-d872f2087c98

Reverting as it breaks BytesFormattingTest.FormatBytes

BUG=chromium-os:22812
TEST=Open task manager or downloads, and observe KB instead of kB.
Review URL: https://chromiumcodereview.appspot.com/9490008

TBR=dgozman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9572006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124623 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:22812
TEST=Open task manager or downloads, and observe KB instead of kB.
Review URL: https://chromiumcodereview.appspot.com/9490008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124622 0039d316-1c4b-4281-b951-d872f2087c98

BUG=113159,116438

Reverting to unbreak the tree. See http://crbug.com/113159 for details.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124346

Review URL: http://codereview.chromium.org/9509001

TBR=jbates@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9581006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124621 0039d316-1c4b-4281-b951-d872f2087c98

Fixes http://goo.gl/AfBE1

BUG=93932
TEST=none

Review URL: http://codereview.chromium.org/9565037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124620 0039d316-1c4b-4281-b951-d872f2087c98

These were being flagged by gcc-4.6.0 using the Wmaybe-uninitialized warning.

BUG=none
TEST=trybot


Review URL: http://codereview.chromium.org/9309008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124619 0039d316-1c4b-4281-b951-d872f2087c98

https://bugs.webkit.org/show_bug.cgi?id=79954 is the webkit side.

BUG=116344
TEST=


Review URL: http://codereview.chromium.org/9557009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124618 0039d316-1c4b-4281-b951-d872f2087c98

Replace make function back now that not using goma (removed in http://chromiumcodereview.appspot.com/9570042)

TBR=maruel@chromium.org

BUG=None
TEST=

Review URL: https://chromiumcodereview.appspot.com/9585002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124615 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=

Review URL: https://chromiumcodereview.appspot.com/9584001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124612 0039d316-1c4b-4281-b951-d872f2087c98

displayed as '*', was implemented in NativeTextfieldViews
via TextfieldViewsModel::GetVisibleText() (issue 5857002),
but the refactoring into RenderText (issue 7265011) removed
all calls of that method.

I moved the password handling code into RenderText because I
think it's logically a visual style (although RenderText
also contains a lot of model-related stuff right now).
RenderText now has a password property (in earlier patchsets
it was an attribute in StyleRange).

BUG=105054
TEST=unit tests and manual testing of the wifi login dialog

Review URL: https://chromiumcodereview.appspot.com/8747001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124611 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124610 0039d316-1c4b-4281-b951-d872f2087c98

Only change in hunspell roll: https://chromiumcodereview.appspot.com/9568018

BUG=none
TEST=none
TBR=hans

Review URL: https://chromiumcodereview.appspot.com/9570054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124609 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124607 0039d316-1c4b-4281-b951-d872f2087c98

- Added new ErrorCode enum to pass error codes everywhere except between 
  the webapp and the plugin.
- Signaling timeout when connection now is interpreted as disconnect instead of
  error condition (see bug 112739).
- Fixed webapp to properly handle unknown error codes.

BUG=112739


Review URL: http://codereview.chromium.org/9567033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124606 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98716
TBR=dcheng
Review URL: https://chromiumcodereview.appspot.com/9581001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124605 0039d316-1c4b-4281-b951-d872f2087c98

The duplicate flush after the swapbuffers makes handling commands from other stubs difficult, so get rid of it.

BUG=112349
TEST=


Review URL: http://codereview.chromium.org/9567026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124604 0039d316-1c4b-4281-b951-d872f2087c98

Move the core drag&drop code for Windows to content\browser to match Mac/GTK. I've had to add temporary exceptions to DEPS which I'll remove in followup changes.

BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9562049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124603 0039d316-1c4b-4281-b951-d872f2087c98

BUG=113075
TEST=none, just committing so I can send tryjobs for the next patch
TBR=davemoore@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9569054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124602 0039d316-1c4b-4281-b951-d872f2087c98

This change removes executable flags from the files added by r124588 <http://crrev.com/124588>.

TBR=michaelbai
BUG=none
TEST=check_persm
Review URL: https://chromiumcodereview.appspot.com/9566049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124601 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116216
TEST=manually checked the three buttons

Review URL: https://chromiumcodereview.appspot.com/9536007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124598 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/116073
TEST=see unit tests

Review URL: http://codereview.chromium.org/9570037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124597 0039d316-1c4b-4281-b951-d872f2087c98

R=aa@chromium.org
BUG=109425
TEST=*Extension*


Review URL: http://codereview.chromium.org/9316102

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124596 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116475
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9569053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124595 0039d316-1c4b-4281-b951-d872f2087c98

This is needed for using compositor filters in Aura such as glass blur.

BUG=99528
TEST=


Review URL: http://codereview.chromium.org/9568042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124594 0039d316-1c4b-4281-b951-d872f2087c98

BUG=114101
TEST=none


Review URL: http://codereview.chromium.org/9565025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124590 0039d316-1c4b-4281-b951-d872f2087c98

Some strings currently have a specific version for Android, but the
description attribute does not mention this.

This prefixes "Mobile: " for all Android strings where the same message
name is already in use, and Android just has a specific version of a
string for mobile.

BUG=114046
TEST=Verify that strings show up correctly in Android build.


Review URL: http://codereview.chromium.org/9567017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124589 0039d316-1c4b-4281-b951-d872f2087c98

Just like the history_types, this is Android corresponding one.

BUG=
TEST=


Review URL: http://codereview.chromium.org/9558015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124588 0039d316-1c4b-4281-b951-d872f2087c98

We want to count the number of searches from various access points in Chrome. To do this, we've added a new UMA enumerated histogram to track these values (GoogleSearch.AccessPoint). These are the necessary declarations for various search access points that will be added shortly.

We've also added a IsGoogleSearchUrl helper to google_util to identify search URLs.

BUG=
TEST=Ensure that unit tests GoogleUtilTest all succeed.


Review URL: http://codereview.chromium.org/9452039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124587 0039d316-1c4b-4281-b951-d872f2087c98

BUG=111139
TEST=SessionStartupPrefTest.HomePageMigration
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9559002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124583 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116441
TEST=dialog doesn't resize itself

Review URL: https://chromiumcodereview.appspot.com/9566039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124582 0039d316-1c4b-4281-b951-d872f2087c98