GitLab

This CL make the following changes:
- Fixes a potential null-dereference crash when multiple rules couldn't be
  parsed.
- Instead of showing only a single install warning for multiple unparsed rules,
  show individual warnings. Limit the count to 5 warnings.
- The rule count exceeded warning doesn't override the rule unparsed warning
  now.

BUG=894275

Change-Id: Iac8db1cf927a9302ec9295501f84616efafeca4e
Reviewed-on: https://chromium-review.googlesource.com/c/1274838
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599352}

If root_ was destroyed while MenuPreTargetHandlerAura exists, then
MenuPreTargetHandlerAura would set root_ to null. This would result
in the pre-target-handler being removed from the wrong env.

I don't think this is the result of the bug referenced, but I came across
this in looking for bad pre-target handlers.

BUG=867035
TEST=none

Change-Id: Ic549cf306441e31dcd750665992e41f06416f295
Reviewed-on: https://chromium-review.googlesource.com/c/1279147Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599351}

Bug: 894362, 845079
Test: The back button works as history back when ARC IME doesn't show up.
Change-Id: Ibffbf39f02f9bc3c75c42b4091dce442046d48e2
Reviewed-on: https://chromium-review.googlesource.com/c/1278511
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599350}

I've never been able to repro, but to me this looks like long
clicking while we're in the middle of tearing down the activity somehow.

The quick bandaid fix is to catch the BadToken exception, but hopefully
we'll be able to do something more graceful with the MVC refactor.

This moves the logic to the Coordinator to avoid the 3 delegate calls
and minimize it to one (and reduces the business logic in the view).

NOPRESUBMIT=true
BUG=881074

Change-Id: I611648abcfa9ba87c2fe0ecd63e212f1985e1834
Reviewed-on: https://chromium-review.googlesource.com/c/1278957
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599349}

There seems to be a regression on M70 head that get AccountInfo using
identity_manager->GetPrimaryAccountInfo() always return empty
hosted_domain field. Using signin_manager->GetAuthenticatedAccountInfo()
seems to be a more stable way.

Bug: b/116746192
Test: Local build
Change-Id: I8369787b4f8d33e63d4029705d9f3f02c1a0376d
Reviewed-on: https://chromium-review.googlesource.com/c/1278526Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599348}

Previously, the SQL query included site icons that were NULL or empty,
resulting in category tiles often having less than 4 site icons present.
This fix skips the empty icons, and grabs the next non-empty ones.

Change-Id: I314c78f1797769e598640d06162811e1672c2449
Reviewed-on: https://chromium-review.googlesource.com/c/1279155Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Jonathan Freed <freedjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599347}

Tbr: ellyjones@chromium.org
Bug: 828031
Change-Id: I3f492d5ed53aa30f3ce518464a5fcc96109c1e13
Reviewed-on: https://chromium-review.googlesource.com/c/1279205
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599346}

This is a refactor that simplifies using voice interaction observer

Bug: 870515
Test: locally compile and run
Change-Id: I60368068c1124e9f8d0a6901fff23c1eb5b05717
Reviewed-on: https://chromium-review.googlesource.com/c/1278862Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599345}

simple spelling/grammar fixes
renamed some functions

Bug: N/A
Change-Id: Ia753e830bbc06632e24a5812c970efda82110c5b
Reviewed-on: https://chromium-review.googlesource.com/c/1278286
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599344}

This reverts commit c43eba93.

Reason for revert: This broke http/tests/devtools/service-workers/service-workers-navigation-preload.js on the mojo bots:
Mojo Windows: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20Windows/18554
Mojo Linux: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20Linux/20553

Original change's description:
> Make DataPipeBytesConsumer support ReadableStream loading better.
> 
> This CL fixes some edge condition interactions when being loaded as
> a ReadableStream.  In particular, it:
> 
> 1. Properly distinguishes between the end of the DataPipe and a closed
>    DataPipe with bytes left to be read.  A ReadableStream that is not
>    actively draining the pipe could get closed too early.
> 2. Responses must support explicit completion in order to handle error
>    conditions properly.  This CL makes DataPipeBytesConsumer wait
>    for an explicit signal before closing.
> 3. Service worker navigation preload is updated to provide the explicit
>    completion signals.
> 
> Bug: 894815
> Change-Id: I8cff3de94aa2dcbc8deb4a9601a95c13b8ab94d9
> Reviewed-on: https://chromium-review.googlesource.com/c/1272715
> Commit-Queue: Ben Kelly <wanderview@chromium.org>
> Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599192}

TBR=kinuko@chromium.org,mek@chromium.org,yhirano@chromium.org,wanderview@chromium.org

Change-Id: Iddb6b2121a0b014b4b08c6ec64fc534820474010
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 894815
Reviewed-on: https://chromium-review.googlesource.com/c/1279194Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599343}

Fixing the next available field and adding comments,
to be synced with the server code.

Change-Id: I52d91d5ccbd1c79d61cb537e6f81a879a74d2a0b
Reviewed-on: https://chromium-review.googlesource.com/c/1277697Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Cr-Commit-Position: refs/heads/master@{#599342}

The keychain was re-authorized to support Chrome's new signing
certificate 18+ months ago. At this point, users who haven't re-launch
Chrome in 18 months are unlikely to do so, or need the keychain. This
removes the re-authorization code.

Bug: 893729
Change-Id: I75b5a40407d196adfa5c31996024b9bb278221a1
Reviewed-on: https://chromium-review.googlesource.com/c/1271935Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599341}

Only query it if the extension is enabled.

Bug: 894049
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I5c2be0c41c2361ef06381a7e73c2025baa63e191
Reviewed-on: https://chromium-review.googlesource.com/c/1275299Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599340}

Bug: 894927,867488
Change-Id: I8c92aa6b3561aed2efd6332a0b1cd3ecde8cdb9b
Reviewed-on: https://chromium-review.googlesource.com/c/1277695Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599339}

R=rch@chromium.org

Change-Id: Ie45a70cecf865edefa565bff8b8af1d51e0b0705
Reviewed-on: https://chromium-review.googlesource.com/c/1277582Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599338}

Bug: 890912
Change-Id: Idc11767c37580c540cbb741a4cce5cabc3a0f29f
Reviewed-on: https://chromium-review.googlesource.com/c/1277989
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599337}

Removes the explicit hard timeout on VR tests on Nougat. This makes it
instead use the default of 1 hour, which is the same as the Oreo bot and
should make the tests stop timing out after the recent addition of lots
of tests.

Change-Id: Icb290a23732977b305d6d0a779c69909e401f806
Reviewed-on: https://chromium-review.googlesource.com/c/1277884Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599336}

Cut-and-paste these classes into separate files, because their current
location is getting crowded.

Bug: 859152
Change-Id: I9bc9fe8225589f91ba1cbc9daaccfbe58288197f
Reviewed-on: https://chromium-review.googlesource.com/c/1277581Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599335}

This reverts commit 9846f362.

Reason for revert: Compile failure on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/GPU%20Linux%20Builder/134994

Original change's description:
> [Autofill] Save form submission button's title for FormData
> 
> Save a button title into FormData for crowdsourcing.
> 
> Title is inferred in two ways:
> Type 1) Value attribute of an <input type="submit">.
> Type 2) Text content of <button>
> 
> If there are several labels within a <form>, all labels are concatenated to collect more data. A delimiter depends on the type of <button>/<input>:
> $ <input type="submit">
> # <input type="button">
> & <button type="submit">
> % <button type="button">
> 
> The value is truncated if the length is more than 200. The same value is used for labels.
> 
> TODO: introduce title inference when there is no <form> tag.
> TODO: consider other types of elements as submit button (e.g. <input type="image">, <a>, <div>/<span>)
> 
> Bug: 850606
> Change-Id: I54783cfdd0134b3aec52e9404740a3e1495a8176
> Reviewed-on: https://chromium-review.googlesource.com/c/1272356
> Reviewed-by: Mike West <mkwst@chromium.org>
> Reviewed-by: Roger McFarlane <rogerm@chromium.org>
> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599333}

TBR=rogerm@chromium.org,kolos@chromium.org,mkwst@chromium.org

Change-Id: I5f72413c856b359045df86a532db24ad69922e0a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 850606
Reviewed-on: https://chromium-review.googlesource.com/c/1279163Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599334}

Save a button title into FormData for crowdsourcing.

Title is inferred in two ways:
Type 1) Value attribute of an <input type="submit">.
Type 2) Text content of <button>

If there are several labels within a <form>, all labels are concatenated to collect more data. A delimiter depends on the type of <button>/<input>:
$ <input type="submit">
# <input type="button">
& <button type="submit">
% <button type="button">

The value is truncated if the length is more than 200. The same value is used for labels.

TODO: introduce title inference when there is no <form> tag.
TODO: consider other types of elements as submit button (e.g. <input type="image">, <a>, <div>/<span>)

Bug: 850606
Change-Id: I54783cfdd0134b3aec52e9404740a3e1495a8176
Reviewed-on: https://chromium-review.googlesource.com/c/1272356Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599333}

We were submitting UMA every time we recorded a update time measurement,
but some metric, particularly ForcedStyleAndLayout, may run multiple
times per frame. In such cases we want the per lifecycle time, to make
it comparable to UKM data and to avoid considering lots of small updates
to be less bad than one big update.

R=vmpstr@chromium.org
BUG=869966

Only report UMA once per lifecycle update

Change-Id: If4eebd782b4d109b18a608ece2a351226bb74732
Reviewed-on: https://chromium-review.googlesource.com/c/1277549
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599332}

Various places that use the JNI functions for accessing array elements
directly either forgot to release the array elements afterward, or are
doing something that can be done with one of the array helpers in base.
Fix them up to behave properly.

Change-Id: Iab3fe07949c67c884d60f7ffaaf0bd0faf0f13dc
Reviewed-on: https://chromium-review.googlesource.com/c/1279005Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599331}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I79ca1ec2869afec3c51b1a7d5f9faf830e325558
Reviewed-on: https://chromium-review.googlesource.com/c/1279092Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599330}

This became specially relevant recently due to ongoing adoption of
ModelTypeStoreBackend for allmost all sync datatypes. Let's keep an eye
of whether any of them is hammering disk I/O.

Bug: 870624
Change-Id: I739ad4feaf9ef0ba3d74d0444d2c9fcb7ef48455
Reviewed-on: https://chromium-review.googlesource.com/c/1275852Reviewed-by: Florian Uunk <feuunk@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599329}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I377414b2858dec1b847811853ac50f30bf4042e8
Reviewed-on: https://chromium-review.googlesource.com/c/1279089Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599328}

This patch fixes LayoutNGListMarker::TextAlternative to not
to rely on it has LayoutText child. This can happen if the
list marker is an image marker (for bullet lists) or the
function was called before layout completes.

LayoutListMarker always computes from its list item. LayoutNG
took a shortcut because we store the result in its LayoutText
child, but cases where we don't store was missed.

AXLayoutObject::TextAlternative() calls this function.

Bug: 894691
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I6c13c6f00920702e17188858d15c674d38698dfb
Reviewed-on: https://chromium-review.googlesource.com/c/1277132
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: cathie chen <cathiechen@tencent.com>
Cr-Commit-Position: refs/heads/master@{#599327}

Bug: 750327
Change-Id: I1e29f70a8628f7ac85f66d86a5949ee4a3477545
Reviewed-on: https://chromium-review.googlesource.com/c/1278956Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599326}

Make sure sites in the blacklist are not returned as part of a catalog get
operation. This builds upon Site blacklisting part 1.

Bug: 893845
Change-Id: I38686753167bbcb8e9f9d75d6c323bda813cab31
Reviewed-on: https://chromium-review.googlesource.com/c/1274058
Commit-Queue: Peter Williamson <petewil@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599325}

In recent change crrev.com/c/1263566, HeadlessContentUtilityClient
will be exported in component build on Windows. As usual, it should
be exported in headless.dll. However, library headless_shell_lib
also includes this class which results compilation errors.

This CL excludes HeadlessContentUtilityClient from
headless_shell_lib in component build to resolve the breakage.

BUG=894835

Change-Id: I44853a4c7a0701b9ea29cc16b18e9c3b358cb148
Reviewed-on: https://chromium-review.googlesource.com/c/1277883
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599324}

The underlying bug that caused this test to fail with Network Service
is now fixed, so the test can be enabled in that configuration.

Bug: 866549
Change-Id: I7ad64a2b58f31293b0d9e93ec6865618df0d5924
Reviewed-on: https://chromium-review.googlesource.com/c/1278064Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599323}

The shortcuts were looking for the SourcesPanel, when only the
SourcesView was present.

Bug: 875434
Change-Id: I6095ccaab4d7ab0c35f98153031e7204f023a30e
Reviewed-on: https://chromium-review.googlesource.com/c/1277988Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599322}

Enable those two options which may improve skia performance.

Bug: 894492

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I80a1b9d1ce018d90ab91e5e676b6d09a7dc23d8d
Reviewed-on: https://chromium-review.googlesource.com/c/1273267
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Cr-Commit-Position: refs/heads/master@{#599321}

If the lock screen was shown on the non-primary user, fingerprint auth would not
display because it only checked the primary user.

Bug: 882688
Change-Id: Ibbc479f4e393f587594b3915d8afe3492246c303
Reviewed-on: https://chromium-review.googlesource.com/c/1272026Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599320}

The original cl is reviewed here:
https://chromium-review.googlesource.com/c/chromium/src/+/1251901

The reland calls waitForCompositorCommit before starting the test to make
sure that the compositor is ready.

To Sheriffs:
Please update the test expectations in case of a flaky test instead of
reverting this cl since I need to convert middleClickAutoscroll
tests to use gpuBenchmarking to land the fix for autoscroll coordinates:
https://chromium-review.googlesource.com/c/chromium/src/+/1239174
GpuBenchmarking makes the tests prone to flakiness, input team will work
on the flakiness of the tests using gpu benchmarking in Q4.

Bug: 875945
Change-Id: Ic722fbd8a08bee7bc1e51143ae9a6cb738807fe7
Reviewed-on: https://chromium-review.googlesource.com/c/1277806Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599319}

The Multizone buffer must be flushed when we change the playback. The
simplest way to do this is to stop the backend each time. This is
equivalent to what is done in MediaPipelineImpl for cast devices that
use CastRenderer.

Bug: b/116795513, b/117497043
Test: cast_media_unittests, MZ and non-MZ pause/seek/skip
Change-Id: I885f1be625944b907859b99bd86b4eb2ef1e9bbd
Reviewed-on: https://chromium-review.googlesource.com/c/1271937
Commit-Queue: Aidan Wolter <awolter@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599318}

Bug: 892156
Change-Id: I2daa27782f4765d7f770505b0a198b5632678cc6
Reviewed-on: https://chromium-review.googlesource.com/c/1264660
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599317}

R=jhawkins@chromium.org

Change-Id: Ic1b65341c11279c450322223fe87ff565faa36e3
Reviewed-on: https://chromium-review.googlesource.com/c/1278953
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599316}

Fix site settings and detail link not shown on page info under URL
with certain unescaped characters.

Bug: 874455
Change-Id: Icf31bee1b644136d285c5286938b16bc2b3de88c
Reviewed-on: https://chromium-review.googlesource.com/c/1278205
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599315}

This API is being used for abuse.

Bug: 880863
Change-Id: I122e23f589d62eecc01a4418db3573c53779de7f
Reviewed-on: https://chromium-review.googlesource.com/c/1275165Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599314}

ScopedBlockingCall is now used to label blocking calls. There is no need to annotate
calls to blocking //base APIs (base::File) since those are already annotated.

Original CL intention was:
This CL uses ScopedBlockingCall to mark blocking calls in /components/filename_generation.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

Bug: 874080
Change-Id: Iaa06bd88ea651b96f69b594158ee859124b890d8
Reviewed-on: https://chromium-review.googlesource.com/c/1191662Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599313}