- 20 May, 2020 40 commits
-
-
Maksim Moskvitin authored
This CL removes some outdated unittests, which blocks removal of SyncEncryptionHandlerImpl. Bug: 1083924 Change-Id: I2af118b22c1943bce535cf329f5da5afa69f6956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207208Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#770555}
-
Rune Lillesveen authored
We could end up with a MatchedPropertiesCache hit for a ComputedStyle which was cached while in display:none, but was now supposed to be rendered. The problem with that is that for non-rendered elements we don't fetch image resources and have StylePendingImage set during style application. In order to use the MPC in this case we would have had to re-traverse the ComputedStyle for StylePendingImages an start fetching them. Instead, avoid using MPC for these cases. Bug: 1082486, 1084911 Change-Id: Ifecd66ef6d135990d9083616bd07d076815ab839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209464 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#770554}
-
Matt Menke authored
URLLoaderFactoryParamsHelper::CreateForRendererProcess is deprecated and untested, but it's still used in production under certain circumstances. It was using an empty IsolationInfo, which is no longer allowed. This CL makes it use a transient IsolationInfo instead, which prevents a DCHECK in the network service from triggering, due to the IsolationInfo being empty. Bug: 1082280,891872 Change-Id: I80c632957937f4d09be0bc20625397d9a1f04ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208369Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#770553}
-
Wei Lee authored
It is useful and this CL moves it to the upper directory so other components in CCA can use it as well. Bug: 980846 Test: tast run [DUT] camera.CCAUI* Change-Id: Ib37ae32dcda3cbc9fb79a8faf6e36f8d9641d562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210290 Commit-Queue: Wei Lee <wtlee@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#770552}
-
Yuichiro Hanada authored
The tests in input_ime_apitest_nonchromeos.cc are running only on Win and Linux bots, so disabling on Win and Linux bots means it's disabled simply. Change-Id: I862dde9915fb417d0d111d6e565a9e5e1b5ac5de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208487 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#770551}
-
arthursonzogni authored
The origin of the error page is already an opaque data-url. Updating the sandbox flags isn't necessary. This unlocks https://crbug.com/1041376. After that, the browser is able to compute the sandbox flags by itself, without relying on the (potentially compromised) renderer process. Bug: 1041376 Change-Id: Ida3635d4a07bcb486072b7dd6a271317fe274939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203199Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#770550}
-
arthursonzogni authored
Two new fields have been added to ContentSecurityPolicy: - treat-as-public-address - sandbox The ConvertToBlink function needs to be updated. Note: Ideally, the ConvertToBlink function should be future-proof. It shouldn't require developers to make update each time the ContentSecurityPolicy struct is updated. This has been proposed below: https://chromium-review.googlesource.com/c/chromium/src/+/2126933 but this has been rejected. This patch doesn't introduce a regression test, because those values are not used yet. This patch is required for: https://chromium-review.googlesource.com/c/chromium/src/+/2190680 Bug: 1041376 Change-Id: I490920aae96c8666aebf97a9f636aeb2405f824f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203070 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
Nazerke authored
This is a reland of 3585551d Original change's description: > [iOS][tabmodel] Deprecation of TabModel in tab_test_util. > > This CL removes tab_test_util's dependence on TabModel by getting > WebStateList from Browser instead. > > Bug: 1045575, 1050138 > Change-Id: I981eae54cc934d444a93824cfa9bc6bb46199aff > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171480 > Reviewed-by: Mark Cogan <marq@chromium.org> > Commit-Queue: Nazerke Kalidolda <nazerke@google.com> > Cr-Commit-Position: refs/heads/master@{#765981} Bug: 1045575, 1050138 Change-Id: I0c0e8f1318db598ef4e6a54ebf2ec1f9edb6a139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199337Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#770548}
-
Esmael El-Moslimany authored
chrome-search://local-ntp/local-ntp.html is being replaced with chrome://new-tab-page. Change-Id: I57f8b19f72edbe52a2c7830bd3e8e5c0ecc467cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209303Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#770547}
-
Roman Aleksandrov authored
The X button of the window could be removed since config dialogs have their own Cancel button. Bug: 1023768 Change-Id: I05c0f5551c4c5f63119faeed79537e1dc05ded4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209076Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#770546}
-
Denis Kuznetsov authored
Also replaced class-based selectors with hidden attribute, removed unused APIs. Bug: 1017156 Change-Id: I6daf2e6f75943c9f1186e31dd207c53ca160db92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207218Reviewed-by:
Renato Silva <rrsilva@google.com> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Thomas Tellier <tellier@google.com> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#770545}
-
Roman Sorokin authored
Before this CL Login screen hid the Oobe dialog when switching from empty user list to non empty. I believe this might cause an issue when Device Disabled screen was shown but then Login screen hid it on the first run. Now Login screen hides the dialog only if the Gaia login is shown. Also removed LoginScreenController::HideGaiaSignin Fixed: 1084460, b/155437418 Change-Id: I80bd5290488824d9a094a334cfa39712adb1da4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209130Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d45b30b5a554..583c9a38d9bd 2020-05-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 67eac5116ba3 to 4683991f7675 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: Ic3bdcaa3b59ba0c4f5dc3a0e6157232a9a87ae69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209324Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770543}
-
Antonio Sartori authored
The file /services/network/public/cpp/content_security_policy/csp_source_unittests.c was not being built as part of the services_unittests. I guess we forgot to add it after a refactoring. This commit enables those tests. Change-Id: If451b06f05bf375fca18ad7c1a7a206700d6c572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209079Reviewed-by:
-
Mark Cogan authored
Bug: 1072370 Change-Id: I1edcafd14b31472b80e165c22b6ffeab7ef1667d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199336 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770541}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b3bb9d3aa2c5..5e736fbd7e3d 2020-05-20 wolfi@chromium.org Port DOMDebuggerModel to ts 2020-05-20 sigurds@chromium.org Typescriptify ServiceWorkerCacheModel If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1079233 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If9547f2c0118badcbcb3583515589828f64a390b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209327Reviewed-by:
-
Denis Kuznetsov authored
Bug: 1007876 Change-Id: If20a2e559c49d5df22e71b2a49ad74c4fbd9b460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209065 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770539}
-
Denis Kuznetsov authored
This check is unnecessary: if web_ui is not present, JSCall will be deferred (see base_web_ui_handler.h) and executed once OobeUI::InitializeHandlers is called. Bug: 1084928 Change-Id: Ib1d3577896b5792d4d9a9629854feb9b5a90f5c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209135Reviewed-by:
-
Anders Hartvoll Ruud authored
This CL optimizes the memory impact of dependencies in two ways: - Use AtomicString to store the property names for both standard and custom properties. AtomicString only requires 8 bytes vs 16 bytes for CSSPropertyName. Converting AtomicString back to CSSPropertyID for usage is very quick, since the hash table is gperf'ed. - It is quite common to have zero dependencies, in which case a Vector is wasteful given sizeof(Vector)==16. Hence use a g_null_atom- terminated array instead. Bug: 1057072, 1083168 Change-Id: Iddfa5bae870a8d91d570538e69ad6220aee2fb9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207192 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#770537}
-
Christopher Lam authored
Bug: 1060060 Change-Id: I3f7d7862385f86db2cc41fe17c4993a552a3be64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210172Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#770536}
-
Yutaka Hirano authored
Bug: 1083850 Change-Id: I54576070093187ccff5931d8b7e15c66cd6dc455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206146 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#770535}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/0ab78114a9e1..2e0f0a0517e4 2020-05-20 cepheus@frii.com Fix #2227, which was coded incorrectly, to be simpler/safer. 2020-05-20 cepheus@frii.com Build: Fix #2228, by correcting the type used. 2020-05-20 lryer@msn.com Code refine. (#2227) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I44d10f89025fff3449990a3b8c34119e8514092e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210221Reviewed-by:
-
Alexander Hendrich authored
This CL refactors large parts of the EnterpriseDeviceAttributesApiTest class into a new ForceInstalledAffiliatedExtensionApiTest class that can be shared for the enterprise.deviceAttributes API test and the new enterprise.networkingAttributes API test. The parameterized test class takes care of setting up a affiliated/non-affiliated (based on parameter) user and force-installs the specified extension. Bug: 1081333 Change-Id: Ic3c73c36dfe9e5cbff02d31e05099eca38eba42d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196669 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770533}
-
Jérôme Lebel authored
Adding metrics to record the duration to get the SSO identity list, when those calls happen, and if the cache is stale or not. + Signin.SSOIdentityListRequest.CacheState Records the cache state (stale or valid) before GCRSSOService is called (|identitiesWithError:| and |identitySortedForDisplay|). This histogram has a suffix: * BackgroundRequest When Chrome is in background. * FirstRequest When it is the request of the live time of Chrome. * FirstRequestForeground The first request when Chrome is in foreground. * ForegroundRequest When Chrome is in foreground. + Signin.SSOIdentityListRequest.Duration Records the duration of |identitiesWithError:| and |identitySortedForDisplay|. This histogram has a suffix: * Stale: when the cache is stale before the call. * Valid: when the cache is valid before the call. Related to: crrev.com/i/2995955 Bug: 1082767 Change-Id: I4d71a4271f3f5dc59d919785b4557e4b3133044a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201720 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770532}
-
Åsa Persson authored
- WebRTC.Video.AdaptChangesPerMinute.Quality - WebRTC.Video.AdaptChangesPerMinute.Cpu - WebRTC.Video.AdaptChangesPerMinute - WebRTC.Video.Encoder.CodecType Bug: 1075637 Change-Id: Ieaeb1532a9108a4ca9b7755e3b1c8a6cf0ed146a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208974Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Åsa Persson <asapersson@chromium.org> Cr-Commit-Position: refs/heads/master@{#770531}
-
Yifan Luo authored
Change-Id: Ic948638ce9641d58fd734fdbc0ec05e031b92fb5 Bug: 1064598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201217Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/master@{#770530}
-
Yoshifumi Inoue authored
This patch changes "extend-selection-bidi.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: If09b8ac1691ce739dd4c0f058eca2850c1660a1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209776 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770529}
-
Makoto Shimazu authored
The experiment will be resumed, and this CL is to reflect the latest state of the experiment. Bug: 824858 Change-Id: Id3d31140a623cde26fe8de8436c23406d248bc5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208581Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6ae0b83914c0..b3bb9d3aa2c5 2020-05-20 tvanderlippe@chromium.org Fix registerDispatcher types in Closure 2020-05-20 yangguo@chromium.org Seed more owners to front_end directories 2020-05-20 wolfi@chromium.org [Issues] Fix margin for affected resource list 2020-05-20 beaufort.francois@gmail.com Fix nit in releases notes 2020-05-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1072335,chromium:1081686,chromium:1082687,chromium:955497 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2a50e93d32779ccdc3e64eef3243ff7665551da0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210218Reviewed-by:
-
Matthias Körber authored
Change-Id: I6113a2bc0b7724c880ca3c686206eac035594de7 Bug: 1084903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209211 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#770526}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1589903980-ca5fa5e99fa1c661edfdfa4ab3f1c52b9013445e.profdata to chrome-win64-master-1589961590-b5238e477e88144b4ee977d3e9b375905cf319c2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: If8a7afcf994cfdf150eda6721146a510e181b769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209326Reviewed-by:
-
Andrew Walbran authored
This is a third-party USB game controller for the Nintendo Switch, but doesn't seem to work with or require the special Switch controller initialisation. Windows and Mac OS use the same mapping but Linux is different for some reason. Change-Id: I889e7fbe84c9e126d73c65e3be88bab3976f3941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203383Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Andrew Walbran <qwandor@google.com> Cr-Commit-Position: refs/heads/master@{#770524}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I836e77c23be591459d5f2769116b1d7e0869e7f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210213Reviewed-by:
-
Henrique Ferreiro authored
Change-Id: Iea8ecbca185da46169fb23e1b2ea35a82d6ac626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203198Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#770522}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1589947115-56f4011405e4eeb70dd293d8da98a761636dbc3e.profdata to chrome-mac-master-1589961590-5bcd8ca24d15822b25b9ab44f061677dc2856648.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I59006a54ae8d9ad2d9628994c0be0ff99347bab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209323Reviewed-by:
-
Dominic Battre authored
This CL introduces just a few helper functions to simplify debugging automated autofill tests. Bug: 1079488 Change-Id: I90f3b1f608a8bfb4303eee0ab8830972634440d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209451 Commit-Queue: Dominic Battré <battre@chromium.org> Auto-Submit: Dominic Battré <battre@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#770520}
-
Zach Trudo authored
PluginVmLicenseValidator ensures that a user has a valid license. File Changes: ~ chrome/browser/chromeos/ | ~ BUILD.gn | | Add PluginVmLicenseValidator to the buildable target. | ~ plugin_vm/ | | + plugin_vm_license_validator.cc/h | | | Create PLuginVmLicenceValidator | | ~ plugin_vm_util.cc/h | | | Include PluginVmLicenseValidator as part of the checks. Change-Id: I4974f0904b43fb8ec40fcd54e9bc89a16e7d2d6c Bug: b/152619375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207942 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#770519}
-
Roman Sorokin authored
The function is not used (anymore?). Thus removing it. Also replaced LoginDisplayHostMojo::SetUsers with SetUserCount. As only the number of users used in the class Fixed: 1084533 Change-Id: I301c6a768ca95bacb94882f16c512c8f2e59f674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207385Reviewed-by:
-
Christian Dullweber authored
Remove some usages of the old third party cookie preference. Observe settings changes though CookieSettings instead of listening to preferences directly. Change-Id: I1f863e391867ce86dbaf2ecb7a53569a20c0e8ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181289 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#770517}
-
tby authored
Bug: 1076270 Change-Id: Ia9c2cac890d0288211e399734f0fae70603bf866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208839 Auto-Submit: Tony Yeoman <tby@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#770516}
-
