- 28 Nov, 2018 40 commits
-
-
Ted Choc authored
The underlying problem is how Chrome determines what action mode should be shown on long press. If you long press on whitespace, then just the paste popup is shown. If you long press on text, then cut/copy/paste is shown. On these test devices, it simply happened to touch on whitespace where other devices would touch on the text based on the offsets calculated. This changes the bulk of the tests to not have whitespace at all to avoid this. For testLongPressInputWhileComposingText, it just makes the first portion of the text very long to avoid the mismatch (not fool proof, but better). BUG=907573 Change-Id: I87fabd8d6fcc8a532976e2abe028e60664e3c7f5 Reviewed-on: https://chromium-review.googlesource.com/c/1353953Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#611876}
-
Drew Davenport authored
Disabling this prevents drawing the UI in the corner of an external display at the internal display's size when closing the lid. This makes the transition in this use case smoother, and also avoids displaying uninitialized framebuffer contents on some gpus. BUG=898524 Change-Id: Id23ef472ad7d7504c74644bd11186a4380e36f13 Reviewed-on: https://chromium-review.googlesource.com/c/1352709Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Drew Davenport <ddavenport@chromium.org> Cr-Commit-Position: refs/heads/master@{#611875}
-
Eric Roman authored
After I changed the bypass policy for localhost, this test stopped routing through proxy. Bug: 901896 Change-Id: I5f604865b60837143e7b2bc00c3dcbc9971c70c3 Reviewed-on: https://chromium-review.googlesource.com/c/1351145Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#611874}
-
Ramya Nagarajan authored
Change-Id: I65f32e69901e78bf56d028c5e09fcca3c964850c Reviewed-on: https://chromium-review.googlesource.com/c/1352812Reviewed-by:
Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#611873}
-
Xi Han authored
This is the first patch that adds tests that start Service Manager and run without full browser starts. Bug: 904549 Change-Id: I713aa68ba5ce7af11075a73a4ff52303b3c013ec Reviewed-on: https://chromium-review.googlesource.com/c/1332259 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#611872}
-
Mounir Lamouri authored
This is adding the interface changes, the code checking for corectedness, does type conversion and checks for the edge cases mentioned in spec. This is also adding WPT. Bug: 907909 Change-Id: Ieebe5b25202a403e50a09576ac283690c0f0ba55 Reviewed-on: https://chromium-review.googlesource.com/c/1348972 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#611871}
-
Khushal authored
Update the SurfaceControl ABI based on NDK changes and hook up transaction acks from the framework for GLSurface swap acks. Change-Id: I7919bbe97cc621c1912657ed4c1894ede8308fab Bug: 889328 Reviewed-on: https://chromium-review.googlesource.com/c/1347792Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#611870}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dbc542d5f0f3..cbdf45b8cca9 Created with: gclient setdep -r src-internal@cbdf45b8cca9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I460dbdd5c3a6ad7a866c63144ba5702325b51ef1 Reviewed-on: https://chromium-review.googlesource.com/c/1354299Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611869}
-
Carlos IL authored
Bug: 894513 Change-Id: Ic1d07c820cfce2aa4eae54a54e748fd0450ca7ab Reviewed-on: https://chromium-review.googlesource.com/c/1347797Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#611868}
-
Dmitry Iljinskiy authored
Change-Id: I69146b9a9a0bc750f37ef87083c146a62044018e Reviewed-on: https://chromium-review.googlesource.com/c/1349949Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#611867}
-
Ryan Meier authored
Bug: 396473 Change-Id: I372f2493d01ce4a2c3271bce9800451cff0cc63c Reviewed-on: https://chromium-review.googlesource.com/c/1352614 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#611866}
-
Mike Reed authored
See skia cl https://skia-review.googlesource.com/c/skia/+/173226 Change-Id: Id097cfd805140a297dff07bbfae1037f2a18467a Reviewed-on: https://chromium-review.googlesource.com/c/1352679Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#611865}
-
Chris Harrelson authored
The code is not reachable in SPv2 mode. This check is a leftover from an earlier iteration of the SPv2 implementation. Change-Id: I3cbeb1f7e085bfab493130c1f2fe3aa1486a33e6 Reviewed-on: https://chromium-review.googlesource.com/c/1351807Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#611864}
-
Michael Spang authored
This does not appear to be used. Bug: none Test: compile Change-Id: I4fd983a685ee9e1d493b34d542c3f40d9253643c Reviewed-on: https://chromium-review.googlesource.com/c/1345417Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#611863}
-
Daniel McArdle authored
Page info no longer displays the number of bits of security, so we no longer need the various security_bits fields contained in SSL structs. Specifically, this patch removes security_bits from the following structs/classes: * net::SSLInfo * content::SSLStatus, * security_state::VisibleSecurityState * security_state::SecurityInfo Bug: 905692 Change-Id: Ia55be6573476453c8dfcabc7dcf36b9ddf27d290 Reviewed-on: https://chromium-review.googlesource.com/c/1338259 Commit-Queue: Daniel McArdle <dmcardle@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#611862}
-
Michael Spang authored
When the GPU process restarts we need to re-send the cursor bitmap since all GPU process display state is lost. It looks like it may have been broken all the way back to d818104f ("[Ozone-Drm] Notify cursor of channel established last"), which fixed a different issue but also caused the message that was intended to restore the cursor (in CommitBoundsChange) to not get delivered. Reland fixing case where a GPU process connects and the cursor is not placed because there are no displays to place it on. This should only affects tests, because there's always at least one display on Chrome OS. Bug: 908682 Test: kill $(pgrep -f type=gpu-process), cursor restored Change-Id: I378d14e61c95822c2362d047123e5f7e40778a80 Reviewed-on: https://chromium-review.googlesource.com/c/1351143Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#611861}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia8469eb5c5803c4db403d682cd8f8bc84b4cf1c6 Reviewed-on: https://chromium-review.googlesource.com/c/1354300Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611860}
-
Vladimir Levin authored
This patch ensures that we don't accidentally use display locking in mode 1, which isn't currently supported. R=chrishtr@chromium.org Bug: 882663 Change-Id: I2be26e2573ebe93a97bd6df4c8fcb7cd6221b28c Reviewed-on: https://chromium-review.googlesource.com/c/1347102Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#611859}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e7e7a29184f5..4274496685fe git log e7e7a29184f5..4274496685fe --date=short --no-merges --format='%ad %ae %s' 2018-11-28 cjmcdonald@chromium.org chromeos_config: Add grunt_march USE flag to grunt-release builder Created with: gclient setdep -r src/third_party/chromite@4274496685fe The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I77bf66ab3b0a8cab29348e22d27fb33a3c94cd26 Reviewed-on: https://chromium-review.googlesource.com/c/1354298Reviewed-by:
-
Dan Zhang authored
Add stats platform API for client and server side. R=rch@chromium.org Change-Id: Ic26e26b1e77916f1f76da3c7cb9b1b1cc43e3e8f Reviewed-on: https://chromium-review.googlesource.com/c/1344193Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Dan Zhang <danzh@chromium.org> Cr-Commit-Position: refs/heads/master@{#611857}
-
John Abd-El-Malek authored
r562058 made the network process always run in a job object to try to avoid it outliving the browser process. This was added to make the network process quit sooner if there was a lot of pending I/O, which happened with layout tests. Windows before version 8 doesn't support nested job objects though, so we need to stop this mitigation for those old versions. Bug: 904361 Change-Id: If75fc933052b1b7d4ef3d3e90664f777624c04d7 Reviewed-on: https://chromium-review.googlesource.com/c/1350977 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#611856}
-
Tibor Goldschwendt authored
Bug: 873719 Change-Id: I3b9a44f5fa1b9ec47acb429e9062fcd2fbbb8f27 Reviewed-on: https://chromium-review.googlesource.com/c/1347038Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#611855}
-
Anthony Vallee-Dubois authored
Bug: 901867 Change-Id: Ica4f7ef18854c726f678485ce045042b8d13fbc1 Reviewed-on: https://chromium-review.googlesource.com/c/1352334Reviewed-by:
Michael Martis <martis@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#611854}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6457c042bc7b..029a56af584c git log 6457c042bc7b..029a56af584c --date=short --no-merges --format='%ad %ae %s' 2018-11-28 nednguyen@google.com Disable testSmokeStartingWebPageReplayGoServer Created with: gclient setdep -r src/third_party/catapult@029a56af584c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:909746 TBR=sullivan@chromium.org Change-Id: Iacd9bd664c2e2a236365c120bdc810ff8e31a873 Reviewed-on: https://chromium-review.googlesource.com/c/1354181Reviewed-by:
-
John Abd-El-Malek authored
Also remove a bunch of usages of MockResourceContext that are no longer needed. Bug: 908955 Change-Id: I3485595c83ef8e22f245c22c97775845c5e0e7fc Reviewed-on: https://chromium-review.googlesource.com/c/1352035Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#611852}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/cb8a4ddc2277..b67698386664 git log cb8a4ddc2277..b67698386664 --date=short --no-merges --format='%ad %ae %s' 2018-11-28 asweintraub@google.com Fix for a bug where no valid codepoints are recognized in certain PDFs. Created with: gclient setdep -r src/third_party/pdfium@b67698386664 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:909762 TBR=dsinclair@chromium.org Change-Id: Ib6b3b5038a133df9fcfc404253a3de0e5756b205 Reviewed-on: https://chromium-review.googlesource.com/c/1352868Reviewed-by:
-
Charles Zhao authored
Change-Id: I6fe3dd94a248914cd3f86339f7a152fdda3886d0 Reviewed-on: https://chromium-review.googlesource.com/c/1353033Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#611850}
-
Liquan(Max) Gu authored
The design of FCP++ have several containers that store the node ids of objects. In case the size of them will grow unlimitedly, we set a cap for these containers. The original implementation uses a counter to count the number of nodes. As a better approach, we can use the sum of the sizes of the containers for the same purpose. The original implementation uses "recorded_node_count_ > kTextNodeNumberLimit" as a condition. The condition was still checked each time after the condition has been met. As A better approach, we can have "is_recording_" flag to indicate whether the container still accepts new entries. Bug: 869924 Change-Id: Ifc03e5f782e16bab65f6f024d9f73974051ca421 Reviewed-on: https://chromium-review.googlesource.com/c/1349477 Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#611849}
-
Brian White authored
This ensures that all metrics for a page will be sampled in/out together and is important for things like Blink.UseCounter that is a multi-output per page and capturing different outputs on different pages can be misleading. All or nothing, per-page. Design Doc: https://docs.google.com/document/d/19UKLg7JJSmcS59V7TPnC6w8Smt22xeB12x-lvASVR0s/edit?usp=sharing Bug: 766909 Change-Id: Ib025b31b85e343d0b8ffec1d190395c1a8bd573d Reviewed-on: https://chromium-review.googlesource.com/c/1343060 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#611848}
-
edchin authored
This CL renames SnapshotGeneratorDelegate protocol methods to be unique to SnapshotGenerator. Bug: 904992 Change-Id: I6357931f782a7d533a74a0b438751b4d5a78aab4 Reviewed-on: https://chromium-review.googlesource.com/c/1345128 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#611847}
-
Devlin Cronin authored
Refactor the permissions parsing in the chrome.permissions API in order to separate out requested permissions into different fields, including required permissions, optional permissions, and permissions that were not specified in the manifest. Add more robust testing for the permissions parsing code. This CL is prework for subsequently adding support for requesting withheld content script permissions through the permissions API. There should be no behavior change as a result of this CL. Bug: 889654 Change-Id: I22c1e057ccb259b4fcff4051923fc9c1128c8213 Reviewed-on: https://chromium-review.googlesource.com/c/1347310 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#611846}
-
Aleksei Koziatinskii authored
TBR=dgozman@chromium.org Bug: chromium:595206 Change-Id: I95ed4bb30e36b4e2dd7a76713e849fbefe7f932c Reviewed-on: https://chromium-review.googlesource.com/c/1354232Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#611845}
-
Sebastien Seguin-Gagnon authored
This reverts commit 995f8099. Reason for revert: Breaks browser tests on continues builders (consistent failures) See crbug.com/908787 Original change's description: > Make SaveCardBubble browsertest use the sync state > > The browsertests used to rely on the save manager being hardcoded to > upload to Google if the observer_for_testing was set. This makes it > impossible to test that the logic for showing the upload prompt works > properly. > > BUG=906630, 859761 > > Change-Id: Id7352a869388aac4ff36e1284750e22ac68c91b3 > Reviewed-on: https://chromium-review.googlesource.com/c/1348335 > Commit-Queue: Florian Uunk <feuunk@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610866} TBR=vasilii@chromium.org,sebsg@chromium.org,feuunk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 906630, 859761 Change-Id: I145d2b56295af6014b6a94c44beb38b1bf6b9e01 Reviewed-on: https://chromium-review.googlesource.com/c/1352680Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#611844}
-
Robert Ogden authored
Needed for testing so that we can reliably trigger in cases where we normally would have needed to show the HTTPS Previews Notification Infobar first. Bug: 908491 Change-Id: I83c3ca2bf41de24e5926128804ab523f77608e18 Reviewed-on: https://chromium-review.googlesource.com/c/1352975 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#611843}
-
file:///*.svgzChris Mumford authored
Adding a UMA counter for file:///*.svgz file loads in order to ensure we aren't deprecating support for something widely used in Chrome. Bug: 857117 Change-Id: I74e40df6c9aebd33197c2a5cfaf1af83bb84ea51 Reviewed-on: https://chromium-review.googlesource.com/c/1338302Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#611842}
-
edchin authored
This CL migrates the pageInfo coordinator from BVC to BrowserCoordinator. Bug: 905524 Change-Id: I56ed15b3bb13ce07db3da97de8e66ff020f032f2 Reviewed-on: https://chromium-review.googlesource.com/c/1338162 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Fredrik Söderquist authored
Disabled SVG shapes [1][2][3] should not be possible to hit since they are considered "not rendered". [1] https://svgwg.org/svg2-draft/shapes.html#RectElement [2] https://svgwg.org/svg2-draft/shapes.html#CircleElement [3] https://svgwg.org/svg2-draft/shapes.html#EllipseElement Bug: 896641 Change-Id: I5fe530722a4d60ecd416cd68f06a7555bb6a520f Reviewed-on: https://chromium-review.googlesource.com/c/1353983Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#611840}
-
Ian Kilpatrick authored
There should be no behaviour change. Change-Id: I32389eb3b05a6935e320fa3d871d27c3eead2c73 Reviewed-on: https://chromium-review.googlesource.com/c/1353948Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#611839}
-
danakj authored
This is a reland of 66794d00 In this reland we revert changes to RenderThreadImpl and mus to make LayerTreeFrameSink creation asynchronous again. Then in RenderWidget we must remember that a warmup is underway, we do so with a bool and a WeakPtrFactory. If it is aborted, we reset the bool and invalidate the WeakPtrFactory. If a request for a frame sink beats the warmup completing, we save the callback and run that instead of saving the frame sink on RenderWidget when the warmup completes. This ignores some weird weird corner cases like where warmup is aborted then we start another warmup or unfreeze the widget or something and will just make redundant requests. Since these are so rare they are not worth adding complexity for. Original change's description: > Start gpu channel and compositor mojo pipe collection eagerly > > When a RenderWidget is frozen, its compositor is stopped. However when > the main frame is being navigated, we want to start requesting mojo > pipes for the gpu and display compositor immediately so that it can > happen in parallel with the navigation loading. > > Previously, we just always did this when creating a RenderWidget, and > left them active when freezing the RenderWidget. After 678f025f > however, we don't, and this causes time-to-first-pixels regressions > on navigation. > > So we add a WarmupCompositor() method to RenderWidget, and call this > from RenderFrameImpl::CreateFrame() when it makes the provisional > frame, and the WebFrameWidget, since we expect to make use of the > main frame RenderWidget shortly. > > Then, if RenderFrameImpl::FrameDetached() occurs, due to the > navigation failing, we will AbortWarmupCompositor() to drop the > mojo pipes instead of holding onto them indefinitely. > > This recovers the loading regressions introduced, while also not > allocating mojo channels for frozen RenderWidgets indefinitely. > > In order to do this reasonably, we drop the "callback" from the > request to RenderThreadImpl::RequestNewLayerTreeFrameSink so that > it always returns something immediately. This way RenderWidget > does not need to worry about having a task run to collect the > new frame sink, and ordering with tasks from the compositor to > collect it. > > R=piman@chromium.org > > Change-Id: I6007e26e1622006652ce3619cdd080539d11e7b0 > Bug: 905191 > Reviewed-on: https://chromium-review.googlesource.com/c/1341073 > Commit-Queue: danakj <danakj@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610909} Bug: 905191 Change-Id: I6cb65e08a832a969156b96bece0f2e12eccd5b60 Reviewed-on: https://chromium-review.googlesource.com/c/1351938 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Evan Stade authored
This relands commit 01dd4ead. Breakage was due to in-flight conflict with 39536eb8 Fix is just to update a few more function names that were added in that change. Original change's description: > Make BrowserWithTestWindowTests work with single process Mash > > The InputDeviceClient needs to only be created once, so remove it > from AuraTestSuiteSetup. Otherwise, in BrowserWithTestWindowTest, > it gets created twice: during test suite setup, and as part of > OzonePlatform (due to AshTestHelper/ash::Shell). > > Many tests still need one though, especially those that create a > WebContents, so add it to RenderViewHostTestEnabler, which should > take care of all RenderViewHostTestHarness tests or tests that create > the enabler manually. > > Also update a few other tests to either create their own > RenderViewHostTestEnabler or InputDeviceClient as appropriate. > > Also the InputDeviceManager can be a true singleton now (not thread- > singleton). TBR=sky@chromium.org Change-Id: I4eb8579404ab6c10fb9d6ac9ac8c8c6e7a9baa57 Reviewed-on: https://chromium-review.googlesource.com/c/1352969 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#611837}
-
