- 25 Feb, 2019 40 commits
-
-
Xiaocheng Hu authored
NoTry: True Tbr: dtrainor@chromium.org Bug: 932092 Change-Id: Ie1484936cd92f1d48c69d02c7efdeb3c47d6f6b3 Reviewed-on: https://chromium-review.googlesource.com/c/1488054Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635313}
-
Daniel Cheng authored
Change-Id: Id3444dca74b55269c4f07c303f2f9c49cc0e6049 Reviewed-on: https://chromium-review.googlesource.com/c/1485699Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#635312}
-
Anand K. Mistry authored
This is a reland of https://crrev.com/634562. The original change didn't handle failures as expected for the watcher API functions. BUG=934541 Change-Id: I964dc908a35f02e237604bfd18f931d282b3a4d5 Reviewed-on: https://chromium-review.googlesource.com/c/1484965Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#635311}
-
Andrew Moylan authored
This CL uses ScopedFeatureList to control the UserActivityPredictionMlService flag to toggle between the ML Service and old TfNative codepath for Smart Dim. Both codepaths are now tested. In order for the ML Service codepath to work in a unit test environment, where there is no real ML Service daemon, we need to inject a fake MlServiceClient implementation. Quite a bit of refactoring was applied to separate the tests that don't apply to both codepaths from the tests that do apply to both codepaths, and to control the different combinations of flags we need to test. Bug: 933638 Test: unit_tests --gtest_filter=SmartDim* Change-Id: I95f19c1fcc925422effef1ec4221a76cbe1fc8e6 Reviewed-on: https://chromium-review.googlesource.com/c/1478666 Commit-Queue: Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#635310}
-
Nick Harper authored
TBR=bnc@chromium.org Change-Id: I9517216cc228282085f0676ec676ea5157c46360 Reviewed-on: https://chromium-review.googlesource.com/c/1486877Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#635309}
-
Xiaocheng Hu authored
[Sheriff] Mark two more external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/counter-styles-3/ tests as failure on Mac Tbr: xiaochengh@chromium.org NoTry: True Bug: 935689 Change-Id: Ic831b15257501a092f9e33610165f6a3d0baa5e1 Reviewed-on: https://chromium-review.googlesource.com/c/1488014Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f78131dac076..fe14b2e503a5 git log f78131dac076..fe14b2e503a5 --date=short --no-merges --format='%ad %ae %s' 2019-02-25 ynovikov@chromium.org Revert "Add system util to execute app and retrieve its output" 2019-02-25 tobine@google.com Vulkan:Adding custom pool allocator 2019-02-23 syoussefi@chromium.org Add system util to execute app and retrieve its output Created with: gclient setdep -r src/third_party/angle@fe14b2e503a5 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I4e9aec9815b57f6262abff44cc86175dacf4faac Reviewed-on: https://chromium-review.googlesource.com/c/1487845Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635307}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8c1e8f1fb771..9b433073ba38 git log 8c1e8f1fb771..9b433073ba38 --date=short --no-merges --format='%ad %ae %s' 2019-02-25 hliatis@google.com Fix minor issue in vkCreateInstance extension loop Created with: gclient setdep -r src/third_party/swiftshader@9b433073ba38 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/125943360 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I4d09db4a8744991c5d852f5ae0ac8d404ca9bf38 Reviewed-on: https://chromium-review.googlesource.com/c/1487136Reviewed-by:
-
Ryan Sturm authored
I am targetting fixing one test before moving on to other tests. By calling the UI thread version of the method (instead of the general one) we guarantee a more synchronous interaction, and by disabling the hints installer from sending actual hints, we guarantee that nothing overrides the test hints. This fix is motivated by two facts: the installer and the test both might try to install hints that override each other, and the PreviewsOptimizationGuide starts observing after the HintCache is fully initialized (meaning a DB is read). Bug: 932913 Change-Id: I9f0dc5ef85c9ac1d2e099e7227182890e2114338 Reviewed-on: https://chromium-review.googlesource.com/c/1487174Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Auto-Submit: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#635305}
-
Jacques Newman authored
Also removed xy test to avoid being dependant on scrollbar width. Bug: 935256 Change-Id: Id0436cd2f9654ee7dd121a65eefcdf5b6d458fb7 Reviewed-on: https://chromium-review.googlesource.com/c/1486875 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#635304}
-
Karan Bhatia authored
Protect requests made by the local NTP by treating the chrome-search://local-ntp as sensitive. BUG=931013 Change-Id: I6480bfa606be837295daff9d7fd5c906cd7dd98f Reviewed-on: https://chromium-review.googlesource.com/c/1483874Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#635303}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9e322313..a32d20ab Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5dbd2cecbf000818991f0806ff6ea531f5d732e9 Reviewed-on: https://chromium-review.googlesource.com/c/1487803Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635302}
-
Karandeep Bhatia authored
We don't correctly handle patterns beginning/ending with wildcards and an anchor. Fix this. Also disallow patterns starting with a wildcard and having a subdomain anchor, since it's not clear how these should be matched. This also necessitates a scheme update. BUG=932958 Change-Id: I2cf249b7de1ec238044c293f5dcc1168bb3e1d8e Reviewed-on: https://chromium-review.googlesource.com/c/1484828 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#635301}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/b92fa105572a..9b8d2b0bbfad git log b92fa105572a..9b8d2b0bbfad --date=short --no-merges --format='%ad %ae %s' 2019-02-25 cwallez@chromium.org Instance: Only discover default adapters once. Created with: gclient setdep -r src/third_party/dawn@9b8d2b0bbfad The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I80465621e490fc10f78d360c6013f64c3ca40572 Reviewed-on: https://chromium-review.googlesource.com/c/1487836Reviewed-by:
-
Xiaocheng Hu authored
[Sheriff] Disable ProfileWindowBrowserTest.OpenBrowserWindowForProfileWithSigninRequired on Win and Linux Bug: 935746 Tbr: droger@chromium.org NoTry: True Change-Id: Ibf25dfaa3136e06501faaab14e3e54d9a30341a8 Reviewed-on: https://chromium-review.googlesource.com/c/1488031Reviewed-by:
-
Elly Fong-Jones authored
Bug: None Change-Id: I63b4eae1090eb0c8622ac3b1e6e0d177ca91b69d Reviewed-on: https://chromium-review.googlesource.com/c/1487877 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#635298}
-
Sergey Ulanov authored
viewsv1 dependencies have been removed from topaz, so WebComponent doesn't need to support it anymore. Bug: 899348 Change-Id: Icd666bcbd00b8bbb52ccd1948b4d977e83bab40b Reviewed-on: https://chromium-review.googlesource.com/c/1487848 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#635297}
-
dpapad authored
Bug: 933062 Change-Id: Id7865e5d14ae505a590d7b14da45e24dfb31f81d Reviewed-on: https://chromium-review.googlesource.com/c/1475208 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#635296}
-
Tommy Steimel authored
This CL adds a new component to interface with MPRemoteCommandCenter: https://developer.apple.com/documentation/mediaplayer/mpremotecommandcenter?language=objc This is used to receive media key presses instead of using an event tap so that we avoid an issue where the OS prompts the user for extra privileges when the event tap is created. Bug: 930180 Change-Id: I3877499a49529c88427590cc013700b2e5e985ee Reviewed-on: https://chromium-review.googlesource.com/c/1480702Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#635295}
-
kylechar authored
Post[Delayed]TaskWithTraits() takes a OnceCallback. Replace usage of base::Bind(), which produces a RepeatingCallback, with base::BindOnce() when the callback is created as a temporary inside of PostTask(). The following regex was used to find instances that could be replaced: (Post(?:Delayed)?TaskWithTraits)\((?:\n\s*)?FROM_HERE,\n?\s*(\{.*?\n?.*?\}),(?:\n)?\s*base::Bind\( Also replace any usage of base::Passed(&var) with std::move(var) for variables passed to base::BindOnce(). base::Passed() isn't needed for move-only types with OnceCallbacks. This CL was uploaded by git cl split. R=jochen@chromium.org Bug: 714018 Change-Id: I7aea860addd894f1c0b0895ae474c5e52dfb23ee Reviewed-on: https://chromium-review.googlesource.com/c/1486155 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#635294}
-
Wenzhao Zang authored
In order to support country-level customization for Demo Mode, there's a newly added |device_owner| field, which is an email address. (https://critique.corp.google.com/#review/235043138) DM server will directly enroll the device into the corresponding sub organization based on its value. Bug: 888733 Change-Id: I86fee12c5b76e28f50f6329b76cb73893b596483 Reviewed-on: https://chromium-review.googlesource.com/c/1461777Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#635293}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ac25a05e. With Chromium commits locally applied on WPT: 14c11107 "Implement `Sec-CH-Lang`" df760ab0 "Don't skip past auto-height flexboxes in quirks mode." cd40220a "Fix as=fetch preload where preload is used before response arrives" 1d89521e "[LayoutNG] Force relayout when constraint spaces change." 98e7141b "Fix 2_tracks, 3_tracks wpt/webvtt tests" 68d5240e "[ChromeDriver] Set key modifiers with mouse actions" 359fd7da "[PE] Fix rendering issue with effect escaping in pre-CompositeAfterPaint" 3685447d "[WPT] Move subresource_path from generator to referrer-policy-test-case.js" 4ea68472 "Creates an ICE transport object at DTLS transport initialization." 9e55e3db "[css-flexbox] Shrink-to-fit sizing needs to take margins into account" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bugsnash@chromium.org, ericwilligers@chromium.org, meade@chromium.org, nainar@chromium.org, rjwright@chromium.org, shend@chromium.org: external/wpt/css/css-namespaces kojii@chromium.org: external/wpt/css/CSS2/text external/wpt/css/css-writing-modes NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Ib777ee8b5d9132218f144b9f8b2e11ea37352041 Reviewed-on: https://chromium-review.googlesource.com/c/1487199Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635292}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a4323c9b818b..85a76645b4e4 git log a4323c9b818b..85a76645b4e4 --date=short --no-merges --format='%ad %ae %s' 2019-02-25 rmhasan@google.com Adds new method to serially executed browser test case API Created with: gclient setdep -r src/third_party/catapult@85a76645b4e4 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:698902 TBR=sullivan@chromium.org Change-Id: I08ff76ec1f77cc0e6ec5a1e5ed64a781913fe8b8 Reviewed-on: https://chromium-review.googlesource.com/c/1487708Reviewed-by:
-
Shawn Anastasio authored
This change allows a clang toolchain to be used on ppc64 hosts. This change is part of the effort to upstream a set of patches that allow chromium to build and run on ppc64le hosts available here: https://wiki.raptorcs.com/wiki/Porting/Chromium Change-Id: I4496523f4948c675d4d1d8e529e0f4d5bbf99b8c Reviewed-on: https://chromium-review.googlesource.com/c/1480698 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#635290}
-
liberato@chromium.org authored
Since it's unclear if gpu workarounds about zero-copy video are applicable to D3D11VideoDecoder, allow ignoring them via finch. It's possible that they're only needed for DXVA. Change-Id: I2c9605668bd0f3e033102501d989d0d012960910 Reviewed-on: https://chromium-review.googlesource.com/c/1484590Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#635289}
-
Hesen Zhang authored
Implemented Rename Downloads feature in Download Home > UI in download home Bug: 924751 Change-Id: Ib9288e5c6428e4c42f7c5e5d0e2b222eb6c16997 Reviewed-on: https://chromium-review.googlesource.com/c/1468584 Commit-Queue: Hesen Zhang <hesen@google.com> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#635288}
-
Tim Song authored
BUG=926133 Change-Id: I7c6221cef4499de23bc1ff54d0eaaccf62449102 Reviewed-on: https://chromium-review.googlesource.com/c/1484510Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#635287}
-
Matt Menke authored
This CL adds a new callback passed in to ClientSocketPools when making a request, to handle HTTP auth. The callback is never invoked, nor is a non-NULL callback ever passed in, in this CL. This CL just updates all consumers to pass pass in an empty callback, and ClientSocketPoolBase to track the callback for the request. This is part of an effort to flatten the socket pools. https://docs.google.com/document/d/1g0EA4iDqaDhNXA_mq-YK3SlSX-xRkoKvZetAQqdRrxM/edit Bug: 472729 Change-Id: Icd4b0024d3fb83d3f1e452d817a0361d83c922dd Reviewed-on: https://chromium-review.googlesource.com/c/1466869Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#635286}
-
Thanh Nguyen authored
This CL relands commit 8fc6db24. Bug: 931149 Change-Id: I666531690b807b3b2a71a95fdfd2fb6ad10784eb Reviewed-on: https://chromium-review.googlesource.com/c/1484877Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Mike Wasserman authored
Add WindowMonitorAura; removes pre-target handler in OnWindowDestroying. Fixes UAF when EventMonitors are destroyed late in window destruction. (avoid EventTarget::RemovePreTargetHandler calls later in destruction) Add a simple unit test. Bug: 932922 Test: No crash when quitting Chrome with a fullscreen tab. Change-Id: I2ace83b9de127d8fa70a57021dda94561f5bd4c4 Reviewed-on: https://chromium-review.googlesource.com/c/1487353Reviewed-by:
-
kylechar authored
Post[Delayed]TaskWithTraits() takes a OnceCallback. Replace usage of base::Bind(), which produces a RepeatingCallback, with base::BindOnce() when the callback is created as a temporary inside of PostTask(). The following regex was used to find instances that could be replaced: (Post(?:Delayed)?TaskWithTraits)\((?:\n\s*)?FROM_HERE,\n?\s*(\{.*?\n?.*?\}),(?:\n)?\s*base::Bind\( Also replace any usage of base::Passed(&var) with std::move(var) for variables passed to base::BindOnce(). base::Passed() isn't needed for move-only types with OnceCallbacks. This CL was uploaded by git cl split. R=rdevlin.cronin@chromium.org Bug: 714018 Change-Id: If908711b9a4a0fe41cd04970b69bf66698ebded9 Reviewed-on: https://chromium-review.googlesource.com/c/1486591 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by: -
Xiaocheng Hu authored
Bug: 935651 Change-Id: Ie6519f30dbe0fe835c4983f9639aac3ebf28861e Tbr: dmazzoni@chromium.org NoTry: True Reviewed-on: https://chromium-review.googlesource.com/c/1487514Reviewed-by:
-
Xiaocheng Hu authored
Bug: 894651 Tbr: xiaochengh@chromium.org NoTry: True Change-Id: I9a0ebf251a5b1fdee15cafd8715af4bec9ba387f Reviewed-on: https://chromium-review.googlesource.com/c/1487878Reviewed-by:
-
Xiaocheng Hu authored
[Sheriff] Mark external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/counter-styles-3/system-additive-invalid.html as failure on Mac Bug: 935689 Tbr: xiaochengh@chromium.org NoTry: True Change-Id: Ia191b210375139d3a4e277f9a8305d65c30c7989 Reviewed-on: https://chromium-review.googlesource.com/c/1487528Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/62f4f3343374..967b98310a63 Created with: gclient setdep -r src-internal@967b98310a63 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4c148bf0e4ddb4a7befcc128ac0594ccdc1d9cef Reviewed-on: https://chromium-review.googlesource.com/c/1487710Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635279}
-
Joanmarie Diggs authored
Bug: 866554 Change-Id: Id968baed09b8b2323fff4e94b29b8dd856f80f16 Reviewed-on: https://chromium-review.googlesource.com/c/1483081Reviewed-by:
-
Toni Barzic authored
Adds new browser factory function Browser::CreateIfAllowed, which checks whether browser windows are allowed in the target context before creating a browser instance. It will return nullptr if creating a browser window is not allowed, for example when attempting to create a browser in Chrome OS sign-in profile, or system profile. The cl utilizes the new function in extensions tabs, windows and runtime API. Bug: 916859 Change-Id: I1a55025f51b83e9b512f9314ad77741ef80e1473 Reviewed-on: https://chromium-review.googlesource.com/c/1459521 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#635277}
-
Marcin Wiącek authored
DateUtils contains some useful constants, which can be used instead of functions - thx to that patch is removing one unnecessary function and replacing one TimeUnit usage. Note: it continues strategy from https://chromium-review.googlesource.com/c/chromium/src/+/1444831 Change-Id: Ic556f1df1c41fdcda2969771c3585e069b5c858d Reviewed-on: https://chromium-review.googlesource.com/c/1484307Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#635276}
-
Xiaohui Chen authored
|assistant_client::AssistantManager| instance is created on a background thread and then posted to main thread for general use. When the browser process is shutdown quickly after login due to changes to chrome:://flags or some domain policy, it is possible that an |assistant_client::AssistantManager| instance is being created on the background thread. Although we join and finish the creation during destruction, which guarantees the creation finishes, we post the instance to the main thread message queue which would outlive the |AssistantManagerServiceImpl| instance. This would potentially cause shutdown crash when the |assistant_client::AssistantManager| tries to access resources owned by the already destructed |AssistantManagerServiceImpl|. Here we move the ownership of the newly created instance from the message queue task to |AssistantManagerServiceImpl|. Bug: 930258 Test: locally build and run Change-Id: I8c6442fe6fff4da2bfe0e036878248c0e9908d05 Reviewed-on: https://chromium-review.googlesource.com/c/1485028Reviewed-by:
-
Min Qin authored
This CL uses display name as the criteria to find duplicate downloads. When download is triggered, this CL will query the java side to check if a download with the same name exists, and trigger the duplicate infobar if necessary. BUG=931021 Change-Id: I9edf3df3063c3ec0ead6d3723c23ce1b04ba0936 Reviewed-on: https://chromium-review.googlesource.com/c/1481909 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
-
