- 29 Jan, 2020 40 commits
-
-
Demetrios Papadopoulos authored
Specifically, adding #cr_define_end comments in all files that use cr.define() as required by the auto-generation tools. The BUILD.gn targets that actually make use of these special comments will be added in a follow up CL. Eventually these special comments/metadata will be removed, when the Polymer 3 version of Settings is actually checked-in (and no longer auto-generated). Bug: 1026426 Change-Id: I02ee25d71928a103d397c070854fde1a78ebd1c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999281Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#736451}
-
Chromium WPT Sync authored
Using wpt-import in Chromium df3250dd. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I900a0a0c44f84de9cb312e05f0f2269e771dbe32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028407Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736450}
-
Christopher Thompson authored
This is a reland of cb98eddd This fixes a crash caused by a call to GetStringFUTF16() with a format string that didn’t have placeholders. Original change's description: > Add legacy TLS interstitial warning > > This adds a new interstitial page for the legacy TLS warning. It > generally follows the SSL interstitial, but with different strings and > a different icon (the (i) info icon). > > The test interstitial is available at chrome://interstitials/legacy-tls > > Screenshot: https://drive.google.com/file/d/1MkWCqWKtQwo7k-ybYjKotYJDjTzRwcd0/view > > This also refactors the legacy TLS browsertest classes slightly, basing > them on SSLUITest rather than CertVerifierBrowserTest, brings in the > mock cert verifier explicitly. It also adds a SetPolicy() method to > SSLUITestBase (to complement the EnablePolicy() method, but for policies > that take base::Value types, in this case for the SSLVersionMin policy). > Overall, this makes for a slightly simpler class structure and lets us > reuse all of the infrastructure setup by SSLUITest (since > CertVerifierBrowserTest is fairly simple in comparison). > > The new cert error is introduced in https://crrev.com/c/1894616. Support > for the control site list will be added in https://crrev.com/c/1906779. > > Bug: 896013, 1039756 > Change-Id: Ic3242178239ac8c68d02fe0a2a21a52638146580 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940707 > Commit-Queue: Christopher Thompson <cthomp@chromium.org> > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736197} Bug: 896013, 1039756, 1046696 Change-Id: I35df3efb3f5e7fcc44211a9497724cb5a68d7d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027890 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#736449}
-
John Budorick authored
Also adds the sandbox_linux_unittests filter file to the bot as a follow-up to crrev.com/c/2020615. Bug: 1034001, 1045623 Change-Id: I13970aaca28fb4fd71868301d4a82748d6889fb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027896 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#736448}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/db1cab866afd..cd8060e73e83 git log db1cab866afd..cd8060e73e83 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 linxinan@chromium.org chromite: add owners for api/gen/test_platform 2020-01-28 bpastene@chromium.org cros_chrome_sdk: Remove support for optionally enabling clang. 2020-01-28 pprabhu@chromium.org config: Set quota account for synchronous bvt suite 2020-01-28 vapier@chromium.org qemu: fix race when installing binaries 2020-01-28 cjmcdonald@chromium.org Make toolchain changes directly imply a full source build 2020-01-28 mmortensen@google.com Fix goma_artifacts output proto update for stats/counterz. 2020-01-28 lamontjones@chromium.org api: call toolchain.BundleArtifacts endpoints. 2020-01-28 lamontjones@chromium.org toolchain_util: BundleChromeClangWarningsFile. 2020-01-28 lamontjones@chromium.org chroot_lib: add chroot_path method. 2020-01-28 saklein@chromium.org workon_helper: Minor cleanup. Created with: gclient setdep -r src/third_party/chromite@cd8060e73e83 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Ie2f969f8f6936e029331ff6e79e24653b95fa33b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028007Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736447}
-
Josh Nohle authored
Bug: 951969, 936273 Change-Id: I59a980ee3f7af519b8916d0831c738c1ada84f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988838 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#736446}
-
Yi Gu authored
This test started to timeout on Linux: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyfgsSBUZsYWtlInNjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAaHR0cC90ZXN0cy9tZWRpYS9hdXRvcGxheS9kb2N1bWVudC11c2VyLWFjdGl2YXRpb24tY3Jvc3Mtb3JpZ2luLWZlYXR1cmUtcG9saWN5LWhlYWRlci5odG1sDA TBR=beccahughes@chromium.org NOTRY=True Bug: 995663 Change-Id: I9a0d4bd2f63b1616b12999aaf7a500563401234f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027901Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736445}
-
Michael Thiessen authored
Native Java Unittests can now simply enable/disable features for individual tests using, for example: @NativeJavaTestFeatures.Enabled({"Feature1", "Feature2"}) or @NativeJavaTestFeatures.Disabled("Feature3") This will generate a test method body that creates a ScopedFeatureList with the specified feature overrides set. Bug: 783819 Change-Id: I6473f6b9584e3faa1c19277a6c8eb6f4cf280677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015442 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
(gone) Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#736444}
-
Steve Anton authored
Bug: 1044521 Change-Id: Ib7350579495f4774a05980c763d1fe453a4c179b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024074Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#736443}
-
Trevor Perrier authored
This reverts commit eec2c8df. Reason for revert: An exception for the zh-HK ByteOrderMarks has been added. https://chromium-review.googlesource.com/c/chromium/src/+/2026149 Original change's description: > Revert "[Android] don't map zh-hk to zh-tw in bundle builds." > > This reverts commit 43fcd55d. > > Reason for revert: > > Suspecting this change caused the compile failure at https://cr-buildbucket.appspot.com/build/8889983375245058816. > > Original change's description: > > [Android] don't map zh-hk to zh-tw in bundle builds. > > > > To give Clank language parity with Android 27 new locales are being > > added. 26 of those locales have been added in two previous CLs: > > > > - https://crrev.com/c/1941058 > > - https://crrev.com/c/1952288 > > > > zh-hk was skipped because currently resources for it are mapped to > > zh-tw. This CL skips that mapping for bundle builds where zh-hk is > > now included. zh-hk is still mapped to zh-tw in apk builds. > > > > There is an increase in size even when language splits are used in > > bundles. A bug has been created to look into this: > > - APK Bundles wastes a lot of space in resources.arsc (400kb) > > - https://crbug.com/1031645 > > > > Bug: 1034774 > > Binary-Size: Size increase is unavoidable (see above). > > Change-Id: I4edb9d5213e8dd3443522deee5395e500af34371 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970258 > > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > > Reviewed-by: (gone) Eric Stevenson <estevenson@chromium.org> > > Commit-Queue: Trevor Perrier <perrier@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#736071} > > TBR=yfriedman@chromium.org,tedchoc@chromium.org,agrieve@chromium.org,estevenson@chromium.org,perrier@chromium.org > > Change-Id: I6748ad1e997bb5e2e05d6a99a52fd3e3595253fd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1034774 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026151 > Reviewed-by: Chan Li <chanli@chromium.org> > Commit-Queue: Chan Li <chanli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736091} TBR=yfriedman@chromium.org,tedchoc@chromium.org,agrieve@chromium.org,chanli@chromium.org,estevenson@chromium.org,perrier@chromium.org Change-Id: I934feb29c7f8b032236ce2e0cc4c4c8c38de5511 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1034774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026427Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#736442}
-
Daniel Rubery authored
The Advanced Protection deep scanning feature will prompt users enrolled in the Advanced Protection program to send their files to Google for malware scanning. While the user needs to choose which files to upload, admins may be concerned about the potential sharing of data. So this CL adds a policy which can be used to prevent this prompt from appearing. Bug: 1020418 Change-Id: I1f3bf1952aa9774bd503256c943179e6fdc81cbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024081 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#736441}
-
Jérôme Lebel authored
Adding SigninCoordinator class for the new implementation of sign-in UI. Based on design: http://go/chrome-ios-signin-migration Related to: + crrev.com/c/2025353 + crrev.com/c/2027809 Bug: 971989 Change-Id: Ib9e07a05cb843a7335bb79b5cf576d7b00e91970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025547 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#736440}
-
Sam Bowen authored
This is a two-sided patch and will break downstream clank until the following is landed: https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/2473783 There are no changes to this reland. The fix for the original revert is in the other patch linked above. This is a reland of da0bf646 Original change's description: > Rename CopylessPaste to DocumentMetadata to reuse the class for other purposes > > Bug: 1044244 > Change-Id: I7af8208b8c5a25f247b09cc0cbe55d44934f1d2d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020604 > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Sam Bowen <sgbowen@google.com> > Cr-Commit-Position: refs/heads/master@{#735612} TBR=dcheng@chromium.org,haraken@chromium.org Bug: 1044244 Change-Id: I5348c86f79e39539d21956f82981a3e6d49d7009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026409Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Sam Bowen <sgbowen@google.com> Cr-Commit-Position: refs/heads/master@{#736439}
-
Mark Yacoub authored
If the device supports atomic APIs, use drmModeAtomicCommit to modeset and disable instead of drmModeSetCrtc. Abstracted Modeset and Disabled code to HDPM to handle both atomic and legacy call. Updated tests to support Connector and CRTC props. This is a reland of crrev.com/c/1715751 BUG=987274 TEST=HardwareDisplayControllerTest.CheckModesettingSetsProps, HardwareDisplayPlaneManagerLegacyTest.Modeset, HardwareDisplayPlaneManagerLegacyTest.DisableModeset, HardwareDisplayPlaneManagerAtomicTest.DisableModeset, Tested on Nautilus(Intel), Grunt(AMD) and Cave(Legacy). Change-Id: I8ac3f81a0c117f3b3489cc0168e934799f387891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028168Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Auto-Submit: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#736438}
-
David Black authored
Scroll indicator is drawn over UiElementContainerView's empty bottom border to work around issue of drawing over top of Assistant cards. Visibility of the scroll indicator view is synced to vertical scroll bar update/visibility events. Bug: b:112669597 Change-Id: Ib8ae57428bb827913957fdd92168868c181ab4d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024285Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#736437}
-
Leonard Grey authored
Bug: None Change-Id: Ia4af230ed8d5200a98eafae136eb96a0bc56fd48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028153 Commit-Queue: Leonard Grey <lgrey@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#736436}
-
Yi Gu authored
The tests started to timeout in Jan 16. A sample flaky report: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyUgsSBUZsYWtlIkdjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAaHR0cC90ZXN0cy9kZXZ0b29scy9zZWFyY2gvc2VhcmNoLWluLXNjcmlwdC5qcww TBR=yangguo@chromium.org Bug: 1046784 Change-Id: I7ee87bfc88cc22d2e9afaa4d6383cd95eaf2d7f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027895Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736435}
-
Daniel Hosseinian authored
Remove call to DumpWithoutCrashing() and replace with a histogram that counts instances of unknown PPD color models. Bug: 1035010 Change-Id: I1bbf1ec423db08f06e66de38fd27b727849b61ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026313 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#736434}
-
Devlin Cronin authored
Bug: None Change-Id: Ie5214c159e1c14c59dcbd4d4660f33bd44d4a77e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021287 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#736433}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I73b9a09913c156a2a38a573139aed7c69bcc16f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028169Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736432}
-
Jeremy Roman authored
And resolve a couple of TODOs. Bug: 1013389 Change-Id: Iae6b9625dce5ec2319cb2b099678cba11f594e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028251 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#736431}
-
John Budorick authored
Bug: 1046060 Change-Id: I7748fc85861f88ddc7496975d4a822eac9675f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023234Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#736430}
-
Michael Thiessen authored
Implements a shim over native GURL, exposing it to Java. Attempting to use GURL will block on the native library initializing and registering MainDex (though this is unlikely in practice unless you're manipulating URLs really early in startup). The Java object holds onto all necessary objects to reconstruct the native GURL without re-parsing. This is both to make the Java implementation fast for the common case, and to avoid a clunky API requiring destroy() - the native GURL is recreated on-demand. Relative performance of parse() followed by getHost() on a search result page URL: android.net.Uri: ~10.5μs java.net.URI: ~14.5μs GURLJava: ~16μs Repeated getHost() calls: android.net.Uri: ~90ns java.net.URI: ~10ns GURLJava: ~350ns Why? Android Uri only parses what you ask for, then caches that as volatile(?!), so each new thing you ask for causes it to do parsing work and increase memory usage (and lookups are weirdly slow for a cached value). Java URI parses upon creation and caches almost everything that can be asked for as a separate String (>2x memory usage of GURL). GURL only stores the uri String (spec) and indices into it, so a new String is created each time. This could be cached so that memory can be shared if many callers ask for the same GURL component. Doc: https://docs.google.com/document/d/1kDKqBaq-b6EbUm0F4ea7ARoksUcj1KUx3qxFuSXEwM4/edit Bug: 783819 Change-Id: I3e0fbf3505ef6294b6915b44a6fdbd6ca3f5494c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856622 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#736429}
-
Dominique Fauteux-Chapleau authored
This reverts commit 5bd704b2. Reason for revert: The fix is applied in crrev.com/c/2024497 Original change's description: > Revert "Update Deep Scanning upload UI text" > > This reverts commit 75458c57. > > Reason for revert: to unblock reverting https://chromium-review.googlesource.com/c/chromium/src/+/2020891 (crbug.com/1046693) > > Original change's description: > > Update Deep Scanning upload UI text > > > > Add code to use the appropriate drag-data, drag-file and paste strings > > instead of just defaulting to the upload strings. Removes the optional > > part of the access point since it's used to determine the appropriate > > string now. > > > > Bug: 999145 > > Change-Id: I115cd567f94d9c4ca7a4befdff386ba76163ae20 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016965 > > Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> > > Reviewed-by: Daniel Rubery <drubery@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#735943} > > TBR=drubery@chromium.org,domfc@chromium.org > > Change-Id: I78b6b5c3c3fe10cdd731d84233d20c31cb1a9e00 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 999145,1046693 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027547 > Reviewed-by: vitaliii <vitaliii@chromium.org> > Commit-Queue: vitaliii <vitaliii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736301} TBR=vitaliii@chromium.org,drubery@chromium.org,domfc@chromium.org Change-Id: I717f12ae775142aa6337d7aefc70c426b19d22f3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 999145, 1046693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026652Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#736428}
-
Dominique Fauteux-Chapleau authored
This reverts commit 86c4251e. Reason for revert: The fix is applied in crrev.com/c/2024497 Original change's description: > Revert "Cleanup base::Optional use in Deep Scanning dialog code" > > This reverts commit 0f668c37. > > Reason for revert: Fails Linux MSan Tests crbug.com/1046693. > > Original change's description: > > Cleanup base::Optional use in Deep Scanning dialog code > > > > 2 instances of optional can be removed from DeepScanningDialog* code to > > make it more readable: > > - The access point no longer needs to be optional since all the access > > points have been added to Chrome. A default value is still included > > in order to simplify tests calling ShowForWebContents. > > > > - The state variable in DeepScanningDialogViews is better as an enum > > than an optional bool indicanting pending/success/failure, especially > > since a timeout state is very likely in the future. > > > > Change-Id: I767db78e428a607a7cc2dfe39d1d63c0f85c30d7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020891 > > Reviewed-by: Daniel Rubery <drubery@chromium.org> > > Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#735857} > > TBR=drubery@chromium.org,domfc@chromium.org > > Change-Id: Id4814d523935f867ab8fb69942281a6fc8fcf3b0 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1046693 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026970 > Reviewed-by: vitaliii <vitaliii@chromium.org> > Commit-Queue: vitaliii <vitaliii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736302} TBR=vitaliii@chromium.org,drubery@chromium.org,domfc@chromium.org Change-Id: I9a094d5d1d3105dd5b5712b0c77e9b0d58788420 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1046693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026355Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#736427}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bf682ef3..4bf20c76 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idf1b205a19f5489f19349615979c7280c6545c0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027871Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736426}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/26b4cb3fc56c..99d6d8115b37 git log 26b4cb3fc56c..99d6d8115b37 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 minyue@webrtc.org Adding absolute capture timestamp to AudioTrackSinkInterface. Created with: gclient setdep -r src/third_party/webrtc@99d6d8115b37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I26bf20559350b612e50f5eeb3f6bcacec542dea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028014Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736425}
-
Sebastien Marchand authored
The current convention is to not send notification when the system exit memory pressure, this isn't ideal as it doesn't let stateful listeners know that they should stop their intervention. This CL was uploaded by git cl split. R=vmiura@chromium.org Change-Id: I2c4a53b537d6bfa8391fadd8def543ba525558f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017047 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#736424}
-
David Tseng authored
This change is the result of several discussions related to lazy background pages in the context of web assembly and slow load times. This approach: - keeps alive tts engines while ChromeVox is enabled - specifically for Google text-to-speech engine only at this time - reverts back to event/lazy background page behavior when ChromeVox is disabled Bug: 1044209 Change-Id: Ic4e6e36e7a0405e2546c5a8ce48e59117041a59f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001108 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#736423}
-
Manuel Rego Casasnovas authored
In r727590 there was introduced a regression regarding visual overflow of inline elements in legacy layout. The problem is that inline elements in legacy layout don't recompute the visual overflow, so we still need to mark the element for layout in that case. The fix is basically bringing back the code in LayoutObject::SetStyle() to mark inline elements for layout, including an extra condition for doing it only for legacy layout objects. BUG=1043927 TEST=ParameterizedLayoutInlineTest.VisualOverflowRecalcLegacyLayout Change-Id: I4c5dff4c75c3a9484a52f51fbd85f2b65672de1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025389Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#736422}
-
Toni Barzic authored
When animating app list to closed state, use the current target shelf y coordinate at target animation bounds. Before this cl, app list was using ideal shelf bounds, so the animation ends at the visible shelf bounds, assuming that shelf will remain in visible state, which is the case when the app list is hidden by clicking home button, but may not always be true - for example, shelf gets hidden if app list is closed using esc key. BUG=1046198 Change-Id: Idb343482432fe9315082b45caff6679177c7d94f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027172Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#736421}
-
Julian Pastarmov authored
Fixing comments on the already submitted https://chromium-review.googlesource.com/c/chromium/src/+/1952324. BUG=none Change-Id: Ic8037c6e3d8b51944ba39d2782f78a9d068c9c20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027414 Auto-Submit: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#736420}
-
Sebastien Marchand authored
Also add this to the slow report to get a better understanding of the pressure level when looking at a report. Change-Id: I73bc8804cb06f5c481b7f8bdc14c79bbcdd28d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025951Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#736419}
-
Alison Maher authored
This change adds the default color and fill forced colors for SVG elements (WindowText). Before this change, SVG fill and color would default to black in forced colors mode, making certain elements un-readable. Bug: 970285 Change-Id: I68ecb4769a502fbb1c4ceb27ba0b3d21205aeb45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026147Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#736418}
-
Maks Orlovich authored
For ComputeSiteForCookies, we care about the parent when the frame was created (parent_) rather than the root of the current tree hierarchy in FrameTreeNode land, as if our parent is being navigated, the latter will get updated to the destination, which isn't relevant here. Bug: 1013733, 1032668 Change-Id: If78b77a082812b3feee8befde7cf537607938039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023249 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#736417}
-
Anqing Zhao authored
This policy is used for desktop browsers only when cloud reporting is enabled. Now, the mapping should be extended to CrOS since the similar functionality is supported on it. Bug: 1010213 Change-Id: I78c98edbc172d5fd2ad2e9d610a1adfdb5d5ca63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027336Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Anqing Zhao <anqing@google.com> Cr-Commit-Position: refs/heads/master@{#736416}
-
Chan Li authored
This reverts commit a54e29af. Reason for revert: This change breaks ash_unittests on Linux Chromium OS ASan LSan Tests (1) builder: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/36800 Findit analysis: https://findit-for-me.appspot.com/waterfall/failure?url=https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/36800 Original change's description: > Use timeout to wait until there is no presentation callback. > > R=yigu@chromium.org > > Bug: 1043465 > Test: run 100 times and no flaky > Change-Id: I64aef46f8f61a5bde32d678a91301f9ea9304b74 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026508 > Reviewed-by: Jun Mukai <mukai@chromium.org> > Commit-Queue: Mitsuru Oshima (slow in TOK) <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736206} TBR=mukai@chromium.org,oshima@chromium.org,yigu@chromium.org Change-Id: I5294b8fcb958f02af01ab1e8bfb00358bf3b36e1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1043465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027897Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#736415}
-
Denis Kuznetsov authored
Bug: 955194 Change-Id: I1f08087a0ce9675c43a6879ed14c53790c8f06b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025548Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#736414}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/45c948791441..d960cc31b658 git log 45c948791441..d960cc31b658 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 fmalita@chromium.org [skottie] Cleanup: remove unused header 2020-01-29 robertphillips@google.com Update wacky_yuv_formats GM to demonstrate YUV resizing on the GPU Created with: gclient setdep -r src/third_party/skia@d960cc31b658 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: If35ed000890178ec5609ce393c81d060cb1f4da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028008Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736413}
-
Mohamed Heikal authored
This reverts commit 9876c905. Reason for revert: breaks official builders crbug.com/1046654 Original change's description: > [android] do not filter locales in resource packing > > This CL makes it so that all locales are used during resource_packaging > > It looks like previously resource_packaging was only called for apk > builds. But now that it is also used for bundle builds the locales > for Android bundles should be included as well. > > Before this change all language splits for the 27 + 9 new languages > recently added to Clank were about half the size as older languages in > monochrome_public_bundle.apks > > After this change the new languages and old languages are about the same > size in monochrome_public_bundle.apks. > > Example Before (af,as, az, be, bn, and bs are new languages): > > 158921 2001-01-01 00:00 splits/base-af.apk > 424765 2001-01-01 00:00 splits/base-am.apk > 432527 2001-01-01 00:00 splits/base-ar.apk > 226815 2001-01-01 00:00 splits/base-as.apk > 165763 2001-01-01 00:00 splits/base-az.apk > 203683 2001-01-01 00:00 splits/base-be.apk > 473236 2001-01-01 00:00 splits/base-bg.apk > 234710 2001-01-01 00:00 splits/base-bn.apk > 163986 2001-01-01 00:00 splits/base-bs.apk > > Example After: > > 305787 2001-01-01 00:00 splits/base-af.apk > 424765 2001-01-01 00:00 splits/base-am.apk > 432527 2001-01-01 00:00 splits/base-ar.apk > 569512 2001-01-01 00:00 splits/base-as.apk > 325961 2001-01-01 00:00 splits/base-az.apk > 468522 2001-01-01 00:00 splits/base-be.apk > 473236 2001-01-01 00:00 splits/base-bg.apk > 577862 2001-01-01 00:00 splits/base-bn.apk > 324504 2001-01-01 00:00 splits/base-bs.apk > > > > Bug: 1035665 > Change-Id: I31d3bddba38148931212e6bccb63155376b82bda > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024159 > Reviewed-by: Megan Jablonski <megjablon@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Trevor Perrier <perrier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736004} TBR=agrieve@chromium.org,megjablon@chromium.org,perrier@chromium.org Change-Id: I893b0c956826db5bf20dffa580ce8ba77181dfff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1035665, 1046654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028112Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#736412}
-