- 17 May, 2019 40 commits
-
-
Eric Roman authored
Bug: 962523 Change-Id: I7f1d20a2864470b0addb8064f6e553ea3d95435c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614697 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#661101}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/036cc9ae1244..35993b267671 git log 036cc9ae1244..35993b267671 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 fdegans@chromium.org [fuchsia] Disable build warning. Created with: gclient setdep -r src/third_party/swiftshader@35993b267671 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:921807 TBR=swiftshader-team+autoroll@google.com Change-Id: Iba107f6e2f15b0f664564b4c520748ea1f1d6adc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618066Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661100}
-
Xianzhu Wang authored
The client calls (static) GraphicsLayer::UnregisterContentsLayer() when it changes cc contents layer (sometimes deletes it), so we should never return contents_layer_ when it's unregistered. This further hardens https://chromium-review.googlesource.com/c/chromium/src/+/1617639. Bug: 962879 Change-Id: I6fade10d360ec3e8120db9cdbfa308c3d6099d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618054Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#661099}
-
Max Moroz authored
- Rename the roles into Sheriff and Marshal; - Clarify the responsibilities a little bit; - Remove the "check in on the weekend" part; - Format the markdown source. Change-Id: Ief674326ae87c835313579290255ce94e8591805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602442 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#661098}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/25331bfed596..a86225ee247d git log 25331bfed596..a86225ee247d --date=short --no-merges --format='%ad %ae %s' 2019-05-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@a86225ee247d The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: If1c46cc5fe0045271bca867ee7549949fb768655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618068Reviewed-by:
-
Eric Aleshire authored
goBack requires waitForPageToFinishLoading, so that is converted also. The wait is moved from app-side to test-side using a GREYCondition. Uses http://crrev.com/c/1578949 as a guideline. Bug: 922813 Change-Id: I4e4616f5f9bc7857e89e28df01171d3167e396c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610548 Commit-Queue: ericale <ericale@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#661096}
-
Wei-Yin Chen (陳威尹) authored
This mostly reverts commit 57639246. The "Create group" functionality has been moved to Grid Tab Switcher (GTS), so this is not used anymore. Having it left behind leads to visible artifacts in the compositor layer animations we plan to add to GTS transitions. Bug: 936038, 964406 Change-Id: I0ffa76fd90e57e2f3a9b30ca91601271f93e99ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617554Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#661095}
-
Jordy Greenblatt authored
The goal of this CL is to protect passwords saved to the Chrome browser running on CrOS by requiring a GAIA password entry within the last minute to show a saved password in settings and a fresh auth token [1] to export passwords to a .csv. The key steps for changing the password flow for CrOS were -Provide passwords-section with a authToken and bound to a password-prompt-dialog -On "show password" clicks, check if there is a valid there is a valid and <1 minute old auth token [2] -If not, prompt the user for their password and check again -If so, go back to the old flow. The new steps in the export passwords flow are almost the same except that the password prompt comes up on every request [3]. The less intuitive parts of the code come from trying to tinker as little as possible with security an UX for non CrOS users. In particular, I added and infrastructure for pausing the password flows to allow the user to enter their password and then resume the flow when the auth token is received [4] and incorporated an auth token check in a way that fits the general OS specific password safety flow [5]. I also added CrOS specific browser tests in a new file and refactored the existing password-section browser tests to share utilities with the new file. Beyond that there were some minor changes to the existing file that the change required due to the more involved Polymer event dependencies for CrOS. --- Testing: Beyond the browser tests, I manually tested on CrOS by -going through a flow of entering an incorrect password, cancelling, and then entering the correct password for all the affected elements -checking that I could freely show passwords for a minute after a successful password entry/auth token request -checking that I could not export passwords or get plaintext passwords after the respective deadlines of 5 seconds and 1 second through the standard user flow or by manually entering the requests directly into the JS console. I also tested on Linux (i.e. my workstation) and Mac (a corp loaner) to ensure that the functionality was not changed. --- [1] In practice we require it be within the last 5 seconds because it saved some work and provided comparable security. [2] The auth token does not need to be passed through the passwordsPrivate API because there is a single auth token for the machine so just checking its age ensures that the user entered their password in the last minute and provided it to the quickUnlockPrivate API. [3] Since the 5 second expiration is a proxy for immediate expiration and in practice will rarely allow for reusing a token, we can prompt the password on each attempt for a more consistent UX. [4] See AuthTokenRequestorBehavior and the 'request-auth-token-refresh' event. [5] See PasswordsPrivateDelegateImpl::OsReauthCall(). Bug: 917178 Change-Id: I8d8e988270ff627668f2022c093e558fa0409a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574684 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#661094}
-
Dana Fried authored
Bug: 961764 Change-Id: I33b888e06cd02155407f18f2a64840da911d60e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612176 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#661093}
-
Suman Kancherla authored
The metrics added are - 'XR.WebXR.ConsentFlowDuration' measures how long the consent dialog was open 'XR.WebXR.ConsentFlow.Presented' counts the number of times the consent dialog was displayed 'XR.WebXR.ConsentFlow.ConsentGranted' counts the number of times the user clicked the 'allow' button on the dialog 'XR.WebXR.ConsentFlow.ConsentNotGranted' counts the number of times the user either clicked the 'cancel' button on the dialog, or closed the dialog Bug: 962755 Change-Id: I16f9e7fc00abb7188e4ebe7a1685c15b2e94a232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614458Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Cr-Commit-Position: refs/heads/master@{#661092}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1b5fb81a01df..3a8aa31d88b1 git log 1b5fb81a01df..3a8aa31d88b1 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 enga@chromium.org Rename .inl to .inc Created with: gclient setdep -r src/third_party/dawn@3a8aa31d88b1 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel BUG=chromium:964411 TBR=cwallez@google.com Change-Id: I80c842e683c118adb960f798fd1ee1c84ae7ba0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617885Reviewed-by:
-
Doug Turner authored
For an yet unexplained reason, we must allow kern.tcsm_available AFTER kern.tcsm_enable or we are unable to set kern.tcsm_enable. Bug: 964353 Change-Id: I732b93cca4d1a6fad07ddba6d5e64c63bcda9c1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617634Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#661090}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f17fbca40861..79b19c11139f Created with: gclient setdep -r src-internal@79b19c11139f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:764900,chromium:764882,chromium:790415,chromium:790399,chromium:764883,chromium:764882,chromium:764880 TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: Ia9dd144b93a55e1b45a0dc4e4906b12b53226f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618307Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661089}
-
yilkal authored
Updated KioskNextBackButtonTest so that TestApi is recreated using the new ShelfView when a KioskNextUser logs in. Updated ApplistButtonTest to not keep a local pointer to app_list_button_. Bug: 951212 Change-Id: I72d3c3a3470ff776f63d841b39d9218b2bc00c70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618060 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#661088}
-
Xianzhu Wang authored
The type-safe version FlipForWritingMode() flips LayoutRect/LayoutPoint to PhysicalRect/PhysicalOffset or vice versa. The original FlipForWritingMode() from LayoutRect/LayoutPoint to LayoutRect/LayoutPoint is renamed to DeprecatedFlipForWritingMode(). They are still used in legacy inline layout, hit testing (will change to type-safe soon), multicol, etc. Change-Id: I8a348f2930b9a6d19b9ae57d2aac75d9c6fa995f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614253 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#661087}
-
Kyle Milka authored
This was broken for the current version of the picker in https://crrev.com/c/1603206. Bug: None Change-Id: I90474ff2fa6c0a64a1f886d53cdb92d6522fbc16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618266 Commit-Queue: Kyle Milka <kmilka@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Auto-Submit: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#661086}
-
John Budorick authored
Bug: 816629 Change-Id: Icbe9e55a4560d51ad9c384a66d0c7e2c7c730549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606599 Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#661085}
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: I71906e6b47518046e9e7c1b812ff0faaa016cfdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618023 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#661084}
-
Lucas Tenório authored
To power the tests we need to setup an HTTP server to handle access token requests and supervision pages. It's expected that the Supervision server will return a custom HTTP header with an specific value when the user is eligible to see the flow. We test cases where the server doesn't send the header as well as when the header doesn't contain the values that we want. Bug: 958995 Change-Id: Ib8017678951ba9da1ae9b7b5b801c755ee2f7533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611038Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Cr-Commit-Position: refs/heads/master@{#661083}
-
Wez authored
Previously NetworkChangeNotifierFuchsia would start in the UNKNOWN state and dispatch an asynchronous request for interface and route information. This could result in the network state not becoming available until after requests had been started, causing them to be cancelled with ERR_NETWORK_CHANGED. NetworkChangeNotifierFuchsiaTests now run the FakeNetstack on a separate thread, requiring explicit synchronization to ensure that requests are processed before expectations are checked. The tests are also migrated to verify OnIPAddressChanged() and OnConnectionTypeChanged() rather than the derived OnNetworkChanged() signal. Bug: 964161, b/130731732 Change-Id: Ibb59f676468e66190ccc5b88af8e492a5102f8db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616324 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#661082}
-
Jonathan Metzman authored
Remove unrar_fuzzer since it depends on exceptions. This reverts commit d7eec28b. This reverts commit 2cd234bc. Bug: 963444 Change-Id: I604922a4255a4a1313a26db0ae76e1b5266569de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618045 Auto-Submit: Jonathan Metzman <metzman@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#661081}
-
Tina Wang authored
Add target device id and name when create a new entry on desktop. Bug: 946804 Change-Id: I1b5dab7f7edbdb27779aec8756fb785508548a59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617124Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#661080}
-
David Dorwin authored
WebXR code is now returning this value. This simply documents that. Enum values do not support extended attributes. Bug: 944880 Change-Id: Icacd08407b1ce578443d9e4a6da708abb45fc9c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601416Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#661079}
-
Avery Musbach authored
OverviewWindowDragController::UpdateDragIndicatorsAndOverviewGrid() contains code that bails out if the window cannot be snapped in split view. So then OverviewSession::RearrangeDuringDrag() does not get called, and it has responsibility for updating the drop target background visibility, hence Issue 964469. Also, OverviewSession::SetSplitViewDragIndicatorsIndicatorState() does not get called, and it has responsibility for reparenting the split view drag indicators widget so that it appears on the correct display, meaning that the present CL is a step toward fixing Issue 961171, although the present CL certainly does not completely fix Issue 961171. Test: manual Bug: 961171, 964469 Change-Id: I95704caacfb315161c9ecf34e3ad55b1c40a8c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617272Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#661078}
-
Matthew Mourgos authored
Bug: 889637 Change-Id: I75e48b670bc237761f0bc9a786dac1fcc1b2b529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617558Reviewed-by:
-
Ian Wells authored
Disables offline indicator, prefetching, MHTML intent handling, offline page cache, the net error page download button, offline pages cached data remover, auto-fetch, and intercepting HTML downloads. Bug: 955642, 959321 Change-Id: Ia7fc981cd18e70334d2951cf3794bc0dc96b6210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600356 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Edward Jung (EMEA) <edwardjung@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#661076}
-
Bruno Santos authored
Adding one histogram to keep track of bridge methods usage, and others for specific actions and their results. Bug: 963993 Change-Id: I200a604516937c87e1af7c9b96fe275e92a011ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615449Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Bruno Santos <brunoad@chromium.org> Cr-Commit-Position: refs/heads/master@{#661075}
-
Xianzhu Wang authored
This ensures that the video GraphicsLayer get its cc layer refreshed during compositing update, to avoid dangling pointer of cc layer in the GraphicsLayer. Bug: 962879 Change-Id: Ib0612990fd933fb6ce6d30879c7618158baffc75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617639Reviewed-by:
-
Scott Violet authored
And additionally some code in ui/aura that was entangled with the window-service. BUG=964460 TEST=covered by tests Change-Id: I69ab8940a50a24e6c49cf6eb5680069acf11d6ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618142Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#661073}
-
Tina Wang authored
Omnibox pop-up bubble appears when the user click on the omnibox share icon. It lists all valid devices that a user can share tab to. In this change I introduced a new class ShareBubbleDeviceButton to implement each device button. Bug: 960595, 950388 Change-Id: I947175db88e4bc5ce657eb5108854107728b1eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600462Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#661072}
-
Esmael El-Moslimany authored
Bug: 963845 Change-Id: I7585fb60aa7582e39af0beb38651a4fcefb48623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613750Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#661071}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/efb9f14aba03..7bf160e6d5c4 git log efb9f14aba03..7bf160e6d5c4 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 reed@google.com Revert "Revert "Experimental SkVideoDecoder, to wrap calls to ffmpeg"" 2019-05-17 mtklein@google.com Reland "byte align everything in SkSLInterpreter" 2019-05-17 michaelludwig@google.com Revert "Experimental SkVideoDecoder, to wrap calls to ffmpeg" 2019-05-17 mtklein@google.com disassemble on unit test failure 2019-05-17 rmistry@google.com [Recreate SKPs bot] Fix failing web pages 2019-05-17 mtklein@google.com remove stray kNop Created with: gclient setdep -r src/third_party/skia@7bf160e6d5c4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: I251b21d8aa4d9992c0349e12c60cf2ac528da607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617314Reviewed-by:
-
Adam Langley authored
Change the layout of the account selection dialog in response to feedback from UI. See https://screenshot.googleplex.com/d7L6RQC2kEi for the source of the padding numbers. Also, based on UI feedback, remove the placeholder avatar icons since we do not currently have plans to show any non-placeholder icons. Change-Id: I36f58d4db2a0036a4fb6c38aa11036b6f945b014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617098 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#661069}
-
Robert Sesek authored
Tbr: avi@chromium.org Bug: 964486, 958976 Change-Id: Ib178de301ee4b4c4b381135a7a5c8a0faadc08a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618172 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#661068}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fbda592d. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" 64cbdf7a "Replace originOffset public member with getOffsetReferenceSpace method" e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I9e3ac25271c301a0dd6e154e5eaea8eef1dcebf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618183Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661067}
-
Scott Violet authored
It's still used by test_ws (and tests), but no longer used by ash/chrome. BUG=964460 TEST=covered by tests Change-Id: Iaeb601bae144b775b710b8e80ff2a8ed9bf5e1ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618063Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/662a859f9bb3..c9cf972dcae3 git log 662a859f9bb3..c9cf972dcae3 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 sadrul@chromium.org rendering: Fix handling unsual traces. Created with: gclient setdep -r src/third_party/catapult@c9cf972dcae3 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:964187 TBR=simonhatch@google.com Change-Id: I77bb88a16f90d7758182941f10c41f4d5cd8468f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617890Reviewed-by:
-
Jun Cai authored
This CL removes the unnecessary include file in bluetooth_scanning_prompt_controller.cc Bug: 953075 Change-Id: Ie1fb4efdeaced43308aed0782775ee295c6b48db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614708Reviewed-by:
-
Henrique Grandinetti authored
This widget is being create to facilitate the usage of the Parent Access views in WebUI pages. With the widget it is possible to instantiate the view without a pre-existing view hierarchy. We will start using this in a follow up cl. Bug: 921145, 921142 Change-Id: If57a14aac63a45c0da46766ce191ef392c322aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610818Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#661063}
-
Henrique Nakashima authored
This CL creates the following new metrics: - Android.BackgroundTaskScheduler.TaskLoadedNative.ReducedMode - Android.BackgroundTaskScheduler.TaskLoadedNative.FullBrowser They represent Android.BackgroundTaskScheduler.TaskLoadedNative broken down into two cases: loading Reduced Mode and loading Full Browser. These histograms will inform whether the behavior is in line with our expectations for each task type. Bug: 962577 Change-Id: Ic58b5b0ef45713377bc53a559c93c0ac65b86507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611656 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#661062}
-
