- 16 May, 2018 40 commits
-
-
Majid Valipour authored
The last two values should be optional according to the specification [1]. Added two new factory methods to allow this. To do this cleanly switched WorkletAnimation to have Member<AnimationTimeline> instead of holding onto a DocumentTimelineOrScrollTimeline. [1] https://wicg.github.io/animation-worklet/#creating-worklet-animation TEST: virtual/threaded/fast/animationworklet/worklet-animation-creation.html Bug: 840383 Change-Id: Ida5aa077fbf19b4918652c02e92f40435db4fbb4 Reviewed-on: https://chromium-review.googlesource.com/1047691 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#559240}
-
Esmael El-Moslimany authored
Bug: 832179 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7db70455f9e9a6f72840b51ba8d9f89dab38d406 Reviewed-on: https://chromium-review.googlesource.com/1060472 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#559239}
-
Koji Ishii authored
Following bot results are included. 5481 5487 5495 5503 5510 5512 5515 5519 5521 5530 6 lines were removed and 1 lines were deflaked by consecutive results since 5415. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I8425fc95505fb852cbdcce272cae87a4dfc3114e Reviewed-on: https://chromium-review.googlesource.com/1059534 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#559238}
-
Takumi Fujimoto authored
Reorder the methods in .cc files to match the order in .h files. No functional changes. Change-Id: Ie798b6ee82d7fbd6913fe58b01bb9a177aba9d12 Reviewed-on: https://chromium-review.googlesource.com/1058603Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#559237}
-
Vasilii Sukhanov authored
The CL is created in response to https://chromium-review.googlesource.com/c/chromium/src/+/1057235 SubmissionIndicatorEvent is already recorded via UMA. It indicates the event that made the password manager believe that there was a submission. The UKM is to be recorded only when a password is saved. It means that the submission detectioln was probably correct. Bug: 842643 Change-Id: Ic381ee93de7459d7d942a9ee1b27d43e39095fc7 Reviewed-on: https://chromium-review.googlesource.com/1060034Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#559236}
-
Scott Chen authored
Bug: 843334 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0e087221f922f9abf2327bd10defb19b671dfb29 Reviewed-on: https://chromium-review.googlesource.com/1059867Reviewed-by:
-
Xiaohan Wang authored
Even though a new |cdm_context| is passed in re-initialization, the current MediaCodecVideoDecoder (MCVD) code assumes SetCdm() only happens in the first initialization. Instead of trying to fix MCVD to support setting CDM on a later config change, we'll only allow CDM setting in the initial initialization. More precisely: - SetCdm() is only triggered in initial initialization, if |cdm_context| is non-null, even if the initial config is clear. - In a re-initialization, if the config is encrypted, and we don't have a MediaCrypto already, we'll simply fail, even if a non-null |cdm_context| is passed in. For the reference, "Support of switching [between clear and encrypted] when MediaKeys is set after the playback starts, [or ...], is a quality of implementation issue" [1]. We may apply this to our media pipeline and all decoders to simplify our code. The cost for a JS player to setMediaKeys() before playback starts is really minimal (no need to even start license exchange). There are some other changes in this CL: - Fix AVDA so that if MediaCrytoContext is not available but the stream, is clear, we'll not try to initialize CDM. - Misc logging fixes based on media logging guidance [2]. [1] https://github.com/w3c/encrypted-media/pull/374/files [2] https://chromium.googlesource.com/chromium/src/+/master/media/README.md#logging Bug: 840586 Test: Manually tested switching from clear to encrypted H264. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I584a21dc992ae8bf13794b9310cb2a549e73bade Reviewed-on: https://chromium-review.googlesource.com/1056490Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#559234}
-
Mustafa Çamurcu authored
Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1048043. Also removes OSMesa implementation on Windows platform. Also removes CreateNativeViewGLSurfaceEGL. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie7bdcfc5fbe24a24df5eb6416bb6062812a7cc1f Reviewed-on: https://chromium-review.googlesource.com/1055680 Commit-Queue: Mustafa Çamurcu <camurcu@google.com> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#559233}
-
khmel@google.com authored
We switched to new unified (Android Play Store and ARC++ OptIn UI) Play Store id year ago. Now it is time to clean up conversion code. Test: Manually, no problem observed. Positions are preserved. Bug: 722675 Change-Id: Ief70ea26b6ec1b446c72fed63ffec8edf56bb956 Reviewed-on: https://chromium-review.googlesource.com/1062218Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#559232}
-
Nico Weber authored
Remove all unreferenced bots this finds, and even a whole unused waterfall. The testing/buildbot presubmit doesn't run on infra/config/global/luci-milo.cfg changes, so it will instead fire on the first testing/buildbot change after removing a bot, but that seems better than not having this check. Bug: 843511 Change-Id: I8319329d01217cb5c4129c523f79ebd81732d8d9 Reviewed-on: https://chromium-review.googlesource.com/1061597 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#559231}
-
Fabrice de Gans-Riberi authored
This cleans up multi-platform code paths selection and prepares for the removal of OS_POSIX for the Fuchsia build. Bug: 836416 Change-Id: I3a8e6393d0a9981aa890fb6d8c302ed8d2bdd69d Reviewed-on: https://chromium-review.googlesource.com/1031099 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#559230}
-
Ryan Hansberry authored
This object will replace the direct usage of the RemoteDevice in future CLs. It serves as a reference to a RemoteDevice for clients to pass around amongst themselves, while providing the guarantee that the RemoteDevice object is not copied (it's important that its BeaconSeeds are not copied because of their size), and has an explicit lifetime (which will be tied to lifetime of the RemoteDeviceCache, introduced in a future CL). Bug: 824568, 752273 Change-Id: Ic2c0f15d5edf893e5c1d9e01c91a95f3e6894340 Reviewed-on: https://chromium-review.googlesource.com/1060090 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#559229}
-
Jacob Dufault authored
Also extend fake_cryptohome_client to support multiple keys, checking keys, and removing keys. The implementation is still not entirely correct, but good enough for testing PIN. Bug: 826773 Change-Id: I3f789c87095b663ca3ab6fb8becae5e924f02a5a Reviewed-on: https://chromium-review.googlesource.com/1054247Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#559228}
-
chrome://snippets-internalsBrandon Wylie authored
Create/implement a mojo interface for snippets-internals. Bug: 830931 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I48978cab1c26e88d588f6f56e6cae80cbe13826b Reviewed-on: https://chromium-review.googlesource.com/1033807 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#559227}
-
Andrew Grieve authored
They are both close to the dex limit. Change-Id: Ie5041bca4b4fc3cc56f97351455fa3db29500773 Reviewed-on: https://chromium-review.googlesource.com/1061624Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#559226}
-
Mustafa Çamurcu authored
A small appendix to https://chromium-review.googlesource.com/c/chromium/src/+/1011109 Change-Id: I7247b274fc2083a743437d9cb5aeec488237cba3 Reviewed-on: https://chromium-review.googlesource.com/1062213Reviewed-by:
-
David Trainor authored
This adds the complete MVC structure for a generic horizontal list of chip views for filter selection. This will be first used by the new Download Home UI. BUG=839489 Screenshot of widget placed in UI: https://drive.google.com/open?id=1Em7em1jg-GnEdyoGLwHUezfgryuJ-cja Change-Id: I6a7f8a29280c5aeaf01c7be86c15f3fb64ba0288 Reviewed-on: https://chromium-review.googlesource.com/1042813Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#559224}
-
Victor Costan authored
https://chromium.googlesource.com/external/leveldb.git/+log/d177a0263cce..e9098a1311a1 $ git log d177a0263..e9098a131 --date=short --no-merges --format='%ad %ae %s' 2018-04-19 costan Cleanup SnapshotImpl. 2018-03-10 costan Add YouCompleteMe configuration. 2018-04-23 costan Add move constructor to Status. Created with: roll-dep src/third_party/leveldatabase/src Change-Id: I9aad751c72ea10d81d06ca25ae98e1a6b0f095b4 Reviewed-on: https://chromium-review.googlesource.com/1033586Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#559223}
-
Steve Kobes authored
Bug: 823365 Change-Id: Iec2e356bc185a0bc24abffd17586cafad1bb17ef Reviewed-on: https://chromium-review.googlesource.com/1062126Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#559222}
-
David Jacobo authored
IntentPickerBubbleView is not saving the user's preference when they decide to "Stay in Chrome" + "Remember my choice". This is a regression that appeared in M67. This CL specials case AppType::INVALID to handle saving user's preference, previously proposed to add a new AppType::NATIVE_CHROME but that sounds wrong given this enum lists non-cros app sources. Besides that we need to make sure that the preference is communicated to ARC via AddPreferredPackage and honored within ArcNavigationThrottle, this can be achieved by adding a new enum PreferredPlatform that will help DidLaunchPreferredArcApp to be more explicit. Bug: 841971 Test: Build. Change-Id: I383a926ae613ffe48f4dcd3a478ac124aefe4947 Reviewed-on: https://chromium-review.googlesource.com/1054584 Commit-Queue: David Jacobo <djacobo@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#559221}
-
Aaron Leventhal authored
Bug: 843355 Change-Id: I837d0c38e7ab986a92e256d24703fc2ba088331d Reviewed-on: https://chromium-review.googlesource.com/1060266 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#559220}
-
Boris Sazonov authored
This CL reimplements how SigninFragmentBase selects accounts after creation or when a new account is added. Also, account name is no longer ignored in forced sign-in flows (condition that checks mPreselectedAccount in updateAccounts has been overwriting account name requested by the sign-in arguments). mIsDefaultAccountSelected flag is now always computed by updateAccounts, so the corresponding parameter has been removed from createArgumentsForForcedSigninFlow. Bug: 814728 Change-Id: I82b6a1520d0e30757058bb7ff226b9be1550f909 Reviewed-on: https://chromium-review.googlesource.com/1062265Reviewed-by:
-
Tommy Steimel authored
This CL prevents video tags from acting as audio tags when the controls are not enabled. This fixes a bug where video tags with only audio were showing the audio controls background despite the controls being hidden. Bug: 843101 Change-Id: Ic7bb98b198a6ec7c497d233d40d673d7cfa7e44e Reviewed-on: https://chromium-review.googlesource.com/1062225Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#559218}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I98e91beb09d8e76fe0fd2337f3a2e52c4e6a16d9 Reviewed-on: https://chromium-review.googlesource.com/1062332 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559217}
-
Theresa authored
BUG=843585 Change-Id: I995039a1173771c91acc5dd04a60d6e1499ea9b2 Reviewed-on: https://chromium-review.googlesource.com/1062148Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#559216}
-
David Tseng authored
- add a contextmenu event capturer which prevents the context menu from showing up via right click or key shortcut. This appears to have ben the primary motivation behind the original patch. However, it disables critical ChromeVox functionality in places where it is most important (e.g. OOBE). - fix a small type error (not cuaght by Closure). |evt.docUrl should be evt.target.docUrl). Bug: 699760 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4f47b298daad449d5d92b176c6e805201db94153 Reviewed-on: https://chromium-review.googlesource.com/1060381 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/510e9e399b3d..d6b41a27678f $ git log 510e9e399..d6b41a276 --date=short --no-merges --format='%ad %ae %s' 2018-05-16 skcms-skia-autoroll Roll skia/third_party/skcms ce2fabc..e040063 (1 commits) 2018-05-15 benjaminwagner Add MacBookPro11,5 jobs. 2018-05-16 rmistry Fix capitalization of "twitter" in RecreateSKPs bot 2018-05-15 rmistry Run RecreateSKPs bot on SkiaCT pool which has more disk space 2018-05-16 reed check for too-big rects, as we do for paths 2018-05-16 borenet [recipes] Normalize SwiftShader build dir 2018-05-15 rmistry Use Chromium ToT instead of lkcr Created with: roll-dep src/third_party/skia BUG=chromium:807743 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: Ifc36f79f4df2d258f9c286e992f3789fbb16f031 Reviewed-on: https://chromium-review.googlesource.com/1062019 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559214}
-
Ria Jiang authored
Bug: 804888 Change-Id: I9a4783a4dd29150e2dbf13c4a3ca43eea8b1b510 Reviewed-on: https://chromium-review.googlesource.com/1053907 Commit-Queue: Ria Jiang <riajiang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
-
Jan Wilken Doerrie authored
This change provides an implementation of Windows::Foundation's ITypedEventHandlder. It serves as a thin wrapper around a base::RepeatingCallback of the appropriate signature. Bug: 821766 Change-Id: Ib940ebc5a4d90e5304be2c08839efbc020011180 Reviewed-on: https://chromium-review.googlesource.com/1060054 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#559212}
-
Sahel Sharify authored
This cl adds tracing to answer the following questions to be able to further narrow down the root cause of crbug.com/797708 -When did the last call to SetCurrentlyScrollingNode happen? (other than on PushPropertyTrees after each commit) -Is animation tick needed? (due to an ongoing animation) -Whether the animation_host notifies the compositor about animation end or not? -When does the CurrentlyScrollingNode get cleared? Bug: 797708 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I70f2295905798e430ce080c26f6924617504491b Reviewed-on: https://chromium-review.googlesource.com/1060302 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#559211}
-
rbpotter authored
Add a timeout to the select sections, so that the preview does not immediately begin generating and freeze the dropdown when the value is changed. Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If217c25420815f56a7c37adde7e97f86bcc99fa3 Reviewed-on: https://chromium-review.googlesource.com/1056216 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Sigurdur Asgeirsson authored
The old-style CPUUsage attributes are supported by transforming the batched cumulatives in the System CU. Bug: 755840 Change-Id: I3e5d3d66223070a90ad35a835a210db0bb257809 Reviewed-on: https://chromium-review.googlesource.com/1060127 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#559209}
-
Dominic Mazzoni authored
Bug: None Change-Id: Ic63e1619729b79dc5c6010fed3223895c72c5999 Reviewed-on: https://chromium-review.googlesource.com/679446 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#559208}
-
Ken Rockot authored
Changes the SharedMemoryRegion types in mojo_base mojom to use a handle<shared_buffer> as their internal representation. This simplifies the traits and makes these region types usable in Java and JS. Bug: 826213 Change-Id: Id515f61f34b85c655b70d45d53302e873547a83a Reviewed-on: https://chromium-review.googlesource.com/1059008 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
-
https://pdfium.googlesource.com/pdfium.git/+log/99a046acd2d1..67268cd0efa2 $ git log 99a046acd..67268cd0e --date=short --no-merges --format='%ad %ae %s' 2018-05-16 dsinclair Cleanup CPDF_ContentParser 2018-05-16 tsepez Use pdfium::span<> in CPDF_Encryptor 2018-05-16 dsinclair Remove CFX_BidiLine 2018-05-16 dsinclair Convert Formcalc ToJavascript to a pointer WideTextBuf Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I62d1fbb948e1971ead399113ac157004ca96a473 Reviewed-on: https://chromium-review.googlesource.com/1062024Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559206}
-
Steve Kobes authored
Bug: 823365 Change-Id: I34bd09b180ed8c7403217d0931cf2e765dc951d8 Reviewed-on: https://chromium-review.googlesource.com/1062288Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#559205}
-
Xiaohui Chen authored
R=xiyuan Bug: None Change-Id: I9a0b6decf9e2eae5d58ef74e5f482854592f054e Reviewed-on: https://chromium-review.googlesource.com/1062022Reviewed-by:
-
Dominic Mazzoni authored
Bug: 841218 TBR=michaelpg@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iaea99a1a18c1eea7d1480b68b4a1aa71448d09d1 Reviewed-on: https://chromium-review.googlesource.com/1050498 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#559203}
-
Jeffrey Kardatzke authored
Bug: 832508 Test: Verified key generation by concierge from Chrome call Change-Id: Ie031d59ab95da3f5394c9621413a5a48066619a5 Reviewed-on: https://chromium-review.googlesource.com/1053273Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#559202}
-
Devlin Cronin authored
Correct a bug where an extension would be improperly disabled for a privilege increase when it went from a more powerful permission to a less powerful one, if the permission messages were different. Previously, privilege escalation code would look check if there were any warning strings in the new set of permissions that were not in the old set. This failed, because a new warning (not contained in the previous set) might be less powerful. Instead, compare whether *adding* the new permissions to the already-granted permissions results in any new (or different) warnings. Consider it a permissions increase only if there is a difference. Conceptually, this is more accurate, since when an extension is updated, new permissions are added to the list of granted permissions (and any already-granted permissions are not revoked). Update the IsPrivilegeIncrease() arguments to make this slightly more clear by replacing "old_permissions" and "new_permissions" with "granted_permissions" and "requested_permissions", respectively. Add a regression test for the same. TBR=slan@chromium.org Bug: 841938 Change-Id: I41542c6813c1f4a2f0318609bd75b838eef00cb5 Reviewed-on: https://chromium-review.googlesource.com/1054607 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#559201}
-
