- 16 Oct, 2018 40 commits
- 
- 
Sylvain Defresne authoredTestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/apps/platform_apps/api/easy_unlock_private. This CL was uploaded by git cl split. R=jhawkins@chromium.org Bug: 809610 Change-Id: I491e41bd7735ed3a940594eb11f88542dcc0e3e5 Reviewed-on: https://chromium-review.googlesource.com/c/1258906Reviewed-by: James Hawkins <jhawkins@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#600025} 
- 
Jan Wilken Doerrie authoredThis change is a follow-up to r599728 that renamed index to id in passwords_private.idl. That change missed to update password_manager_proxy.js, which is fixed by this change. Bug: 892260, 895785 Change-Id: Id1ae5e6e46f8dd66c51bb01988b537ec99a1975c Reviewed-on: https://chromium-review.googlesource.com/c/1283129Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#600024} 
- 
Scott Violet authoredThe trace event macro in LayerTreeHostImpl::DidPresentCompositorFrame() moves to ui::Compositor::DidPresentCompositorFrame(), and Compositor/WindowTreeHost get the ability to provide an additional value that is then passed to the macro. This value will be later used to identify where the frame came from. BUG=883894 TEST=none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1341c39029c54228964e433de5aafa1c89099e0b Reviewed-on: https://chromium-review.googlesource.com/c/1282039Reviewed-by: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#600023} 
- 
Antonio Gomes authoredMigrate components/data_reduction_proxy/core/browser/secure_proxy_checker.cc to using SimpleURLLoader URLFetcher will stop working with advent of Network Service, and SimpleURLLoader is the replacement API for most clients. This CL migrates DRP's SecureProxyChecker and the respective unittests away from URLFetcher. Note that according to tbansal@, using a separate URL request context that disables SPDY/QUIC is not be needed anymore. Another requirement of DRP's SecureProxyChecker is that the use of any proxies is also disabled. For this, the load flag LOAD_BYPASS_PROXY should be enough. This means that the customized class BasicHTTPURLRequestContextGetter is not used anymore, and will be removed in a follow up pass. BUG=879783 Change-Id: I5f62007c284b35f9364caec37984cbf63e813720 Reviewed-on: https://chromium-review.googlesource.com/c/1281643Reviewed-by: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#600022} 
- 
David Trainor authoredUpdate the chip colors/styles to be the snowflake approved styles. This currently includes changing the background color, the text color and the stroke color for chip states. This patch also updates the padding for the chip list in downloads home v2 to match spec. BUG=893915 Change-Id: I7f298542cbe630f6d6b2f02f104b4b5f71f0ba85 Reviewed-on: https://chromium-review.googlesource.com/c/1278987 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by: Becky Zhou <huayinz@chromium.org> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#600021} 
- 
Chromium WPT Sync authoredUsing wpt-import in Chromium 65bc0fea. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26303 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I43f32aca0c86a1959d55b7231b37b8033753e9a6 Reviewed-on: https://chromium-review.googlesource.com/c/1283431 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#600020} 
- 
Stephen Chenney authoredThis reverts commit 36b96a42. Reason for revert: The change blew up the UMA metrics because apparently multiple lifecycle updates occur within on BeginMainFrame execution. Will reland once the problem issue is resolved, or in a different form. Original change's description: > Delay UMA submission until end of lifecycle > > We were submitting UMA every time we recorded a update time measurement, > but some metric, particularly ForcedStyleAndLayout, may run multiple > times per frame. In such cases we want the per lifecycle time, to make > it comparable to UKM data and to avoid considering lots of small updates > to be less bad than one big update. > > R=vmpstr@chromium.org > BUG=869966 > > Only report UMA once per lifecycle update > > Change-Id: If4eebd782b4d109b18a608ece2a351226bb74732 > Reviewed-on: https://chromium-review.googlesource.com/c/1277549 > Commit-Queue: Stephen Chenney <schenney@chromium.org> > Reviewed-by: vmpstr <vmpstr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599332} TBR=vmpstr@chromium.org,schenney@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 869966 Change-Id: I12c182fd48f4807af61dbb9a77d097fb665216ed Reviewed-on: https://chromium-review.googlesource.com/c/1283550Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#600019} 
- 
Steve Anton authoredBug: 874296 Change-Id: I8c0d22bf4d688accf30ea1fef0109723c319234b Reviewed-on: https://chromium-review.googlesource.com/c/1278385Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#600018} 
- 
Vadym Doroshenko authoredThe new form parsing for saving requires the new parsing for filling is available. This CL enforces it. Bug: 831123 Change-Id: I9b2463f5e80ef51a267325dfdb3b576f244d15e5 Reviewed-on: https://chromium-review.googlesource.com/c/1282952Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#600017} 
- 
Charlie Harrison authoredThe popup_blocker_tab_helper is designed to manage blocked popups, which backs the UI on desktop. Currently it also contains logic for _which_ popups should be blocked. This CL separates these two functions. The tab helper continues to manage the list of blocked popups, but the policy decisions are moved to flat functions in a new file: popup_blocker.{cc,h}. Additionally, the tab helper stops maintaining ownership of the safe browsing triggered popup blocker (it still creates it though). The safe browsing triggered blocker is changed to be a WebContentsUserData. Bug: 895555 Change-Id: Ib62d2e2b3e7f80fc8bf9f78158ba5e6106ab0f56 Reviewed-on: https://chromium-review.googlesource.com/c/1281725Reviewed-by:Avi Drissman <avi@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#600016} 
- 
Jordan Demeulenaere authoredScreenshot: https://screenshot.googleplex.com/chZ1byvKBqa.png Bug: 806868 Change-Id: Ib7714b1b554d030c461614bcd51cc30156cac594 Reviewed-on: https://chromium-review.googlesource.com/c/1278808Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Ganggui Tang <gogerald@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#600015} 
- 
Dave Tapuska authoredDon't use an index it isn't needed. BUG=879657 Change-Id: I798ee0f1f472515536ffd7bcbb6d4e7b37dcfbfe Reviewed-on: https://chromium-review.googlesource.com/c/1283258Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#600014} 
- 
Dave Tapuska authoredUse appropriate types for handling ArrayBuffer BUG=879657 Change-Id: I0a46fcd98837a041c76d7b68defc06fc786b024b Reviewed-on: https://chromium-review.googlesource.com/c/1281689Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#600013} 
- 
Xida Chen authoredThis CL adds a new PaintWorkletInput structure which includes some necessary information that is needed for PaintWorklet to paint. Bug: 884698 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic6f4960c383191c33e1bbfbc18a1d3f7826b3ef2 Reviewed-on: https://chromium-review.googlesource.com/c/1256371Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#600012} 
- 
John Budorick authoredBug: 878082 Change-Id: Iaa92ae14c3d64b8cfee0628080c7a4377397741e Reviewed-on: https://chromium-review.googlesource.com/c/1282217Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#600011} 
- 
Tarun Bansal authoredIn network quality estimator (NQE), replace all occurences of thread checker by sequence checker. This CL does not introduce any functionality changes. This CL has been factored out of a larger CL that hooks up NQE with the SPDY session class, and is needed to prevent crashes in some of the tests. Change-Id: I95eef8a8cc593812889ece20b5fb346df94c1608 Bug: 823322 Reviewed-on: https://chromium-review.googlesource.com/c/1282722Reviewed-by: Doug Arnett <dougarnett@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#600010} 
- 
chromium-internal-autoroll authoredhttps://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2129101d5e9b..55fbadac66fe Created with: gclient setdep -r src-internal@55fbadac66fe The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I13f1995574e35b129f3e7aa91c1a31f2a5abd443 Reviewed-on: https://chromium-review.googlesource.com/c/1283509Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600009} 
- 
Leonard Grey authoredBug: 850098, 893598 Change-Id: I0ec85e12ae0714974e4d8122914afe330ac0fe93 Reviewed-on: https://chromium-review.googlesource.com/c/1240172Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#600008} 
- 
Roger Tawa authoredFix up the tests so that they run correctly with base::LaunchUnitTests(). Add the unit test exe to the buildbot configs. The original CL was reverted by: https://chromium-review.googlesource.com/c/chromium/src/+/1281880 patchset 1 of this CL contains the unmodified change that originally broken the build. Further patchset contain the corrections. Bug: 895819 Change-Id: Idad19d89192df4fdf11dc8def75709322bfd9c31 Reviewed-on: https://chromium-review.googlesource.com/c/1283255Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Owen Min <zmin@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#600007} 
- 
David Bertoni authoredBug: 805600 Change-Id: I6fb4f40c4095030edca03d6389164edaf16573d8 Reviewed-on: https://chromium-review.googlesource.com/c/1279065 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#600006} 
- 
Scott Violet authoredPointerEvents are never generated by the system, so this code is never reached. PointerEvent is going to be removed shortly. BUG=895619 TEST=covered by tests Change-Id: Ie8f65ed28d1f00a2f27093acab242a5d679944a1 Reviewed-on: https://chromium-review.googlesource.com/c/1282206Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#600005} 
- 
Ian Clelland authoredReport all feature policy violations to the inspector console. This log message is generated at the same time that a report would be sent to the ReportingAPI. By default, a generic message is logged, but the methods will accept a ConsoleMessage object which will be used in its place if the FP check determines that use of the feature is not allowed. Bug: 661280 Change-Id: Icf2e89e3e6e582480b809b64edfa5832a836ebac Reviewed-on: https://chromium-review.googlesource.com/c/1257545 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#600004} 
- 
Jdragon authoredThis patch means cleaning up old pref that have passed over year+. A follow up to that CL. (https://chromium-review.googlesource.com/c/chromium/src/+/1264343) Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ib1949419b5b2df9b6906d5f5b7d100f5d5a7046c Reviewed-on: https://chromium-review.googlesource.com/c/1278455Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Cr-Commit-Position: refs/heads/master@{#600003} 
- 
Nico Weber authoredNo longer needed after https://chromium-review.googlesource.com/c/chromium/src/+/1267596/ Bug: none Change-Id: I2caabdde712595b68dc70b6d20c101295dd81c42 Reviewed-on: https://chromium-review.googlesource.com/c/1282383Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#600002} 
- 
sczs authored- The infobarContainerView is now being added in the Coordinator start method. - The infobarCoordinator now starts right after its initialized. Bug: 892376 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ifd5e99e165280df73849f5590e2ccbe9d32945c8 Reviewed-on: https://chromium-review.googlesource.com/c/1282035Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#600001} 
- 
Pavel Shmakov authoredThe crash is in the NotificationManagerService, only on Lenovo Marshmallow devices, and from error message it's clear that the Icon class is used incorrectly: type of Icon is not checked before calling getResId(). We can't do much except blacklisting lenovo along with samsung and yulong. Bug: 894361 Change-Id: Iee094561227ab83cffb6cf913a4eb31961bf35b5 Reviewed-on: https://chromium-review.googlesource.com/c/1278847 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#600000} 
- 
Hiroshige Hayashizaki authoredBug: 827415 Change-Id: Ia2b38a57a7232dffaaa5f815b486baccbca92d4b Reviewed-on: https://chromium-review.googlesource.com/c/1274904 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#599999} 
- 
Ahmed Fakhry authoredThe flag tracks a feature that is enabled by default, which allows us to disable double-tap-to-zoom in the future if we need to. BUG=895574 TEST=Disable the feature and expect double-tap-to-zoom to stop working in tablet mode. Change-Id: Ia3bafbb96ecd2fb55186b1fae388d955e34efb2f Reviewed-on: https://chromium-review.googlesource.com/c/1281884Reviewed-by:Scott Violet <sky@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#599998} 
- 
Francois Doray authoredSince Android O, CurrentProcessInfo::CreationTime() returns a zero base::Time() because access to /proc/stat is forbidden (see https://issuetracker.google.com/issues/37140047). To prevent developers from doing the wrong thing, we will stop supporting CurrentProcessInfo::CreationTime() on Android in a upcoming CL. As a prerequisite, this CL removes the only caller on Android. Infinite values currently recorded to Gaia.AuthFetcher.ListAccounts.ProcessUptime.* on Android O show that CurrentProcessInfo::CreationTime() is broken on Android O. Change-Id: Ib01ef51e7ce4b9855043a5dfa667e8f6c70cdcd1 Reviewed-on: https://chromium-review.googlesource.com/c/1280609Reviewed-by: Roger Tawa <rogerta@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#599997} 
- 
Tarun Bansal authoredThese have been in stable since M-69. Change-Id: Iedd7df0ef4941ba85423c79610ec22c10d567357 Bug: 826950 Reviewed-on: https://chromium-review.googlesource.com/c/1203316Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#599996} 
- 
chromium-autoroll authoredhttps://android.googlesource.com/platform/external/perfetto.git/+log/5f1cbf4f7262..c0c9df23b38c git log 5f1cbf4f7262..c0c9df23b38c --date=short --no-merges --format='%ad %ae %s' 2018-10-16 taylori@google.com Merge "trace_to_text: Output process names and fix json." 2018-10-16 fmayer@google.com Merge "profiling: Allow to generate heap dumps." 2018-10-16 treehugger-gerrit@google.com Merge "Change usage message for trace_processor_shell." Created with: gclient setdep -r src/third_party/perfetto@c0c9df23b38c The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ib146e8c600bb22a4dddbc92455d9eb8e8ea7e671 Reviewed-on: https://chromium-review.googlesource.com/c/1283241Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599995} 
- 
Sky Malice authoredOffline pages uses some non-exact url matching, such as removing fragments and matching redirects. The host communicates with the Feed only through exact matches. The change switches the get status path to full use exact requested URL matches. Unfortunately observations from OfflinePagesModel still must trust the offline pages URL, but this is not easily fixable. Bug: 888770 Change-Id: I9b6d7734547af149d2e0e5af28aea071b4f18a36 Reviewed-on: https://chromium-review.googlesource.com/c/1278933Reviewed-by: Filip Gorski <fgorski@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#599994} 
- 
manuk authoredOmniboxElement, OmniboxInputs, and OmniboxOutput Bug: 891303 Change-Id: I9de04903beddab6638e379227ae714801ad65991 Reviewed-on: https://chromium-review.googlesource.com/c/1281164 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#599993} 
- 
Avi Drissman authoredBUG=891699 Change-Id: Ib0d473673ba6f06e9d46096380df517ebeb3ae4f Reviewed-on: https://chromium-review.googlesource.com/c/1282363Reviewed-by: Leonard Grey <lgrey@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#599992} 
- 
Ken Rockot authoredFixes some ArcVoiceInteractionFrameworkServiceTest expectations. These expectations are not guaranteed by the test setup or execution, and only pass today coincidentally due to timing of Mojo interface message dispatch. Fortunately there is no reason why the expectations need to be met under the given conditions, so they are simply removed here. See linked bug for additional details regarding why timing may change soon. Bug: 872069 Change-Id: If6d15c1db8224555f0476910d10e17afe2f3cbe1 Reviewed-on: https://chromium-review.googlesource.com/c/1281742 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by: Yue Li <updowndota@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#599991} 
- 
Rune Lillesveen authoredAccording to the specification, we should not paint backgrounds for html or body on the viewport if they are display:none [1]. [1] https://drafts.csswg.org/css-backgrounds/#special-backgrounds Bug: 895757 Change-Id: Ia975022e3bfa849298667f72908a64c0d5331872 Reviewed-on: https://chromium-review.googlesource.com/c/1283134 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#599990} 
- 
Frank Tang authoredThis the Chromium side of adding usage counter for Intl objects functions. It depends on https://chromium-review.googlesource.com/c/v8/v8/+/1255628 Bug: v8:8250 Change-Id: I3a56c6948bbe6059b5b997a4199c4ea612c9ee3d Reviewed-on: https://chromium-review.googlesource.com/c/1255629Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#599989} 
- 
Morten Stenshorne authoredThe tests incorrectly assumed that block-size:-webkit-fill-available on absolutely positioned children were resolved against the available *content* box size. But for absolutely positioned descendants, the containing block size is based on the *padding* box. (Fun fact: -webkit-fill-available, when used on *inline* sizes, is handled correctly in legacy, i.e. we use the padding box, then) NG does it correctly in both dimensions. So mark the test as failing in legacy and passing in NG. Updated the tests to look prettier when rendered correctly. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I3f987660920ee0e03974dabb6928c0591717766a Reviewed-on: https://chromium-review.googlesource.com/c/1281967Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#599988} 
- 
kylechar authoredReplace passing around an array+size with passing a vector to cleanup code. Bug: none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I04eb35d9af0c96db0cddaa2a6b5f526517d7ec3e Reviewed-on: https://chromium-review.googlesource.com/c/1280858Reviewed-by: Fady Samuel <fsamuel@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#599987} 
- 
Ehsan Karamad authoredThe API for attaching inner and outer WebContentses only supports a RenderFrameHost which is same-process and origin with its parent. This is due to the fact that all GuestViews start off with a blank <iframe> which is later swapped out with a proxy during attaching process. For MimeHandlerViewGuest it is not guaranteed that the starting frame in an <embed> or <object> is in 'about:blank'. This CL circumvents the problem by first navigating a plugin frame (on the browser side) to 'about:blank' and then proceeding with the attaching process. Bug: 659750 Change-Id: I57d41a38e957b22c4ba3c29cb11122115373946f Reviewed-on: https://chromium-review.googlesource.com/c/1240635 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#599986} 
 
-