- 21 Jul, 2017 40 commits
-
-
nednguyen authored
This benchmark is broken, and benchmark owner no longer works on the Chromium project. Bug: 747000 Change-Id: Ideddacfdf10b4628eb660eb37bee270d4f339020 Reviewed-on: https://chromium-review.googlesource.com/581417Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#488684}
-
Tommy C. Li authored
We've already removed access to this feature from chrome://flags. This just removes the now-dead implementing code. Bug: 709550 Change-Id: I21cd2516874722525c2ddab4a2ab0840e46d38c4 Reviewed-on: https://chromium-review.googlesource.com/580363Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#488683}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/3668235f8a91..950ede098bcd $ git log 3668235f8..950ede098 --date=short --no-merges --format='%ad %ae %s' 2017-07-21 loloangela Fixed errors related to bad-continuation Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: If118eb016db294f7efa8fb1c151f01d9b5d5b23b Reviewed-on: https://chromium-review.googlesource.com/581411 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#488682}
-
mark a. foltz authored
- Adds UseCounters to count presentations started on secure/insecure origins. - Logs a deprecation warning only when presentations are started, because of the warning frequency on PresentationRequest constructor or getAvailability. Blink-dev thread: https://groups.google.com/a/chromium.org/d/topic/blink-dev/lumj0lVdtHA/discussion Bug: 733381 Change-Id: I4352b2b9d3e887ade122bb8efb6e9a8efcbfd874 Reviewed-on: https://chromium-review.googlesource.com/578687 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#488681}
-
Alexander Semashko authored
I observed the use after free in WebContentsImplTest.LoadResourceWithEmptySecurityInfo. It was triggered by some downstream code that is not present in chromium, but the root cause is that the test sets ContentBrowserClient that is destroyed at the end of the test body. This CL extends the lifetime of this object in WebContentsImplTest. Bug: Change-Id: I8d6b553a20b497c346b47aeb043dedcd84e94abb Reviewed-on: https://chromium-review.googlesource.com/563380Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Alexander Semashko <ahest@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#488680}
-
Lucas Garron authored
rus-trip.ru: > [love.rus-trip.ru] - This subdomain of the affiliate program, it was not > planned to https brztec.com: > now this domains will host only static pages from blogspot and blogspot > doesn't support HTTPS when using personalized domains. supinbot.ovh: > I mistakenly enabled HSTS preloading a while back but I frequently have to > test new HTTP services that do not support HTTPS. enterprise-threat-monitor.com: > www.enterprise-threat-monitor.com - too many issues at enterprise customers pixelneat.com: > we added testing HSTS header by mistake and browsers already cached. We did > not have a problem until letsencrypt SSL has been reloaded, so encryption keys > are not the same which have browsers. fumo.se: > I have mistakenly used "includesubdomain and preload" which was not intended. pepchid.com: > I decide to use the new domain yilanju.com and set pepchid.com skip to the new > one, so I request you for the removal. xliu.cf: > The reason is that my registration for this domain name has expired, and the > provider Freenom is now reselling the domain. inspy.me: > The CA that issued my certificate (WoSign) became untrusted. And even though I > have shut my project down I think it is still a good idea to remove it from > HSTS preload list. graysonsmith.co.uk: > The domain is being transferred to a new company and they do not yet have SSL > set up on their servers. Bug: 527947 Change-Id: Ic69a2aa871995041ec13cbe95ba65405a361c874 TBR=palmer@chromium.org Change-Id: Ic69a2aa871995041ec13cbe95ba65405a361c874 Reviewed-on: https://chromium-review.googlesource.com/565801Reviewed-by:
Lucas Garron <lgarron@chromium.org> Commit-Queue: Lucas Garron <lgarron@chromium.org> Cr-Commit-Position: refs/heads/master@{#488679}
-
Adrienne Walker authored
This adds serialization/deserialization/testing for most of the internals of PaintFlags. SkValidatingSerializeFlattenable is used for more complex Skia objects. Still remaining to be handled are PaintShader and SkTypeface. Additionally, SkValidatingSerializeFlattenable ignores SkPictureImageFilters for security purposes and so these will have to be handled in some other manner in the future. This serialization is not yet called while running Chrome yet. This is all for testing purposes at this point. Bug: 737629 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic1787721e7518367dca0c40f7a6a438bca980701 Reviewed-on: https://chromium-review.googlesource.com/578321Reviewed-by:
Vladimir Levin <vmpstr@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#488678}
-
spqchan authored
The animated App Menu Icon is misaligned by 1pt on non-retina screens. To fix this, the icon needs to be translated by 0.5pt. Bug: 704786 Change-Id: Ida9155be424eb9ea46acb6f6ae41d245de3ae28c Reviewed-on: https://chromium-review.googlesource.com/580694Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#488677}
-
Gabriel Charette authored
{} initialization of LAZY_TASK_RUNNERs doesn't work when providing multiple traits. Update documentation to suggest explicit TaskTraits initialization. R=robliao@chromium.org Bug: 730170 Change-Id: Icbd93f47f9d3f36c344ea892ed4b7e11b00becd3 Reviewed-on: https://chromium-review.googlesource.com/580531Reviewed-by:Robert Liao <robliao@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#488676}
-
Christos Froussios authored
OSCrypt only needs to read from the backend during its initialisation. Instances created for this initialisation can be cleaned up afterwards. To support this change, the mocking of OSCrypt can no longer be based on a singleton. Tests using the mocking mechanism are updated. Bug: 709096 Change-Id: Iba5b37ad45ada11b9a217dc2c388313f2371f647 Reviewed-on: https://chromium-review.googlesource.com/571221Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#488675}
-
Chris Harrelson authored
Bug: 726980 Change-Id: I9b537749a96a617617fdddf98f71cafba4bf2833 Reviewed-on: https://chromium-review.googlesource.com/578462 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Walter Korman <wkorman@chromium.org> Cr-Commit-Position: refs/heads/master@{#488674}
-
Iulia Harasim authored
This CL adds SinginPromoMediator which is used to configure the signin promo. This class is then used in SigninPreference, making the promo visibile in the Settings page. Bug: 737743 Change-Id: I7f5587b32a377db603cf536f8cb1cd9ba8851fdb Reviewed-on: https://chromium-review.googlesource.com/576169Reviewed-by:
-
Etienne Pierre-Doray authored
Applying corrections upon grt@ review for 560657: - Fix comments and style. - Fix includes (remove unused, add missing). - Switch from cstd* to std*.h. Bug: 729154 Change-Id: Id63bdaf64e2e468e30f4615f7ea62ef817268b9a Reviewed-on: https://chromium-review.googlesource.com/579582Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#488672}
-
Roger McFarlane authored
If enabled, suppress the suggestion of disused addresses (i.e., those not used the last 6 months) unless they match non-empty user input. BUG=734151 Change-Id: I6b2e52cce16f36af16b41d5a1aeafa2dd79752aa Reviewed-on: https://chromium-review.googlesource.com/576627Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#488671}
-
Yeol authored
Renamed TaskRunner::RunsTasksOnCurrentThread() to TaskRunner: :RunsTasksInCurrentSequence() in //chrome, //content Bug: 665062 Change-Id: I2d6a309bb5f116e521da91a7f66b4fe8b756a386 Reviewed-on: https://chromium-review.googlesource.com/558326 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#488670}
-
danakj authored
TBR=danakj@chromium.org Change-Id: I2f00fa483f3ccb654e6ca59cdb48ff782240050c Reviewed-on: https://chromium-review.googlesource.com/581415 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#488669}
-
Ira Burak authored
Store expiry date as string. Bug: 744672 Change-Id: I83f9548ebe6a3a1e004d48476a5eed020d37b817 Reviewed-on: https://chromium-review.googlesource.com/578438 Commit-Queue: Ira Burak <iburak@google.com> Reviewed-by:
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/89e6562f31f2..926c65a49ca4 $ git log 89e6562f3..926c65a49 --date=short --no-merges --format='%ad %ae %s' 2017-07-20 hnakashima Add safetynet_measure.py to measure pdfium performance. Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I840fd241d05541fff1340ae3d65dbde40f01b1c2 Reviewed-on: https://chromium-review.googlesource.com/581410 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#488667}
-
Yoland Yan authored
This reverts commit bc3e2f93. Reason for revert: This broke cronet bots Original change's description: > Convert components/ java tests to JUnit4 > > For more on JUnit4 migration, please check src/testing/android/docs/junit4.md > > Bug: 640116 > Change-Id: Ied8a563ee6833b76beeaa0b4141aa6e0e74a2abd > Reviewed-on: https://chromium-review.googlesource.com/567627 > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Commit-Queue: Yoland Yan <yolandyan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#488657} TBR=nyquist@chromium.org,yolandyan@chromium.org,jochen@chromium.org,jbudorick@chromium.org Change-Id: I64276e77844bdfeabc4a6e2b253185fa661bd4f2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 640116 Reviewed-on: https://chromium-review.googlesource.com/581587Reviewed-by:
Yoland Yan <yolandyan@chromium.org> Commit-Queue: Yoland Yan <yolandyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#488666}
-
Steve Kobes authored
Bug: 740070 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I9c3208a36dd577634c7f74f5ccf63466c8b67f44 Reviewed-on: https://chromium-review.googlesource.com/578653Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#488665}
-
Jonathon Kereliuk authored
WIP needed for Actions API Bug: Change-Id: Ia0e93cc3a7c67b7ae0d4792de60816d44c6867e2 Reviewed-on: https://chromium-review.googlesource.com/579868Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#488664}
-
Jonathon Kereliuk authored
[Chromedriver] Add ability to merge capabilities to make chromedriver closer to being w3c compliant. This is built on yash's previous work. w3c standard: https://w3c.github.io/webdriver/webdriver-spec.html#processing-capabilities Change-Id: I9b2f49c0f2ebff59fd5b053c2d8b9b99a95aabe5 BUG=chromedriver:1740 Change-Id: I9b2f49c0f2ebff59fd5b053c2d8b9b99a95aabe5 Reviewed-on: https://chromium-review.googlesource.com/562377Reviewed-by:
-
Eric Stevenson authored
This CL makes it possible to verify the addition/removal of static initializers using diagnose_bloat.py. Also changes resource_sizes.py to not automatically skip functions that require a proper output directory to be set when one isn't (instead of using --no-output-dir). BUG=None Change-Id: I061dd3d3624550888458cc97b8d6b8324f7a6183 Reviewed-on: https://chromium-review.googlesource.com/580546 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#488662}
-
Peter Conn authored
This reverts commit 9608749b. Reason for revert: Failures on Lollipop Phone Tester, eg: https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Phone%20Tester/builds/13630 https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Phone%20Tester/builds/13631 https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Phone%20Tester/builds/13632 https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Phone%20Tester/builds/13633 Original change's description: >
📷 Enable Render Tests. > > Make the render tests fail if the rendered bitmap does not match the > golden. > > Bug: 641973 > Change-Id: I432111296893bafab18dc65bfb62b12a8212d68e > Reviewed-on: https://chromium-review.googlesource.com/565399 > Commit-Queue: Peter Conn <peconn@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#488631} TBR=bauerb@chromium.org,mikecase@chromium.org,peconn@chromium.org,jbudorick@chromium.org Change-Id: I17ba42053f6679098f176c6ec7fdfb5e14984a39 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 641973 Reviewed-on: https://chromium-review.googlesource.com/581527Reviewed-by:Peter Conn <peconn@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#488661}
-
lukasza authored
Revert of Use FrameIsAd to decide whether to isolate a frame in TopDocumentIsolation mode. (patchset #28 id:540001 of https://codereview.chromium.org/2946113002/ ) Reason for revert: This CL has caused crashes reported in https://crbug.com/747403 Original issue's description: > Use FrameIsAd to decide whether to isolate a frame in TopDocumentIsolation mode. > > FrameIsAd heuristics > ==================== > > After this CL, TopDocumentIsolation will by default only isolate > cross-site frames that also match FrameIsAd heuristics. This behavior > is controllable via Finch, via chrome://flags and via command line > (see below for details). > > Impact on browser tests > ======================= > > Browser tests should not depend on the FrameIsAd heuristics. This is > taken care of by EnableTopDocumentIsolationForTesting, which enables > the mode that isolates all frames that are cross-site from the main > frame. > > chrome://flags changes > ====================== > > This CL tweaks TopDocumentIsolation's entry in chrome://flags, so that the > following variations are present (3. and 4. are introduced by this CL): > 1. Default > 2. Enabled > 3. Enabled (CrossSite - isolate all frames from sites other than > the top-level frame) > 4. Enabled (Ads - isolate only cross-site ads detected by heuristics) > 5. Disabled > > Today variations 1 and 5 turn off TDI mode (because the default for > kTopDocumentIsolation base::Feature is to be disabled). Variation 3 > enables TDI and isolates all cross-site frames (this is what browser > tests use when enabling TDI via EnableTopDocumentIsolationForTesting). > Variations 2 and 4 enable TDI and use FrameIsAd heuristics. Probably a > better name for variation 2 would be "Enabled (unspecified isolation > mode)", but the "Enabled" string is hardcoded in the chrome://flags > code. > > I've manually tested that if a user enabled TDI in chrome://flags before > this CL, then it will stay enabled after this CL (variation 2). > > Command line > ============ > > After this CL, the user can control TDI with the following command line > switches: > > - When no extra cmdline switches are present, then TDI is controlled via > chrome://flags and/or Finch experiments. > > - Cmdline flags to disable TDI: > --disable-features=top-document-isolation > > - Cmdline flags to enable TDI using unspecified / default isolation mode: > --enable-features=top-document-isolation > > - Cmdline flags to enable TDI using specific isolation mode (1 for > cross-site, 2 for ads; see the TopDocumentIsolationMode enum for all > possible values): > --enable-features="top-document-isolation<TopDocumentIsolation" \ > --force-fieldtrials=TopDocumentIsolation/Cmdline \ > --force-fieldtrial-params=TopDocumentIsolation.Cmdline:mode/1 > > BUG=733303 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Review-Url: https://codereview.chromium.org/2946113002 > Cr-Commit-Position: refs/heads/master@{#488372} > Committed: https://chromium.googlesource.com/chromium/src/+/c1dd61f01ced0c94ccc2efe373a93c696bb98c2f TBR=creis@chromium.org,jam@chromium.org,asvitkine@chromium.org,jkarlin@chromium.org,csharrison@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=733303 Review-Url: https://codereview.chromium.org/2987563004 Cr-Commit-Position: refs/heads/master@{#488660}
-
Gabriel Charette authored
R=thakis@chromium.org Bug: 689520 Change-Id: I5ea04e1c89cf5694071aa1c7d0d6ff5caaca4f88 Reviewed-on: https://chromium-review.googlesource.com/580505Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#488659}
-
Gabriel Charette authored
Bug: 689520 Change-Id: I2bd06d69cb54fc81edb8a462caa6458effb5bdfe Reviewed-on: https://chromium-review.googlesource.com/580397Reviewed-by:
-
yolandyan authored
For more on JUnit4 migration, please check src/testing/android/docs/junit4.md Bug: 640116 Change-Id: Ied8a563ee6833b76beeaa0b4141aa6e0e74a2abd Reviewed-on: https://chromium-review.googlesource.com/567627Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Yoland Yan <yolandyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#488657}
-
sohan authored
Change-Id: Ie84d4af16c6d9a0a59e321f300fa1228c55b8799 Reviewed-on: https://chromium-review.googlesource.com/576430 Commit-Queue: Sohan Jyoti Ghosh <sohan.jyoti@huawei.com> Reviewed-by:
Brian Anderson <brianderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#488656}
-
Andrew Grieve authored
Having non-translated strings in .pak files is quite inefficient since they are copied into each locale .pak file. Changing this one string decreases apk size by 3,641 bytes. BUG=703134 Change-Id: I7b64c2d7a48544a7e780e3c300044fdba33b3920 Reviewed-on: https://chromium-review.googlesource.com/578214Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#488655}
-
Daniel Bratell authored
Both JSONParser and JSONValues use constants for the strings "null", "true" and "false". That is probably no problem since the linker will merge identical strings, but since the constants had the same names as well they caused collisions in jumbo builds. This patch makes JSONParser use the JSONValues constants. Change-Id: I27b01b354aa9cfeab0f8c636f22ecfbc2762a6bc Reviewed-on: https://chromium-review.googlesource.com/577552Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#488654}
-
Yeol authored
Renamed TaskRunner::RunsTasksOnCurrentThread() to TaskRunner::RunsTasksInCurrentSequence() in //service Bug: 665062 Change-Id: Id5de459e44ff12c2f8d0ac64270c135ee902912e Reviewed-on: https://chromium-review.googlesource.com/579317Reviewed-by:
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/f9e1294920ec..3668235f8a91 $ git log f9e129492..3668235f8 --date=short --no-merges --format='%ad %ae %s' 2017-07-21 loloangela Fixed errors related to bad-continuation. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ib129ee6ee29e7ceb87ab2b0875c135eda86c447e Reviewed-on: https://chromium-review.googlesource.com/581269 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#488652}
-
Robert Ma authored
Conversion script is based on directory_owners_extractor.py, and can be found at https://gist.github.com/Hexcles/ce7110a8d07bf81378e254914ae8cbb2 Verification: git show HEAD --name-only | sed 's|third_party/WebKit/LayoutTests/||' | sed 's|/OWNERS||' | sort > list1 grep 'external.*\[ Pass \]' W3CImportExpectations | grep -o -E 'external[^ ]+' | sort > list2 diff list1 list2 The diff output: 5a6 > external/wpt/common 51a53 > external/wpt/fonts 61a64 > external/wpt/images 64a68 > external/wpt/interfaces 65a70 > external/wpt/media All five directories are explicitly marked as "Owners: none; No tests in the directory." in W3CImportExpectations. Bug: 713987 Change-Id: Ic00f2eb971ed2ba3cc1a44aef59e2a32586a5e24 Reviewed-on: https://chromium-review.googlesource.com/580535Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#488651}
-
Scott Violet authored
I was debugging some strangness from these classes and didn't readily know who was creating the windows. BUG=none TEST=none Change-Id: I698070c53a90ca9f5e01225ba96fcbd3a77ed892 Reviewed-on: https://chromium-review.googlesource.com/580695Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#488650}
-
Olivier Robin authored
The current timeout for page load (0.1s) is a bit short and leads to flakyness on official bots on iPad Air. I can reproduce the flakyness locally. Increase the timeout to 1s as the loading is not the tested part. Bug: None Change-Id: Ie944a99590f8083e2c22d43769dcdf7d9a0dcab1 Reviewed-on: https://chromium-review.googlesource.com/579369Reviewed-by:
Ed Chin <edchin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#488649}
-
Daniel Vogelheim authored
In this implementation, all script streamer actions are controlled by ClassicPendingScript, and ScriptRunner ends up asking ClassicPendingScript to perform the streaming. To facilitate this, ClassicPendingScript has a new state kReadyStreaming, for cases where we start streaming while the script has already been 'ready' (and stays 'ready'). Bug: 557466 Change-Id: I990920830af3a820f530f360347f6fa98d8754c2 Reviewed-on: https://chromium-review.googlesource.com/519168Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#488648}
-
Mikel Astiz authored
InstantService is the only caller of MostVisitedSites::Refresh() and it is obvious from the caller's side that TopSites should be refreshed too, when an NTP is opened. Prior to this patch, TopSites would be updated time-based, leading to more stale NTP tiles when the feature kNtpTilesFeature is enabled (non-default case). The bug is believed to make little impact. Bug: 741431 Change-Id: Iccdc4f89d3ab430eafd9a2faf1b1564f363ff29f Reviewed-on: https://chromium-review.googlesource.com/581147 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#488647}
-
Peter E Conn authored
Bug: 739719 Change-Id: I24f44759324ae715a9d8abbd71753f0d3e85ab5b Reviewed-on: https://chromium-review.googlesource.com/581189Reviewed-by:
-
Tommi authored
Video frames might never arrive. Waiting is appropriate for a <video> tag, but not for <audio>. TBR=hubbe@chromium.org Bug: 738379 Change-Id: I3f6c886c32b06f6def8024ca585179ca81a6ef29 Reviewed-on: https://chromium-review.googlesource.com/575998 Commit-Queue: Tommi <tommi@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
-
