GitLab

Review URL: http://codereview.chromium.org/3106037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57324 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3110039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57323 0039d316-1c4b-4281-b951-d872f2087c98

BUG=49037
TEST=out/Debug/chrome --enable-tabbed-options. Go to 'Under the Hood' tab, open the
dialog, check some checkbox, the button should become enabled, uncheck all the
checkboxes, the button should become disabled.

Review URL: http://codereview.chromium.org/3143012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57322 0039d316-1c4b-4281-b951-d872f2087c98

BUG=46678
TBR=glider
Review URL: http://codereview.chromium.org/3192018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57321 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3141042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57320 0039d316-1c4b-4281-b951-d872f2087c98

BUG=52866
TEST=The two new WebM tests pass in Chromium and all four new tests pass in
Chrome.

Review URL: http://codereview.chromium.org/3176035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57319 0039d316-1c4b-4281-b951-d872f2087c98

BUG=53304
TBR=glider
Review URL: http://codereview.chromium.org/3122040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57318 0039d316-1c4b-4281-b951-d872f2087c98

Also remove obsolete DnsMasterTest.MassiveConcurrentLookupTest exclude filter
BUG=52844
TBR=glider
Review URL: http://codereview.chromium.org/3204006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57317 0039d316-1c4b-4281-b951-d872f2087c98

- Added Certificate Information link.

- Changed iconography to be:
  Identity  : Green check mark vs. Red skull and bones
  Connection: Green padlock vs. Orange exclamation point.
  (This used to be Green checkmark and Orange Exclamation point for both sections.

- Removed the icon for the First visit section. Need to see if we want an icon for when you haven't visited the site before. Mocks show no icons when you have visited before.

BUG=52916
TEST=Open the SSL InfoBubble and notice the new iconography. Click the link and the Certificate dialog should show.

Review URL: http://codereview.chromium.org/3136031

TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/3170043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57314 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jcivelli
BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3180024

TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/3175040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57313 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jcivelli
BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3180024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57312 0039d316-1c4b-4281-b951-d872f2087c98

- Added Certificate Information link.

- Changed iconography to be:
  Identity  : Green check mark vs. Red skull and bones
  Connection: Green padlock vs. Orange exclamation point.
  (This used to be Green checkmark and Orange Exclamation point for both sections.

- Removed the icon for the First visit section. Need to see if we want an icon for when you haven't visited the site before. Mocks show no icons when you have visited before.

BUG=52916
TEST=Open the SSL InfoBubble and notice the new iconography. Click the link and the Certificate dialog should show.

Review URL: http://codereview.chromium.org/3136031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57311 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57309 0039d316-1c4b-4281-b951-d872f2087c98

Writer for plist manifest and string table files, and custom strings for the Mac templates.

BUG=49316
TEST=plist_writer_unittest.*, plist_strings_writer_unittest.* (grit)

Review URL: http://codereview.chromium.org/3116027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57307 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=dumi
Review URL: http://codereview.chromium.org/3136033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57306 0039d316-1c4b-4281-b951-d872f2087c98

This issue is two-fold:

1) Remove "keyboard layout"-suffix from layouts
2) Do not show language name if obvious

For 1, basically I removed the suffix from keyboard layout names.
There are 2 exceptions:
 * For Japanese, to avoid confusion between Jpaanese input methods and
   Japanese keyboard layout, the suffix is intentionally kept.
 * For keyboard layouts used for Dutch, French and German,
   the suffix is kept (see below for the reason).

For 2,
* for non-ambiguous languages (do not have multiple input methods or layouts),
  show input method name or layout name
* for ambiguous languages
  - show keyboard layout or input method name without language name for
    other languages (as their layout name or input method name explicitly
    or implicitly imply language name)
  - show "language - layout" pair for Dutch, French and German
    (They share "Belgian" keyboard layout in common, showing only "Belgian"
    is ambiguous about language)

BUG=chromium-os:5804
TEST=./unit_tests --gtest_filter="LanguageMenu*" and manually check on ChromeOS device whether the menu text and notification menu are displayed as expected.

Review URL: http://codereview.chromium.org/3185020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57304 0039d316-1c4b-4281-b951-d872f2087c98

This introduces a new policy setting named AutoFillEnabled that administrators
can use to switch off the auto fill feature. The UI adjustments disable the
autofill button and dialog in the preferences dialog appropriate.

Preferences.xib change: Bind enabled state of the auto fill button to
autoFillSettingsButtonEnabled @property.
AutoFillDialog.xib change: Bind enabled state of the auto fill enabled checkbox and save button
to the autoFillEnabledAvailable and saveEnabled @properties, respectively.

BUG=49611
TEST=autofill_dialog_controller_mac_unittest.mm, manual testing

Review URL: http://codereview.chromium.org/3140024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57302 0039d316-1c4b-4281-b951-d872f2087c98

Made CacheInvalidationPacketHandler use a ScopedCallbackFactory.

BUG=53201
TEST=manually with sync_listen_notifications

Review URL: http://codereview.chromium.org/3191024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57301 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3205003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57300 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/3158032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57299 0039d316-1c4b-4281-b951-d872f2087c98

after a WebKit roll.

BUG=none
TEST=none
TBR=yuzo

Review URL: http://codereview.chromium.org/3173045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57298 0039d316-1c4b-4281-b951-d872f2087c98

Refactor: change the spdy session pool key to take a ProxyServer instead of a string representation of the proxy server.
BUG=52668
Review URL: http://codereview.chromium.org/3197018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57297 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=yuzo

Review URL: http://codereview.chromium.org/3181040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57296 0039d316-1c4b-4281-b951-d872f2087c98

implementation of IsConnected() on windows, you'll find that it can
synchronously check if the socket is connected.  This makes it so that
a CHECK (or DCHECK) on this attribute is dependent on the peer.  The peer
could send us a TCP-FIN at any time - even 1 nanosecond before our call
to IsConnected().  We can only use CHECK(!IsConnected()) to check before
we connect, we simply can't use it at runtime.

I searched the code and found 4 other instances of this broken check.  Most
were DCHECKs, which is good, but I've removed them just the same.

Turns out our MockSockets have a mechanism for simulating this error, but it
wasn't tested nor plumbed through the MockSSLClientSocket.  In the process
I added a couple of basic proxy test cases, which may be slightly redundant
with other test cases that are more advanced.  But they seem like a good
idea to cover anyway.  Added 6 tests in total.


BUG=53099
TEST=ProxyTunnelGetHangup, RecycleDeadSSLSocket

Review URL: http://codereview.chromium.org/3107036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57295 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Compiles
Review URL: http://codereview.chromium.org/3146029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57294 0039d316-1c4b-4281-b951-d872f2087c98

When the user presses ctrl, prefer (keeping) inline autocomplete
matches to (new, surprising) exact matches that include the
desired TLD.

BUG=52566
TEST=none

Review URL: http://codereview.chromium.org/3152029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57293 0039d316-1c4b-4281-b951-d872f2087c98

This eliminates wstrings from bookmark_model_unittest.cc, which entails removing
them from model_test_utils.*.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3141033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57292 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tfarina@chromium.org
BUG=fix your checkout/git setup/whatever
TEST=none

Review URL: http://codereview.chromium.org/3165058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57291 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=out/Debug/base_unittests --gtest_filter=RegistryTest.ValueTest

Review URL: http://codereview.chromium.org/3132035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57289 0039d316-1c4b-4281-b951-d872f2087c98

TEST=Open about:system. Table containing available system information is shown.
Clicking on button Expand shows associated entry, and clicking on Collapse hides it. Initialy all entries are hidden. 
Clicking on Expand all / Collapse all shows / hides all entries.
about:system/foo hides all entries but foo, and scrolls to it  

BUG=4973

Review URL: http://codereview.chromium.org/3173038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57288 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tfarina@chromium.org,rohitrao@chromium.org

Review URL: http://codereview.chromium.org/3111032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57284 0039d316-1c4b-4281-b951-d872f2087c98

The menu currently is Preferences, so the dialog title should be named Chromium Preferences to match with it.

BUG=53114
TEST=run chrome, click on "Preferences" menu item. See if the dialog title is "Chromium/Google Chrome Preferences".

Screenshot: http://imgur.com/vferP

Review URL: http://codereview.chromium.org/3151031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57282 0039d316-1c4b-4281-b951-d872f2087c98

Minor adjustments to bookmark folder menu button placement during button moves/adds/deletes.  In most cases it was a simple matter of not accounting for the vertical separation between buttons.  In the case of a button add I reworked the logic a bit.

BUG=51730
TEST=1) Cut or delete a bookmark button at the top, middle and bottom of a bookmark folder and verify that the button placement is correct. 2) Past a bookmark button at top, middle and bottom and verify button placement and that of the buttons above the insertion. 3) Drag move a button both upward and downward, including to the very top and the very bottom, and verify proper button placement and the placement of the buttons above the button moved as well as those buttons between the 'from' location and the 'to' location.

Review URL: http://codereview.chromium.org/3137038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57281 0039d316-1c4b-4281-b951-d872f2087c98

Adds suppression for Chromoting leak.

http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20(valgrind)/builds/7228/steps/memory%20test:%20remoting/logs/stdio

Suppression (error hash=#FFFFFFFFE328E394#):
{
   <insert_a_suppression_name_here>
   Memcheck:Leak
   fun:_Znw*
   fun:_Z11NewCallbackIN8remoting14SessionManagerEPNS0_21ChromotingHostMessageEiEPN9Callback2IT0_T1_E4TypeEPT_MSA_FvS5_S6_E
   fun:_ZN8remoting14SessionManager8DoEncodeE13scoped_refptrINS_11CaptureDataEE
   fun:_Z16DispatchToMethodIN8remoting14SessionManagerEMS1_Fv13scoped_refptrINS0_11CaptureDataEEES4_EvPT_T0_RK6Tuple1IT1_E
   fun:_ZN14RunnableMethodIN8remoting14SessionManagerEMS1_Fv13scoped_refptrINS0_11CaptureDataEEE6Tuple1IS4_EE3RunEv
   fun:_ZN11MessageLoop7RunTaskEP4Task
   fun:_ZN11MessageLoop21DeferOrRunPendingTaskERKNS_11PendingTaskE
   fun:_ZN11MessageLoop6DoWorkEv
   fun:_ZN4base18MessagePumpDefault3RunEPNS_11MessagePump8DelegateE
   fun:_ZN11MessageLoop11RunInternalEv
   fun:_ZN11MessageLoop10RunHandlerEv
   fun:_ZN11MessageLoop13RunAllPendingEv
   fun:_ZN8remoting38SessionManagerTest_OneRecordCycle_Test8TestBodyEv
}

BUG=53277
TEST=Valgrind on Mac turns green.

Review URL: http://codereview.chromium.org/3115026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57280 0039d316-1c4b-4281-b951-d872f2087c98

BUG=TEST=none

Review URL: http://codereview.chromium.org/3200011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57279 0039d316-1c4b-4281-b951-d872f2087c98

The commit in http://codereview.chromium.org/3162038 fixes the win slave such that it fires up crash_service.exe during pyauto run; this makes it generate crash reports.

BUG=53149

Review URL: http://codereview.chromium.org/3152047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57278 0039d316-1c4b-4281-b951-d872f2087c98

We would like to test the impact of automatic retries when a TCP connection exceeds a certain threshold before it gets back an ACK. We are observing a fair number of sockets where the connection had been established, but the sockets
were not used thereafter.


r=mbelche


Review URL: http://codereview.chromium.org/3191019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57276 0039d316-1c4b-4281-b951-d872f2087c98

I introduced a 3-second threshold value between consecutive fetch-plugin requests
that induce a disk read (on the file thread) by forcing a refresh. Now, if
multiple requests are made within the threshold values, no disk read will be
performed. Average request times have been reduced from 11ms/request down to
1ms/request.

BUG=44813
r=brettw

Review URL: http://codereview.chromium.org/3192013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57275 0039d316-1c4b-4281-b951-d872f2087c98

Make sure the key into the spdy session pool identifies the actual proxy used, and not the full list of possible proxies for the URL.

BUG=52668
TEST=SpdyNetworkTransactionTest.DirectConnectProxyReconnect
Review URL: http://codereview.chromium.org/3192011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57274 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=NONE
TBR=nirnimesh
Review URL: http://codereview.chromium.org/660414

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57272 0039d316-1c4b-4281-b951-d872f2087c98