GitLab

Updates test device data to reflect the fact that the local device
should always have access to its own BetterTogetherDeviceMetadata. The
local device now also requests the group private key. Also, added the
missing GetAllTestDevices() declaration.

Bug: 951969
Change-Id: I913c2281cb3bd101bd67137bf66f3181976b64d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728336
Commit-Queue: Josh Nohle <nohle@chromium.org>
Auto-Submit: Josh Nohle <nohle@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682925}

This flag hasn't been used in code in a while. Delete
some unused code.

Test: local build, no breaks.
Bug: none.
Change-Id: Id642f5c9424332395d5abc5d338bb8fe9fcb602e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667607
Commit-Queue: Brett Kilty <brettk@google.com>
Auto-Submit: Brett Kilty <brettk@google.com>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682924}

TextPaintTimingDetector(LTP) and ImagePaintTimingDetector (LIP) both
use ChromeClient to register callbacks in their implementation.
However, ChromeClient is an external component, which needs to
be decoupled in the test.

The initial design bypasses the callback in test. Specifically, LIP
bypasses it by having a control flag to direct the callback to a
local callback queue, and LTP simply just ignores the callback logic.
Either approach did not achieve a comprehensive coverage.

The new design in this CL uses a mocking approach for decoupling. As
ChromeClient was called to register callbacks, the new design
inserts an interface between LTP&LIP and ChromeClient. When testing
LTP&LIP, the interface is mocked with a local callback queue.
So the external component can be removed from the unit test.

Compared to an earlier attempt crrev.com/c/1701058 where two callbacks
were combined, this approach allows for separate callback-queueing
for Image/TextPaintTimingDetector, LargestContentfulPaintDetector
and other paint timing components in unit test. This way, future
change in LTP wouldn't affect the unit-test in LIP via ChromeClient
and vice versa. In addition, LargestContentfulPaintCalculator can
thus keep being capable of controlling the order of text callback and
image callback. As ChromeClient is shared with other paint metrics
(FP, FCP, FMP), the tests of LTP and LIP would couple with these
metrics if ChromeClient is not well separated.

As an extra benefit, this change will make it possible to combine
two callbacks by implementing the callback-manager interface in
a different way. The combination will then provide a hook to the
time when "both LIP and LTP callbacks have been invoked". This
hook would make it easy to solve crbug.com/982307.

This CL doesn't change the unit-tests expectations.

Bug: 982307, 987984

Change-Id: I8d58a9676b1b350c630f076c530b54f2d7c6ab04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722449Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682923}

https://android.googlesource.com/platform/external/perfetto.git/+log/2c1dec165ba6..9b95da7f782d

git log 2c1dec165ba6..9b95da7f782d --date=short --no-merges --format='%ad %ae %s'
2019-07-31 treehugger-gerrit@google.com Merge "ui: Fix missing images"
2019-07-31 treehugger-gerrit@google.com Merge "trace writer: Check that packet is finalized before new one is started"

Created with:
  gclient setdep -r src/third_party/perfetto@9b95da7f782d

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I062bb1402ebec37b3975d7b8f19909050f395e6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728476Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682922}

This change modifies the existing PDF interfaces to send data for links
and images. This extends the existing pipeline to accommodate links and
images which is part of the larger effort to make links and images
accessible in PDF. This extends the messaging pipeline between plugin
process and mimehandler process to send links and images.

This doesn't have any changes pertaining to actual data being populated
in the structures. In future CL's the data will be populated in the
structures for links and images.

Bug: 981448
Change-Id: Iee0b1ffae36df57772a739937c240aec5e01dd02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703627
Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#682921}

Bug: 987465
Change-Id: Id1d4d881f051f5efe0a1ed0e8bfa568813187be2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718368Reviewed-by: Dana Fried <dfried@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682920}

1. Provide explicit values for those enums in the LoginAuthRecorder
   class that are logged as UMA metric values.
   This makes it more clear that those values shouldn't be renumbered,
   and makes it easier to find and verify the correspondence between
   the enum values in the C++ code and the <enum> values in enums.xml.

2. Use new-style UMA utils that deduct the enum size automatically
   based on the "kMaxValue" item.

Bug: none
Change-Id: I853e5cae5eaeb39765d02b4256af59b2d2c2eb93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724087
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682919}

Remove NOTIFICATION_LOGIN_USER_CHANGED, NOTIFICATION_SESSION_STARTED,
NOTIFICATION_SCREEN_LOCK_STATE_CHANGED. Instead, observe SessionManager.

Change-Id: If575b3c9c345946b3e9e48f43643c9a2db4a0c83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709094Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682918}

Show the mono audio accessibility feature only if one of the following conditions have meet :
-Its not being controlled by any policy
-Its being controlled by a policy and the value of the policy is force on

Bug: 552439
Change-Id: I995db08d8331aa062cec26c57d4b2bba6ec74971
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726031
Commit-Queue: Amr Aboelkher <amraboelkher@google.com>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682917}

The goal of this cl is to move all child process logic to TestLauncher.
This should simplify the gtest launcher structure and clarify
each class responsibilities.

TestRunner controls running test processes across sequence runners.

TestLauncherDelegate is now limited to provide test specific needs.
Command line for tests, timeout, result processing, etc.

This allows us to remove the ProcessLifetimeObserver and its extending
classes

The original change has been reverted since result processing
was not thread safe.

Bug: 936248,848465
Change-Id: I2468cf2e92901c7f2c4a6f42838be219397a7b0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721429
Commit-Queue: Ilia Samsonov <isamsonov@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682916}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/f7b43d76692c..18ea66a25d54

git log f7b43d76692c..18ea66a25d54 --date=short --no-merges --format='%ad %ae %s'
2019-07-31 vapier@chromium.org gs: update to 4.41
2019-07-31 tbarzic@chromium.org Revert "Choose the Goma client based on where it runs."

Created with:
  gclient setdep -r src/third_party/chromite@18ea66a25d54

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I1641e150a9edf96d6334b590a9a8e373b36ea01b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728421Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682915}

BUG=977434, 866622

Change-Id: I56569fb480cdcee8c483dd6100be880cb1ae094c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720797Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682914}

With this CL, pixel-moving backdrop-filters will no longer pull in
pixels from outside the backdrop filter bounds; the input image will
be cropped to the bounds prior to filtering. See [1] for the PR for
this spec change, and [2] for the corresponding change in
gl_renderer.

[1] https://github.com/w3c/fxtf-drafts/pull/342
[2] https://chromium.googlesource.com/chromium/src/+/16f5c5ac41dcf6415c1e1a4ab916f693ba850a25

Bug: 973699
Change-Id: I275970e21912a9825edda0254236b0540e67494b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725469
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682913}

Also, updates documentation and makes it more concise.

Bug: 924136
Change-Id: I906dc6295d11cbf9cd83204d681d166e384fb22b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724489
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682912}

Switch Access (go/cros-switch) uses the Accessibility panel to show its
menu and back button. The back button is currently being shown under
the virtual keyboard, which causes confusion on how to navigate outward
in scope.

A similar change was previously submitted (https://osscs.corp.google.com/chromium/chromium/src/+/0a727234100f0d23e3308767087327f458cc92a3)
but later reverted because of unintended side effects of showing the
ChromeVox panel above fullscreen windows. This change does not have
that affect, as it leaves the logic to hide the window in fullscreen
mode intact.

Bug: 946616
Change-Id: I9f85a5f4f699ea5af55f75a69c1c3f5bb4358c93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727511Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#682911}

Bug: 932267
Change-Id: Ia7782e8f48ff3b08f7e1af32623cca54b3bab32d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724605Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682910}

Bug: 934009
Change-Id: I03a76ea596efb01600c8ad622933c5bec911fac2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729059Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682909}

Fix TimeLimitExceed issue for feature policy attr/value parser by adding a fixed limit for the size of the header.

Bug: 981397
Change-Id: I15c5b1864484241394cc26545e19921ed724fa1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724119Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/master@{#682908}

Bug: 934009
Change-Id: I1bf1b1bd6e86bc32aa49c3ea7e5a37b6a53fc580
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728266
Auto-Submit: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682907}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=eroman@chromium.org

Bug: 968047
Change-Id: Ifd4fc0f8ebd8082c821ddb40e42a888388a2971f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729076
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682906}

The metrics should not expire until VizHitTesting V2 is shipped (77) and
stablized.

Other change: riajiang@chromium.org has left chromium. Update the owner
according.

Bug: 988799
Change-Id: Ie086bd1b2a0ddb4ec57bda15e0086fbc873129ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726295Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682905}

https://chromium.googlesource.com/angle/angle.git/+log/3e493c48d2da..eb1b1646aebe


git log 3e493c48d2da..eb1b1646aebe --date=short --no-merges --format='%ad %ae %s'
2019-07-31 jmadill@chromium.org Capture/Replay: Fix capture-enabled libs build.


Created with:
  gclient setdep -r src/third_party/angle@eb1b1646aebe

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

TBR=geofflang@google.com

Bug: None
Change-Id: Ibab6ac84d556ffd0f0126ae2b42ac4f028806627
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729542Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682904}

TBR=benmason@chromium.org

Change-Id: Ic175a770aa5e213f476e310b27094922480641c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728181
Commit-Queue: Krishna Govind <govind@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682903}

https://skia.googlesource.com/skia.git/+log/38037fb44311..f5b14d8843e6

git log 38037fb44311..f5b14d8843e6 --date=short --no-merges --format='%ad %ae %s'
2019-07-31 senorblanco@chromium.org Dawn: update to onSupportedReadColorType().
2019-07-31 egdaniel@google.com Don't have GrVk*CommandBuffer derive from GrVkResource.

Created with:
  gclient setdep -r src/third_party/skia@f5b14d8843e6

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=benjaminwagner@google.com

Bug: None
Change-Id: I421acd9cca88aad6f99271914c12520800fe5b2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728422Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682902}

We are seeing very long delays during tab-switch, which may be due to
metal calls.

Also add trace events for IOSurface-backed shared images.

Bug: 988964
Change-Id: I6cad2aa3dbd700b5f795cec07b9d7538015a46e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729073Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682901}

Bug: 979049
Change-Id: Ifa277e8cf1a76ddd00d76abbf8ac392eb7d0b9f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704692Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682900}

It has been running on stable at 1% without any issues

Bug: 921746
Change-Id: Icd6eaffef7313d01f18c59b5a137fba3e66e06f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724607
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682899}

This CL fixes compilation errors caused when passing const-refs or
non-const-refs as value arguments for the UMA macros.


Before this CL, an attempt to pass a const-ref as a value resulted
in errors like this:

base/metrics/histogram_macros_internal.h:30:5: error: static_assert failed due to requirement 'sizeof(const TestEnum &) == 0' "enumerator must define kMaxValue enumerat
or to use this macro!"
    static_assert(
    ^
base/metrics/histogram_macros_unittest.cc:63:3: note: in instantiation of member function 'base::internal::EnumSizeTraits<const TestEnum &, void>::Count' requested here
  UMA_HISTOGRAM_ENUMERATION("Test.ScopedEnumeration3", value_ref);
  ^
base/metrics/histogram_macros.h:84:7: note: expanded from macro 'UMA_HISTOGRAM_ENUMERATION'
      INTERNAL_UMA_HISTOGRAM_ENUMERATION_DEDUCE_BOUNDARY)               \
      ^
In file included from ../../base/metrics/histogram_macros_unittest.cc:5:
In file included from ../../base/metrics/histogram_macros.h:10:
base/metrics/histogram_macros_internal.h:33:12: error: reference to type 'const TestEnum' requires an initializer
    return Enum();


Bug: none
Change-Id: I875ff783bda12cc30079bcf6188ff843b9b55a0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729593Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682898}

Inspector currently relies on Element::matches() to compute
matching selector indices. This does not support all
selectors, for example ":host".

This CL removes StaticCSSRuleList (only used by Inspector),
and gets selector indices from RuleData (computed by CSS
parsing engine) instead of forcing Inspector to compute them.

Old Explainer:
https://docs.google.com/document/d/1rBOWjHqNpkyvMj4pz-nCW-jxKgEqeRVQLsDwvR5b9Kc/edit?usp=sharing

Bug: 952440, 976062
Change-Id: I846fae5e80d30d9b3fee64d10cbbe01e1b80b751
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703542
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682897}

This renames:
IsFixedSizeInline -> IsFixedInlineSize
IsFixedSizeBlock -> IsFixedBlockSize

"inline-size" / "block-size" words should be kept together.
(other possibilities: HasFixedInlineSize, IsInlineSizeFixed).

And renames:
FixedSizeBlockIsDefinite -> IsFixedBlockSizeIndefinite

 - "block-size" is kept together.
 - Flips the bool (definite to indefinite) as NG cares more about
   something being indefinite (and is a top level-concept
   kIndefiniteSize).
   (This was difficult for me to read if (!somethingDefinite) )
   The only unfortunate thing here is that it is the opposite of
   what Legacy cares about - but arguably should be biasing towards NG.

(other possibilities: HasIndefiniteFixedBlockSize but only if we go
 with HasFixedBlockSize as above).

Change-Id: I76e050f4cb06fb2b86055fff5f800515f938b20c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709691Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682896}

This reverts commit 5351d11f.

Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Fuchsia%20x64/39025

Original change's description:
> [Fuchsia] Update to new FIDL string and vector APIs
> 
> This removes usages of the old API that will become build failures when
> deprecation warnings are turned on.
> 
> See: https://fuchsia-review.googlesource.com/c/fuchsia/+/304389
> Change-Id: Ie5db014401d79787101b2b4b6e7585fd7a23b1ce
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727375
> Commit-Queue: Ian McKellar <ianloic@chromium.org>
> Reviewed-by: Wez <wez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#682796}

TBR=wez@chromium.org,ianloic@chromium.org

Change-Id: Ie266c435355009b8846ed2368fc2c97195f24d6c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729476Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682895}

Show the high contrast accessibility feature only if one of the following
conditions have meet :
-Its not being controlled by any policy
-Its being controlled by a policy and the value of the policy is force on

Bug: 552439
Change-Id: Ia96b797ad9d1ea839b1e8cb74f597dbdfc8cc86b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725911
Commit-Queue: Amr Aboelkher <amraboelkher@google.com>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682894}

This trial is switching to being four legged:
  1) CECPQ2: HRSS-SXY (structured-lattice) exchange.
  2) CECPQ2b: SIKE p434 exchange.
  3) Control: a group equally sized to the first two to allow
     measurements at the server as well as at the client.
  4) Disabled: The no-change group. Different from Control because
     Control clients still signal to the server that they're in the
     trial.

Also adds add histogram to capture latency when the server supports
these post-quantum algorithms.

Bug: 930812

Change-Id: I5a56c86d6fa98b007b1efe01ea5af0becef64e8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709961
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682893}

1) The drive server may intermittently provide a particular suggestion
while typing. E.g. the input 'fluffy' may suggest a doc titled 'fluffy
kitten', while the input 'fluffy k' may not.

2) Drive suggests return asynchronously.

As a consequence of the above 2, when the drive server and bookmark or
history providers suggest the same document, the suggestion displayed
flickers between the preferred drive format (e.g. 'title - date -
doc_type') and the typical URL format (e.g. 'title - url').

This CL caches the 20 most recent drive suggestions to alleviate the
issue. Cached suggestions are scored 0 to avoid affecting the
autocomplete results displayed and their rankings. I.e., this CL is
cosmetic.

Bug: 941548
Change-Id: I8498642b89db463c968c66e3f2181da83e7b623f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576177
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682892}

This is step 3 in the migration of Switch Access options into an
official settings page. While the first two steps created the settings
page and added plumbing for the updated event type, this change modifies
where the Switch Access extension finds the preference values, and what
page opens for Switch Access settings.

Bug: 958081
Change-Id: Id88c6ba1f54444af5cd817222c521121187310cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670272
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682891}

R=alph@chromium.org

Bug: chromium:985454
Change-Id: I1a9b7953b1d7bdd9e9de715c3a999cd8997240db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719006
Commit-Queue: Alexei Filippov <alph@chromium.org>
Auto-Submit: Yang Guo <yangguo@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682890}

This patch fixes the calculation of when the compositor state needs
synchronization.  Ordering is important in the calculation of play
state, and some idle and pause states were being misclassified as
pending.

Bug: 988471, 988607
Change-Id: Ie73c57a3101f07bc44d5c353328d7e17d4fb1a99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728074Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682889}

Currently in PDFiumEngine::FillPageSides() the logic for handling the
bottom gaps of pages on the right side is in the FillPageSides().

This CL moves that logic to
draw_utils::AdjustBottomGapForRightSidePage(), making it testable.

Bug: 51472
Change-Id: I5c5d0929c46745ee315f3b7ce77dc4cb0b44e5f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726757Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Jeremy Chinsen <chinsenj@google.com>
Cr-Commit-Position: refs/heads/master@{#682888}

This reverts commit f9763b52.

Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/55348

Original change's description:
> Convert content::CommitNavigationParams to mojom.
> 
> Bug: 984550
> Change-Id: Ic966c764e7fb52a9fb8d2ea44d9777bd8c1e4011
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725096
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Scott Graham <scottmg@chromium.org>
> Reviewed-by: Nasko Oskov <nasko@chromium.org>
> Commit-Queue: Lucas Gadani <lfg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#682795}

TBR=avi@chromium.org,nasko@chromium.org,scottmg@chromium.org,lfg@chromium.org

Change-Id: Ibc3e06f427783c760970b5deb8f2bf6a6581b610
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 984550
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729577Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682887}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=pwnall@chromium.org

Bug: 968047
Change-Id: If31471ee0f29bdeed0639192d1bdba1e75197c5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729590
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682886}