GitLab

Before: http://i.imgur.com/U1IMJZc.png
After: http://i.imgur.com/2uWTmzi.png

NOTRY=true
BUG=246200

Review URL: https://codereview.chromium.org/60703003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233074 0039d316-1c4b-4281-b951-d872f2087c98

Fixes the build breakage of non-Aura Windows caused by http://crrev.com/54353002 .

BUG=315056
TEST=Done manually.
TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/59193005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233073 0039d316-1c4b-4281-b951-d872f2087c98

With recent changes to ui::gfx::Font, attempting to actually draw non-existent font styles crashes.

BUG=171518,314577
TEST=no crashes as in bug 314577
NOTRY=true

Review URL: https://codereview.chromium.org/58503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233072 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125106
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/55083004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233071 0039d316-1c4b-4281-b951-d872f2087c98

renderer part: https://codereview.chromium.org/57373002/
BUG=314476

Review URL: https://codereview.chromium.org/57073004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233070 0039d316-1c4b-4281-b951-d872f2087c98

I had to add a RenderViewVisitor to ensure that all secondary
windows get their resize mode values applied properly,
but other than that, this is a simple flipping-the-flag
type of thing.

BUG=309760
R=jam

Review URL: https://codereview.chromium.org/53493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233069 0039d316-1c4b-4281-b951-d872f2087c98

Currently vertical overscroll is only used in the experimental scroll
end effect feature and causes issues with gmail, so putting it behind
this feature flag.

BUG=312998
TEST=Built Chrome for CrOS and confirmed that the stuttering with the
     flag off is no long present.

Review URL: https://codereview.chromium.org/52263006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233068 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/50603014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233067 0039d316-1c4b-4281-b951-d872f2087c98

BUG=314916,162530
R=benwells@chromium.org, kalman@chromium.org

Review URL: https://codereview.chromium.org/58543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233066 0039d316-1c4b-4281-b951-d872f2087c98

Instead of accessing the SigninManager singleton from UserCloudPolicyStore, the username from signin is injected to UserCloudPolicyStore.

BUG=271392
(For change on Android:)

R=atwilson@chromium.org, dconnelly@chromium.org, joaodasilva@chromium.org
TBR=tedchoc@chromium.org

Review URL: https://codereview.chromium.org/49783006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233065 0039d316-1c4b-4281-b951-d872f2087c98

to win_rel flakiness.

BUG=314272
TBR=dominikg@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/60573004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233064 0039d316-1c4b-4281-b951-d872f2087c98

> Refactor MediaStreamManager to never output real device id. It now always output sourceId in the form of a HMAC.
> DeviceMessageFilter now don't need to create a source id.
> This also fix a bug that made the source ids useless unless you have called gum once.
> Note that the sourceIds are still just using the security origin as salt. Next step is to add a random number that is stored in the profile somehow.
> 
> This cl also make sure all public APIs are asynchronous by making sure all requests are posted on the UI thread and handled later. Before this change - there were code paths that posted on the UI thread and others that did not that could potentially happen after a request was cancelled. This also make it easier to fail a request based on the input arguments.
> 
> BUG=269139
> 
> Review URL: https://codereview.chromium.org/34393006

TBR=perkj@chromium.org

Review URL: https://codereview.chromium.org/60753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233063 0039d316-1c4b-4281-b951-d872f2087c98

This allows to remove the dependency of UserCloudPolicyManagerFactory on Profile in the next step.

BUG=271392
R=erg@chromium.org, joaodasilva@chromium.org

Review URL: https://codereview.chromium.org/52343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233062 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233060 0039d316-1c4b-4281-b951-d872f2087c98

r1230 (mac sender) NSLocalizedString compatibility (10.8 SDK and clang trunk -Wformat-extra-args).
r1229 (processor) map_serializers_unittest: fix unused variable warning.
r1228 (linux symupload) Print response code when sym_upload fails.
r1227 (processor) Add some symbols missing from last commit.
r1226 (processor) Add simple exploitability analysis for Linux crashes.
r1225 (common) Switch to scoped_array instead of inappropriate scoped_ptr.
r1224 (linux handler) Increase exception handler stack size for dumping thread.
r1223 (mac handler) Remove define of mach_vm_region from mach_vm_compatibility.h.

BUG=314109
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/60293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233059 0039d316-1c4b-4281-b951-d872f2087c98

Use the one defined in constants.py instead.

BUG=
TEST=build/android/test_runner.py instrumentation --test-apk ChromiumTestShellTest --test_data chrome:chrome/test/data/android/device_files --verbose --host-driven-root=chrome/android -f testDisableAndEnableSync --python-only

Review URL: https://codereview.chromium.org/59713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233057 0039d316-1c4b-4281-b951-d872f2087c98

DBusThreadManager's GetSystemBus returns NULL if Chrome built for ChromeOS runs on Linux or in tests.

BUG=275286

Review URL: https://codereview.chromium.org/57333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233056 0039d316-1c4b-4281-b951-d872f2087c98

BUG=313046

Review URL: https://codereview.chromium.org/48733010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233055 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a DeviceLocalAccountExternalDataService that provides each
device-local account with a DeviceLocalAccountExternalDataManager which
fetches, caches and retrieves external policy data.

BUG=256635
TEST=New browser test
R=derat@chromium.org, joaodasilva@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233048

Review URL: https://codereview.chromium.org/25242002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233054 0039d316-1c4b-4281-b951-d872f2087c98

This is for the case where the dialog might overflow and we have to
say "... and N more ..."

TBR=finnur
BUG=315192

Review URL: https://codereview.chromium.org/59883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233052 0039d316-1c4b-4281-b951-d872f2087c98

The CL broke compilation on Chrome OS.

> Support policies referencing external data for device-local accounts
> 
> This CL adds a DeviceLocalAccountExternalDataService that provides each
> device-local account with a DeviceLocalAccountExternalDataManager which
> fetches, caches and retrieves external policy data.
> 
> BUG=256635
> TEST=New browser test
> R=derat@chromium.org, joaodasilva@chromium.org
> 
> Review URL: https://codereview.chromium.org/25242002

TBR=bartfab@chromium.org

Review URL: https://codereview.chromium.org/60683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233051 0039d316-1c4b-4281-b951-d872f2087c98

r232181 changed build/common.gypi to set ARCHS=i386 explicitly for
target_arch==ia32. However, we don't want to set ARCHS=i386 for iOS device
builds (because iOS devices are a different architecture entirely). This CL
arranges to leaved ARCHS untouched for iOS builds, so that Xcode will use its
defaults; this was the behavior before r232181.

The non-intuitive aspect is that target_arch==ia32 for OS=="ios", because
host_arch is set to 'ia32' at line 88 of build/common.gypi for 'OS=="win" or
OS=="mac" or OS=="ios"' and target_arch is set from host_arch at line 117.

With build/common.gypi fixed, we also need to fix
discardable_memory_provider_unittest.cc for iOS device builds, now that it is
being compiled with the correct architecture.

BUG=314712

Review URL: https://codereview.chromium.org/58373003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233050 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=creis@chromium.org

Review URL: https://codereview.chromium.org/58343006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233049 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a DeviceLocalAccountExternalDataService that provides each
device-local account with a DeviceLocalAccountExternalDataManager which
fetches, caches and retrieves external policy data.

BUG=256635
TEST=New browser test
R=derat@chromium.org, joaodasilva@chromium.org

Review URL: https://codereview.chromium.org/25242002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233048 0039d316-1c4b-4281-b951-d872f2087c98

LayerTreeHost instances can exists in multiple threads. e.g. Aura with
--single-process. So this CL makes the sequence thread-safe.

In addition, this CL removes unused s_num_layer_tree_instances.

Review URL: https://codereview.chromium.org/57713004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233047 0039d316-1c4b-4281-b951-d872f2087c98

It wasn't used anywhere outside of the unit tests.

BUG=313827
TBR=danakj

Review URL: https://codereview.chromium.org/56713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233046 0039d316-1c4b-4281-b951-d872f2087c98

Added prefixLength to the items in the result of a getNetworkList. This allows the broadcast address to be calculated.

BUG=149057

Review URL: https://codereview.chromium.org/47443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233045 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233043 0039d316-1c4b-4281-b951-d872f2087c98

Caused compile failures
http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29%2832%29/builds/13904/steps/compile/logs/stdio

FAILED: g++ -MMD -MF obj/third_party/WebKit/Source/wtf/wtf.PartitionAlloc.o.d -DANGLE_DX11 -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DCOMPONENT_BUILD -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_NSS=1 -DUSE_X11=1 -DENABLE_ONE_CLICK_SIGNIN -DGTK_DISABLE_SINGLE_INCLUDES=1 -DUSE_XI2_MT=2 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DWTF_IMPLEMENTATION=1 -DENABLE_CUSTOM_SCHEME_HANDLER=0 -DENABLE_ENCRYPTED_MEDIA_V2=1 -DENABLE_SVG_FONTS=1 -DENABLE_GDI_FONTS_ON_WINDOWS=0 -DENABLE_HARFBUZZ_ON_WINDOWS=0 -DENABLE_TOUCH_ICON_LOADING=0 -DWTF_USE_CONCATENATED_IMPULSE_RESPONSES=1 -DENABLE_CALENDAR_PICKER=1 -DENABLE_INPUT_SPEECH=1 -DENABLE_INPUT_MULTIPLE_FIELDS_UI=1 -DENABLE_LEGACY_NOTIFICATIONS=1 -DENABLE_MEDIA_CAPTURE=0 -DENABLE_NAVIGATOR_CONTENT_UTILS=1 -DENABLE_ORIENTATION_EVENTS=0 -DENABLE_WEB_AUDIO=1 -DWTF_USE_WEBAUDIO_FFMPEG=1 -DENABLE_OPENTYPE_VERTICAL=1 -DWTF_USE_DEFAULT_RENDER_THEME=1 -DU_USING_ICU_NAMESPACE=0 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -I../../third_party/WebKit/Source -I../../third_party/WebKit -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I/usr/include32 -fstack-protector --param=ssp-buffer-size=4 -Werror -pthread -fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -m32 -mmmx -march=pentium4 -msse2 -mfpmath=sse -O0 -g -Wno-c++0x-compat -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -Wno-c++0x-compat  -c ../../third_party/WebKit/Source/wtf/PartitionAlloc.cpp -o obj/third_party/WebKit/Source/wtf/wtf.PartitionAlloc.o
../../third_party/WebKit/Source/wtf/PartitionAlloc.cpp: In function 'void WTF::partitionDumpStats(const WTF::PartitionRoot&)':
../../third_party/WebKit/Source/wtf/PartitionAlloc.cpp:534:328:error: format '%ld' expects argument of type 'long int', but argument 2 has type 'size_t {aka unsigned int}' [-Werror=format]



> Blink roll 161254:161319
> 
> http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=161255:161319&mode=html
> TBR=
> BUG=
> 
> Review URL: https://codereview.chromium.org/59393004

TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/60553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233042 0039d316-1c4b-4281-b951-d872f2087c98

The Credentials class now has basic support for unprivileged namespaces.

BUG=312380
R=jorgelo@chromium.org

Review URL: https://codereview.chromium.org/54643010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233041 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233040 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=161255:161319&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/59393004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233039 0039d316-1c4b-4281-b951-d872f2087c98

BUG=314623
TEST=ExtensionApiTest.ChromeOSInfoPrivateTest

Review URL: https://codereview.chromium.org/57133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233038 0039d316-1c4b-4281-b951-d872f2087c98

There's a problem with the buildbot that it is running an older binary.
This caused WebrtcCastApiTest.Basics to fail consistently because it's
running on a newer test javascript file.

Disable this test for now in the js file so the tree doesn't break.

TBR=kalman@chromium.org
BUG=314971

Review URL: https://codereview.chromium.org/60643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233037 0039d316-1c4b-4281-b951-d872f2087c98

The parser just needs to always output an array for the list of parameters.

BUG=315147
R=davemoore@google.com

Review URL: https://codereview.chromium.org/60203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233036 0039d316-1c4b-4281-b951-d872f2087c98

By delaying actually moving the window, we stop flooding the message
loop. This helps, but doesn't perfectly solve, the performance problems
with message dragging.

This patch adds a lot of TRACE_EVENT calls which were used to narrow
down exactly what was going on.

BUG=313903
R=ben@chromium.org, piman@chromium.org

Review URL: https://codereview.chromium.org/56053005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233035 0039d316-1c4b-4281-b951-d872f2087c98

More extraction of debug code from my local test build.  This adds:
- Trace events for easy logging of AudioOutputController actions.
- A wedge detection UMA statistic for field monitoring.

BUG=160920
TEST=UMA stat is reported correctly when wedged and not.

Review URL: https://codereview.chromium.org/51003005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233034 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=palmer@chromium.org

Review URL: https://codereview.chromium.org/55893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233033 0039d316-1c4b-4281-b951-d872f2087c98

Example Image: http://i.imgur.com/u6f6Ewh.png

NOTRY=true
BUG=239196

Review URL: https://codereview.chromium.org/53403004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233032 0039d316-1c4b-4281-b951-d872f2087c98

BUG=314863
R=kjiwa@google.com, rlarocque@chromium.org

Review URL: https://codereview.chromium.org/53153010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233031 0039d316-1c4b-4281-b951-d872f2087c98