- 15 Mar, 2018 40 commits
-
-
Mike Wittman authored
Disabling pending a resolution to crashes observed in the associated bug. This change also removes the unused GetSamplingParamsForCurrentProcess function and adapts IsProfilerEnabledForCurrentProcess to operate on the current process and specified thread. The call to IsProfilerEnabledForCurrentProcess is also removed from SetServiceManagerConnectorForChildProcess since that function is only invoked in processes supporting the profiler. Bug: 774682 Change-Id: Ibbc6f1bd9348ba09a3ee4db2e1595411617f1ccd Reviewed-on: https://chromium-review.googlesource.com/962937 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#543520}
-
Qiang Xu authored
Bug: None Test: compiles & trybots Change-Id: I29d5c39a018e6a2ddc0df3e123780f0bffd7aa99 Reviewed-on: https://chromium-review.googlesource.com/963650 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#543519}
-
James Hawkins authored
This is a no-op because the BT classic flow is gone. R=khorimoto@chromium.org Bug: none Test: none Change-Id: I9a3c86e5c2fc7cacbf3d301dcae233ef5c04bfc8 Reviewed-on: https://chromium-review.googlesource.com/963308 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#543518}
-
Mitsuru Oshima authored
xdai@ is the owner and author of the code BUG=None Change-Id: I5d40ffeee2cf9c80bf715d1f1656d02b01696ed1 Reviewed-on: https://chromium-review.googlesource.com/965004Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#543517}
-
Elly Fong-Jones authored
This change prohibits a TableView column from becoming too narrow to show its entire title. Bug: 603440 Change-Id: I3184e5fedb6ac7d55792857ea5ba64f85dfedae8 Reviewed-on: https://chromium-review.googlesource.com/962354 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#543516}
-
Eugene But authored
This CL also changes InstallationNotifier class to be compatible with OCMock (UIApplication shared instance is not stored in ivar anymore) and adds resetDispatcher method to allow restoring InstallationNotifier to its default state. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iaee0d80938639d23862b254732eb49c97ddd4e86 Reviewed-on: https://chromium-review.googlesource.com/958123 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#543515}
-
sczs authored
Bug: 819462 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I364154d00b6fb138a7b1b85240b625984e36fee5 Reviewed-on: https://chromium-review.googlesource.com/961492 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#543514}
-
https://pdfium.googlesource.com/pdfium.git/+log/d1ffda2acaee..35841fa4e3db $ git log d1ffda2ac..35841fa4e --date=short --no-merges --format='%ad %ae %s' 2018-03-15 hnakashima Create FPDFPage_RemoveObject(). 2018-03-15 rharrison Fixing order of guards to avoid potential segvs 2018-03-15 thestig Rename FX_COLORREF variables from "rgb" to "bgr". 2018-03-15 thestig Use Width()/Height() methods from rectangles. 2018-03-15 thestig Remove unused CPDFSDK_BAAnnot methods. 2018-03-15 thestig Fix a red-blue channel flip when rendering masks to EMF. Created with: roll-dep src/third_party/pdfium BUG=821672 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: If141edae0fe9d00e024a14545336834d172420e9 Reviewed-on: https://chromium-review.googlesource.com/964620 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543513}
-
Miguel Casas authored
This CL wires 3 display/monitor fields from EDID parsing to the Chrome private API where they surface, as described in the DD [1], namely: 1- manufacturer id 2- product id 3- year of manufacture. (Note that ToT Ozone DRM already parses this list's 1 and 2; this CL adds code to parse 3). A diagram of the touched areas is in the DD [1] extracted for quick access in: https://i.imgur.com/yx8H0R3.jpg (also [2]). but in a nutshell: Ozone DRM creates a DisplaySnapshot from the EDID, and passes it to Browser Process via Mojo and/or IPC (being migrated); in Browser DisplayChangeObserver transforms that snapshot into a ManagedDisplayInfo, and in turn passes it to the DisplayManager that creates a Display that is used later on upon request by DisplayInfoProviderChromeOS to fill in the JS data struct. There's a bit of confusion on ToT between product_id and product_code, so this CL follows the spec and aligns them all, i.e. EDID parser produces a |product_code|, which is a pack of the manufacturer id and product id. Unittests extended, tested on soraka+simplechrome. [1] go/js-edid-chromeos [2] https://imgur.com/a/aqNDD Bug: 821393 Change-Id: Ia219b4eeb92cf3eae3e58046340f1b81c34c9ea2 Reviewed-on: https://chromium-review.googlesource.com/959547 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#543512}
-
https://chromium.googlesource.com/catapult.git/+log/1446cf3fe8a3..ee4c7175f67b $ git log 1446cf3fe..ee4c7175f --date=short --no-merges --format='%ad %ae %s' 2018-03-15 nednguyen Store the failure message in story_run object for debugging failure reason 2018-03-15 simonhatch Dashboard - Fix 500 errors on single rev alerts 2018-03-15 simonhatch Dashboard - Make _CorrespondingRefTest into tasklet. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I394daf8a8578bd86d0703c8147861515885cda9d Reviewed-on: https://chromium-review.googlesource.com/964715 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543511}
-
Avi Drissman authored
This also does some cleanup. BUG=268984 Change-Id: I936c148f22c8c9d18c90b795e2f3412831e9f122 Reviewed-on: https://chromium-review.googlesource.com/962719 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#543510}
-
John Chen authored
Now that we've updated Webview on the Android test device to the latest version, adjust the test filter accordingly. Change-Id: Ica6f14bda130683c8775ec9b8e072c123fada8f5 Reviewed-on: https://chromium-review.googlesource.com/964808Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#543509}
-
Yury Khmel authored
This allows fetching policy for CHILD accunts. CHILD account is known non-enterprise domain. this moment it is empty. Add browser test. Test: Manually. Validated that policy is fetched for CHILD account. At Bug: 813892 Change-Id: I52440ab2737881499eb2e82f6a80eb0816f65542 Reviewed-on: https://chromium-review.googlesource.com/956962 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#543508}
-
Ian Vollick authored
This CL follows the approach described on crbug.com/808527 for respecting element alignment in the linear layout. Bug: 808527 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia11640da59ebcaf14ddd5d82df182ed7cacfd027 Reviewed-on: https://chromium-review.googlesource.com/964787Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#543507}
-
Raymond Toy authored
The spec says that if an input to an AudioWorkletNode is not connected, the input should be represented as an input with a single channel with a Float32Array of length 0. Make it so by passing in nullptr for that input to the AudioWorkletGlobalScope::Process so it can fill the arrays appropriately. Bug: 817145 Change-Id: I82407ed0a9fe84c5012333af8af27f4dd08d29b8 Reviewed-on: https://chromium-review.googlesource.com/953970Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#543506}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1acdfd58..f585291b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Idc8449bdad9dcc003db9fb9c611811bb4e86694f Reviewed-on: https://chromium-review.googlesource.com/964391Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#543505}
-
Gary Kacmarcik authored
The AsyncClipboardAPI feature flag used to control access to the entire async clipboard API, but (since we're now shipping the text portions of the API) its meaning has been changed to control access only to the parts of the API that are still under development (e.g., image and delayed generation support). The Clipboard permission is shipping as part of the text APIs, so it should no longer be checking this feature flag. Bug: 677564,821947 Change-Id: Ia57b57df3eae03c2d4372cf5e7472ef1d0532f49 Reviewed-on: https://chromium-review.googlesource.com/963287Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#543504}
-
Vaclav Brozek authored
In PasswordEntryEditor, PASSWORD_ENTRY_ACTION_CANCELLED represented the action of cancelling viewing of a password. This action no longer maps to the current possible UI flows and its representation is therefore marked as obsolete in this CL. For more info see the discussion on the associated bug. Bug: 807577 Change-Id: I79dc75a4d3a14cf1df7f46d1a5a2b26b664e5a0f Reviewed-on: https://chromium-review.googlesource.com/962453Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#543503}
-
Luna Lu authored
Change-Id: I00fc70141ef1afe1b926e0f9b72c7055d4d82917 Reviewed-on: https://chromium-review.googlesource.com/965007 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#543502}
-
Yuke Liao authored
This reverts commit 5b0cf7de. Reason for revert: This CL is causing iOS payment integration test to fail. For example: https://ci.chromium.org/buildbot/chromium.mac/ios-simulator-full-configs/3996 Original change's description: > [Payments] Modernize test JavaScript > > Before this patch, browser tests for PaymentRequest would print warnings > about deprecation of: > 1) Using an array for 'supportedMethods'. > 2) Specifying card networks in 'supportedMethods'. > > This patch modernizes the browser test by: > 1) Converting single-element 'supportedMethods' arrays into strings. > 2) Splitting up multi-element 'supportedMethods' arrays into arrays of > objects with a single string 'supportedMethods' value in each object. > 3) Using 'basic-card' in 'supportedMethods'. > 4) Specifying card networks in 'supportedNetworks'. > > After this patch, browser tests for PaymentRequest don't print warnings > about deprecation. > > Bug: NONE > Change-Id: I777f299ce32353fbf6a54fb4f839c3bfd19517a9 > Reviewed-on: https://chromium-review.googlesource.com/962928 > Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> > Reviewed-by: anthonyvd <anthonyvd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543474} TBR=rouslan@chromium.org,anthonyvd@chromium.org Change-Id: Ifea0a8c26867af9746b4716564580f36e5f5e7d9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: NONE Reviewed-on: https://chromium-review.googlesource.com/965022Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#543501}
-
Dominik Röttsches authored
Issue 964445 fixed the underlying reason for the crashes in these two test, removing the Crash expectation. Bug: 964445 Change-Id: Ia96ff6e14d00d2f599701a6586b8491c227e60ca Tbr: kojii Reviewed-on: https://chromium-review.googlesource.com/964762Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#543500}
-
David Trainor authored
This reverts commit 5050d462. Reason for revert: Failing some bots on L and M (Cannot create shot files java.io.IOException: open failed: EACCES (Permission denied)). Original change's description: > Create a top level ui screenshot description > > Merge the screenshot descriptions produced by the instrumentation tests > into a single description. If the tests are run locally print a link > to this description, if the are run remotely add a link to the > description to the json file produced by test_results_presentation > > Change-Id: Ia9dd491460633148283bed66949cec47a410dea3 > Reviewed-on: https://chromium-review.googlesource.com/952972 > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Anthony Berent <aberent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543393} TBR=bauerb@chromium.org,aberent@chromium.org,jbudorick@chromium.org Change-Id: Iafb4846c02ba54fcbfe5e4c5391bd1e5fbec540e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/964931Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#543499}
-
Sahel Sharify authored
This reverts commit 0a6d8978. Reason for revert: touchpad-scroll-impl-to-main.html is a flaky test that I changed it in the original cl and removed the tests expectations to see if the flake is fixed or not. Changing the test expectations caused unexpected test failure. In this reland I left the test expectations for touchpad-scroll-impl-to-main.html unchanged. Original change's description: > Revert "Send GSB before switching to mainthread scrolling in smooth scroll path." > > This reverts commit 5d5a062f. > > Reason for revert: added a failing test https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/32246 see issue 822386 > > bug: 822386 > > Original change's description: > > Send GSB before switching to mainthread scrolling in smooth scroll path. > > > > This cl is the equivalent of https://codereview.chromium.org/2854683002 fix for smooth scrolling > > path,if the compositor handles the GSB and during the scrolling we have to switch to main thread > > since the compositor cannot handle a GSU a GSB must be sent to the main thread since the original > > GSB was handled on the compositor rather than being sent to the main thread. > > > > touchpad-scroll-impl-to-main.html is the test that forces switch from compositor thread to main > > thread in the middle of scrolling. It used to get executed with --disable-smooth-scrolling > > in this cl I've moved the test to a new virtual test suite that has default scroll animation > > value. > > > > I have removed the test expectations since I have changed the test and this might fix the flake. > > > > subpixel-accumulation.html needs scroll animation to be disabled and that's why I had to move it to > > a new test suite. > > > > Bug: 820979, 708499, 757165, 800840 > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Change-Id: I21b1f4285897d74559f6827e6a232f007dc897b0 > > Reviewed-on: https://chromium-review.googlesource.com/961264 > > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> > > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#543425} > > TBR=tdresser@chromium.org,sahel@chromium.org > > Change-Id: I3c5253d96d011c9723063effac91c969ee352305 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 820979, 708499, 757165, 800840 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Reviewed-on: https://chromium-review.googlesource.com/963388 > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Commit-Queue: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543467} TBR=tdresser@chromium.org,crouleau@chromium.org Change-Id: I460ff89a12c94772564c77418f2c1e58c72314a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 820979, 708499, 757165, 800840 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/964809 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#543498}
-
Siddhartha authored
Most of the metrics were added to UKM in: https://chromium-review.googlesource.com/c/chromium/src/+/939904 Some metrics were missed due to privacy review being stale. This CL adds the remaining metrics after updating privacy doc BUG=730783 Change-Id: Iec4cc7d6cc4f90c7fb57a9bd8cad23eef7e3dce9 Reviewed-on: https://chromium-review.googlesource.com/961538Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#543497}
-
https://skia.googlesource.com/skia.git/+log/945ac788d85d..e11d7932940b $ git log 945ac788d..e11d79329 --date=short --no-merges --format='%ad %ae %s' 2018-03-15 reed detect non-finite pts 2018-03-15 benjaminwagner Upgrade OS and NVIDIA driver on Win10 Golo/MTV lab bots. 2018-03-15 robertphillips Disable CCPR path rendering in DDL mode 2018-03-15 robertphillips Add DDL SkpOnly bot 2018-03-15 borenet update_meta_config: Use new LUCI optional GPU trybot 2018-03-15 reed drawTextRSXform should not apply matrix to shader 2018-03-15 egdaniel Delete unused VkClearTest 2018-03-14 halcanary GrGLES: unify MakeNativeInterface_{android,egl} 2018-03-14 caryclark fix pathops fuzzers and debugging 2018-03-15 herb SkAutoGlyphCache change some sites to Find*. 2018-03-15 robertphillips Make CreateBackendFormatFromTexture shared code 2018-03-15 egdaniel Fix initialLayout update in Vk createTestingOnlyImage 2018-03-15 sugoi Check GL_EXT_texture_format_BGRA8888 before GL_APPLE_texture_format_BGRA8888 2018-03-14 caryclark protect PathMeasure against input paths with NaNs 2018-03-15 robertphillips Remove SK_RASTER_RECORDER_IMPLEMENTATION 2018-03-15 egdaniel Revert "ccpr: Unblacklist vulkan" 2018-03-14 egdaniel Make sure we set correct GrPixelConfig in promise images 2018-03-14 robertphillips Prepare ddl skp rendering for prime time Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I0c0bf60b31bcf0e9c592476d5d8c88624396034e Reviewed-on: https://chromium-review.googlesource.com/964737Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543496}
-
Sonny Sasaka authored
BlueZ bug makes it wrong to assume that the Discovering property is updated when StartDiscovery/StopDiscovery returns (crbug.com/822104). BlueZ bug fixing is deprioritized so here we remove the DCHECK first until BlueZ bug is fixed. BUG=814595 TEST=No longer crashes Change-Id: I12c6d0df808553d3098525b70ab998d8c957b918 Reviewed-on: https://chromium-review.googlesource.com/963845Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#543495}
-
Henrique Nakashima authored
On this case, a call inside the loop may cause visible_pages_ to change. Bug: 822091 Change-Id: I41b0715faa6fe3e39203cd9142cf5ea38e59aefb Reviewed-on: https://chromium-review.googlesource.com/964592Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#543494}
-
Ryan Hamilton authored
As per recent discussions in the QUIC IETF Working Group, the latter is reserved for implementations of the final RFC. https://github.com/w3c/navigation-timing/issues/71 Change-Id: I743eb5fcca87b1191e046fd531d19a2ee6ce8bef Reviewed-on: https://chromium-review.googlesource.com/963492Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#543493}
-
John Z Wu authored
Bug: 770983 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I237fe77422971a18476d85b60c1ad67d60aa39bd Reviewed-on: https://chromium-review.googlesource.com/963643 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#543492}
-
Sammie Quon authored
Use kAppIconKey if possible instead of kWindowIconKey for the overview icon. Its bigger and clearer when resized. Change split view drag indicators text to use a flat 24 width so they are always pill shaped, instead of line height if it is bigger. Test: manaual Bug: 817877, 817865 Change-Id: I880cbfe7d2474156e5268dcb02ef0efd6db12f00 Reviewed-on: https://chromium-review.googlesource.com/963673Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#543491}
-
John Chen authored
The Chrome option extensionLoadTimeout should allow value of 0, which means do not wait for extensions to load. Bug: chromedriver:2329 Change-Id: I38de01f7c1facbbbd181cbd19ac6c710e379afb9 Reviewed-on: https://chromium-review.googlesource.com/963591Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#543490}
-
Jian Li authored
Bug: 758690 Tbr: ryansturm@chromium.org Change-Id: I94d0f707255a362a71a3eaa9b79f6474c0865fad Reviewed-on: https://chromium-review.googlesource.com/963747 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#543489}
-
Yuwei Huang authored
remoting_localize.py only works if the string has been translated into all supported languages. This CL adds strings for photo library and camera usage into remoting_strings.grd in advance. Bug: 821594 Change-Id: I9ee88f7cf65e07a872a91908b80ee17a391e0bae Reviewed-on: https://chromium-review.googlesource.com/964805Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#543488}
-
Chris Hamilton authored
A previous CL used GlobalSize as the explicit size of clipboard data, removing trailing nulls. This was a fix to open-ended copying logic that would occasionally read past the end of the buffer for clipboard entries not containing terminating nulls. It turns out that some clipboard entries contain much less data than the entire buffer, and don't pad out to the end with terminating nulls (only seen on Win7 when copying from command line or other console apps). The fix is to copy until first null or end of the buffer. BUG=821609 Change-Id: Id0e733ccf10b0f7d2f7ec401a584d7f14d4fd063 Reviewed-on: https://chromium-review.googlesource.com/964722Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#543487}
-
Matthew Wolenetz authored
This reverts commit 27c3af9c. Reason for revert: In combination with https://chromium-review.googlesource.com/c/chromium/src/+/961827, https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/ has been failing consistently (CQ trybot, webkit_layout_tests (with patch)). Example: https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/123308 Original change's description: > Add move right LayoutTests. > > This patch adds test that confirm > |selection.modify('move', 'right', 'character')| behavior on various > DOM tree including RTL characters. > > This patch is a extraction from > editing/selection/move-left-right.html > which tests move right/left inside style=rtl/ltr. > > Bug: 679977 > Change-Id: Iae6a445422999daf6d1da39d8361ecc08ea6c8ec > Reviewed-on: https://chromium-review.googlesource.com/955864 > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > Commit-Queue: Yoichi Osato <yoichio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543312} TBR=yosin@chromium.org,yoichio@chromium.org,xiaochengh@chromium.org Change-Id: I5fefc0ff373b0f990cc8e845206fbbee721e12e0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 679977 Reviewed-on: https://chromium-review.googlesource.com/964902Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#543486}
-
Matthew Wolenetz authored
This reverts commit c079292c. Reason for revert: In combination with https://chromium-review.googlesource.com/c/chromium/src/+/955864, https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/ has been failing consistently (CQ trybot, webkit_layout_tests (with patch)). Example: https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/123308 Original change's description: > [auto] Update FlagExpectations for LayoutNG > > Following bot results are included. > 4218 4221 4224 4227 4229 4230 4232 4235 4236 4237 > > 11 lines were removed and 30 lines were deflaked by consecutive > results since 4191. > > TBR=eae@chromium.org, mstensho@chromium.org > NOTRY=true > > Bug: 591099 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng > Change-Id: Ic59fca5fcef70eb4a19049502ee9e5a8f4ec3a0b > Reviewed-on: https://chromium-review.googlesource.com/961827 > Commit-Queue: Koji Ishii <kojii@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543326} TBR=eae@chromium.org,kojii@chromium.org,mstensho@chromium.org Change-Id: I1791f1d60e650a1b29ff9dd3e2bb9865dbf09d9b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/963389Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#543485}
-
https://webrtc.googlesource.com/src.git/+log/853715c9a906..895ae9a0cdff $ git log 853715c9a..895ae9a0c --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iec0b3345ef60e6d1de800f66b25b0438e1a916e7 Reviewed-on: https://chromium-review.googlesource.com/964717 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543484}
-
Calder Kitagawa authored
Reintroduces the PeakPageMemory (Peak Virtual Memory) and PeakWorkingSetSize (Virtual Memory High Water Mark) metrics to Linux builds of Zucchini. Linux is used for benchmarking of ELF and DEX variants of Zucchini as well as general intergration and regression testing so it is nice to have these metrics remain in the program. The method used is based on code in base/process/internal_linux.[h|cc] however, it avoids the overhead of having to create key value pairs for all of the metrics so is slightly faster. Moreover, the contents of internal_linux are intended to be private to base/process so in order to get these metrics it is necessary to replicate part of the code. These were originally removed in: https://chromium-review.googlesource.com/c/chromium/src/+/951923. Also fixes some weirdness with "// defined(...)" comments. Change-Id: Id69f16fa912117f3d3756b425e584c48b9f0fff2 Reviewed-on: https://chromium-review.googlesource.com/963604 Commit-Queue: Calder Kitagawa <ckitagawa@google.com> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#543483}
-
mark a. foltz authored
TBR=zhaobin Bug: 822231 Change-Id: Ibd6c654a1b5cdc2449ed091de1b1a64589df0746 Reviewed-on: https://chromium-review.googlesource.com/964729Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Adam Parker <amp@chromium.org> Cr-Commit-Position: refs/heads/master@{#543482}
-
Shivani Sharma authored
If a response is not complete and has a content-encoding header, it should not be marked as truncated since we do not want it to lead to range requests for future requests. TEST=net_unittests --gtest_filter= WritersTest.ContentEncodingShouldNotTruncate Also manually verified that the test case reported in the bug is fixed. Bug: 820862 Change-Id: Ie3f4098e769e257632058af2215054809ca8c89f Reviewed-on: https://chromium-review.googlesource.com/962346 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#543481}
-