GitLab

We didn't show the supervised user theme when a supervised user
was created. This CL fixes this by running a callback when the
supervised user profile is fully initialized. This also fixes
the bug that the label string was not drawn on Windows.

BUG=265387,269718
TEST=Created a supervised user, added a unit test.

Review URL: https://chromiumcodereview.appspot.com/22677002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216917 0039d316-1c4b-4281-b951-d872f2087c98

Fixes valgrind failure and relands overview mode using alt-tab.

BUG=263481, 264289
TEST=WindowSelectorTest.Basic,WindowSelectorTest.BasicCycle
TEST=Enable --ash-enable-overview-mode and use alt-tab to cycle through MRU windows. Cycling is done in overview mode on active display.

Review URL: https://chromiumcodereview.appspot.com/22667003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216916 0039d316-1c4b-4281-b951-d872f2087c98

BUG=269843

Review URL: https://chromiumcodereview.appspot.com/22654003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216915 0039d316-1c4b-4281-b951-d872f2087c98

Currently, consecutive clicks will produce this behavior: single-click, double-click, triple-click, single-click, double-click, ...
This should match the Win behavior, which is: single-click, double-click, triple-click, double-click, triple-click, ...

BUG=234344

Review URL: https://chromiumcodereview.appspot.com/22638016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216914 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216909 0039d316-1c4b-4281-b951-d872f2087c98

> Clean up compositor initialization/destruction.
> 
> Moved from https://codereview.chromium.org/21052007/
> 
> Currently the ContextFactory is outliving the compositor thread in 
> tests, which is bad since the contexts in there can be bound to the 
> compositor thread. Then we end up reusing those contexts and bad 
> things happen. 
> 
> This enforces ordering for initializing and destroying the 
> compositor as follows: 
> 
> Initialize ContextFactory 
> ..Compositor::Initialize 
> ....Create Compositor instances 
> ....Delete Compositor instances 
> ..Compositor::Terminate 
> 
> The Compositor::Terminate call also destroys the ContextFactory. 
> 
> The ContextFactory can be initialized in one of two ways: 
> 1. ImageTransportFactory::Initialize will set up the 
> ContextFactory. This is used by things that invoke all of 
> content/browser/. 
> 2. Compositor::InitializeContextFactoryForTests() must be 
> explicitly called by any unit tests that create a compositor. 
> 
> Since some tests want a real GL context and some don't, this 
> does away with the misnomer of initializing the Compositor once 
> for the entire test suite, and then re-initializing somewhere 
> in the middle of the test suite. Instead, each test must 
> Initialize/Terminate the compositor with the ContextFactory 
> type of its choice. 
> 
> Incidently, this test enables 20 tests on aura or win_aura that 
> were previously being skipped. 
> 
> TBR=piman@chromium.org
> BUG=258625
> 
> Review URL: https://chromiumcodereview.appspot.com/22293003

TBR=danakj@chromium.org

Review URL: https://codereview.chromium.org/22648006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216907 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216902 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=155899:155910&mode=html
TBR=tdanderson@chromium.org
BUG=

Review URL: https://codereview.chromium.org/22371010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216901 0039d316-1c4b-4281-b951-d872f2087c98

The last change (r216889) passed the trybots because I didn't try against HEAD.
This change fixes examples that override domContentLoaded: nacl_io, file_io,
and load_progress.

BUG=none
TBR=noelallen@chromium.org

Review URL: https://codereview.chromium.org/22692005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216896 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216892 0039d316-1c4b-4281-b951-d872f2087c98

BUG=263481,264289
TEST=WindowSelectorTest.BasicCycle
TEST=Enable --ash-enable-overview-mode and use alt-tab to cycle through MRU windows. Cycling is done in overview mode on active display.

Review URL: https://chromiumcodereview.appspot.com/22715005

TBR=flackr@chromium.org
Review URL: https://chromiumcodereview.appspot.com/22778002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216890 0039d316-1c4b-4281-b951-d872f2087c98

(NOTE: this fixes the NaCl SDK waterfall)

A bug in common.js was causing the embed to load .pexe with
application/x-nacl, which produces a bizarre failure message:

NaCl module load failed: manifest: program property 'portable' does not have required key: 'url'.

BUG=none
R=noelallen@chromium.org

Review URL: https://codereview.chromium.org/22777002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216889 0039d316-1c4b-4281-b951-d872f2087c98

make TOOLCHAIN=pnacl DEBUG is broken.

This CL redirects all nacl-gdb calls to the gdb in newlib.
For DEBUG builds, the EXECUTABLES=*.nexe
For RELESE builds, the EXECUTABLES=*.pexe

This creates a dependency on the *.bc -> *.nexe translation and
feeds the output the the NMF generator, making the debugging case
essitial the same as newlib.

For RELEASE configs, we build a finalized .pexe and load that.

common.js now only use application-pnacl for release versions.

BUG=270745
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/22766003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216888 0039d316-1c4b-4281-b951-d872f2087c98

We have been incorrectly passing in the name of the .nexe instead
of runnable-ld.so as the "program" which is being debugged to gdb.

BUG=271207
TBR=sbc@chromium.org

Review URL: https://codereview.chromium.org/22434005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216887 0039d316-1c4b-4281-b951-d872f2087c98

PS1@r216878

BUG=270998

Review URL: https://codereview.chromium.org/22773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216886 0039d316-1c4b-4281-b951-d872f2087c98

Currently DesktopDragDropClientAuraX11 does not use DesktopRootWindowHostX11 at all.

Review URL: https://chromiumcodereview.appspot.com/22404006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216885 0039d316-1c4b-4281-b951-d872f2087c98

BUG=246208
R=asargent@chromium.org

Review URL: https://codereview.chromium.org/22597002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216884 0039d316-1c4b-4281-b951-d872f2087c98

This includes JNI bindings, Java interfaces and necessary glue for the requestAutocomplete dialog.

BUG=157277

Review URL: https://chromiumcodereview.appspot.com/22566004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216883 0039d316-1c4b-4281-b951-d872f2087c98

R=asargent@chromium.org, scheib@chromium.org

Review URL: https://codereview.chromium.org/22612003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216882 0039d316-1c4b-4281-b951-d872f2087c98

The notification notifies the change of the resolution, and
contains "Revert" button in case the new resolution doesn't work well.

Also it creates timeout in case the change operation is potentially
dangerous, which means changing the resolution of the only one display.

BUG=230733, 266097
R=oshima@chromium.org, derat@chromium.org
TEST=new test cases in ash_unittests

Review URL: https://chromiumcodereview.appspot.com/22703004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216881 0039d316-1c4b-4281-b951-d872f2087c98

Implement newly saved card bubble for realz and update generated card bubble to match mocks and updated product requirements.

Because these bubbles are not particularly similar any more, this CL splits them into separate interfaces (and hence separate controllers, files, test, etc.).

Functional changes to generated card bubble:
- removed link from bottom
- added link to end of header text

Functional changes to new card bubble:
- removed bubble/window title
- added card description (icon + title + label)
- made link and header text real translations

R=estade@chromium.org
BUG=263156,263158
TBR=sky@chromium.org (for 1 char change to ui/views/window/non_client_view.h)
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/21668003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216880 0039d316-1c4b-4281-b951-d872f2087c98

- Ignore the mouse position if mouse events are disabled (this is the case when the user is interacting with the device via touch)

BUG=268209
TEST=ShelfLayoutManagerTest.GestureDrag

Review URL: https://chromiumcodereview.appspot.com/22121002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216879 0039d316-1c4b-4281-b951-d872f2087c98

> Add option to import from bookmarks html file to "Import Bookmarks..." dialog.
> 
> To test this new feature one can do the following:
> 
> On chrome, open the "Import Bookmarks and Settings..." dialog, you can do this
> by three ways, one is to navigate to chrome://settings/importData, another is
> to open chrome://settings (either through wrench menu or navigating to it through
> omnibox) and then under the Users category click on "Import Bookmarks..." button
> to open the dialog. The third way to open this dialog
> is Wrench->Bookmarks->Import Bookmarks and Settings...".
> 
> Once the dialog is opened, open the "From" combobox and select "Bookmarks HTML File" item.
> That should uncheck and disable all the checkboxes but "Favorites/Bookmarks" and present a
> "Choose file" button in the place where "Import" button was. Click on that new button and select
> your bookmarks html file, once you do that the import process should start, and if you file is
> ok, chrome should import and present you with a success message.
> 
> BUG=80685
> R=dbeam@chromium.org, isherman@chromium.org
> 
> Review URL: https://codereview.chromium.org/22332003

It broke some Linux Tests of first run:

FirstRunMasterPrefsImportBookmarksFile.ImportBookmarksFile: 
[4452:4452:0810/092454:2260755831:ERROR:audio_manager_pulse.cc(234)] Failed to connect to the context.  Error: Connection refused
../../chrome/browser/first_run/first_run_browsertest.cc:186: Failure
Value of: auto_import_state
Actual: 5
Expected: MaskExpectedImportState(first_run::AUTO_IMPORT_CALLED | first_run::AUTO_IMPORT_PROFILE_IMPORTED | first_run::AUTO_IMPORT_BOOKMARKS_FILE_IMPORTED)
Which is: 7

FirstRunMasterPrefsImportDefault.ImportDefault: 
[4405:4405:0810/092452:2258318309:ERROR:audio_manager_pulse.cc(234)] Failed to connect to the context.  Error: Connection refused
../../chrome/browser/first_run/first_run_browsertest.cc:166: Failure
Value of: auto_import_state
Actual: 1
Expected: MaskExpectedImportState(first_run::AUTO_IMPORT_CALLED | first_run::AUTO_IMPORT_PROFILE_IMPORTED)
Which is: 3

TBR=tfarina@chromium.org

Review URL: https://codereview.chromium.org/22671003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216878 0039d316-1c4b-4281-b951-d872f2087c98

BUG=268457
TEST=ImmersiveModeControllerAshTest.Bubbles

Review URL: https://chromiumcodereview.appspot.com/22238003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216877 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216876 0039d316-1c4b-4281-b951-d872f2087c98

R=mallinath@chromium.org

Review URL: https://codereview.chromium.org/22471004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216875 0039d316-1c4b-4281-b951-d872f2087c98

BUG=263481,264289
TEST=WindowSelectorTest.BasicCycle
TEST=Enable --ash-enable-overview-mode and use alt-tab to cycle through MRU windows. Cycling is done in overview mode on active display.

Review URL: https://chromiumcodereview.appspot.com/22715005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216874 0039d316-1c4b-4281-b951-d872f2087c98

BUG=248357

Review URL: https://chromiumcodereview.appspot.com/22695004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216873 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a crash in Chromoting Android app when it hadn't been granted permission to access OAuth tokens for an account.

Review URL: https://chromiumcodereview.appspot.com/22657003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216872 0039d316-1c4b-4281-b951-d872f2087c98

Added in a fix for the memory leak.

Move ExtensionError class to extensions/browser/, since it doesn't need to be in chrome/.
Limit the number of errors stored per extension to 100.
Store errors in a map, keyed by Extension ID, since that is how we will likely be accessing them.

BUG=21734

Review URL: https://chromiumcodereview.appspot.com/22647007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216871 0039d316-1c4b-4281-b951-d872f2087c98

BUG=157660

Review URL: https://chromiumcodereview.appspot.com/22626003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216870 0039d316-1c4b-4281-b951-d872f2087c98

Talkgadget can redirect the user to other subdomains, and our content script won't run over the intermediate 302 pages, only the final URL - so we can't assume that the actual redirect URI we'll receive will match the one we asked for. Note that there is still an implicit restriction that this must be a talkgadget subdomain (since that's our content script's url glob).

BUG=

Review URL: https://chromiumcodereview.appspot.com/22611008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216869 0039d316-1c4b-4281-b951-d872f2087c98

This merges and reimplements what was the GlobalHistoryMenu class from
the GTK+ port into linux_aura's GlobalMenuBarX11 class.

BUG=265560

Review URL: https://chromiumcodereview.appspot.com/22562005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216868 0039d316-1c4b-4281-b951-d872f2087c98

BUG=271056

Review URL: https://chromiumcodereview.appspot.com/22763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216867 0039d316-1c4b-4281-b951-d872f2087c98

BUG=235217
TEST=visual

Review URL: https://chromiumcodereview.appspot.com/22715006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216866 0039d316-1c4b-4281-b951-d872f2087c98

Overflow Button updated to use Rotated image on side shelf.
Overflow Button background changed to match app list background in alternate shelf layout.

BUG=265661, 265662, 163000

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216531

Review URL: https://chromiumcodereview.appspot.com/22527003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216865 0039d316-1c4b-4281-b951-d872f2087c98

Make StreamTextureFactory and StreamTextureProxy abstract
base classes, and create a stub StreamTextureFactory for
Android Webview using synchronous compositor.

This provides enough plumbing to make full screen video
work in Android WebView. In-page video still requires
the in-process context to support streaming texture
manager.

BUG=239760

Review URL: https://chromiumcodereview.appspot.com/22766004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216864 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://chromiumcodereview.appspot.com/22763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216863 0039d316-1c4b-4281-b951-d872f2087c98

BUG=270342
TEST=On ChromeOS and Android, PDF downloads should not trigger the "is
dangerous" warning.

Review URL: https://chromiumcodereview.appspot.com/22761003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216862 0039d316-1c4b-4281-b951-d872f2087c98

This patch fixes naming of member variables (s/mVariable/sVariable) and lowers
visibility of some members in ChildProcessLauncher.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/22735002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216861 0039d316-1c4b-4281-b951-d872f2087c98