- 25 Sep, 2019 40 commits
-
-
Toni Barzic authored
During app list drag, the app list background shield is gradually translated up so it ends up with rounded corners above the display in the full screen state. The translation is currently applied during drag between peeking and fullscreen state. Given that kHalf state (i.e. extended peeking state for search results UI) is above peeking state, starting drag from kHalf state would immediately apply non-identity transform on the background shield, causing the app list view to jump up. This CL changes the starting height at which the background shield starts getting translated up at the larger, kHalf height, thus avoiding the background shield jump when drag starts. BUG=None Change-Id: I47ea834f87cfd2836058a91954a7aad5bda36a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824077 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#699646}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fc604aa990d5..84004c441c75 git log fc604aa990d5..84004c441c75 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f24b5ede..b3fb292c (699513:699622) Created with: gclient setdep -r src/third_party/webrtc@84004c441c75 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ic41dd456a39dab588a775415f190abbf1a111266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824613Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699645}
-
Chris Blume authored
This CL runs pixel_skia_gold_test on the 'Android FYI SkiaRenderer GL (Nexus 5X)' bot with SkiaRenderer, the GLES backend, and OOP rasterization. Bug: 969855 Change-Id: Icde25c694e22c89e2547def673340607afc897b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786871 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#699644}
-
Peter Kotwicz authored
This CL: - Adds UKM recording for WebAPK.Uninstall In particular: - recording how long a WebAPK has been installed - recording how many times a WebAPK which has been uninstalled has been launched. - Changes WebappDataStorage#updateFromShortcutIntent() to take in WebappInfo as input instead of an intent - Adds new fields to WebappDataStorage: - Web Manifest URL - WebAPK version code - WebAPK install timestamp - WebAPK uninstall timestamp - Removes now unused macless webapp shortcut intent creation Privacy doc: https://docs.google.com/document/d/10m4NwkTFVjQ7uboJP9rUQM0Yh7ULD6dVvGlL3eQtD3g/edit?usp=sharing BUG=982362 TEST=WebappDataStorageTest.testWebApkInfoUpdate NOPRESUBMIT=true (To surpress new function ordering requirements) Change-Id: Ie47ef125f6bc60d5fad7f58597d09b4a41648982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781664 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:Theresa <twellington@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#699643}
-
Giovanni Ortuño Urquidi authored
This reverts commit a40589ab. Reason for revert: The flag is used for testing new versions of QuickOffice. Removing the flag makes testing harder. Original change's description: > flags: remove disable-office-editing-component-app > > Bug: None > Change-Id: I2cc23a37cc16724e0056aaec13363483f5d3934e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582230 > Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#654013} Bug: None Change-Id: I89c2c857b1aea5e2d08ea7161cc570b9feb11d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824299 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#699642}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2137f90b9d98..3731bd7ab054 git log 2137f90b9d98..3731bd7ab054 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e3a5983705da..cc3f09861685 (5 commits) Created with: gclient setdep -r src/third_party/skia@3731bd7ab054 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: chromium:None Change-Id: Ia2618af5e6a8b5da160e04b952cd6034c8ee6b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824184Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3232fd81..942786e2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icd7bafc70831ac5b9ecc765edcaa39f338bc5991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823905Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699640}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b079ab860152..6730faf618f8 git log b079ab860152..6730faf618f8 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 ntfschr@google.com Devil: document python3 work and fix CONTRIBUTING link Created with: gclient setdep -r src/third_party/catapult@6730faf618f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:1007101 Change-Id: I75c8a2a9a8d20f38dc0e535e66e8cc9509975cf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823807Reviewed-by:
-
Kunihiko Sakamoto authored
We already use version b3 in the tests. Change-Id: Iadcf6b0a1057d6af01884f524ece0394bf244625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824499 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Auto-Submit: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#699638}
-
Alex Keng authored
This CL implements new looks for <input type=range>, <meter>, and <progress>. NativeThemeAura::PaintProgressBar is added for <progress>. New css rules are added in controls_refresh.css for <meter>. NativeThemeAura::PaintSliderTrack is updated for <input type=range>. Several constants (ex width/radius) are updated per design and cleaned up. AlignSliderTrack is updated to use float instead of int to better align the thumb and the track. The high contrast test, range.html, is replaced with range_meter_progress.html to better visualize the three related controls. Note for some reason NativeThemeAura::PaintProgressBar is not called in webtest mode when ForcedColors flag is enabled (The progress bar in range_meter_progress-expected.png shows some old rendering) The issue will be addressed in a separate CL. Bug: 1001563 Change-Id: I9e6da39caf86c2b12187f5c56e0ef99989e3c0f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817151Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alex Keng <shihken@microsoft.com> Cr-Commit-Position: refs/heads/master@{#699637}
-
Anand K. Mistry authored
This causes the input and dropdown text elements to be aligned together. BUG=977313 Change-Id: I5eca12ab5a5f2b600a1e419309f68d0c1ccc6bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819093 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#699636}
-
Jan Scheffler authored
This patch adds a createTextLink method to create text links and uses it in the security > origin view to link to the network pane. It also adds "show more" and "show less" classes for to the text link. Bug: chromium:977423 Change-Id: If5ff95e5d26af3a20680e93e23e110b912a41de4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789531 Commit-Queue: Jan Scheffler <janscheffler@google.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#699635}
-
Mohamed Amir Yosef authored
No need to pass the complete PasswordForm since it's already stored in the password manager. TBR=vasilii@chromium.org Change-Id: I7eb41dc2db89e2c223198e5666f7fdad75395a3a Bug: 949519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821357 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#699634}
-
Jay Harris authored
Enables file handling in non-extension based web apps. Bug: 938103 Change-Id: I2610e5712c556f03104c95d27a06cfd137b801db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824525Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#699633}
-
John Z Wu authored
Change-Id: Id5d181754a143a2688b63812842d719cb12bc9c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817022Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#699632}
-
John Z Wu authored
Change-Id: I37c0dfe768d60b4306c0c1745517936425047ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817291Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8b16ac056b1a..edb189d40cb2 git log 8b16ac056b1a..edb189d40cb2 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 seanabraham@chromium.org Add jrosenth to chromite OWNERS Created with: gclient setdep -r src/third_party/chromite@edb189d40cb2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I3b08858cc662092e97df400a879450b1fac2572f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824677Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium d077f984. With Chromium commits locally applied on WPT: d4ca0e6e "Add missing worklet referrer tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I27b07c71fc3e8f9c70af132145d3c1df13ac6424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823632Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699629}
-
Hiroki Nakagawa authored
Bug: 1007616 Change-Id: I8f9d11ec78dd43210b3b3d5293f0b69b1a992fad Tbr: nhiroki@chromium.org Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824526Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#699628}
-
Malay Keshav authored
Fragment shader was never initialized in case of StreamVideoQuads thus resulting in them never having a rounded corner. This patch initializes the shader with the correct parameters and fixes the issue. This also fixes direct composition which does not support rounded corners. pixel tests. Bug: 999678 TEST: Manually tested on android with repro steps on bug and added gpu Change-Id: I49767b3f3feeb016f0e39baed1ebe10db1cb24a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812357 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#699627}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/92a0888e..3232fd81 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic441ff4fed5c0a2490581f64bc8146aa33762351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823635Reviewed-by:
-
rajendrant authored
This is a first pass of removal of client and sever LoFi code in blink LoFi feature is deprecated now. Bug: 998691, 944286 Change-Id: Iadeb1ed215de45cf3ee86bc917a847656b88a77c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777051 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#699625}
-
Darren Shen authored
For some reason we use unique_ptr to store CandidateWindow. There's not much benefit apart from saving 1 ptr size. Bug: 1005619 Change-Id: Icd0305135257af3762f67798ab3b04d64c9aa2ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815806 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#699624}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/273175cdf44e..ba04be8c9ef9 git log 273175cdf44e..ba04be8c9ef9 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 jmadill@chromium.org GN: Refactor angle_test and remove angle_test_main. Created with: gclient setdep -r src/third_party/angle@ba04be8c9ef9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: I5ae964663c1bdc0d990eaa96acda277694a79a07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824283Reviewed-by:
-
Michael Thiessen authored
No functional changes intended, please revert if things break. This function is a large, and hard to follow. I'm hoping to break out a bunch of functions that are clearer about what they're doing and make ordering clearer. Bug: 1006927 Change-Id: I46815dd4f160f512c7abc13396b511d01faf18b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819820Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#699622}
-
Xianzhu Wang authored
SkPaint::drawTextBlob applies alpha on each individual glyph, so we should keep SaveAlphaLayer to ensure the alpha is applied atomically on the whole text blob. Bug: 1006140 Change-Id: I8b1d1868a3423ed4f0ef6541cc8db354773dfb24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821944 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#699621}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7628361f558a..a130294887fc Created with: gclient setdep -r src-internal@a130294887fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I452bac5f020efb125c948b4646b0b47fa8ad9946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824285Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699620}
-
nancy authored
Crostini could generate a shelf id with the prefix 'crostini:', and use this shelf id as the app_id, which couldn't match to an app in AppService. Therefore AppService loads an empty icon. This CL checks the prefix, and if it is a Crostini app, sets the resource_id as the invalid resourceId, so that AppService can load the default penguin icon as the expectation. BUG=1006121 Change-Id: I08e4a21e4cf7119170e5c2eeb6d410020559af7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820923Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#699619}
-
Adam Rice authored
Simplify writing tests that verify promise behaviour by adding a ScriptPromiseTester helper class. Use the new class in transform_stream_test.cc and cache_test.cc to prove the concept. Change-Id: I52f525506c34d0f38f9627b964bfbfe823ee9e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789206 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#699618}
-
Gang Wu authored
There are 3 parts to make "removing suggestions from clipboard" works. 1. when create Match In ClipboardProvider, set |deletable| to true. This part makes long-press on the match can pop up delete dialog. 2. delete the match from matches in ClipboardProvider This part will remove the suggestion from suggestion list. 3. delete the suggestion from system clipboard. Bug: 998932 Change-Id: I5c55f1de6fe80e5f40f1181c504a4b1e536b4ec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775439 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#699617}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e78a5c860aa4..2137f90b9d98 git log e78a5c860aa4..2137f90b9d98 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@2137f90b9d98 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: None Change-Id: I2af9bf2fd045e6f34b5a3ffe820a629de32ff6b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824284Reviewed-by:
-
Brandon Wylie authored
This will allow for reuse for related functionality. Bug: 1001839 Change-Id: I4d14866e453294a4cf911dee0f3ac72eb0c56346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814459 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#699615}
-
Brandon Wylie authored
There's no static way to determine if the user is currently in an incognito tab, so it's necessary to take this information as an argument. Bug: 986585 Change-Id: Ib910c4cdf59f008740b59cd09265bb9211e70836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814622 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
-
Alex Danilo authored
Removes all the background image CSS based on the data-category attribute. Adds a listener for attribute changes which is used to set the 'iron-icon' on the embedded 'cr-icon-button' element when the 'data-category' value is changed. Note, 'data-category' of 'pause' was unused, and so, the attribute changed listener handles only the values that are used for icons, amely: 'cancel', 'expand' and 'collapse'. Bug: 1007593 Change-Id: Ic22631df6d7309cabe679ba1b2cca65effceab9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824040Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#699613}
-
Julie Jeongeun Kim authored
This CL converts WebCachePtr and WebCacheRequest to new Mojo types using Remote, ReceiverSet and PendingReceiver. Bug: 955171 Change-Id: Ie26db230a04880aca1fe6be076ae43ae01dfc492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818881Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#699612}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I9755b9e01f3afb1cb7257d05dabf209084eedfe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824282Reviewed-by:
-
Emircan Uysaler authored
vkGetDeviceQueue2 is the prefferred way to pass flags to queue creation. Bug: 982922 Change-Id: I6320c17b5b9d345b3d4a312f0b91c09618bfdb73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817098Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#699610}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6bb573380e0c..b079ab860152 git log 6bb573380e0c..b079ab860152 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 dberris@chromium.org Pinpoint: Query failovers not supported in transactions Created with: gclient setdep -r src/third_party/catapult@b079ab860152 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:1006888 Change-Id: I412d900850666d5ce3bdf626e56e250ff93ded7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824281Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I51308e06b84dcacd4e4f095f78e0f9240ebb1a67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824541Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699608}
-
rajendrant authored
These record http scheme specific histograms and are not neeed. Bug: 673609 Change-Id: I3351fe9b2432cd27f9111d104e26dbf6b443b105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817327Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#699607}
-
