- 12 Aug, 2020 40 commits
-
-
Yi Gu authored
We no longer report after crrev.com/c/2097041. This patch resumes the reporting logic. Bug: 1107590 Change-Id: I9dd8d30a91f48077694a6a3d054f36aa9b259868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350093Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Sam Goto <goto@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#797214}
-
Mason Freed authored
I have run into this twice myself, and I always end up reading the comments next to VLOG() to remind myself what I'm missing. They don't clue you in to the fact that VLOG() statements require enable-logging=stderr or they won't be seen. Change-Id: I8d00da46bf1555e0d6f5728cdc258f1ce36e3d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346927 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#797213}
-
David Bienvenu authored
Miscellaneous cleanup, no functional changes. Change-Id: I45b63c7f9a71e9166ed0178f119aeb1a9f7311e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350839 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#797212}
-
Stepan Khapugin authored
Adds support for scribble in fakebox. For this, an indirect scribble interaction is added to the fakebox. This interaction delays focusing, which allows users to write without the fakebox jumping away. Then it forwards the scribble events to the omnibox. Adds a ton of plumbing to connect the fakebox and the omnibox. Bug: 1098342 Change-Id: I3a5783218b5a25dc8146f53252e50348ac1886d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340978 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#797211}
-
Aaron Tagliaboschi authored
Bug: 955620 Change-Id: I2572a1b33f0ea6371b65f9e74fab0fe182e11244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351548Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#797210}
-
Sahel Sharify authored
This cl throws a range error when extra payment methods are specified along with "secure-payment-confirmation". Change-Id: I68b321a123fb9df8d61f733f1c6e81f024e21d61 Bug: 1110320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340670Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#797209}
-
Gauthier Ambard authored
This CL removes/rename/reorder methods of the TabGridCoordinator. Bug: none Change-Id: I2358a26519604d71657f5411ea5e45ec49f43a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346272 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#797208}
-
Gauthier Ambard authored
The protocol was here for compatibility reason with the old TabSwitcher. This CL removes it and moves its methods in the TabGridCoordinator and rename its methods. It also renames its delegate to TabGridCoordinatorDelegate. It removes the parameter id<TabSwitcher> when it is no longer necessary. It removes the reference to ViewControllerSwapping. Bug: none Change-Id: I4d4504d51f0c7560a13296613dfd72ba68aa116c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339974 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
-
Harald Alvestrand authored
This adapts Chromium to the changes introduced by https://webrtc-review.googlesource.com/c/src/+/180580, and exposes the stop() method behind a flag. Intent to implement and ship thread: https://groups.google.com/a/chromium.org/g/blink-dev/c/dAeG7K7HPG8 Bug: chromium:980879 Change-Id: Iea33c0b915b5ee6ce5cab10ce98f9b906d7d9e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344605 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#797206}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/37f547456cc6..1aff02d44478 2020-08-12 cwallez@chromium.org Small nits for the implementation of WriteTexture in D3D12 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I92a4f047f71db6bdc3572d24ec7547ff2b1e662f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351150Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797205}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/347e854b..689a3a9b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic799e0d8732fed2fa24eb665e0be9eb60e62a548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350049Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797204}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2c4fc0c32598..ebc115d9852c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC beverloo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:897470 Tbr: beverloo@google.com Change-Id: I93f0238a9a5d49bb595b768c878eb166ad7e043e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352031Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797203}
-
Takuto Ikuta authored
This is to fix base_unittests failure in swarming dev builder. https://luci-milo-dev.appspot.com/p/chromium/builders/ci/linux-rel-swarming e.g. https://luci-milo-dev.appspot.com/p/chromium/builders/ci/linux-rel-swarming/6379 I guess 2 core vm does not have sufficient memory for the failed test. AddressPoolManagerTest.ManyPages Change-Id: Ie34fb3492cb96f3876b04db89bbd0a272537b7b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351261Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#797202}
-
Sebastien Lalancette authored
Bug: 1093302 Change-Id: I6789ba847d77283c7e4ca94046047b339e0bf918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348531 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
This is a partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/1881691 , which made it so that only objects that have a fixed size would be allowed to be relayout boundaries, because we'd have correctness issues in LayoutNG otherwise. However, it turns out that this caused performance regressions. So revert this, and instead make sure that starting layout at a non-fixed-size object works, if ObjectIsRelayoutBoundary() has determined that it's otherwise a suitable relayout boundary. Bug: 1058704 Change-Id: I570fb71141019f5f8b5d007fbdfffd056783c3c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100773Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#797200}
-
Renato Silva authored
Add a11y string for the upcoming PIN field on the login screen. Bug: 1075994 Change-Id: I239add7de17c464191e6b0294e58f615e8a90945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349868 Auto-Submit: Renato Silva <rrsilva@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#797199}
-
Alexey Baskakov authored
These are follow up unit tests for this diff: https://chromium-review.googlesource.com/c/chromium/src/+/2237542/13/chrome/browser/web_applications/components/web_app_url_loader.cc The change was: 1) Let's load about:blank page before each WebAppInstallTask to reset the renderer process. It gives us that pseudo-Reset API with a guaranteed completion callback. 2) Let's use about:blank url as a special barrier in WebAppUrlLoader: if WebAppUrlLoader awaits on about:blank loading, it should flush (skip) all noisy DidFinishLoading and DidFailLoading events. Note that these tests are complementary to existing browser tests in web_app_url_loader_browsertest.cc. However, we need low-level unit test environment to reproduce flakiness for DidFinishLoading and DidFailLoading events (unit tests give us that level of detail and control) Bug: 1086778 Change-Id: I77ff72ac55fa227b3bc4af97da8062e8c445bfe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320395 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#797198}
-
Hiroshige Hayashizaki authored
Bug: 1111134 Change-Id: I89c6b229c8871814faabadd08e3963adbe66e53e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348239Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#797197}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7e7cae79f10a..9ca6a7f44301 2020-08-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 23335ac01cb8 to d667ad2f0127 (12 revisions) 2020-08-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from cbec3179ef87 to 37f547456cc6 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Test: Test: Test: Capture application frames using triggerTest: Test: angle_perftests --gtest_filter=TracePerfTest.Run/*mobile*Test: Test: angle_perftests, *vulkan_null_index_buffer_changed_ushortTest: Test: run_angle_perftests --gtest_filter=TracePerfTest.Run/vulkan_angry*:*vulkan_candy* --verbose --local-output Change-Id: Ic7756d4e1cc5e77b9b815249759ad897c68f0cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351866Reviewed-by:
-
Hirokazu Honda authored
Bug: None Test: None Change-Id: I252ce0b7eb284ff1ca34a47191dd12f0a81ddcc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350720 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#797195}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d667ad2f0127..9c37bbd3e5eb 2020-08-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 59b4828f293e to 13f04d59c727 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I7b0061a4617d24d6e5373e3ae71909f33e30e838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351149Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/65eb98d6ed3a..4de6cfa5a936 2020-08-12 cwallez@chromium.org Remove use_relative_hooks now that all deprecated uses are removed. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1107325 Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: Ic2b637db765197be7ba2730be693684d5fd1d9ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352030Reviewed-by:
-
Karandeep Bhatia authored
core/script and platform/loader/fetch. This is part of the work to enforce isolated world CSP for resource requests when the feature IsolatedWorldCSP is enabled and to correctly bypass the main world CSP otherwise. Note that it's possible that the plumbed DOMWrapperWorld might not always be completely correct (for example if it is plumbed asynchronously from the point which caused the resource request). However this is still better than the status quo where the CSP checks for isolated worlds are bypassed based on calling FrameFetchContext::ShouldBypassMainWorldCSP() which is often incorrect especially for redirects since we might be in a different different world by then. Further CLs will ensure the DOMWrapperWorld is plumbed for all ResourceLoaderOptions object. BUG=1099975 Change-Id: Idc902e8c6c2c8ee5e5a97ca58189a8b9476eab4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341413Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#797192}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0377420e4c71..f28c31d179b8 2020-08-12 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-08-12 alexrudenko@chromium.org Remove global grid settings and update the overlay when settings change 2020-08-12 szuend@chromium.org [ts] Type-check ui/ActionRegistry.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1109177 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib98d6ed289d1acc5c65cc5f94baf56cb739a4634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351856Reviewed-by:
-
Yuki Shiino authored
Ports https://crrev.com/c/2346569 to the new bindings generator. Bug: 839839 Change-Id: I922037afa279ac24f909e1655f3a24d80e9f9451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351482 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#797190}
-
Viktor Semeniuk authored
This change fixes crashes when editing/deletion confirmation alerts are displayed. Bug: 1115052, 1112344 Change-Id: I3bbd31c4d37d5036655c51a3caba4de464fb9b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351783Reviewed-by:
-
sauski authored
Extend the expiry of the flag used to force a HaTS Survey for demo/test purposes. Bug: 1110888 Change-Id: I4e7d02d6ea30a449707ff862b388c0d0bf09dd57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351829Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#797188}
-
Jit Yao Yap authored
Sync server-side changes from cl/324954160 and cl/325736815. Change-Id: I4bb71feaa8f9f9d12ecf26f0ae11afa8a502c601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344465Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#797187}
-
Nohemi Fernandez authored
Scenes cannot properly unregister their observers and tear down UI until they are in the unattached scene state. We force this state on all remaining connected scenes when the app is terminated to ensure we have a proper scene state cleanup. Bug: 1103834 Change-Id: I170177c9feb28ce5b88b495012795670ccfb1b91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346273 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
-
Nektarios Paisios authored
The text length of an abstract inline text box was sometimes reported as one character short because the trailing white space was not included, whilst it was included in the actual text. Similarly, the character widths did not include the width of any trailing white space. Also simplified the calculation of OffsetInContainer by using some existing helper methods in Layout NG and improved tests. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: Ia5af8a475c028ecc1980b7cbe12695807164824d Bug: 1008031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346289Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Sreeja Kamishetty authored
This CL disables the failing browser_tests with BackForwardCache and updates the filter. Bug: 1100315 Change-Id: I1f3af955b56b2d2eb91f793fe3c7c25826618ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273499Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#797184}
-
Peter Marshall authored
Change-Id: I043320f32a61676ee5c61524cf4a23fc3c65321d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324382Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#797183}
-
Side Yilmaz authored
This CL replaces deprecated functions of IdentityServicesProvider with the newer service getters with profile parameter.This CL passes |Profile#getLastUsedRegularProfile| to |getIdentityManager| function in GSAState class. Note: This is only clean-up and does not change any code behaviour. Bug: 1041781, 1075562 Change-Id: I42735354d1fa648361452d54e384b673b84aac17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339970Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#797182}
-
Yngve N. Pettersen authored
center channel, but instead mixed into the Left and Right channel, like Mozilla Firefox. Bug: 1112809 Change-Id: I3b3fe53249942ac3884d145bc888decbfcc69e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339672Reviewed-by:
-
Renato Silva authored
Improve padding mechanism in LoginAuthUserView and add smart card option to login screen debug tool. Remove an extra container that used to host the password view and replace it with a fade animation for the smart card view. Bug: 1075994 Change-Id: I102a39a327e05935b67a8f8bfec53e9271cb4285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343110Reviewed-by:
-
David Jean authored
Bug: 1108308 Change-Id: I1c0d7db1d5451f893736a9c59c9ec7a5b3b5edbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351776Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#797179}
-
Austin Tankiang authored
The pinning related actions change depending on whether the entry is pinned or not, which can change externally from the ActionsModel. So, invalidate ActionsModels for Drive entries when pinned state changes. Also remove destroy() as it is never used. Bug: 1096920 Change-Id: Iaafc87bd38035f548cd403eda1ee7014360595e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342524Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#797178}
-
Noel Gordon authored
This reverts commit f29d2ae1. Reason for revert: speculative revert. Suspect this change caused crbug.com/1115411 Original change's description: > Change HeapObserverList to HeapObserverSet > > The previous CL for HeapObserverList https://crrev.com/c/2060348 > addressed two things: changing HeapObserverList to HeapObserverSet and > allowing removal while iteration, and was reverted for performance > reasons. This CL only does the former and avoids performance > implications of the latter. > > This CL is for migration of NewLinkedHashSet. > See: https://crrev.com/c/2134039 > > Bug: 1100257 > Change-Id: I2426d14d77a68f200bf1398b16638e1605dd4ff1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319087 > Commit-Queue: Yuki Yamada <yukiy@chromium.org> > Reviewed-by: Keishi Hattori <keishi@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Bartek Nowierski <bartekn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797115} TBR=haraken@chromium.org,keishi@chromium.org,yukiy@chromium.org,bartekn@chromium.org Change-Id: I7e577184e145135f42979ae05d2c6e4aaa7d0803 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1100257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352130Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#797177}
-
Yunke Zhou authored
Add browser test to verify behavior for back button on the gaia screen when kChildSpecificSignin feature is enabled. Bug: 1101318 Change-Id: Ibaff1cf629520b3fbbe8cd620d8727bd35922295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343068 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8e1380996d6a..13a65b1aee42 2020-08-11 alanbaker@google.com Only validation locations for appropriate execution models (#3656) 2020-08-11 andreperezmaselco.developer@gmail.com spirv-fuzz: Fix in operand type assertion (#3666) 2020-08-11 andreperezmaselco.developer@gmail.com spirv-opt: Add spvOpcodeIsAccessChain (#3682) 2020-08-11 vasniktel@gmail.com spirv-fuzz: FuzzerPassPropagateInstructionsUp (#3478) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: Ic4b47cb923d7bb3dad5bc89bf0b77f2486747adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351868Reviewed-by:
-
