GitLab

Use float coordinates conversion and remove truncation in
render host.

This CL doesn't expose the fractions to the web
because of truncation in later stages in event pipeline.

Bug: 456625
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I30803bf5eab3b0fbe71abef6eaaf16a468770f15
Reviewed-on: https://chromium-review.googlesource.com/692175
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510094}

https://skia.googlesource.com/skia.git/+log/6fb802e2b2e3..0341f160befa

$ git log 6fb802e2b..0341f160b --date=short --no-merges --format='%ad %ae %s'
2017-10-18 mtklein replace gInited with SkOnce

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=benjaminwagner@chromium.org

Change-Id: Ie7fd1b983ecb29a6145c7ab5d489dce05de231b1
Reviewed-on: https://chromium-review.googlesource.com/728201Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510093}

No functionality change, but commands are ordered as they appear in spec
followed by the commands only in the JSON wire protocol, then the
ChromeDriver only commands

Bug: 
Change-Id: Ib0dbd5775cf91979603e66a0bcb3669a7d4cca51
Reviewed-on: https://chromium-review.googlesource.com/717026
Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510092}

In case of long username, the beginning of value should be visible.

Bug: 770055
Change-Id: I09423d0131e7198de69211a020e38eaff2b7c503
Reviewed-on: https://chromium-review.googlesource.com/728099Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510091}

Pass through the Abort message to the DownloadService for any
outstanding downloads matching the given job_unique_id.

Update abort unit tests to verify that the download successful messages
do not get delivered.

Change-Id: I600a3f102047939d7189dc6d30e9ca88eedf4c04
Bug: 758562
Reviewed-on: https://chromium-review.googlesource.com/723321Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: John Mellor <johnme@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510090}

It is based on the logic in
    string16 InferLabelFromValueAttr(const WebFormControlElement& element)
in chromium/src/components/autofill/content/renderer/form_autofill_util.cc.

Bug: 762970
Change-Id: I5f0c2963111289cf5f043415176624644c58938b
Reviewed-on: https://chromium-review.googlesource.com/721699Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510089}

https://webrtc.googlesource.com/src.git/+log/117c48291cbf..bd83b914c352

$ git log 117c48291..bd83b914c --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I893e6fa091b27d5437f703590c07f50a4e5a7367
Reviewed-on: https://chromium-review.googlesource.com/728200Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510088}

With --enable-viz the host portion of the renderer cannot access
FrameSinkManagerImpl or create CompositorFrameSinkSupports. Update so
that viz doesn't immediately crash.

The --enable-viz flag should work for basic websites on Linux desktop
Chrome now. OOPIF and PDF Viewer are not implemented however.

Bug: 770833, 732903
Change-Id: I373e02a221361b362f0eb35cc91d7d1a6b7c73a5
Reviewed-on: https://chromium-review.googlesource.com/724222
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510087}

Bug: 776125
Change-Id: I4f5e788dccd9aca77ad58c45db75027f5288a629
Reviewed-on: https://chromium-review.googlesource.com/727075
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510086}

This change:
1) Migrates the existing long title strings to corresponding message strings
2) Adds new short title strings
3) Adds titlecase variants for titles that did not previously have them

Bug: 700196
Change-Id: I2f1373fabeeb4e9ad946374c2f00a3fe46904ccf
Reviewed-on: https://chromium-review.googlesource.com/723939
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510085}

- Add modules.
- Misc additions to the dictionary (based on the coverage report).
- Pass the command line flags to V8 (for debugging purposes).

Bug: 
Change-Id: Ic0777906cbfd86f1c551df33b7af95e0a5a26b0f
Reviewed-on: https://chromium-review.googlesource.com/727806Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Commit-Queue: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510084}

The content of the toolbar needs to respect the safe area. This CL
fixes the content displayed outside of the safe area by creating a
contentView respecting the safe area boundaries.
The content is added to this view instead of the ToolbarView.

This also makes the back menu dropdown to be displayed inside the safe
area.
It also dismisses it during device rotation.

Bug: 765304, 776340, 764877
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia4f5b8499644b0b406a94a723bde1a6d80928cd0
Reviewed-on: https://chromium-review.googlesource.com/727890
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510083}

https://chromium.googlesource.com/catapult.git/+log/b9501ea73c6c..2713d6d5f30d

$ git log b9501ea73..2713d6d5f --date=short --no-merges --format='%ad %ae %s'
2017-10-19 perezju [Telemetry] Log output from commands sent to TsProxy

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ic95fe55ccdd85c97bf7b59b0f63c79bb0d98bd76
Reviewed-on: https://chromium-review.googlesource.com/726827
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510082}

This mirrors the existing Blink feature flag, in order to support runtime
experiments with this feature.

Bug: 557466
Change-Id: Ifa74a5ac15b35474bda14abca9aea40755f48c5c
Reviewed-on: https://chromium-review.googlesource.com/642966
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510081}

The pages returning a 404 http status should not be displayed as Most
Visited tiles on the NTP.
This CL fixes it by checking the status code.

Bug: 773792
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5381a36bc66b675acc4bc3a9b2fa703dc8d6f0ee
Reviewed-on: https://chromium-review.googlesource.com/725294
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510080}

Add a timer to let the CRWCertVerificationController finish tasks.
This is a workaround crbug.com/776330.

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ide3f3b38a1e981db9b2c42a053e1caaae13c1348
Reviewed-on: https://chromium-review.googlesource.com/728100Reviewed-by: Eric Noyau <noyau@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510079}

scoped_refptr is allowed in Blink now, and WTF::RefPtr is an alias of
scoped_refptr for migration. This CL inlines the alias to the RefPtr
users in core/loader to remove RefPtr.

Bug: 763844
Change-Id: Ifc46f2984639ab3f6a9d5ea3c248e28b10f65f71
Reviewed-on: https://chromium-review.googlesource.com/727501Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510078}

This CL adds sanity checks in the creation of gfx::ColorSpace 
from a monitor's EDID. The checks are: making sure that the 
primaries are correctly located relative to each other, and that
the area covered by the triangle of primaries is not too small.

This CL also adds a wacky EDID to the drm_util_unittest.cc, 
which primaries can be seen painted on a CIE chromaticity 
diagram in [1], and uses it to test the new sanity checks.

The "sanity checks" are implemented at the drm_util level because
technically speaking the EDID parsing succeeds.

[1] https://i.imgur.com/JYk2rVG.png (or https://imgur.com/a/F7Bvo)

Bug: 771345
Change-Id: Ia7c85f409383f340cc9deb4633d2a9bd8085ccab
Reviewed-on: https://chromium-review.googlesource.com/723164
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510077}

The VizProcessTransportFactory is a replacement for
GpuProcessTransportFactory for viz mode. In this mode the display
compositor runs in the viz process instead of browser process.

The --enable-viz flag won't work yet since there are changes required in
content/browser/renderer_host that still need to land.

TBR: mpearson@chromium.org
Bug: 770833, 732900
Change-Id: I0aaf9ef369366838e2335447358fd6dfaaa5bf0a
Reviewed-on: https://chromium-review.googlesource.com/703274
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510076}

scoped_refptr is allowed in Blink now, and WTF::RefPtr is an alias of
scoped_refptr for migration. This CL inlines the alias to the RefPtr
users in core/html to remove RefPtr.

Bug: 763844
Change-Id: I66a4c246afce9800028427adef60f4a6e9cd429d
Reviewed-on: https://chromium-review.googlesource.com/727601Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510075}

Reason: flaky

TBR=zea@chromium.org

Bug: 776251
Change-Id: I82c27e2a9586fb9560a03ed9d2f823020c7a55e0
Reviewed-on: https://chromium-review.googlesource.com/728220Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510074}

In this CL, we change reset mouse states in mouse move to
not do MouseReleaseEventUpdateStates, but only ClearDragHeuristicState.
The reason is:
1. click_count_ & click_element_ are set from WebMouseEvent on mousePress.
It won't be incorrect even if we do not receive the MouseUp.
2. On Mac(with software like BBT that trap events), event queue might
got incorrect: a MouseMove with no button down is received&handled
before MouseUp. Therefore click event will not fire since we did the
InvalidateClick() on MouseMove.

This fix won't break crbug.com/527582

Bug: 763642
Change-Id: Ic278412281ba177a23b1a5fffeaa62ae123cc71d
Reviewed-on: https://chromium-review.googlesource.com/726962
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510073}

latency_info.source_event_type for fake KeyUp event
should be OTHER instead of KEYPRESS.

Bug: 772505
Change-Id: Ie43e31426e345f427f0eeb9863fbd0449c1c67dc
Reviewed-on: https://chromium-review.googlesource.com/727370Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510072}

In the current ChromeTabbedActivity to FullscreenActivity transition we
detach the Tab from the CTA then launch the FA which reattaches the Tab.
Since Activity creation takes time, the user gets a glimpse of a second
Tab before the FA opens with the fullscreen Tab.

Here we change the flow so the Tab is only detached and reattached once
the FA has started.

Bug: 757878, 758116
Change-Id: I8cd4afe80ff053ae2bf0bc89454a286429330440
Reviewed-on: https://chromium-review.googlesource.com/632686
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510071}

This should be called when a cleanup ends in a reboot required state
and the Settings page is not the current active tab.

Bug: 770749
Change-Id: I3e81cc52e4973b767ce375647331dc51ae925d69
Reviewed-on: https://chromium-review.googlesource.com/695754
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Reviewed-by: Ali Tofigh <alito@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510070}

When the NTP will appear, the layout needs to be invalidated. It ensures
that the insets for the Most Visited section are correct when the device
is rotated while another screen (e.g. settings) is presented in front of
the NTP.

Bug: 771149
Change-Id: If8c926fbb0e5cca860b31c4ccc7b672fe49b9e80
Reviewed-on: https://chromium-review.googlesource.com/726082Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510069}

TBR=dpranke@chromium.org

Bug: webrtc:8363
Change-Id: I4dd6d686e901fa0b050cc0e0d15e1c89a357891b
Reviewed-on: https://chromium-review.googlesource.com/706790Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510068}

I removed the test parameter a while back but didn't see this comment.

Bug: 
Change-Id: Ib916240cf10ca0f8b589e8aa9d1b32a4a4a03889
Reviewed-on: https://chromium-review.googlesource.com/727820Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510067}

This reverts commit 0b789948.

Reason for revert: breaks Linux ChromiumOS Tests.

Bug: 776308

Original change's description:
> Reland: Fire focus if needed in automation api
> 
> TBR=dtseng@chromium.org
> Bug: 773866
> 
> Original change
> 
> Reviewed-on: https://chromium-review.googlesource.com/723606
> Commit-Queue: David Tseng <dtseng@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#509911}
> Change-Id: I74c39f7d8372b623a827dff89cc20b25f6485a2f
> Reviewed-on: https://chromium-review.googlesource.com/727122
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#510006}

TBR=dmazzoni@chromium.org,dtseng@chromium.org

Change-Id: I9025ec011491530ec70cf0c1a0e33bdfec32c512
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 773866
Reviewed-on: https://chromium-review.googlesource.com/728160Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510066}

The button to close all windows, which appears in the profile chooser 
menu, should be shown even when there is only one window open.
This addresses the comment crbug.com/130656#c49. 
More fixes are coming.

The MacOS version can be found here: crrev.com/c/725426.

Bug: 130656
Change-Id: I90b9c93c9a8452472b1d8dfc89fcf7084987a3a6
Reviewed-on: https://chromium-review.googlesource.com/720360
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510065}

This CL changes WebFrameSchedulerImpl::*TaskRunner() to create
WebTaskRunnerImpl objects anytime so that the relationship between
WebTaskRunnerImpl and TaskQueue will be n:1. This is a preparation to
make WebFrameSchedulerImpl's task runner getters accept task type and
store it inside WebTaskRunnerImpl.

This is part of the big CL that includes all the necessary changes:
https://chromium-review.googlesource.com/c/chromium/src/+/704459

This is a part of adding-task-type work (https://docs.google.com/document/d/1Py2ZdjpaCMdpVtKfdHMITAn5gst_owjQiqlbPm3mCxc/edit?ts=59d49142#)

Bug: 762453
Change-Id: Iae1263717990ea959a2ed62ba86c63ef593be600
Reviewed-on: https://chromium-review.googlesource.com/727420Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510064}

For progress paint timeout values instead of ints.

Change-Id: Ibf1391b3c9871e69ef03859063310f8b5f03b38a
Reviewed-on: https://chromium-review.googlesource.com/727722
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510063}

https://webrtc.googlesource.com/src.git/+log/8a958528b2ca..117c48291cbf

$ git log 8a958528b..117c48291 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I0429718a89130518353842a462bee9bf89cc9974
Reviewed-on: https://chromium-review.googlesource.com/727544Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510062}

This moves scale-handling out into the (now former) consumers of the
ImageResourceContent::ImageSize method.

Bug: 773272
Change-Id: I08760b181a48f8a5dcc5ceff68a19c67eba3601a
Reviewed-on: https://chromium-review.googlesource.com/726087
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510061}

* Remove self-destroying objects in favor of simply binding callbacks
* Make SiteDataDeleteHelper not refouncted anymore
* Don't hold on to JNIEnv

Bug: 766752
Change-Id: Ib85bc88b7118100a4af730c88c86dca489d5d3ed
Reviewed-on: https://chromium-review.googlesource.com/725732Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510060}

This test creates site data entries via javascript and tests that they
are counted and deleted correctly.

Bug: 769425
Change-Id: I81178ade64a5d76fd19ee7e79c6a55c4c5ae32cc
Reviewed-on: https://chromium-review.googlesource.com/725385
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510059}

Since the feature is already launched and we do not need to monitor
performance impact any more, let's remove intervention related metrics.

Bug: 578029
Change-Id: I11f682d3bfcfe5f2bd5ec8d27c355635568489d5
Reviewed-on: https://chromium-review.googlesource.com/722820Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510058}

It seems they were used to make sure users are aware of that the
contents in the String argument must be "output of KURL::GetString()
called on a valid KURL object, or indiscernible from such" as noted in
the comment.

However, these methods are actually performing validation and there's
no fast path assuming the input is valid.

Considering the value of the annotation and additional character typing
in coding, I'd like to propose removal of it.

The constructor invocation in WorkletModuleResponsesMapTest.cpp that is
taking String() (i.e. null String) is replaced with KURL() invocation.

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I40f433e6c1472fba559af9b87ea12cff06d21045
Reviewed-on: https://chromium-review.googlesource.com/718236
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510057}

This reverts commit 38636aa2.

Reason for revert: downstream failure: unable to find chromium-debug.keystore (internal bug: http://crbug.com/776328)

Original change's description:
> Android: Remove last remnants of ANT
> 
> It had a good run.
> 
> Bug: 375324
> Change-Id: I1db1d501f58d3d3ac8731bc36e8ca550da24adf9
> Reviewed-on: https://chromium-review.googlesource.com/722521
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: agrieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#509785}

TBR=thakis@chromium.org,agrieve@chromium.org

Change-Id: I7323c95dcdd47145166d6bbd61345cc17db2e7d7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 375324
Reviewed-on: https://chromium-review.googlesource.com/727902Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510056}

Currently the RequestGlobalDump has an ambiguous dual semantic: return results
or add to the trace. For historical reasons both semantics have been collapsed 
in the same function, but this is now getting too hairy, making the codebase hard
to reason about, and caused some bugs.

Splitting the functions names as they clearly achieve two different functions
with different outcomes, specifically:
When adding the dump to the trace, clients don't care about the returned
object (which also happens to be empty). Likewise when returning the dump
(e.g. for SUMMARY_ONLY) the clients don't care about the dump_guid.

Bug: 775039
Change-Id: Ia0861bcd20775802813a35f5a138fa022521f416
Reviewed-on: https://chromium-review.googlesource.com/721540
Commit-Queue: Lalit Maganti <lalitm@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510055}