- 26 Nov, 2019 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ef4ab7682b6c..fdaba6cf16f3 git log ef4ab7682b6c..fdaba6cf16f3 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 danilchap@webrtc.org Use std::atomic for RefCounter Created with: gclient setdep -r src/third_party/webrtc@fdaba6cf16f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I27aa023934660b7abf97c03d23efd1fe639c630c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936746Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719168}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ae3c27d5c5c3..663dcefa22ea git log ae3c27d5c5c3..663dcefa22ea --date=short --first-parent --format='%ad %ae %s' 2019-11-26 bclayton@google.com Reactor: Work around new MSVC brokenness. 2019-11-26 swiftshader.regress@gmail.com Regres: Update test lists @ f2637d0d Created with: gclient setdep -r src/third_party/swiftshader@663dcefa22ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: If4a7b3a89cbe6124d6d37083376e1ff2015a58a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936548Reviewed-by:
-
Rohit Rao authored
This works around issues where overlapped tabs confuses VoiceOver. BUG=979803 Change-Id: I45f9fafa5b14187cc83ab935a3be385886ff8cb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933729Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#719166}
-
Tim Schumann authored
It's failing a lot on linux-chromeos-dbg TBR=alemate@chromium.org Bug: 1028606 Change-Id: Id0565b1bcaad544d5ef983aeeffb09b8c377afb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936493Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#719165}
-
Robert Sesek authored
Under the V2 sandbox architecture, there is technically nothing that runs "pre-sandbox startup". But we hypothesize that deferring the initialization of VideoToolbox to the first use is leading to hangs, which the watchdog turns into crashes. By forcing initialization at this call site, the GPU watchdog thread is not running, which is what happens under the V1 sandbox architecture. Bug: 871280 Change-Id: I7c1173ecf7752307c19ac15f81e9b1c699d4523b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932166Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#719164}
-
Egor Pasko authored
The bot has been using --new-commit-flow for a while now (see http://crbug.com/908406). Make this the default to later remove and make it less confusingly not new. Bug: 1028600 Change-Id: Iebbb7f5362083155b7c53bdb2da4624b713236bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936494 Auto-Submit: Egor Pasko <pasko@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#719163}
-
Aaron Tagliaboschi authored
Adding changes to client hint lifetimes <https://github.com/httpwg/http-extensions/commit/7d24ea40f02ba791c13e5fd70d6932079abf14cf> under the client hint feature policy flag. Bug: 1017166 Change-Id: Ia4d63777c4a4fcb150d4e854312851105fa0a11b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919953Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#719162}
-
Tao Bai authored
This reverts commit 5347b384. Reason for revert: The downstream has rolled to my change, this patch should be good to go. Original change's description: > Revert "Upstreaming ContentCapture" > > This reverts commit edc475ed. > > Reason for revert: Causes compilation failure: > https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8895755054118235408/+/steps/compile/0/stdout > > ../../clank/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolderForQ.java:26: error: method does not override or implement a method from a supertype > @Override > ^ > > > > Original change's description: > > Upstreaming ContentCapture > > > > Related downstream change: > > https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/2172237 > > > > Binary-Size: all added code was from downstream, the size increase is expected. > > Bug: 951275 > > Change-Id: Ibf56135e2a7d2f437f167dc0cdb7761bce447e86 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922603 > > Reviewed-by: Changwan Ryu <changwan@chromium.org> > > Reviewed-by: Richard Coles <torne@chromium.org> > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > Commit-Queue: Tao Bai <michaelbai@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#718894} > > TBR=michaelbai@chromium.org,dtrainor@chromium.org,torne@chromium.org,changwan@chromium.org > > Change-Id: Id904c28aa48d561ccea36942da1f507982a698dd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 951275 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935578 > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#719031} TBR=michaelbai@chromium.org,yosin@chromium.org,dtrainor@chromium.org,torne@chromium.org,changwan@chromium.org Change-Id: I1aeb6ccb43989d58aa872860d2048b1eff2815ee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 951275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936969Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#719161}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e78d04eb..1da43bc4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic561beb4f0df5f437767b07c1451714019941e06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936847Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719160}
-
Yoav Weiss authored
Resource Timing entries' `workerStart` attribute exposes the time it took for a service worker to get started. In the case of cross-origin iframes, this means that the parent frame becomes aware of whether a child frame has a Service Worker installed. It shouldn't do that without an explicit opt-in from the iframe, in the form of a Timing-Allow-Origin header. Bug: 1026404 Change-Id: Ibf86bc2c4fc2657411dc07515ce1405e5e133766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924520Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#719159}
-
Mihai Sardarescu authored
CoreAccountId objects should not be constructed directly by the clients of the IdentityManager. Instead they should be using the IdentityManager API to create CoreAccountId objects. This CL only allows tests to directly create CoreAccountId objects. Bug: 1028182 Change-Id: I3b893e0d24cacfcc85536e8781cd354e22566cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926501Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#719158}
-
Vladimir Levin authored
This patch removes the published WPT tests for intrinsic-size, since we believe that the feature as it stands isn't as useful as we initially thought. R=chrishtr@chromium.org Change-Id: Ie6cb1ebdd7e36be9cfc039406563ba8c603c37a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934244Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#719157}
-
bungeman authored
https://chromium.googlesource.com/external/github.com/libexpat/libexpat.git/+log/25d3c190c69e..63abbcdb3b74 $ git log 25d3c190c..63abbcdb3 --date=short --no-merges --format='%ad %ae %s' 2019-11-18 bhargava.shastry CMake: Enable oss-fuzz integration 2019-11-17 bhargava.shastry parsebuffer fuzzer: Bail out on empty fuzzer input 2019-11-04 luzpaz Fix source comment typos 2019-10-26 sebastian xmlparse.c: Improve warning regarding lack of high quality entropy (#172) Created with: roll-dep src/third_party/expat/src R=bungeman@chromium.org,dcheng@chromium.org Change-Id: I3601728881f639c6109607993e508ff5eda9a785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931537Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#719156}
-
W. James MacLean authored
Since the test fails even when the embedder WebContents and the iframe for the text area both have focus (in the browser process), then next theory is that focus hasn't had time to propagate to the DOM in some cases. This CL adds a retry mechanism in the JS code that tests for initial focus in the iframe containing the text area. TBR=alexmos@chromium.org Bug: 1024672 Change-Id: I4a35a6e1c7858b207b65d41d954b3e5a618a2af8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935023Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#719155}
-
Andrew Grieve authored
TBR=agrieve # Markdown Change-Id: I83ddd80a0e334470f1752a6d2d9b6a25673322ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927129Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Vasiliy Telezhnikov authored
This CL adds TextureQuads5x5SameTex to viz_perftests to test batching of DrawQuads. It draws 25 simple TextureQuads with the same resource_id so they can be batched in one draw call. Change-Id: I107e6cd8aaddcc67e1fc3afbcf8fe2e60767ace2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936529Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#719153}
-
Andrew Grieve authored
And fix last few warnings that crept it. Bug: 894616 Change-Id: I5d6d43e585c9fff1f0672a7f95b17a0d2e900194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933769 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#719152}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a1cb75450db1..01adcafce0bf Created with: gclient setdep -r src-internal@01adcafce0bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Icf3bc3bf72f51e86fe3650774c24f82e2eb12fdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935939Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719151}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a88655daf934..ef4ab7682b6c git log a88655daf934..ef4ab7682b6c --date=short --first-parent --format='%ad %ae %s' 2019-11-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision bdce3460..65c32b57 (718772:719106) Created with: gclient setdep -r src/third_party/webrtc@ef4ab7682b6c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2d1fa007ef9ed85e350239defb4cbea9bddea952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935942Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d0dd9068ec64..b62621c1dd8e git log d0dd9068ec64..b62621c1dd8e --date=short --first-parent --format='%ad %ae %s' 2019-11-26 tneda@google.com perfetto-ui: Moving heap profile flamegraph to details panel Created with: gclient setdep -r src/third_party/perfetto@b62621c1dd8e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Idf2e710b54627fbdb303fe22556224e701d3de5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935941Reviewed-by:
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=dtapuska@chromium.org Bug: 1023677 Change-Id: I56b64adfb8db9789f58acdc4a210299c32430b5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927002 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#719148}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ab63fd28450a..4cef8a49b49d git log ab63fd28450a..4cef8a49b49d --date=short --first-parent --format='%ad %ae %s' 2019-11-26 lehoangq@gmail.com Metal: Support depthRange near > far Created with: gclient setdep -r src/third_party/angle@4cef8a49b49d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I7e2140478e2ad8c39fe57b4fbde4d83d22b8471d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935210Reviewed-by:
-
Benoît Lizé authored
Bug: 979638 Change-Id: I7ea71dbe79489648fe418f439224a2e2fa11a378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930737 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
-
Greg Thompson authored
This change introduces the //rlz:rlz_lib_no_network source_set for use by Chrome's installer on Windows. This breaks a dependency on a slew of networking pieces that bloat setup.exe. Results from building chrome/installer/setup at r718552: - before: 6536 build targets -- 2,590,720 bytes - after : 2390 build targets -- 2,298,880 bytes - 4,146 fewer build targets (63.43% reduction) - 291,840 bytes smaller (11.26% reduction) BUG=1026780 Change-Id: I99892e6b0b9f730e1467a9af1af55c42ddeb8903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932803Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#719145}
-
Sebastien authored
Created a new DataFilesParser class which wraps the file IO operations, allowing us to mock these calls in unit tests. The file reading operation is kicked-off in a task posted on the thread pool to make sure we're not blocking the calling thread. In this CL, the highlighted game is simply the first game in the catalog. A future CL will update that logic. Bug: 1018201 Change-Id: Ic7bb5795344a7a3b4017587d7041ace77d921b00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928205 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#719144}
-
Kinuko Yasuda authored
Change-Id: Ib180117dea189876c2e095a114277b6e2d1ba6eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935972 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#719143}
-
Mustaq Ahmed authored
User activation state sync across frames didn't previously consider outer-vs-inner WebContents boundary. As a result, a user interaction in an inner WebContents didn't activate any frames in the outer WebContents. This CL minimally completes the notification state propagation from inner to outer WebContents to fix the bug. Bug: 1013447 Change-Id: If06fa2c1c5c431b45219eeb4b75ec8cf93164042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907209Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
-
David Bienvenu authored
This is a partial revert of crrev.com/c/1686222, which changed app model ids to include the default profile name. That caused issues with duplicate taskbar icons, which were worse than the original bug being fixed. Bug: 1007911 Change-Id: I28da312817b4223b7be842acf71e2d14f39711c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934525 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#719141}
-
Andrew Grieve authored
There is one non-trivial one which I've just suppressed here, where CronetEngine.Builder.addPublicKeyPins() takes a Set<byte[]>. Apparently byte[] does not implement hashCode() nor compare(), so they should not be used as keys in maps/sets: https://errorprone.info/bugpattern/ArrayAsKeyOfSetOrMap Bug: 894616 Change-Id: I1feefa33a4d9a28f859b21ee0eeb051d969483cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934314Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#719140}
-
Denis Kuznetsov authored
It should remove flakiness upon shutdown. Bug: 997685 Change-Id: I7258be4a2be53e6e42e9fc0cebc23bd0d78d6fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934342Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#719139}
-
Bret Sepulveda authored
This patch rewrites all the tests in ToolbarActionsBarUnitTest that are relevant to the new UI into ExtensionsMenuViewUnitTest: * BasicToolbarActionsBarTest is converted to PinnedExtensionAppearsInToolbar and ReorderPinnedExtensions. Since ExtensionsToolbarContainer does not shrink to fit available space, that part of the test has not been converted. * ToolbarActionsReorderOnPrefChange is converted to PinnedExtensionsReorderOnPrefChange. * TestHighlightMode is not converted because highlight mode is not yet supported on the new UI. * The relevant part of TestActionFrameBounds is converted to PinnedExtensionLayout. * TestStartAndEndIndexes is not converted because ExtensionsToolbarContainer cannot be manually shrunk. * TestNeedsOverflow is not converted because there is no "overflow" container in the new UI. * ReuploadExtensionFailed is converted and split into two tests: ReloadExtension and ReloadExtensionFailed. This patch also disables the kExtensionsToolbarMenu feature for the ToolbarActionsBarUnitTest suite, so they will now pass when the feature is enabled by default. Bug: 984654 Change-Id: I287efbbe916354d7572ec0ea684cce86777213f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930816 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719138}
-
Yifan Luo authored
`Sec-Fetch-Dest` header for both manifests and resources should be `empty` for the requests called from application cache according to step 4 and 18.3 of https://html.spec.whatwg.org/#application-cache-download-process: ``` 4. Let request be a new request whose url is manifest URL, client is null, destination is the empty string, referrer is "no-referrer", synchronous flag is set, credentials mode is "include", and whose use-URL-credentials flag is set. 18.3. Let request be a new request whose url is URL, client is null, destination is the empty string, origin is manifest URL's origin, referrer is "no-referrer", synchronous flag is set, credentials mode is "include", use-URL-credentials flag is set, and redirect mode is "manual". ``` Bug: 1024198 Change-Id: I6566cead95f995089685fc8eed9635d82e3d4d81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926478 Commit-Queue: Yifan Luo <lyf@google.com> Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#719137}
-
Arthur Hemery authored
A prerequisite to COOP is to move COEP computation before we have selected a RenderFrameHost. This is done in this patch. Bug: 922191 Change-Id: Id78dc3a984b984f0b5daf5d0dd5729d60eeb7dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930563 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#719136}
-
Yi Su authored
In iOS 12, calling [UITableView reloadRowsAtIndexPaths:withRowAnimation:] inside the completion handler of [UITableView performBatchUpdates:completion:] may trigger a crash. The workaround is to get UITableViewCell via [UITableView cellForRowAtIndexPath:] and then reconfigure the cell directly. This will lose the built-in animation from UIKit when cells are updated. Once iOS 12 is deprecated, remove this workaround and use [UITableView reloadRowsAtIndexPaths:withRowAnimation:]. Bug: 1028074 Change-Id: Ida4fbf94f31b7b00cb9052177f3350c60ae9e4e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936487Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#719135}
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for UDPSocketListener from UDPSocket and uses PendingReceiver and Receiver, which are new Mojo types. Bug: 955171 Change-Id: Id5987eadff71ac110c223e4b3d20287caacddbc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935582 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for mojom::KeepAlive using Remote and PendingRemote. Bug: 955171 Change-Id: I7ef3aecf2cca7c595b5fcae0dd9138814da8ec79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935485 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Olivier Robin authored
Bug: None Change-Id: I1d6b104c7d9723ce11c1dc94e533cc24c61bc297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936288 Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#719132}
-
Kevin Ellis authored
Bug: 960944 Change-Id: I9001bae7cccbd006f34a98d28aca470c44ecc0af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929391 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#719131}
-
Andreas Haas authored
We saw this issue in another CL. R=haraken@chromium.org Change-Id: Ib1bd74d8df9de318430970d7c36e0b18f42e37bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936489Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#719130}
-
Corentin Wallez authored
Mark all WebGL tests as flaky to make Win10 FYI x64 Release (NVIDIA) green while the failures are investigated. [ win nvidia vulkan passthrough ] conformance/* [ RetryOnFailure ] BUG=chromium:1017162 TBR=kbr@chromium.org Change-Id: I617d892f33233d427557b38bd322054ef029d8d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936490Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#719129}
-
