- 14 Nov, 2019 40 commits
-
-
Adam Rice authored
QuicTransport is a low-level JavaScript interface to permit communication via the QUIC protocol. This CL implements only the connection and close parts of the API, along with unit tests. Bug: 1011392 Change-Id: I7383680e04c83a45f483e5d542e9227f8288ed65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899631Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#715349}
-
Robbie McElrath authored
crrev.com/c/1900130 renamed //aw/apk to //aw/nonembedded, but there were two //aw/apk references added in crrev.com/c/1904674 that I missed during the merge. Everything still seemed to build because they're behind a non-default build flag (webview_devui_show_icon). Test: 'ninja -C out/aw system_webview_apk' with webview_devui_show_icon=true in args.gn Bug: 934152 Change-Id: I0693a1abfeffa6a858fc0655ff3ad17627c6ef45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913598Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#715348}
-
Kurt Horimoto authored
When the expanded toolbar height is updated while the page is scrolled to the top, the top of the page will be obscured behind the toolbar. Toolbar heights only change during trait collection updates, so the page can be re-scrolled to the top after the trait collection is finished updating if it was detected that it was scrolled to the top when the update began. Bug: 1017146 Change-Id: I1065cae2c1824e61a8688b845b88211013fa1949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914968 Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#715347}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e2486aeb. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 88d98fda "Add more scroll to text WPTs" 788a3004 "Fix failing Fetch Metadata WPT" b16db925 "[Trusted Types] Add test for duplicate names in non-enforcing mode." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ie8ebf3e274e43fbe35cf465aacd13751fc8f67d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917080Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715346}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/68ff3171f360..ccb4439237a9 git log 68ff3171f360..ccb4439237a9 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 hjd@google.com Merge "traced_probes: Ignore ip field on print events" 2019-11-14 lalitm@google.com Merge "Update Vulkan memory tracker counters" 2019-11-14 lalitm@google.com trace_processor: add benchmarks for measuring sort performance Created with: gclient setdep -r src/third_party/perfetto@ccb4439237a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:135177627 Change-Id: I3783fa09941e7d0c0262af3cafb52a0f1da4f09b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916636Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715345}
-
shrekshao authored
Bug: 890539 Binary-Size: Increase needed to implement a feature; the added entry points are necessary to expose the functionality. Change-Id: I34c435bb6f576ee47f478810918599eb5fc82513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888732 Commit-Queue: Shrek Shao <shrekshao@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#715344}
-
Mikel Astiz authored
The test suite already instantiates a FieldTrialList as per https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so it's no longer necessary to do so explicitly in tests. This patch addresses unit tests under: /ios/chrome This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 1018667 Change-Id: I3ce32f0feaa2d652f5f4b8c68ae93e337e5e16be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916824 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#715343}
-
Salvador Guerrero authored
Bug: 870813 Change-Id: I01b36a864a3c573bc5ef392f88180e27206fdeb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914961Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Salvador Guerrero <salg@google.com> Cr-Commit-Position: refs/heads/master@{#715342}
-
Victor Fei authored
Previously, we notify an AXTreeObserver of a node removed from AXTree before the node is actually removed from the tree. In this change, we notify an AXTreeObserver of a node removed from AXTree after the tree is stable and its nodes have been updated. Previously, when in AXTree::Unserialize and before tree modification takes place, we call NotifyNodeWillBeReparentedOrDeleted on the node to be deleted. AXTreeObserver/ BrowserAccessibilityManager::OnNodeWillBeDeleted removes its reference to the AxNode's BrowserAccessibility object and destroy it as well. This takes place before the actual ax node is deleted from the tree. The subsequent action, also before tree modification, such as a call to BrowserAccessibility::InternalGetFirstChild() will reveal the inconsistent state--retrieving the child node from ax tree, however when we query through BrowserAccessibilityManager::id_wrapper_map_ for its BrowserAccessibility, it is not found because it is deleted in the prior action. This inconsistent state can cause a null dereferencing in BrowserAccessibility::PlatformIsLeafIncludingIgnored for role::kButton. In the following scenario, a crash would occur. AXTree: kRootWebArea #1 ++kButton #5 ++++kCheckBox #2 ++++kGenericContainer #3 IGNORED ++++++kStaticText #4 IGNORED AXTreeUpdate: 1. remove node kCheckBox #2 2. remove subtree kGenericContainer #3 IGNORED --- AXTree::Unserailize: { NotifyNodeWillBeReparentedOrDeleted(kCheckBox#2) OnNodeWillBeDeleted(kCheckBox#2) id_wrapper_map_.erase(kCheckBox#2) delete BrowserAccessibility of kCheckBox#2 NotifySubTreeWillBeReparentedOrDeleted(#kGenericContainer#3) FireWinAccessibilityEvent(kGenericContainer#3) ... PlatformIsLeafIncludingIgnored(kButton#5) InternalGetFirstChild(kButton#5) GetUnignoredChildAtIndex(0) returns kCheckBox ax node id_wrapper_map.get(kCheckBox#2) -> null Dereferencing null, exception occurs. //--- then tree modification/ax node deletion happens -- } Bug: 1020187 Change-Id: I8e83b3450ca6253e837f4854a1c90a4779b3d435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907774 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by:Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Adam Ettenberger <adettenb@microsoft.com> Cr-Commit-Position: refs/heads/master@{#715341}
-
Sorin Jianu authored
Bug: 1024881 Change-Id: Id1d4d38856591b85f753c797e46288bdaca724d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917466Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#715340}
-
Abul Hasan Md Osama authored
Bug: 1015473 Change-Id: Icc8101ef374a8b00d4d1ad6986dedaffcc54a6bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911882Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#715339}
-
Wez authored
This was most recently reverted by https://chromium-review.googlesource.com/c/chromium/src/+/1912704 due to failures on the MSan bot. Bug: 999737, 706728 Change-Id: I8a8e423b3bfbd57ef7871a809071c992251f209e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915321 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#715338}
-
Mike Dougherty authored
Bug: 987646 Change-Id: I01c8a58a8f51d7aeee0a03d1eed0e3cd040ea941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902068 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#715337}
-
Xiyuan Xia authored
AccelerometerReader's data reading blocks shutdown on certain devices. Use CONTINUE_ON_SHUTDOWN to run it on a thread that Chrome does not wait to join during shutdown. Bug: 1023989 Change-Id: I4fdad845fd59b45f3dc58a28edea031e733d934a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916691Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#715336}
-
Hongchan Choi authored
The previous CL [1] does not work anymore due to the changes in Worker infrastructure, so this CL changes ThreadCreationParams to fix the issue. ThreadCreationParams will check the thread type and assign the right priority for the WebAudio operation. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1580221 Bug: 813825, 877978 Test: third_party/blink/renderer/modules/webaudio/audio_worklet_thread_test.cc Change-Id: I9be6b2ccc37feaed22c2342391d5ef27388ef912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865013 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#715335}
-
Jazz Xu authored
Bug: 1021681 Change-Id: I551f94a2d195a8235a2c5292dbae67ccae5089b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904494Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#715334}
-
Mila Green authored
Bug: 1024318 Change-Id: Ia01b50058e4addd0ae9ce22a37ff37f8d8e384df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915096 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
-
Mark Yacoub authored
When Getting format modifiers, exclude I915_FORMAT_MOD_Y*_TILED_CCS (Intel color control surface (CCS) for render compression) if it's not an internal display. This solves the bandwidth issue when driving more than 1 4K monitor with rbc enabled. BUG=996011,996036,994341,979736 TEST=External display doesn't pick I915...CSS modifier Change-Id: I9d7aa06f5f9331d232a3cbd7e74bd41771bc4030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912460 Commit-Queue: Mark Yacoub <markyacoub@google.com> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#715332}
-
Natalie Chouinard authored
Move Incognito-related methods from PrefServiceBridge to IncognitoUtils. This is part of a larger change to limit PrefServiceBridge to only feature-agnostic logic related to the native PrefService. Bug: 1016957 Change-Id: I82622c38daa7ada27c648a978ad76dbfe7a9ecb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909957Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#715331}
-
Richard Knoll authored
To allow other communication channels to ingest messages into the sharing architecture, this CL extracts the handlers into a new class. This class can then be called when a new message is received, to look up the handler that should handle the message. Bug: 1021980 Change-Id: I1f8c9af0e08a9bd6fd1a99954d28ff22fd902d09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906152 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#715330}
-
yilkal authored
This CL adds PATL blocking page strings and blocking page. Bug: 1015661 Change-Id: I9641c94c0989b1d6335eff6b1ef4cb59bc002f37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895784 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#715329}
-
Elly Fong-Jones authored
This meta-target had a couple of transitive dependencies on dawn, despite dawn not being available on cros. This change makes those dependencies conditional on `use_dawn`. Bug: None Change-Id: I630e8786ab21510a2caee54a85034591a215981a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917380Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#715328}
-
Tommy Steimel authored
This reverts commit 57ee9cf0. Reason for revert: Speculative revert for the failures on deterministic builds, e.g. https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux%20%28dbg%29/12654 Original change's description: > views: Enable toolkit_views on Chromecast builds that use views > > Chromecast uses views, but does not set toolkit_views=true. Set this to > true & remove desktop-oriented code that breaks in this case. > > This replaces !defined(OS_CHROMEOS) with a new > BUILDFLAG(ENABLE_DESKTOP_AURA) flag as necessary throughout views. This > is needed because Chromecast doesn't use desktop_aura and uses aura > similarly to Chrome OS by creating one WindowTreeHost for the display > [alternative suggestions on how to handle this distinction welcome]. > > This does not enable views in content(_shell) yet. That's left to the > next patch as it changes the UI. > > As of this change, views_unittests passes in Chromecast Linux builds. > > Bug: 1021770 > Test: views_unittests, content_browsertests on is_chromecast=true build > > Change-Id: I54e79402a761572feb76f122ed846558e84210b6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907559 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Michael Spang <spang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715183} TBR=sky@chromium.org,spang@chromium.org,jam@chromium.org,dpranke@chromium.org Change-Id: I17c9efdff45b51d3a215bccd3be9eb9418478de0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1021770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917294Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#715327}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/321c12255e73..58dbfcae38f4 git log 321c12255e73..58dbfcae38f4 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 rharrison@chromium.org Refactor ShaderModule creation to use a Builder pattern Created with: gclient setdep -r src/third_party/dawn@58dbfcae38f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: Ie5d65800a7d164c19d5632d1310964c1537473d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916635Reviewed-by:
-
Peter Boström authored
This makes ConfigureBubbleMenuItem public in bubble_menu_item_factory.h and makes use of it in ExtensionsMenuButton's constructor. Bug: chromium:943702 Change-Id: I4c28038b73b7ac8b7922da1ac5d348b60777082f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916690 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#715325}
-
Mikel Astiz authored
The test suite already instantiates a FieldTrialList as per https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so it's no longer necessary to do so explicitly in tests. This patch addresses unit tests under: /content/public/test This CL was uploaded by git cl split. R=sky@chromium.org Bug: 1018667 Change-Id: I71fc1531d779cc0d4d1b1cc7255b5a53f445e6eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916867 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#715324}
-
sczs authored
This will then be used by the SaveCardInfobarCoordinator. Bug: 1014652 Change-Id: I2b92f3e4b818bb3844e87c15371a364797d22aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915819 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#715323}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d04f123cc7ff..95f0b1673fe6 git log d04f123cc7ff..95f0b1673fe6 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 egdaniel@google.com Miscellaneous updates to handle more vulkan creation failures. 2019-11-14 flar@google.com Only define SK_GL for Flutter on non-Fuchsia platforms. Created with: gclient setdep -r src/third_party/skia@95f0b1673fe6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: None Change-Id: Ie6ffb2a0b1c61b530f573210e05201b0122bcd8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916637Reviewed-by:
-
Toni Barzic authored
Follow-up on CL:1913508. This moves window minimization done during transition to home when overview exit starts after observers were notified about overview start animations have been canceled (as window hiding is actually part of overview exit). BUG=1024107 Change-Id: I1b5a520b3ef38c8cf2d69f32ea54b5ea94bd7c0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915227Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#715321}
-
David Van Cleve authored
A recent change (5f37444e) to GURL::PathForRequest led to some crashes caused by URLPattern calling PathForRequest with invalid URLs, which was explicitly prohibited with a DCHECK prior to the change but, in release builds, had been silently accepted. This change makes URLPattern only call GURL::PathForRequest with valid input, by failing URLPattern::MatchesURL on pathless inputs prior to the call to PathForRequest. Test: Added a regression test. Bug: 1022771 Change-Id: I52896977b6474603d30cbea99ebb776eb3ccf308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906511 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#715320}
-
Hans Wennborg authored
The binary or operator meant the if conditions were always true, and recent Clang versions warn about it. This patch makes the code match the comments. Bug: 1024203 Change-Id: Ie4716dadc40a43f8f97e26ee04745cf967fc98f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912718 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
-
Andreas Haas authored
The removed template parameters are unnecessary, they can be determined from the types of the normal parameters. This is part of my work to reduce uses of blink::ArrayBuffer and co, which were originally WTF::ArrayBuffer and co. Bug: chromium:1008840 Change-Id: Id609a811966405dec14ab62a304ea0a56bd7b287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917139Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f6fc149b0b16..1dbf452d7ecb git log f6fc149b0b16..1dbf452d7ecb --date=short --no-merges --format='%ad %ae %s' 2019-11-14 khokhlov@google.com [Telemetry] Write Telemetry traces in proto format under experimental flag 2019-11-14 perezju@chromium.org Reland "[Telemetry] Remove more unused properties in results object" Created with: gclient setdep -r src/third_party/catapult@1dbf452d7ecb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:990304,chromium:973837 Change-Id: I2fed45457c98bd47614ccf7d2afb001798d41d3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916626Reviewed-by:
-
Thomas Lukaszewicz authored
This reverts commit 0cb19df2. Reason for revert: Reverted change due to transparency issues when using older profile icons. See https://bugs.chromium.org/p/chromium/issues/detail?id=1016334 Bug: 857064,1016334 Change-Id: I9f35f0692c733f1a7544249581104006f0673642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913465Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ff11d441ccdf..4d4332ed66fa git log ff11d441ccdf..4d4332ed66fa --date=short --no-merges --format='%ad %ae %s' 2019-11-14 cjmcdonald@chromium.org Reland 'DependencyService: Provide exact eclass dependency paths' Created with: gclient setdep -r src/third_party/chromite@4d4332ed66fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Idb14d0c1004dfeba2eb52321bcdfb6463ded8b79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916634Reviewed-by:
-
Collin Baker authored
Currently, capturing a thumbnail for a background tab must call WebContents::IncrementCapturerCount(). However, this tells the renderer that a page is visible, triggering any deferred media autoplay. This adds a flag to IncrementCapturerCount() which makes it use the new PageVisibilityState::kHiddenButPainting state. This indicates that the page should be rendered, but shouldn't be treated as user-visible yet. Fixed: 995131 Change-Id: Ie90fdc25e412969d904f93c8c5ffcbc2312ddc0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885511Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#715314}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/60bd1aea3d6d..01294f0e2987 git log 60bd1aea3d6d..01294f0e2987 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 philipel@webrtc.org Don't configure video codec switching if no video stream has been created. 2019-11-14 noahric@chromium.org Reduce verbosity of logging around playout underrun count on iOS. 2019-11-13 mbonadei@webrtc.org Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."" 2019-11-13 mbonadei@webrtc.org Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." 2019-11-13 danilchap@webrtc.org Stop using DEPRECATED_SingleThreadedTaskQueueForTesting in call tests Created with: gclient setdep -r src/third_party/webrtc@01294f0e2987 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com No-Try: True Bug: chromium:none,chromium:None Change-Id: Ib951232ed85757f7df6c6872674056a728204106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916629 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Dave Tapuska authored
It is possible to block the main thread with a invalid pattern, input and CSS. Now that V8 has added a backtracking limit take advantage of it. 1000000 matches the limit Yarr (webkit's regex engine). See https://github.com/WebKit/webkit/blob/89c28d471fae35f1788a0f857067896a10af8974/Source/JavaScriptCore/yarr/Yarr.h#L50 BUG=966405 Change-Id: I08bc956806bc7efb8cdc06dc0db30fa94e68df9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915280 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#715312}
-
Gyuyoung Kim authored
This is a reland of 184873e8 The original CL had an extra ')' in audio_output_provider_impl.cc. This CL fixes it. Original change's description: > Clean up old uses of AssistantAudioDecoderFactory > > This CL replaces the last use of old Mojo type of > AssistantAudioDecoderFactory interface with > mojo::Remote. > > Bug: 955171 > Change-Id: I16778198e4dc1b7a7693dbbc0f7b85ae4a3d6bbc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890454 > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Tao Wu <wutao@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#711712} Bug: 955171 Change-Id: I559da6829ba6fb8914f08ee761b9f998ec3de98d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895265 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#715311}
-
Eric Willigers authored
The minimal-ui buttons (Back and Reload) now appear to the left of the window title, The origin and three dot menu appear to the far right (as before). Box layout is used to layout the buttons on the left and the buttons on the right. Flex layout is used to distribute space between the left and right button areas and the window title area in the center. Platform-specific adjustment of the spacing around the minimal-ui buttons will occur in a subsequent CL. Desktop web applications can request the minimal-ui buttons by specifying display minimal-ui in their web app manifest: https://www.w3.org/TR/appmanifest/#dom-displaymodetype-minimal-ui Bug: 1016663 Change-Id: I449f85b2a8d5912811245e40e084411629e8b1db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900801 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#715310}
-
