- 24 Apr, 2018 40 commits
-
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=kmackay@chromium.org Bug: 825327 Change-Id: Ic2d81d1bc53eac58a69f323c8ef4820defc8af93 Reviewed-on: https://chromium-review.googlesource.com/1024473Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553073}
-
Xida Chen authored
TBR=clamy@chromium.org NOTRY=true Bug: 836211 Change-Id: I3049e37717dce84ee9f4692210391c1d3eeb7c74 Reviewed-on: https://chromium-review.googlesource.com/1025323Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#553072}
-
Gauthier Ambard authored
This CL adjusts the navigation menu items to look like the mocks. Bug: 804778 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3d4b45196207e98187af64cac25a6d7cf7309f90 Reviewed-on: https://chromium-review.googlesource.com/1025752 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553071}
-
Yuki Shiino authored
[CallWith=ThisValue] is obsolete from the beginning and only used at Location's valueOf(), which must be implemented in the way of https://html.spec.whatwg.org/multipage/history.html#the-location-interface No need to support it in IDL callback interface, and it's actually not supported now. Change-Id: I3546f78a68fb2b335950d3848b6c4b51628cc505 Reviewed-on: https://chromium-review.googlesource.com/1025153Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#553070}
-
Rayan Kanso authored
Serialize the ServiceWorkerFetchRequests and store them with the metadata. Store Pending Requests (all requests are pending initially), and add util functions to query pending/active requests. Design doc: https://docs.google.com/document/d/1zk6WSUb063I_07ct1EP8krOsDKXai1v4nJchvpQeAio/ Bug: 826257, 757760 Change-Id: Ic3aa98106583e9273e5f93b53123b2e2f1067cd9 Reviewed-on: https://chromium-review.googlesource.com/1017101 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#553069}
-
Juan Antonio Navarro Perez authored
TBR=nednguye@google.com NOTRY=true Bug: 834905 Change-Id: Ie5a2736ca742071d1338ae1a28c025ef113c9786 Reviewed-on: https://chromium-review.googlesource.com/1025657Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#553068}
-
Olivier Robin authored
Server card fetching requires that ChromeAutofillClientIOS returns a valid sync_service. Bug: 825319, 535784 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic59cfd5fba28f0fa3721806bcfbfc91829f75445 Reviewed-on: https://chromium-review.googlesource.com/1023930 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#553067}
-
Sigurdur Asgeirsson authored
Also rearrange method order a little and rename HandleMetrics to DispatchMetrics, as there's no need to pass the metrics map to the method. R=chrisha@chromium.org Bug: 755840 Change-Id: If316817f540315bf8c0465d1d32be60734183db6 Reviewed-on: https://chromium-review.googlesource.com/1019563Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#553066}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=manzagop@chromium.org Bug: 825327 Change-Id: I6fb6356e6c0b8dded0c990bca7c15012d757405d Reviewed-on: https://chromium-review.googlesource.com/1024390 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#553065}
-
clamy authored
This CL disables SitePerProcessBrowserTest.ScrollBubblingFromOOPIFWithBodyOverflowHidden which is flaky on linux-chromeos-rel. TBR=xidachen@chromium.org, nasko@chromium.org NOTRY=true Bug: 836200 Change-Id: If6bd9bad4d852eebfe4fe277f420854b228ed5a4 Reviewed-on: https://chromium-review.googlesource.com/1025694Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#553064}
-
Noel Gordon authored
Fixed on issue 831074 issue 804413 issue 829310. Tbr: yamaguchi-san Bug: 835794,690983 Change-Id: Ia92b6e5a096760c747ebb20802dc59f07f918ea5 Reviewed-on: https://chromium-review.googlesource.com/1025850Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#553063}
-
Lei Zhang authored
BUG=605605 Change-Id: I22f0c4a6fe06ec3d76359f2559e532e155c53815 Reviewed-on: https://chromium-review.googlesource.com/1014677 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#553062}
-
clamy authored
This CL disable to extensions browser_tests that are flaky on ChromeOS MSan bots. TBR=thestig@chromium.org, xidachen@chromium.org NOTRY=true Bug: 836188 Change-Id: I0579a0129291a82a0818b31046cd946a469abd02 Reviewed-on: https://chromium-review.googlesource.com/1025755Reviewed-by:
-
Fan Yang authored
In QUIC, use bit 0x08 of each packet's first byte to demultiplex Google QUIC and IETF QUIC. Not protected. Make QUIC_VERSION_99 be able to build/process IETF QUIC packet header format. Merge internal change: 193045984 R=rch@chromium.org Change-Id: Icb282bd79239c824ee1f3ad1db5aed90023646df Reviewed-on: https://chromium-review.googlesource.com/1024772Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#553060}
-
Vaclav Brozek authored
Autofill and password autofill uses IsFocusable to approximate visibility of form fields, as long as Blink is done rendering the page and triggering a layout in order to compute visibility is acceptable. Triggering a layout is not acceptable when Blink is about to render the page. See https://crbug.com/595078 for past issues with this. When triggering a layout is not acceptable, the variable g_prevent_layout is set to true and computing visibility for (non-password) autofill in WebFormControlElementToFormField is given up, assuming all fields are potentially visible. Password autofill used a different path to compute visibility for the form fields, querying IsWebElementVisible. This has historically used HasNonEmptyLayout at all times, but then switched to using IsFocusable when triggering a layout was acceptable (see https://codereview.chromium.org/2769023003). Calling HasNonEmptyLayout remained to minimize the change in behaviour, leading to the puzzling situation when a function clearly triggering a layout was called when layout should not be triggered. While the latter never seemed to produce crashes as seen in https://crbug.com/595078, it is a potential landmine, and likely unnecessary, given that the data it provided needed improvement in the form of IsFocusable anyway. Therefore this CL stops calling HasNonEmptyLayout from IsWebElementVisible. It also extends a visibility-related test to check IsWebElementVisible and two scenarios based on prevention of layout. Bug: 833838 Change-Id: I6aedca91ff0369c541891c96336125dff9adeac0 Reviewed-on: https://chromium-review.googlesource.com/1021573Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#553059}
-
Ramin Halavati authored
New profiles' last selected file directory was left uninitialized, and hence the first file open was done in the last OS selected directory. This created unpredicted behavior for new profiles, and could cause leakage of the last folder used in incognito mode. User's home directory is now set as the default value for it. Bug: 659632 Change-Id: I91e49e7152bda9abe26ff97ece12f08f9805c8de Reviewed-on: https://chromium-review.googlesource.com/1023401 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#553058}
-
stkhapugin@chromium.org authored
This test relies on the typing shield tap, but on phones the typing shield is not available when some suggestions are shown. With zero suggest, there are some suggestions in the popup. Use cancel button to close omnibox on phones instead. Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie01c78c86cd9a7baa6d25391142bdcdbe89533a1 Reviewed-on: https://chromium-review.googlesource.com/1025095Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553057}
-
Gabriel Charette authored
Migrate MessageLoop::current() to MessageLoopCurrent in /chrome/browser/chrome_browser_main_android.cc These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=bauerb@chromium.org Bug: 825327 Change-Id: Ia10a44445d3e9b765511fda5e1135afc0d32a338 Reviewed-on: https://chromium-review.googlesource.com/1024710 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=bauerb@chromium.org Bug: 825327 Change-Id: I87bfe63cc53b805a916de25b360c6db5be350358 Reviewed-on: https://chromium-review.googlesource.com/1024507 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
-
clamy authored
They now match the general mac expectations for this 2 WPT tests. TBR=smcgruer@chromium.org,xidachen@chromium.org Change-Id: Ic229e507522b78aece533009c2b29d33829d293f Reviewed-on: https://chromium-review.googlesource.com/1024837Reviewed-by:
-
Xida Chen authored
TBR=smcgruer@chromium.org NOTRY=true Bug: 836185 Change-Id: I0f31be6d2638556bf6b734e6d8f03f1fd7eb4b19 Reviewed-on: https://chromium-review.googlesource.com/1025318Reviewed-by:
-
Ravi Mistry authored
Also creates new local_trace_measurement and shared_browserless_story for the benchmark to use. Depends on https://chromium-review.googlesource.com/c/catapult/+/1017440/ landing first and rolling into chromium. Bug: skia:7796 Change-Id: I7503f19b90c6231b96547d480c7fb13d1dd79071 Reviewed-on: https://chromium-review.googlesource.com/1019640Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ravi Mistry <rmistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#553052}
-
Marc Treib authored
Bug: 825190, 814787 Change-Id: I733c0dc3baca101b9ebe1b2448a31fadf815ae58 Reviewed-on: https://chromium-review.googlesource.com/1024835Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#553051}
-
Noel Gordon authored
These tests have been running under, or re-enabled for, ASAN and are working well there. Time to re-enable under MSAN issue 508949 to see see if that issue (OOM) is still a problem. The expected answer is: no, it's not a problem for this browser test suite anymore. Let's see. Tbr: yamaguchi-san Bug: 835794,508949 Change-Id: Ia6e2a0164872b315fd060d8fa6c49f65b7e3c0ed Reviewed-on: https://chromium-review.googlesource.com/1025439Reviewed-by:
-
Tatiana Gornak authored
BUG=801985 Change-Id: Id7de2e23ea11a6a0a620c9c6063a03397f38af41 Reviewed-on: https://chromium-review.googlesource.com/1019480 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#553049}
-
Marc Treib authored
and some (unused) UI code that still depended on it. Legacy Supervised Users are deprecated, so this isn't needed anymore. Bug: 824756 Change-Id: Ib0434298a547aed61550a828514d0be759324dea Reviewed-on: https://chromium-review.googlesource.com/1019580Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#553048}
-
Noel Gordon authored
Fixed on issue 831074 issue 804413 issue 829310. Tbr: yamaguchi-san Bug: 835794,803505 Change-Id: I1a9e3a80a57dd32de63c1dd28e5fc10f7e4ad90b Reviewed-on: https://chromium-review.googlesource.com/1025436Reviewed-by:
-
Manuel Rego Casasnovas authored
This patch removes the grid logic from LayoutBox::ContainingBlockLogicalWidth|HeightForContent(). Instead it initializes the OverrideContainingBlock size to zero in LayoutGrid::PlaceItemsOnGrid(). For grid items we don't want to use the grid container size (which would be the regular containing block size), so we want to use the overridden value. And while we don't have such value, it's better we use zero for widths (so percentages are not resolved against the wrong thing) and -1 (indefinite) for heights. Note that we need a small change in LayoutBox::ComputeLogicalWidth() as now for orthogonal items we'll get -1 as PerpendicularContainingBlockLogicalHeight(), but the width cannot be negative, so we clamp it to zero. This change is covered by existent tests. Change-Id: I73b0941aa53b80e3c377362b7e023eb01cfad38b Reviewed-on: https://chromium-review.googlesource.com/1019242 Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#553046}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I735f9f6e7e8a96e2c43cbc1789c252a2bf3c3f39 Reviewed-on: https://chromium-review.googlesource.com/1025123 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553045}
-
tanvir.rizvi authored
position_with_affinity.h includes TextAffinity, but uses only declaration. We should instead do a forward declaration for TextAffinity. Bug: 831592 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ia4d167bbf1eb3e91264a526972324cfc5cb90e33 Reviewed-on: https://chromium-review.googlesource.com/1025539Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com> Cr-Commit-Position: refs/heads/master@{#553044}
-
Bernhard Bauer authored
ParameterizedRunnerDelegateFactory used to create the test class when creating the runner, passing the instance in so that createTest() would just return it. This meant that all test rules would be created at that time as well, which in the case of RenderTestRule is before the command line is instantiated, so it would not have the right value of the render test output directory. (In addition, it defaults to using the test data directory, so writing failure files would suceed, but the test runner wouldn't find them when pulling from the device.) With this change, the test class is created in the createTest() method to avoid this and other subtle differences between parameterized and non-parameterized tests. Bug: 834712 Change-Id: I49bec0e6dbbf5aebe92f29a0de65c9b60729646a Reviewed-on: https://chromium-review.googlesource.com/1023854Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#553043}
-
Chris Nardi authored
https://github.com/w3c/csswg-drafts/issues/2601 removed [LegacyArrayClass] from the spec, so these TODOs are no longer needed. Change-Id: I38e6c2b0cd726d3f8af75e1c3966f794d4487af5 Reviewed-on: https://chromium-review.googlesource.com/1025313Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#553042}
-
Takuto Ikuta authored
print shows u prefix in string (e.g u"directory"). I also updated clang_tidy docs to change directory for compile_commands.json. Change-Id: I5e801519e7856feab2d32ac1ec6062687f0156b0 Reviewed-on: https://chromium-review.googlesource.com/1025491 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#553041}
-
Marc Treib authored
and everything that's directly related (factory, update) or depends on it (pref mapping service, (ChromeOS only) SU password service, manager password service). Legacy Supervised Users are deprecated, so this isn't needed anymore. Bug: 824756 Change-Id: If8dc0841cdb10add42330e193362c28a02668af8 Reviewed-on: https://chromium-review.googlesource.com/1016914Reviewed-by:
-
Yoshifumi Inoue authored
This patch gets rid of a redundant parameter |text_node_| from |TextIteratorTextNodeHandler::EmitText()| since all call sites pass |text_node_| for improving code health. Change-Id: I4bd160a5095229322cc6c6fce1f7795b66ec7ac5 Reviewed-on: https://chromium-review.googlesource.com/1025536Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553039}
-
Mihai Sardarescu authored
This CL records the following user actions when Desktop Identity Consistency is enabled: * Signin_ImpressionWithAccount_FromSettings * Signin_ImpressionWithNoAccount_FromSettings Bug: 833282 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie15cbf5c74466755559cf7d3359b76973ee5dc6f Reviewed-on: https://chromium-review.googlesource.com/1016919Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#553038}
-
Hiroki Nakagawa authored
DocumentWebSocketChannel is used for WebSocket on Document, but it's also used on WorkerGlobalScope when the off-main-thread WebSocket is enabled. This CL renames DocumentWebSocketChannel to WebSocketChannelImpl for reducing confusion. Before this CL, the class hierarchy is as follows: - WebSocketChannel - DocumentWebSocketChannel - WorkerWebSocketChannel - MockWebSocketChannel After this CL, the class hierarchy is as follows: - WebSocketChannel - WebSocketChannelImpl - WorkerWebSocketChannel (to be removed) - MockWebSocketChannel After the off-main-thread WebSocketChannel is enabled by default, WorkerWebSocketChannel is removed. Bug: 825740 Change-Id: If9998a7c30cfda05d6d3ffb6f7b4b4437edf0aed Reviewed-on: https://chromium-review.googlesource.com/1025240Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Erik Luo authored
This CL marks methods and attributes that produce no JS-observable side-effect and have return type Element, Node, HTMLCollection, NodeList, or a derived type. Bug: 829571 Change-Id: Ia1d7def24fae8764620f80f3f46f8454de976ce4 Reviewed-on: https://chromium-review.googlesource.com/1025170Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#553036}
-
Andrew Grieve authored
I'm sure this will need some iteration, but it's a start. Bug: 702625 Change-Id: Id9451eee9a39e589c3e126dc3b2b4dfbdab9ea46 Reviewed-on: https://chromium-review.googlesource.com/1024930Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#553035}
-
Fergal Daly authored
Adds a NamesMap class to represent a map of part names to ordered-set of partnames. Add partmap attribute to HTML attributes. Adds methods on Element and ElementRareData to set/get the parsed part name map. Bug: 805271 Change-Id: Ib17a00873cd1598b88f5e120dd96e63580390443 Reviewed-on: https://chromium-review.googlesource.com/994896Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#553034}
-
