- 31 Oct, 2018 40 commits
-
-
Josh Karlin authored
Since LocalFrame already has a IsAdSubframe() method we don't need to also have this information in the SubresourceFilter. This is a behavior change for workers, because we'll no longer tag ad resources in workers but we weren't actually doing anything with that information. If we want that information in the future, we can add a similar IsAdWorker method on the ExecutionContext itself. Bug: 894505 Change-Id: I17cdc258d42169679a205993123b5026e76b2b89 Reviewed-on: https://chromium-review.googlesource.com/c/1277546Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604228}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cde793b094e2..3bb0ac4bc943 Created with: gclient setdep -r src-internal@3bb0ac4bc943 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2c87e0d109f96562130baedc91f9a02495042427 Reviewed-on: https://chromium-review.googlesource.com/c/1309544Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604227}
-
Ioana Pandele authored
This reverts commit 2ae6a697. Reason for revert: The following tests fail on WebKit Linux Trusty MSAN * http/tests/devtools/isolated-code-cache/same-origin-test.js * virtual/site-isolated-code-cache/http/tests/devtools/isolated-code-cache/same-origin-test.js Original change's description: > Add layout tests for javascript code caching. > > This add layout tests to ensure javascript code caching is working as > expected. This also adds virtual tests with ( > --enable-features=IsolatedCodeCache --site-per-process) to test that the > isolated code cache is behaving as expected. These tests test that: > 1. code cache is created on the second visit to the script > 2. code cache is consumed on the third visit to the script > 3. code cache for the same script resource is not reused if > requested from a different origin (for the virtual tests). > > Bug: chromium:879494 > Change-Id: I05f92fa129dac2419c84fcc65e9d0c684b9d48e2 > Reviewed-on: https://chromium-review.googlesource.com/c/1297363 > Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Commit-Queue: Mythri Alle <mythria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604199} TBR=kozyatinskiy@chromium.org,mythria@chromium.org Change-Id: I7169c097989e642fb5296d19965b162e256b6507 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:879494 Reviewed-on: https://chromium-review.googlesource.com/c/1309740Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#604226}
-
Max Morin authored
I reproduced the flake locally and found that the RenderCallback was busy generating sine values, causing an underrun. This CL increases the buffer duration by 10 (also increasing the timeout by 5), and decreases the sample frequency (so that fewer values have to be generated). Since the test was quite slow, kBuffers is also reduced a bit. With these changes, the test ran 1M times with asan without any flakes. Bug: 761214 Change-Id: I0855a63edbd62e4c4f9afe4d9d1f68c2b61ff61c Reviewed-on: https://chromium-review.googlesource.com/c/1309734Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604225}
-
Vladislav Kuzkokov authored
Bug: 891174 Change-Id: I6962a3a9f07249dfe8e40f30d331606b61bc27d8 Reviewed-on: https://chromium-review.googlesource.com/c/1273144Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#604224}
-
Francois Doray authored
With this CL, a ProcessCoordinationUnit stores the launch time obtained from base::Process::CreationTime() rather than a time obtained from base::Time::Now() after process launch. That will make it easier to validate that a handle to the right process is obtained when calling ::OpenProcess() with a Pid on Windows. Bug: 885293 Change-Id: I56bfce59b51542f71eec83777aa53fd8f4e7d245 Reviewed-on: https://chromium-review.googlesource.com/c/1273257 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#604223}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8b7d206d37ba..b32bb959c9a9 git log 8b7d206d37ba..b32bb959c9a9 --date=short --no-merges --format='%ad %ae %s' 2018-10-31 yinwa@webrtc.org Bugfix: FlexFEC causes retransmit bitrate increase. Created with: gclient setdep -r src/third_party/webrtc@b32bb959c9a9 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6801009142b4ada7f15e352689b428a519fd78a8 Reviewed-on: https://chromium-review.googlesource.com/c/1309542Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604222}
-
Shu Chen authored
1) Avoid wchar_t at all. Use u8"" literal. 2) Avoid heavy parsing at all. Make the key mapping definitions contains the parsed map instead of a big string for parsing. 3) Removes the test cases for parsing because there is no parsing at all. 4) Split the .h files under def/ into .h and .cc files. Bug: 859432 Change-Id: Iae110d556aa80b6a7b64d2373b8fafbbfee3c41c Reviewed-on: https://chromium-review.googlesource.com/c/1301096 Commit-Queue: Shu Chen <shuchen@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#604221}
-
Finnur Thorarinsson authored
- Fix sorting. Use a Sort key that takes into account locale-based traditions for sorting names in address books. - Make sure contact icons are all of equal size. - Use only single letter for icons without contact images (instead of two). Trying to figure out what is the last name requires some heuristics. Bug: 860467 Change-Id: Ib6c03cea6ade5f479d1b46fc2a2164ba55e8ca14 Reviewed-on: https://chromium-review.googlesource.com/c/1307504 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#604220}
-
Sergio Villar Senin authored
IdentityTestEnvironment posts tasks to handle access tokens in order to support cases where the access token request is handled synchronously. The problem was that the object could be destroyed before those tasks are run resulting in bad crashes. We can get them all canceled just by using weak pointers instead of base::Unretained. Change-Id: If61aee64ab5eaf7667a7470c309d810ba6f2be54 Reviewed-on: https://chromium-review.googlesource.com/c/1298026 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#604219}
-
Raphael Kubo da Costa authored
This test was added in https://github.com/web-platform-tests/wpt/pull/13487, and triggers the same content_shell crash we had a while ago when a reftest has <link href="about:blank">. Mark it as both passing and crashing to allow imports to continue. TBR=lukebjerring Bug: 895777 No-Try: True Change-Id: I9cee89e8ff67e3c83414a73bb18cb7d74c5d6c06 Reviewed-on: https://chromium-review.googlesource.com/c/1309779 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#604218}
-
Ian Kilpatrick authored
This changes the line_left_edges, and line_right_edges to keep a simple tuple instead of a scoped_refptr to an NGExclusion. This speeds up some of the float benchmarks by ~2.5%. Bug: 635619 Change-Id: I2d4801c5e2eecdbdc53e147dc8e9609150bab581 Reviewed-on: https://chromium-review.googlesource.com/c/1308259Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#604217}
-
Mythri Alle authored
Add tests for the defering logic in the code cache fetch. Bug: chromium:812168, chromium:879494 Change-Id: Iac88631b4b5df3d13e327f2642f45fb285d2659f Reviewed-on: https://chromium-review.googlesource.com/c/1209484 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#604216}
-
Alex Clarke authored
Cross thread immediate task posting performance matters for the UI thread and the Blink main thread. This patch adds a perf test for this case. Also refactors things into classes which hopefully makes it a bit more manageable. Bug: 863341, 897751 Change-Id: I5cc1492fb1988582085af0c4ff04ac7e729a4fd7 Reviewed-on: https://chromium-review.googlesource.com/c/1307500Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#604215}
-
Tanja Gornak authored
sync_client isn't used on any platforms, hence it doesn't make sense to keep it around. Bug: 880056, 801985 Change-Id: I1bbb5c689d1b004fa8a673e5d86c91a3e9712900 Reviewed-on: https://chromium-review.googlesource.com/c/1307494 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Tanja Gornak authored
Bug: 880056, 801985 Change-Id: I0606bb84518b35a8d965e6bb2fb44bb6fcee5620 Reviewed-on: https://chromium-review.googlesource.com/c/1307435Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#604213}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/abc8edfb888a..cde793b094e2 Created with: gclient setdep -r src-internal@cde793b094e2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I93fa09250c3e2b7d0c0f6612a9facc6835b58f2f Reviewed-on: https://chromium-review.googlesource.com/c/1309541Reviewed-by:
-
Ian Kilpatrick authored
This was an over-otimization, which realistically probably never gets hit. Bug: 635619 Change-Id: Icac53b8605e56242b8455228d0767b2dafb66b5d Reviewed-on: https://chromium-review.googlesource.com/c/1305133 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
Daniel Bratell authored
There are some circular include dependencies in the zlib build system because some parts are extracted into their own targets. To make gn check understand that, those targets need to be added to the allow_circular_includes_from list. Bug: 898837 Change-Id: Ic94c5f5ac88e10792b458f4d734c4ad0487023c2 Reviewed-on: https://chromium-review.googlesource.com/c/1299135Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#604210}
-
Eric Seckler authored
Fixes the flakiness of buffer usage / known categories tests by resolving an accidental race condition. Also restricts disabling the other two tests to <= kitkat devices since those seem to be the only ones that show (inexplicable) flakiness. TBR=yfriedman@chromium.org Bug: 899894 Change-Id: I0225c1519ea19910492ffb60a242bcc71b2275b4 Reviewed-on: https://chromium-review.googlesource.com/c/1307433Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#604209}
-
Eliot Courtney authored
It seems that WindowState::UpdatePipState was overwriting window visibility animation types set by other code. Modify it to be called earlier and only to update the window visibility animation type on transitions from and to PIP. as well (properly uses FADE type animation) Bug: 899432 Test: Animation to overview mode no longer has black backdrop animating Test: Dismiss animation for PIP still works on closing the PIP window. Change-Id: I9a575fbc55273cb4be7e26482f6f749e6d3ce15c Reviewed-on: https://chromium-review.googlesource.com/c/1306971Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#604208}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4d8f48db9ef5..af730f2b44f6 git log 4d8f48db9ef5..af730f2b44f6 --date=short --no-merges --format='%ad %ae %s' 2018-10-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 70942e2e8566..e36ca90f33e9 (1 commits) Created with: gclient setdep -r src/third_party/skia@af730f2b44f6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I0bb6b3ac4b255878b61ae0532b615df2ec355e96 Reviewed-on: https://chromium-review.googlesource.com/c/1309540Reviewed-by:
-
Mitsuru Oshima authored
* Pause occusion tracker during overview animation * Activate the text filter after animation * Don't animate backdrop window during overview animation. * Fix the bounds change issue in WindowGrid. It shouldn't change the parent window's bounds. in both clamshell and tabletmode. The web contents should load after animations without backdrop animation. No gap at the bottom of the screen after exiting overview mode. Bug: 898077, 897387 Test: no functional change. Manually tested visual change by entering/exiting overview mode Change-Id: I60c2709c5394a565bae6d0c4bfdd7006e2e76496 Reviewed-on: https://chromium-review.googlesource.com/c/1304973 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#604206}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f577ab3d38f9..8b7d206d37ba git log f577ab3d38f9..8b7d206d37ba --date=short --no-merges --format='%ad %ae %s' 2018-10-31 peah@webrtc.org AEC3: Decrease latency until the delay has been detected Created with: gclient setdep -r src/third_party/webrtc@8b7d206d37ba The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:896334 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I4959a12dc3a5557463627b200eac455332ce4249 Reviewed-on: https://chromium-review.googlesource.com/c/1309539Reviewed-by:
-
Tatsuhisa Yamaguchi authored
This is a follow-up of crrev.com/c/1306969. After that change it showed the tooltip for power status even when hovering on other parts of the tray. Bug: 888072 Change-Id: I26c5786a8ff19347f2eb58dd1430e2d5ea66d066 Reviewed-on: https://chromium-review.googlesource.com/c/1308961Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#604204}
-
Sunny authored
When calling |RegisterNonPersistentNotificationListener| with an existed notification id, it will first dispatch a close event to old notification and set new listener into listener map. Currently the new listener is replaced immediately after calling |DispatchNonPersistentCloseEvent|, since it's an asynchronize call, it will remove the replaced listener unexpectedly, instead of removing the original listener. To fix this, we can postpone listener replacement after the close event finish it's cleaning job. For new created notification, the listener can be set immediately due to there is no close event need to be dispatched. Bug: 880266, 898486 Change-Id: I370d77386cf1a6636f368f1785d92d362a3b4263 Reviewed-on: https://chromium-review.googlesource.com/c/1303898Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/600998aa..0ccf17e9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id2065b11573e0f0a2911068dbdf371bdcbdddeb7 Reviewed-on: https://chromium-review.googlesource.com/c/1309308Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604202}
-
Stephen Kyle authored
The static |destructor_calls_| variables used with the HeapTest.Finalization and HeapTest.SimpleFinalization tests were not being reset to 0 on subsequent runs of the test (e.g. when running with --gtest_repeat). BUG=899757 Change-Id: I55419a946431267cf88122aae80ae46fcbe8f467 Reviewed-on: https://chromium-review.googlesource.com/c/1309693Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#604201}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9662809abb16..e3f4b1f5ee13 git log 9662809abb16..e3f4b1f5ee13 --date=short --no-merges --format='%ad %ae %s' 2018-10-31 sergiyb@chromium.org Flip the default for ensure_logs_on_timeout Created with: gclient setdep -r src/third_party/catapult@e3f4b1f5ee13 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:899721 TBR=sullivan@chromium.org Change-Id: I41e617d6b3bd381fc038390eab703afd1434dc94 Reviewed-on: https://chromium-review.googlesource.com/c/1309538Reviewed-by:
-
Mythri Alle authored
This add layout tests to ensure javascript code caching is working as expected. This also adds virtual tests with ( --enable-features=IsolatedCodeCache --site-per-process) to test that the isolated code cache is behaving as expected. These tests test that: 1. code cache is created on the second visit to the script 2. code cache is consumed on the third visit to the script 3. code cache for the same script resource is not reused if requested from a different origin (for the virtual tests). Bug: chromium:879494 Change-Id: I05f92fa129dac2419c84fcc65e9d0c684b9d48e2 Reviewed-on: https://chromium-review.googlesource.com/c/1297363Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#604199}
-
Nico Weber authored
Apparenly preserving the user x bit isn't enough for remoting's installer. Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1301793 Bug: 900303,875279,870611 Change-Id: Ibbdf71b1d33941b0d6bde5e6cc3c964404a653c0 Reviewed-on: https://chromium-review.googlesource.com/c/1308759Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#604198}
-
Ioana Pandele authored
TBR=atotic@chromium.org Bug: 726520 Change-Id: I4711dc131a5c819dc47ef6b1ea4670e3642aa536 Reviewed-on: https://chromium-review.googlesource.com/c/1308939Reviewed-by:
-
Daniel Bratell authored
This allows third_party/cache_invalidation to be checked with gn check (as soon as it's enabled in //.gn). Bug: 898837 Change-Id: Ica669d8a7277178878d630b54879e1439350f566 Reviewed-on: https://chromium-review.googlesource.com/c/1307496Reviewed-by:
Nicolas Zea <zea@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#604196}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/99e9e292a1a3..abc8edfb888a Created with: gclient setdep -r src-internal@abc8edfb888a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie16f0d1ed3e5ad686f45c1e090cde32839b00b65 Reviewed-on: https://chromium-review.googlesource.com/c/1309537Reviewed-by:
-
Luciano Pacheco authored
This reverts commit b7ecb7e9. Reason for revert: ChromiumOS MSAN got flaky/failing crbug.com/899664 Original change's description: > [Reland attempt #2] Refactor DirectoryTree > > Fix flakiness by adding call to this.expanded=true in EntryListItem. > > Change updateSubDirectories: > - use arrow function and const; > - change error callback calling style to match the same style used by > success callback (without if). > - change check from isFakeEntry to check for presence of the method > that's used "createReader". > > Change the sorting to be an method, so it can be customized per > sub-class, later it will be used to sort My files to show Linux and Play > files at the bottom. > > Fix unittest that started failing because it metadataModel was null. > > No changes in behaviour for users, the small change in behaviour is > EntryListItem.updateSubDirectories now reads its children using FS API > which isn't synchronous. > > CrOS FilesApp UI Tests: ensure downloads selected and refreshed in setup > > TBR: joelhockey@chromium.org > Bug: 899664 > Change-Id: I8a93616f74cf3bf2b99851dc2452249e1353d85e > Reviewed-on: https://chromium-review.googlesource.com/c/1306963 > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604069} TBR=joelhockey@chromium.org,lucmult@chromium.org Change-Id: Ic7903e70225a59e3eca7d581ea44202462b01dee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 899664 Reviewed-on: https://chromium-review.googlesource.com/c/1309570Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#604194}
-
Luciano Pacheco authored
This reverts commit 2903236d. Reason for revert: ChromiumOS MSAN got flaky/failing crbug.com/899664 Original change's description: > Change NavigationListModel to support MyFiles as Volume. > > Add MYFILES_VOLUME_ENABLED in private strings to be able to have the > feature flag in the JS/UI code. > > Change VolumeManager to use MyFiles folder for Downloads volume, the > method |GetMyFilesFolderForProfile| takes care of returning the right > value based on the feature flag MyFilesVolume. > > Change NavigationListModel to support MyFiles as Volume when > MyFilesVolume feature flag is enabled: > 1. MyFiles volume is the Downloads volume (after the feature flag is > removed we can rename it accordingly). Setup Downloads volume as > VolumeEntry, > 2. Create a NavigationModelFakeItem with "My files" label, based on the > VolumeEntry (step #1). > 3. Skip adding "Downloads" to Myfiles, since now MyFiles is in fact > Downloads volume. > 4. Continue to add Linux and Play files to Myfiles. > > Test: unit_tests --gtest_filter='VolumeManagerTest.GetVolumeListMyFilesVolume' and browser_test --gtest_filter='FileManagerJsTest.DirectoryTreeTest:FileManagerJsTest.NavigationList*' > Bug: 873539 > Change-Id: Ia242d52a1e4d7b4fb3c7ca219d9cfdc4fce72543 > Reviewed-on: https://chromium-review.googlesource.com/c/1308235 > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604143} TBR=joelhockey@chromium.org,lucmult@chromium.org,ioanap@chromium.org Change-Id: I0c5b1fd5f23b2ec2b56ab13ab93a2d3a1ffd277a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 873539 Reviewed-on: https://chromium-review.googlesource.com/c/1309569Reviewed-by:
-
Hiroki Nakagawa authored
This is a preparation CL for implementing off-the-main-thread worker top-level classic script loading. <Context of this change> Currently, a top-level worker classic script is loaded on the main thread with a parent document's context. In this case, MIME-type of the script is loosely checked for historical reasons. For example, 'text/html' can be executed as a script. On the other hand, once off-the-main-thread script loading is implemented, a top-level worker classic script is loaded on a worker thread with a worker's context and MIME-type of the script is strictly checked. This breaks bunch of web-platform-tests. To keep the backward compatibility, this CL allows WorkerClassicScriptLoader to specify whether to impose strict MIME-type checks regardless of the execution context type. A subsequent CL will disable it when off-the-main-thread top-level worker classic script loading: https://chromium-review.googlesource.com/c/chromium/src/+/1293432 <Possible cleanup in the future> The flag to disable the strict MIME-type check should actually be determined based on the 'fetch client' of script loading, so a subsequent cleanup CL may move the flag from WorkerClassicScriptLoader to FetchClientSettingsObject. Bug: 794548, 835717 Change-Id: I5cc8828966dd7619b30879f3d287505ad4b22fc0 Reviewed-on: https://chromium-review.googlesource.com/c/1293097 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#604192}
-
yoshiki iguchi authored
This is a follow up of crrev.com/c/1303322. This CL adds a test for it. Bug: 897653 Test: passed the added test Change-Id: I546979f9e88c548201c733b446aa6c2f4ab2a7c9 Reviewed-on: https://chromium-review.googlesource.com/c/1308252 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b00b28ee5067..f577ab3d38f9 git log b00b28ee5067..f577ab3d38f9 --date=short --no-merges --format='%ad %ae %s' 2018-10-31 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7e85c092..9996ac89 (604065:604166) Created with: gclient setdep -r src/third_party/webrtc@f577ab3d38f9 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I61583a2d3b39cb47a2caa88fe713d371e22e1f75 Reviewed-on: https://chromium-review.googlesource.com/c/1309536Reviewed-by:
-
Mario Sanchez Prada authored
Bug: 886600 Change-Id: Idd339ae91bffeeceaeee929accde53fedc9f804d Reviewed-on: https://chromium-review.googlesource.com/c/1299162Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#604189}
-
