- 30 Jul, 2018 40 commits
- 
- 
Martin Kreichgauer authoredTouchIdAuthenticator was using FidoAttestationStatement, which is fido-u2f, when it should have been using packed format. This adds a PackedAttestationStatement class and changes the Touch ID code to use it. Bug: 868571, 678128 Change-Id: I84626df6299d4d9df44500dcbbba365e9a30f2a2 Reviewed-on: https://chromium-review.googlesource.com/1153849 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#579131} 
- 
wutao authoredMost of the startup time of Shortcut Viewer is spent to layout the text. This patch only layouts the shortcuts list in the first category and layouts other categories panes in the background. When tested on Linux build: The CreateWidget wall duration is reduced from 403ms to 137ms. The StartupTime is reduced from 1100ms to 900ms. Tested on Eve: The CreateWidget wall duration is reduced from 224ms to 73ms. The StartupTime is reduced from 529ms to 297ms. Bug: 849413 Test: manual. Change-Id: Ia59a90b4eec9c12ba5846883501ee73e8afc8a59 Reviewed-on: https://chromium-review.googlesource.com/1150775 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#579130} 
- 
Takumi Fujimoto authoredThe dialog needs to be closed when a PresentationRequest is fulfilled, so that the user cannot attempt to cast again using the same request. Bug: 868186 Change-Id: I9d00cc5119257bba046e67c750210104123f0bdb Reviewed-on: https://chromium-review.googlesource.com/1151890Reviewed-by: Derek Cheng <imcheng@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#579129} 
- 
Koji Ishii authoredQuerying ComputedStyle::HasBoxDecorationBackground is rather costly, use the cached value from LayoutObject instead for now and add a TODO. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2fc28723066ece5c0059ddd36c0b4e4d641a154f Reviewed-on: https://chromium-review.googlesource.com/1152509 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#579128} 
- 
Jonathan Metzman authoredDon't do ClusterFuzz builds of targets dependant on fuzzable_proto_library when not on Linux. Bug: 869035, 769578 Change-Id: Ic872263c117a2ef63ab4552d0b5d9f200311aed0 Reviewed-on: https://chromium-review.googlesource.com/1155485 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by: Martin Barbella <mbarbella@chromium.org> Cr-Commit-Position: refs/heads/master@{#579127} 
- 
Peter Wen authoredPrint CIPD commands that avoid creating new ones if existing CIPD packages are found with the same tags, display those with `cipd describe` instead. Bug: 867454 Change-Id: I9cccdcf55d5ddb02a98f4dd8d530d9240618b817 Reviewed-on: https://chromium-review.googlesource.com/1155480Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#579126} 
- 
Kenneth Russell authoredSite Isolation has shipped there so it is safe to expose this extension again. Improve the GPU test logs to include the disabled extensions and WebGL extensions, to reduce confusion. Bug: 820891 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I404bcab474046d90f82d9ba6d042fb3eaaf394bd Reviewed-on: https://chromium-review.googlesource.com/1147872 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#579125} 
- 
Sky Malice authoredThe ActionApi implementation might not be the best place to get this information from long term, it seems like the LoggingApi or the SchedulerApi might be more logical places. However, only the ActionApi currently knows when suggestions are used, so send them over for now. Bug: 831648 Change-Id: Ibfd750590eebb54b75fa9fb45a3706aa2b3b96fe Reviewed-on: https://chromium-review.googlesource.com/1135844 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#579124} 
- 
Daniele Castagna authoredSingle buffer mode for pepper relied on TakeFromBuffer associating different mailboxes to the same texture. This does not work anymore after https://crrev.com/c/1097696 and single buffer nacl plugins now sends invalid mailboxes to the compositor. This CL fixes the issue making sure that Graphics3D is aware of the single buffer mode and it will associate only one mailbox, only once, to the front buffer. Bug: 866643, b/111601347 Test: http://nacl-latency.firebaseapp.com runs without flickering Change-Id: I8625fbb87bf3e9503068681bed681c88a068a123 Reviewed-on: https://chromium-review.googlesource.com/1144486 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#579123} 
- 
Ryan Daum authored- Prevent crashes caused by incomplete gesture state when side swipes occur while using side swipe gestures between multiple views. Bug: internal b/111100155 Test: manual Change-Id: I5bd91b9322afc06e2ee69b5f311d60c8e373a5ed Reviewed-on: https://chromium-review.googlesource.com/1155378Reviewed-by:Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#579122} 
- 
Fredrik Hubinette authoredAs far as I can tell, these tests were never really broken, but at some point they started failing because they don't ask for pixel output. Bug: 767926 Change-Id: I80e6934b2c6b07c99a75aec68b0ba6fb3880d193 Reviewed-on: https://chromium-review.googlesource.com/1151715 Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#579121} 
- 
Scott Chen authoredScreenshot after fix: https://imgur.com/a/0C7ZNai This CL adds padding for the sync-confirmation title so the text doesn't go right up to the edge, since that looks pretty broken. Bug: 868090 Change-Id: I7d842068860abe9886c2cfe77af1ca1f48440b85 Reviewed-on: https://chromium-review.googlesource.com/1153555Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#579120} 
- 
Albert Chaulk authoredThis adds the referrer, extra http headers and the upload data stream to the sub request Bug: 110888390 Test: None Change-Id: I66c18e8671ea61dd6078ec871da0b19f72c12589 Reviewed-on: https://chromium-review.googlesource.com/1134035Reviewed-by: Luke Halliwell <halliwell@chromium.org> Commit-Queue: Albert Chaulk <achaulk@chromium.org> Cr-Commit-Position: refs/heads/master@{#579119} 
- 
Ben Pastene authoredBug: 867077 Change-Id: Icad4a62735d3be6579b3c6476bbbb65ad1843ec8 Reviewed-on: https://chromium-review.googlesource.com/1150939Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#579118} 
- 
Daniel Park authored> Logs a new filtering result - if the survey already existed > Logs if a download was requested or not as a histogram This is logged downstream Bug: 842692 Change-Id: Ifc4a2e9ff3a1e334a6983bf7e1a68038ff58d710 Reviewed-on: https://chromium-review.googlesource.com/1057446Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#579117} 
- 
Vladimir Levin authoredThis patch splits ups the four major components of lifecycle updates: - Style and layout - Compositing - PrePaint - Paint into separate functions, named similarly to indicate that they are a part of lifecycle updates. It also separates various checks and state set up to be in a wrapper function around UpdateLifecyclePhasesInternal to ensure that the lifecycle updates themselves are easy to follow. Also adds comments throughout. R=chrishtr@chromium.org Change-Id: I5fb23bd48757866bdb42e49b6d35fa99fa9f8d41 Reviewed-on: https://chromium-review.googlesource.com/1136882 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#579116} 
- 
Clark DuVall authoredTests now wait for the webRequest listeners to be set up, and the correct render_frame_id is now used in WebRequestInfo. The reason tests need to wait for listeners to be set up with the network service is that requests need to be proxied through WebRequestProxyingURLLoaderFactory for web request listeners to be called. Since this proxy is in the browser process, we only set it up when necessary for performance reasons. This means that if there are no web request listeners set up, we do not proxy requests, but when the first listener is set up we then reset all URLLoaderFactories, which causes them to be recreated with the proxy. Because of this, there is a behavior difference in the network service, where code like: chrome.webRequest.foo.addListener(...); sendSomeRequest(...); will no longer work with network service. This should probably be fine since this is a very rare occurrence. For more discussion on this, see crbug.com/784576#c19. Bug: 721414 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I92fb4a02b14641886624a726301acc9e95f53533 Reviewed-on: https://chromium-review.googlesource.com/1149407Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#579115} 
- 
Saman Sami authoredBug: 868828,827242 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I13199db914192ab81bbe6fd34b086b58fa275fa4 Reviewed-on: https://chromium-review.googlesource.com/1155005Reviewed-by: Fady Samuel <fsamuel@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#579114} 
- 
Gabriel Charette authoredOops hadn't saved file locally before "git cl upload -c" for last patch set @ https://chromium-review.googlesource.com/c/chromium/src/+/1153458 TBR=kylechar@chromium.org Bug: None Change-Id: I4466d287a80f4472b61da2017c28c01ff31c4dbb Reviewed-on: https://chromium-review.googlesource.com/1155250Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#579113} 
- 
Jose Dapena Paz authoredAnother regression in GCC build caused by the introduction of wtf_size_t on WTF::Vector in the commit 9d0fd86c "Introduce wtf_size_t which is typedef for uint32_t". In this case, it failed because the WTF::CrossThreadCopier structs for vector were still using size_ instead of wtf_size_t. Bug: 819294 Change-Id: I62811a58218696f5c3bd409132b44954ff682a40 Reviewed-on: https://chromium-review.googlesource.com/1155110Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#579112} 
- 
Yao Xiao authored(FullscreenSecureOrigin + FullscreenInsecureOrigin) / PageVisits = 1.78% Bug: 864196 Change-Id: I88e313288e5d960ba8bc93cef4b45b8a2e6af8ac Reviewed-on: https://chromium-review.googlesource.com/1151652Reviewed-by: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Bryan McQuade <bmcquade@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#579111} 
- 
Leonard Grey authoredWhen the native share menu was an experiment, we needed to replace the Email Page Location menu item at runtime if the experiment was enabled. It's now been enabled for a while, so this change removes the Email Page Location menu item entirely and creates the Share menu item as part of the initial menu creation. Also removes the experiment infrastructure for share menu. Bug: 770804 Change-Id: If5f17c213ffb185b461ee4e766423c647cb43e18 Reviewed-on: https://chromium-review.googlesource.com/1152007 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#579110} 
- 
Vadym Doroshenko authoredThis classifier is superseded by server-side classifiers. Since the generation logic in the renderer process is going to be refactored and simplified, that the good time to remove it. Bug: 866444, 621442 Change-Id: I813d53fda594956813fc8cd83567712e34331cfb Reviewed-on: https://chromium-review.googlesource.com/1146724 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#579109} 
- 
John Budorick authoredThey've bitrotten quite a bit :( Bug: 853040,824539 Change-Id: I5127a984e7a92a7fc74cd57b9f5945f3abe7c5f6 Reviewed-on: https://chromium-review.googlesource.com/1120431Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#579108} 
- 
Koji Ishii authoredThis patch excludes SelfPaintingLayer fragments, such as 'visibility: hidden', from ContentsInkOverflow, by following the logic in LayoutBox::AddOverflowFromChild. Seems to fix 10 tests. 2 layer dump rebaselines are no longer needed, but compositing/iframes/floating-self-painting-frame.html starts failing. Somehow we fail to invalidate the self painting layer created by iframe. Bug: 635619 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I09ab9a5fa2c062acf4d5cd37225e5c8f756ad04b Reviewed-on: https://chromium-review.googlesource.com/1155029Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#579107} 
- 
catapult-chromium-autoroll authoredhttps://chromium.googlesource.com/catapult.git/+log/dd9e5b9c8c10..0f2c4fec1272 git log dd9e5b9c8c10..0f2c4fec1272 --date=short --no-merges --format='%ad %ae %s' 2018-07-30 dtu@chromium.org [pinpoint] Rename "Values" to "Get results". 2018-07-30 wangge@google.com Add new flag '--compatibility-mode' to Run Benchmark in Compatibility Mode Created with: gclient setdep -r src/third_party/catapult@0f2c4fec1272 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866881 TBR=sullivan@chromium.org Change-Id: I9c8ba6acf9bc368320880b603b4453953a0f033d Reviewed-on: https://chromium-review.googlesource.com/1155227Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579106} 
- 
Ted Choc authoredTrack whether form submits have user gestures when opening external applications. BUG=839751 Change-Id: I2b3689bc3eded951641ecab80ed2e3f363ff2abb Reviewed-on: https://chromium-review.googlesource.com/1153771Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Troy Hildebrandt <thildebr@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#579105} 
- 
Michael Spang authoredThis broke as of b29640a7 ("[ozone/wayland/drm] Implement gbm bo wrapper in common."). Bug: 866564 Test: compile Change-Id: Id85dbb719e39b61f11cb756bbb7212d8bfdf88b3 Reviewed-on: https://chromium-review.googlesource.com/1151457Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#579104} 
- 
skia-chromium-autoroll authoredhttps://skia.googlesource.com/skia.git/+log/c06b8a4e0ca3..62501c12c83e git log c06b8a4e0ca3..62501c12c83e --date=short --no-merges --format='%ad %ae %s' 2018-07-30 brianosman@google.com Remove unused 'create_flutter_test_images' tool 2018-07-30 herb@google.com Combine GPU drawing routines into one large routine 2018-07-30 fmalita@chromium.org [sksg] Fix image filter quality handling 2018-07-30 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 779b8c7799f3..c663954a7567 (1 commits) 2018-07-30 brianosman@google.com Add 'u' to zoom stats display on high DPI devices 2018-07-30 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 6b7ef53d3298..779b8c7799f3 (1 commits) 2018-07-30 bsalomon@google.com Introduce enum class for texture type. 2018-07-30 herb@google.com Make a glyphrun version of DrawBmpPosTextAsPaths 2018-07-30 herb@google.com Make SkInternalAtlasTextTarget use glyph runs 2018-07-30 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 51fba282d9a0..6b7ef53d3298 (1 commits) 2018-07-30 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 23e7777f421d..51fba282d9a0 (1 commits) Created with: gclient setdep -r src/third_party/skia@62501c12c83e The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: If8b9200e3040acf6e3e13336f76f1798c4ab80ea Reviewed-on: https://chromium-review.googlesource.com/1155168Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579103} 
- 
Kurt Horimoto authoredWhen closing the last incognito tab, the incognito TabGridMediator's TabModel is reset to nil as the incognito BrowserState is being destroyed. This can occur by tapping the close button and new tab button at the same time, or simply by tapping the new tab button when a tab is closed by JavaScript. Simultaneous button tapping was disabled by crrev.com/c/1150634. This CL adds an extra safeguard to prevent the creation of WebStates with a nil BrowserState. Bug: 838961 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iae669290bb9d8079861d488e46cd59495dc809fb Reviewed-on: https://chromium-review.googlesource.com/1152454Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#579102} 
- 
Min Qin authoredChrome assigns a download Id to each new download. This ID was retrieved from the history DB on start up, and then keep on incrementing. For in-progress DB work, download will only be stored to history DB once they finish. As a result, the history DB don't have all the Ids on startup. This CL lets the DownloadManagerImpl to get all Ids from both history DB and In-progress downloads. And use the largest Id to issueing out new Ids for new downloads. This allows in-progress downloads to have their own IDs without reporting them to history DB. BUG=842245 Change-Id: Ia5130f02b0e32e09ba4395a6bfa10dfd5adafc82 Reviewed-on: https://chromium-review.googlesource.com/1144311 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#579101} 
- 
ccameron authoredThis reverts commit 9d5b1986. Reason for revert: Didn't fix the crashes Original change's description: > Revert BridgedNativeWidget compositor recycling > > We've previously disabled this, but now try reverting all of the code > back to the way it was prior to compositor recycling being possible. > > TBR=lgrey (revert of files from https://crrev.com/574738) > > Bug: 863817 > Change-Id: I1b933e17c523fb14860284f06631cb2af0c4bf98 > Reviewed-on: https://chromium-review.googlesource.com/1152548 > Reviewed-by: ccameron <ccameron@chromium.org> > Commit-Queue: ccameron <ccameron@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578522} TBR=ccameron@chromium.org,lgrey@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 863817 Change-Id: I66f78ab5d216b7a29719005c2117cecfa71a8c2a Reviewed-on: https://chromium-review.googlesource.com/1155051Reviewed-by: ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#579100} 
- 
Nate Chapin authoredBug: 868253 Change-Id: Ib79fe6b36e3bfb06bc44d050d154c1ad23cf1585 Reviewed-on: https://chromium-review.googlesource.com/1153469Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#579099} 
- 
perfetto-chromium-autoroll authoredhttps://android.googlesource.com/platform/external/perfetto.git/+log/7e4b89eab724..296b43d7e177 git log 7e4b89eab724..296b43d7e177 --date=short --no-merges --format='%ad %ae %s' 2018-07-30 hjd@google.com perfetto-ui: Fix half pixel offset in TimeAxis Created with: gclient setdep -r src/third_party/perfetto@296b43d7e177 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I544c81f24a8b570454c02fcab70b2678aaac6bec Reviewed-on: https://chromium-review.googlesource.com/1155009 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579098} 
- 
Dan Harrington authoredBug: 852872 Change-Id: Id8211211920db4ee977ea0dfd665b0c571ccd224 Reviewed-on: https://chromium-review.googlesource.com/1147090 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#579097} 
- 
Peter Boström authoredSitePerProcessHitTestBrowserTest.TouchpadPinchOverOOPIF is being reported as flaky on Windows. Bug: chromium:868308, chromium:833380 TBR: kenrb@chromium.org Change-Id: I83142d0d777bbe51773eaba0ab1d191a4af0cbc5 Reviewed-on: https://chromium-review.googlesource.com/1155165Reviewed-by: Kevin McNee <mcnee@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#579096} 
- 
Mark Pearson authoredFixes code and corresponding text. Tested change interactively using the repro steps on the bug. Bug: 868486 Change-Id: Id81cbddf28242b6c4efe5c50595fdb393d59d5b1 Reviewed-on: https://chromium-review.googlesource.com/1154432 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#579095} 
- 
Tessa Nijssen authoredCurrently, when a user selects multiple lines of text, right clicks, and selects "Look Up", the yellow overlay appears on the last line of the selected text but with the text of the first line of the selected text. WebSubstringUtil::GetBaselinePoint() was modified to call FirstRectForRange() instead of ComputeTextRect(). FirstRectForRange() returns the IntRect for the first line of text which is needed to get the baseline point of the first line of text. WebViewTest.WebSubstringUtilBaselinePoint was added to test that the baseline point does not change when multiple lines of text are selected compared to a single line of text. Bug: 819864 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iec0bac8d45baf2142ea5e826ebdfd7d997e7f584 Reviewed-on: https://chromium-review.googlesource.com/1103448 Commit-Queue: Tessa Nijssen <tnijssen@google.com> Reviewed-by: Emil A Eklund <eae@chromium.org> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#579094} 
- 
kristipark authoredAdded functionality for editing the title and URL of a custom link. If the new URL already exists as a custom link, the edit is not applied. Bug: 851293, 856394 Change-Id: I8a5351644370b6f91ef4376e7b336dce6831acbd Reviewed-on: https://chromium-review.googlesource.com/1152495 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#579093} 
- 
Wei-Yin Chen (陳威尹) authoredA CL adding new headers without corresponding GN changes is likely wrong. Bug: 661774 Change-Id: I11da5615b36ebc7b9f60490beb3a39874bd74ac2 Reviewed-on: https://chromium-review.googlesource.com/1152126 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#579092} 
 
-