Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 19 Nov, 2015 37 commits
  3. 18 Nov, 2015 3 commits
    • dzhioev's avatar
      Remove Chrome OS Mirror UI. Part 2. · c694a022
      dzhioev authored 
      InlineLoginDialog removed.

BUG=546731

Review URL: https://codereview.chromium.org/1457683002

Cr-Commit-Position: refs/heads/master@{#360448}
      c694a022
    • estade's avatar
      [MD] update EV bubble icon and location bar https icons · e9b57b3e
      estade authored 
      - Lock icon in EV bubble is not supposed to have a background box
- location bar https icon has different colors for incognito

Colors that are hardcoded for inverted color schemes (as they no longer match their native theme values):
- chip border and background colors are white
- selected keyword chip is blue700
These colors could be made part of NativeTheme, but they seem specific to these chips, so I just set them inline.

BUG=501377

Review URL: https://codereview.chromium.org/1448433004

Cr-Commit-Position: refs/heads/master@{#360447}
      e9b57b3e
    • alancutter's avatar
      Revert of Bind Application in renderer (patchset #15 id:280001 of... · 1b3bd8ec
      alancutter authored 
      Revert of Bind Application in renderer (patchset #15 id:280001 of https://codereview.chromium.org/1452823003/ )

Reason for revert:
This change is making hundreds of webkit_tests crash on linux_chromium_rel_ng with:

[1:1:1118/141621:108326049405:FATAL:lock.cc(32)] Check failed: owning_thread_ref_.is_null().
#0 0x00000067e2de base::debug::StackTrace::StackTrace()
#1 0x00000057a71f logging::LogMessage::~LogMessage()
#2 0x0000005eb69b base::Lock::CheckUnheldAndMark()
#3 0x000000518e1c base::Lock::Acquire()
#4 0x000000518b43 base::AutoLock::AutoLock()
#5 0x0000005b4014 base::SequenceCheckerImpl::CalledOnValidSequencedThread()
#6 0x000006f074ae IDMap<>::Lookup()
#7 0x000006f0598c content::RendererBlinkPlatformImpl::SetPlatformEventObserverForTesting()
#8 0x000008459264 content::SetMockGamepadProvider()

Original issue's description:
> Bind Application in renderer.
>
> This involved changing how we get the client handle to the renderer. In the first iteration I was passing this on the command line but that turns out not to work with the sandbox. So instead I an approach used by the Mojo-in-Chrome MojoApplication class and pass the primordial handle via Chrome IPC.
>
> I had to twiddle a bunch of BUILD.gn files in content to get this to work without crashing due to inconsistencies in how MOJO_SHELL_CLIENT was defined.
>
> R=jam@chromium.org,tsepez@chromium.org
> http://crbug.com/551253
>
> Committed: https://crrev.com/3edb97198bc5fbc22c5cf13286e8af80449ddfb9
> Cr-Commit-Position: refs/heads/master@{#360293}
>
> Committed: https://crrev.com/2c716f9d5ebff610641f4506c17ec81d4b89b7bb
> Cr-Commit-Position: refs/heads/master@{#360396}

TBR=jam@chromium.org,tsepez@chromium.org,ben@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1457173002

Cr-Commit-Position: refs/heads/master@{#360446}
      1b3bd8ec