- 29 Jan, 2018 21 commits
-
-
Han Leon authored
This CL mojofies the 2 legacy IPCs: ServiceWorkerHostMsg_SkipWaiting ServiceWorkerMsg_DidSkipWaiting BUG=772793 Change-Id: Ieed08b0eec8da72d87b93500f82f74d85803545c Reviewed-on: https://chromium-review.googlesource.com/880602 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#532318}
-
Yuzu Saijo authored
This CL moves reddit to resource_loading_list, because reddit has been flakily timing out with a resource load. Change-Id: I886f418863c1f3a1834441b5215dbd04a5604ba7 Reviewed-on: https://chromium-review.googlesource.com/882643Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#532317}
-
Charles Zhao authored
(1) Add generic logstic regression to support preprocessed model. (2) Also add validation logic in binary classifer to prevent misuse preprocessed_model with non-preprocessed_model. Change-Id: Idf3f531c8d7bd45d31a45f6e54be0752a02334d1 Reviewed-on: https://chromium-review.googlesource.com/885541 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by:
Philippe Hamel <hamelphi@chromium.org> Cr-Commit-Position: refs/heads/master@{#532316}
-
Naoki Fukino authored
In some vide files, there is no I-frame after the first frame. In this case, seeking to some position may end up loading entire video. To avoid the issue in Image Loader, we should abort loading video file when we don't receive 'canplay' event for a while. Bug: 777521 Test: Manually tested using the video on the issue. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icb37b457d7753c46592894993a235840d0c92fd7 Reviewed-on: https://chromium-review.googlesource.com/888233 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#532315}
-
Ryo Hashimoto authored
GURL::ExtractFileName() does not unescape the string. Bug: 806192 Test: unit_tests --gtest_filter="ArcFileSystemBridgeTest.*" Change-Id: I31409e7554ae361de9cca809dfbe1a6ef6111b0e Reviewed-on: https://chromium-review.googlesource.com/888189Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#532314}
-
Andrew Grieve authored
If an apk had a post-process action defined, and then later it was removed, the post-process depfile would become the process_resources.py depfile. Change-Id: I1b5d26f800772db6c25bd6a34ce5a7a3bed75f1c Reviewed-on: https://chromium-review.googlesource.com/890172Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#532313}
-
Megumi Hattori authored
Before this CL, the reply icon color was opaque white regardless of whether the textfield is empty or not. This CL Changes the icon color to transparent white (opacity: 38%) when textfield is empty. BUG=803759 Change-Id: Id7824e62fd44b0700ea5608b222cdda4de03048c Reviewed-on: https://chromium-review.googlesource.com/886204Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Megumi Hattori <megumihattori@google.com> Cr-Commit-Position: refs/heads/master@{#532312}
-
Takayoshi Kochi authored
Bug: 802185 Change-Id: Ibbffe82ac4dfdeb200e608deb908dbbc691459f1 Reviewed-on: https://chromium-review.googlesource.com/888459Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#532311}
-
Austin Tankiang authored
This allows the lifetime of WeakInterfacePtrs to be tied to an ExecutionContext, as now the interface can be tied to an invalidator whose lifetime is bound to an ExecutionContext. Bug: 800641 Change-Id: I0c922c90a89108f56c179b74170a8e0e2a5f666f Reviewed-on: https://chromium-review.googlesource.com/872470 Commit-Queue: Austin Tankiang <austinct@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#532310}
-
Han Leon authored
This CL mojofies the 2 legacy IPCs: ServiceWorkerHostMsg_GetClient ServiceWorkerMsg_DidGetClient BUG=772793 Change-Id: I3a069713c1ed0068883214c6ba583eca758ed323 Reviewed-on: https://chromium-review.googlesource.com/880486 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
-
Kent Tamura authored
HTMLConstructionSite should call CustomElementDefinition:: CreateElementAsync() if it's in fragment parsing mode. - Separate HTMLElementFactory::createHTMLElement() into two. CreateElementAsync() uses the first part of separated functions. Bug: 805280 Change-Id: I2e2dafcd33c033c87c3accaca7c1b00c56474591 Reviewed-on: https://chromium-review.googlesource.com/890680Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#532308}
-
Dmitry Gozman authored
If a message comes right before navigation, and we send it out but never get a response from the old renderer (e.g. it was killed), and then suspend messages due to navigation, the original message is stuck in waiting_for_response_messages_ and will not be dispatched when resuming upon navigation finish. To mitigate this, we move all waiting messages to suspended if we are not resending them to new renderer due to being currently suspended. Bug: 803678 Change-Id: I125609e0ec8a5e2b98ff2d81a9e71732fc8f6f0f Reviewed-on: https://chromium-review.googlesource.com/887435Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#532307}
-
Meredith Lane authored
Adds the attributes into the ComputedAccessibleNode interface, and accessors on the content tree for an AXNode with a given ID. This is the first of the accessors for the wider set of ComputedAccessibleNode's properties. The other types will be added in seperate CLs. This change also introduces an AOMIntAttribute enum, which is translated to an AXIntAttribute inside content to retrieve the corresponding accessible property. This will also be expanded to the other types in later CLs. BUG=792783 Change-Id: I39875ae8eef03620b85c8480fd1ffc590c3591d5 Reviewed-on: https://chromium-review.googlesource.com/869911 Commit-Queue: Meredith Lane <meredithl@google.com> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#532306}
-
Eric Willigers authored
LHS and RHS of comparison were identical, when we should have been comparing the current parent rotation with the stored parent rotation. Added a responsive animation test where the inherited rotation changes from none. BUG=806085 Change-Id: I9fc85ff2b7ddd894bd07d03eed90f8c23f26f6e4 Reviewed-on: https://chromium-review.googlesource.com/890682Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#532305}
-
Ilya Sherman authored
R=asvitkine@chromium.org Bug: 727984 Change-Id: I58348938e320daa4645327c2e160dcaaf988f1f2 Reviewed-on: https://chromium-review.googlesource.com/888172 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#532304}
-
Nico Weber authored
This CL was uploaded by git cl split. R=yosin@chromium.org Bug: 177475 Change-Id: Ia3fdc134c6bf9a85f215156a8da48d2fcfbf4e83 Reviewed-on: https://chromium-review.googlesource.com/889962Reviewed-by:
-
Rob Buis authored
Serialize Text nodes for HTML fragments correctly as described in the spec: https://html.spec.whatwg.org/#serialising-html-fragments Bug: 651762 TEST=external/wpt/html/syntax/serializing-html-fragments/serializing.html Change-Id: Ib9e66b04caa82b366cf1c0f846ed9c597cba74a9 Reviewed-on: https://chromium-review.googlesource.com/886646 Commit-Queue: Rob Buis <rob.buis@samsung.com> Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Changes all uses of base::Bind and base::Closure in BookmarkAppNavigationThrottle code. base::Bind and base::Closure are deprecated in favor of base::BindOnce and base::OnceClosure. Bug: 804653 Change-Id: Idc4b84649b52835d67aaedd83c50cb7c0e0a7c00 Reviewed-on: https://chromium-review.googlesource.com/880082Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#532301}
-
Jinsuk Kim authored
WebContentsAccessibility as the implementation of AccessibilityNodeProvider can get |createAccessibilityNodeInfo| even past the WebContents finished its lifecycle. In such case mWebContents should be null-checked to prevent crash. This CL puts the missing check that caused the reported crash. Bug: 806033 Change-Id: Ic80a6fd7d6289aab332a60221cd3c7a1c93d12c8 Reviewed-on: https://chromium-review.googlesource.com/887698Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#532300}
-
Jordy Greenblatt authored
classes with factories. At the moment we have classes with factory methods that have public constructors. Because the constructors only have to been visible to the factory and unittests, they should be protected. Bug: 775753 Change-Id: I410b5c40446b8957c4f08840069b12a870d8c93f Reviewed-on: https://chromium-review.googlesource.com/883612Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#532299}
-
Chris Nardi authored
According to the CSSOM spec (https://drafts.csswg.org/cssom/#common-serializing-idioms), all strings should be serialized with double-quotes. The feature tag value was previously serialized with single-quotes; change this to double-quotes to match the spec and non-WebKit browsers. Bug: 806412 Change-Id: I5a93cc6add285aff46184c238b180e7617750702 Reviewed-on: https://chromium-review.googlesource.com/889909 Commit-Queue: Chris Nardi <cnardi@chromium.org> Reviewed-by:
-
- 28 Jan, 2018 19 commits
-
-
Yoshifumi Inoue authored
This patch add [HTMLConstructor] IDL extend attribute[1] to interface declaration of all of HTML element except for below to support custom element. Following HTML elements are not supported by this patch - <canvas> [2] Blink IDL compiler issue - <embed> [3] Crash in V8 - <form> [4] Crash in Blink - <iframe> [2] Blink IDL compiler issue - <input> [2] Blink IDL compiler issue - <object> [5] Crash in V8 - <video> [2] Blink IDL compiler issue [1] https://html.spec.whatwg.org/multipage/dom.html#htmlconstructor [2] http://crbug.com/806163 Blink IDL compiler should ignore HTMLConstructor extended attribute [3] http://crbug.com/806184 HTMLEmbedElement.idl should have HTMLConstruct extend attribute [4] http://crbug.com/806185 HTMLFormElement.idl should have HTMLConstruct extend attribute [5] http://crbug.com/806187 HTMLObjectElement.idl should have HTMLConstruct extend attribute Bug: 805326 Change-Id: Iccd292766102dbcd3eebf3ec1fd044dc4ff266b5 Reviewed-on: https://chromium-review.googlesource.com/888228 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
JavascriptInjector instance cached in |AwContents| was left untouched upon destruction. This is fine for normal webview but popup window whose WebContents is swapped out on loading kept using the cached one, therefore caused a problem restoring the injected Javascript interface objects into the new WebContents. This CL fixes that by nulling it out, and adds an instrumentation that does what the failing CTS test does. Bug: 800941 Change-Id: I8fb50998fd461316d6fd4dc34f6a02f95856d24d Reviewed-on: https://chromium-review.googlesource.com/886122Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#532296}
-
Raymes Khoury authored
This removes the CancelRequest functionality from the permissions UI code. Cancelling permission requests is rarely used and very complicated. It's not actually needed as requests will automatically be cancelled when the user navigates. Callers can use weak pointers in the request callback if they expect that the lifetime of the request will outlast the lifetime of the callsite. Bug: 792382 Change-Id: Ib757b9d796b80474e06af3a341bbf565ff9ff2e9 Tbr: lcwu@chromium.org Reviewed-on: https://chromium-review.googlesource.com/876746 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
Randy Smith <rdsmith@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#532295}
-
Eric Karl authored
To understand the cost of workarounds for low-bit-depth banding with alpha we need to know how many tiles rasterized are opaque. This UMA should give us a reasonable approximation, and might be useful in other cases as well. R=vmpstr Bug: 789153 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ic66314fb189bf87cc5892cc1e0d6f0970229226f Reviewed-on: https://chromium-review.googlesource.com/886566 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#532294}
-
Chris Nardi authored
calc() was previously unsupported in webkit-gradient and webkit-cross-fade, but both should take calc() values. Update the code to support calc() values. Bug: 397061 Change-Id: Icadf35d5fa0d4c01de24cabbdb0f0d8435e73c69 Reviewed-on: https://chromium-review.googlesource.com/890700 Commit-Queue: Chris Nardi <cnardi@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#532293}
-
Raymes Khoury authored
Currently we still display the text "Location - Blocked for current search engine" in Page Info when in incognito mode. However, in reality, DSE settings don't impact incognito mode so we should just display the same thing in Page Info as we do for a regular website. Change-Id: I0dc820f888945adb4288c1aec65f2c3d726f252f Reviewed-on: https://chromium-review.googlesource.com/885382Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
-
Adam Langley authored
I noticed one case in the README.md and figured that I should fix them all. Change-Id: I7c48a7a178ed377073c8e49a1884c961e8075053 Reviewed-on: https://chromium-review.googlesource.com/872194 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#532291}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/75f4c4058811..4a49068fafa8 $ git log 75f4c4058..4a49068fa --date=short --no-merges --format='%ad %ae %s' 2018-01-28 fmalita [skottie] Simplify layer matrix caching Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: If1195e4a73a57b33d1e3d60626a3204546b28d97 Reviewed-on: https://chromium-review.googlesource.com/890639 Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#532290}
-
David McAllister authored
BUG=None TEST=GpuMemoryBufferTest on Pixel, Nexus Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If63280993d620c8db00ed1f7eaccda8b1dee83a5 Reviewed-on: https://chromium-review.googlesource.com/871973Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#532289}
-
Adam Langley authored
In the U2F code we have supported an individual attestation signal to tokens based on a magic AppID. Since we hate that sort of special casing, it is being transitioned to using an enterprise policy to enumerate AppIDs and RP IDs which should get this treatment. This change adds the policy-based behaviour to webauthn so that we can, hopefully, eventually discontinue the use of the U2F API. Bug: none Change-Id: Ifc68792c91947f9233e1be50477f338e7cb4bb6c Reviewed-on: https://chromium-review.googlesource.com/876803 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#532288}
-
Peter Boström authored
Replaces the dialog showing "Saved passwords for this site:" as title alongside "No passwords saved." in the body. Instead this now shows only "No passwords saved for this site" as title. Bug: chromium:654115 Change-Id: Id8c340991fd22a5406112788ddf24e04b79487b5 Reviewed-on: https://chromium-review.googlesource.com/847908 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#532287}
-
Daniele Castagna authored
Currently GpuMemoryBufferVideoFramePool allocates buffers with GPU_READ_CPU_READ_WRITE usage. This means these buffers won't be used for scanout (no fb added on CrOS). This CL simply changes the usage used when allocating buffers to SCANOUT_CPU_READ_WRITE, in this way this buffers will be created for scanout, if possible. Note that SCANOUT implies GPU_READ, meaning that in case the allocation of the buffer for scanout will fail, the buffers will be allocated exactly as they'd be if GPU_READ_CPU_READ_WRITE were used instead. Bug: b/71837407 Change-Id: I3a03daf721f1cc04038a4f6f91985b5affe2a276 Reviewed-on: https://chromium-review.googlesource.com/884401 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#532286}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/04fce9c80879..75f4c4058811 $ git log 04fce9c80..75f4c4058 --date=short --no-merges --format='%ad %ae %s' 2018-01-28 fmalita [skottie] Switch animators to SkTArray Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: Ia338e706b9587bc2c05e6c0b5190655dca3c48c5 Reviewed-on: https://chromium-review.googlesource.com/890699Reviewed-by:
-
Jay Civelli authored
Bug: 775677 Change-Id: I8a974f2e43218bd8e91a2f6377ec22bf044cc2ba Reviewed-on: https://chromium-review.googlesource.com/887753Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#532284}
-
Koji Ishii authored
Following bot results are included. 3314 3325 3328 3334 3335 3336 3337 3338 3340 3342 3343 3344 3345 3351 3352 3353 3354 3355 100 lines were removed and 151 lines were deflaked by consecutive results since 3300. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I482e02b642fe97129f875362f8d45e700427e894 Reviewed-on: https://chromium-review.googlesource.com/886901 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#532283}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d8685f3c. With Chromium commits locally applied on WPT: 9f32e9c0 "S13nServiceWorker: Add tests for network fallback for navigations with request bodies" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/11182 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-writing-modes TBR=leon.han@intel.com No-Export: true Change-Id: Ic131a4b21c27e843fa9a3cd51b540ddd9782a853 Reviewed-on: https://chromium-review.googlesource.com/890363 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#532282}
-
David Tseng authored
(i.e. focusObject == anchorObject) Test: verify that moving a caret (*not a selection*) never results in a non-collapsed selection in the accessibility tree data Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I29f3d807fd7d9e29b997e3f1969f60d7a99b170a Reviewed-on: https://chromium-review.googlesource.com/884991Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#532281}
-
Matt Wolenetz authored
SAP-Type-2 sequences may contain a nonkeyframe so far in advance of the range's first GOP's keyframe timestamp that it may appear to belong to the presentation interval of some other range. If we continued to use |last_appended_buffer_timestamp_| when re-determining |range_for_next_append_| upon consulting PotentialNextAppendTimestamp() during buffer removal operations that touched the current |range_for_next_append_|, we could incorrectly append to the earlier range. This change uses the |highest_timestamp_in_append_sequence_| in PotentialNextAppendTimestamp(), enabling correct determination of |range_for_next_append_| when such SAP-Type-2 scenarios are encountered when BufferingByPts. Note: This change continues the direction of the BufferingByPts logic so far: it doesn't move a range's start time earlier if that range contains a nonkeyframe from a SAP-Type-2 GOP before the range's starting keyframe. This greatly simplifies adapting our existing logic to gracefully handle SAP-Type-2, with the known caveat that range start times don't indicate any potentially buffered earlier SAP-Type-2 nonkeyframes. See also https://crbug.com/798935#c10 BUG=798935,804802,795655 TEST=Added SBST.Sap2GopWithNonKeyframeInEarlierRangesInterval, and the CF cases for bugs 798935 and 804802 no longer repro locally with this change. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ieff9b086ec9ac73f02a6bfbfa406765b434d9728 Reviewed-on: https://chromium-review.googlesource.com/879408 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#532280}
-
Nico Weber authored
This CL was uploaded by git cl split. R=michaeln@chromium.org Bug: 177475 Change-Id: I3ebd2f2384837724637614391d1894f870662b6f Reviewed-on: https://chromium-review.googlesource.com/889731Reviewed-by:
-
