GitLab

This reverts commit 2c449f4d.

Reason for revert: Because of this was a Chromium bug and it is currently fixed, we are reverting this change.

Original change's description:
> [ChromeDriver] Disable failing tests on Waterfall on Windows build bot
> 
> Disabling failing tests testDownloadDirectoryOverridesExistingPreferences and
> testExistingDevToolsPortFile on Waterfall on Windows build bot
> 
> Bug: 907608:chromedriver:2673
> Change-Id: I74adcfa17f6349aa74805e6905fa630661ea4a9b
> Reviewed-on: https://chromium-review.googlesource.com/c/1347613
> Reviewed-by: John Chen <johnchen@chromium.org>
> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610254}

TBR=johnchen@chromium.org,khachatryan@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 907608:chromedriver:2673
Change-Id: I159363b6d2712ef07fbf0d833cce4baeea4b4fd3
Reviewed-on: https://chromium-review.googlesource.com/c/1351290Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610880}

base::AssertBlockingAllowedDeprecated is deprecated in favor of
ScopedBlockingCall, which serves as a precise annotation of
the scope that may/will block.

Please make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation:
      MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache).
      WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging
        server synchronously).
    See BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().
  - Calls to blocking //base APIs don't need to be annotated
    with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read,
    base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their
    own internal annotations.

Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1338391

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=reillyg@chromium.org

Bug: 903957
Change-Id: I232ee84dfca8770994440c95abf2eb17f0780e83
Reviewed-on: https://chromium-review.googlesource.com/c/1338485
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610879}

The unit test currently fails in LayoutNG due to different location/size
of BODY element from legacy layout, which occurs only in quirks mode.
Since quirks mode is not of priority, this patch changes the test to use
standards mode so that it also passes in LayoutNG.

Bug: 906190
Change-Id: If655826bd8ddd641c4dc6ce04f3a5acb10d1b5d9
Reviewed-on: https://chromium-review.googlesource.com/c/1347775
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610878}

The basic codepage converion functions in base, namely, CodepageToUTF16,
CodepageToUTF16, and ConvertToUtf8AndNormalize are now taking
StringPiece as the input type. This allows more flexibility when using
theses interfaces, as well as providing the benefit of avoiding
unnecessary string copies.

Change-Id: I5922bd7cc3236f99fbac9393cba61afd9c475af3
Reviewed-on: https://chromium-review.googlesource.com/c/1349652
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610877}

We want to A/B test two different backends for MessageLoop: (old) MessageLoopImpl and
(new) SequenceManager, as part of an ongoing effort to get rid of MessageLoop
completely. In order to use Finch, we move its initialisation before that of
MessageLoop in all builds and tests.

Bug: 891670
Change-Id: I808f72b6cf36238f7a2380568a0898ed6c0f5557

Forcing due to fuschia_x64 tests failing because of infrastructure flakiness.
NOTRY=true

Change-Id: I808f72b6cf36238f7a2380568a0898ed6c0f5557
Reviewed-on: https://chromium-review.googlesource.com/c/1333770
Commit-Queue: Karolina Soltys <ksolt@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610876}

We see significant numbers of failures. There are many steps where the
migration can fail, so we will distinguish them to identify the fragile step.

Bug: 571003
Change-Id: I23703898d86fcc3ad714228ac8dbeb5ec7e4589b
Reviewed-on: https://chromium-review.googlesource.com/c/1280766Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610875}

Cast or use appropriate type where applicable.

BUG=879657

Change-Id: I94f2a425e14281978bce8bfaf256f69b90af7bda
Reviewed-on: https://chromium-review.googlesource.com/c/1347047Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610874}

The PluginVmImage policy has been introduced as a device policy, which
turned out to be wrong. Since it has not been used yet, we can change
it to a user policy. Pref mappings will follow with a separate CL.

Bug: 904843
Change-Id: I6f9e7f4288bfafc4cd89a5bef0bdf38a397239b1
Reviewed-on: https://chromium-review.googlesource.com/c/1348094
Commit-Queue: Alex Oldemeier <aoldemeier@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610873}

c60563591a9a86196f19987c81dde4384a088861 -> d6d98957ca8ccb1ef45922e978bb10efca0ea541

Sep 20, 2017 -> Oct 23, 2018

Change-Id: I37ee273e9930fb20e126085a51c70eb808b4145f
Reviewed-on: https://chromium-review.googlesource.com/c/1348068
Commit-Queue: Eugene Kliuchnikov <eustas@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610872}

This patch fixes a bug in previous fuzzer patch. We need to use "and"
operand to make sure the flag contains kHitTestAsk.

Bug: 905463
Change-Id: I13935185756dfef4474b94975bfec833469bdac1
Reviewed-on: https://chromium-review.googlesource.com/c/1351271Reviewed-by: Ria Jiang <riajiang@chromium.org>
Commit-Queue: Xianda Sun <sunxd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610871}

This reverts commit 3260717d.

Reason for revert: The broken test was disabled for committed interstitials (since the behavior it tests does not apply for CI) in crrev.com/c/1348971. TBR-ing since there are no changes from the original CL in this reland.

Original change's description:
> Revert "Added committed ssl interstitials to testing_config"
> 
> This reverts commit a1b9cd32.
> 
> Reason for revert: Suspect this CL caused WebViewTest.InterstitialPageFocusedWidget failure
> 
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/16877
> 
> [ RUN      ] WebViewTest.InterstitialPageFocusedWidget
> [20977:51975:1119/183258.737359:WARNING:notification_platform_bridge_mac.mm(512)] AlertNotificationService: XPC connection invalidated.
> [20977:775:1119/183258.919345:ERROR:delegated_frame_host.cc(165)] Not implemented reached in void content::DelegatedFrameHost::SetNeedsBeginFrames(bool)
> [20977:775:1119/183300.396209:ERROR:delegated_frame_host.cc(165)] Not implemented reached in void content::DelegatedFrameHost::SetNeedsBeginFrames(bool)
> [20977:775:1119/183300.901427:ERROR:delegated_frame_host.cc(165)] Not implemented reached in void content::DelegatedFrameHost::SetNeedsBeginFrames(bool)
> [20977:775:1119/183301.011438:INFO:CONSOLE(15)] "embedder.loadGuest: 49781", source: chrome-extension://cdeknlbiapideljomhnngchhffjgbmfc/embedder.js (15)
> [20977:775:1119/183301.011622:INFO:CONSOLE(21)] "guestSrcHTTPS: https://localhost:49781/extensions/platform_apps/web_view/interstitial_teardown/https_page.html", source: chrome-extension://cdeknlbiapideljomhnngchhffjgbmfc/embedder.js (21)
> ../../chrome/browser/apps/guest_view/web_view_browsertest.cc:1953: Failure
> Expected: (interstitial_widget) != (content::GetFocusedRenderWidgetHost(guest_web_contents)), actual: 0x7fe90b092600 vs 0x7fe90b092600
> Stack trace:
> 0   browser_tests                       0x0000000103d7875b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91
> 1   browser_tests                       0x0000000103d78119 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89
> 2   browser_tests                       0x00000001026c1a62 WebViewTest_InterstitialPageFocusedWidget_Test::RunTestOnMainThread() + 466
> 3   browser_tests                       0x00000001071d7f6b content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 491
> 4   browser_tests                       0x0000000106c255c4 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4372
> 5   browser_tests                       0x0000000106c243ed ChromeBrowserMainParts::PreMainMessageLoopRun() + 45
> 6   browser_tests                       0x0000000104d913d2 content::BrowserMainLoop::PreMainMessageLoopRun() + 50
> 7   browser_tests                       0x00000001051f8f07 content::StartupTaskRunner::RunAllTasksNow() + 39
> 8   browser_tests                       0x0000000104d9000b content::BrowserMainLoop::CreateStartupTasks() + 683
> 9   browser_tests                       0x0000000104d93615 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 85
> 10  browser_tests                       0x0000000104d8e402 content::BrowserMain(content::MainFunctionParams const&) + 178
> 11  browser_tests                       0x00000001066ae490 content::ContentMainRunnerImpl::Run(bool) + 752
> 12  browser_tests                       0x00000001099f5a4b service_manager::Main(service_manager::MainParams const&) + 3051
> 13  browser_tests                       0x00000001066ad514 content::ContentMain(content::ContentMainParams const&) + 68
> 14  browser_tests                       0x00000001071d7bbd content::BrowserTestBase::SetUp() + 2829
> 15  browser_tests                       0x0000000106b96431 InProcessBrowserTest::SetUp() + 529
> 
> 
> Original change's description:
> > Added committed ssl interstitials to testing_config
> > 
> > Bug: 755632
> > Change-Id: I7e156e2df3a3124a13a5b576b7d691d77dd9c08b
> > Reviewed-on: https://chromium-review.googlesource.com/c/1289687
> > Commit-Queue: Carlos IL <carlosil@chromium.org>
> > Reviewed-by: Nasko Oskov <nasko@chromium.org>
> > Reviewed-by: Christopher Thompson <cthomp@chromium.org>
> > Reviewed-by: Varun Khaneja <vakh@chromium.org>
> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> > Reviewed-by: Matt Giuca <mgiuca@chromium.org>
> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
> > Reviewed-by: Doug Turner <dougt@chromium.org>
> > Reviewed-by: Steven Holte <holte@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#609543}
> 
> TBR=nasko@chromium.org,mgiuca@chromium.org,alexmos@chromium.org,holte@chromium.org,emaxx@chromium.org,vakh@chromium.org,cthomp@chromium.org,dougt@chromium.org,carlosil@chromium.org
> 
> Change-Id: I4832ced67d6d115ed43fdd155424469d1136d695
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 755632
> Reviewed-on: https://chromium-review.googlesource.com/c/1343084
> Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#609654}

TBR=nasko@chromium.org,mgiuca@chromium.org,alexmos@chromium.org,holte@chromium.org,emaxx@chromium.org,vakh@chromium.org,kolos@chromium.org,cthomp@chromium.org,dougt@chromium.org,carlosil@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 755632
Change-Id: Ia688911b9ee994674651ef3cdc28eb8fb58cfa91
Reviewed-on: https://chromium-review.googlesource.com/c/1351270Reviewed-by: Carlos IL <carlosil@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610870}

TBR=hans

Bug: 899438
Change-Id: I790c63caa60a56fa5102c46ac10ff57aa22e535b
Reviewed-on: https://chromium-review.googlesource.com/c/1351375Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610869}

Use MaybeLocal version of GetFunction in GinJavaBridgeObject as original
function is deprecated. Since the original code seems to react to other
failures by returning an empty Local<>, I've used the same pattern
rather than ToLocalChecked.

Bug: v8:7295, v8:8238
Change-Id: I634b4d7ec51c4874f9628f05fbf5106f10c0990c
Reviewed-on: https://chromium-review.googlesource.com/c/1348045Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610868}

Now that HarfBuzz AAT landed, enable more HarfBuzzShaper tests on Mac.

Bug: 894354
Change-Id: I2d3cdf721187f4366c964bcd982f3954ccd61429
Reviewed-on: https://chromium-review.googlesource.com/c/1350810
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610867}

The browsertests used to rely on the save manager being hardcoded to
upload to Google if the observer_for_testing was set. This makes it
impossible to test that the logic for showing the upload prompt works
properly.

BUG=906630, 859761

Change-Id: Id7352a869388aac4ff36e1284750e22ac68c91b3
Reviewed-on: https://chromium-review.googlesource.com/c/1348335
Commit-Queue: Florian Uunk <feuunk@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610866}

Before this change, the tab controls were not accessible while the
overlay was enabled. This is because the touch event filter covers the
whole screen, even though only a part of the screen is grayed out. The
controls were only accessible while an area of the screen was touchable.

With this change, the tab controls are always accessible, no matter the
state of the touch event filter.

Bug: 806868
Change-Id: Ia3e2e8b3c78758f92027afb73cebe4d703bbfb1c
Reviewed-on: https://chromium-review.googlesource.com/c/1350951Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610865}

This change drops uses of GTMSMJobRemove and GTMSMJobSubmit, and replaces themm
with uses of new functions in the mac::services namespace.

Bug: 903800
Change-Id: I0e38ddf3532274bd8ff0ea861f14707a183cd3ff
Reviewed-on: https://chromium-review.googlesource.com/c/1337823Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610864}

Bug: 565837
Change-Id: Ifc6fc164cd3587d6f3ffb996074878a34014fc00
Reviewed-on: https://chromium-review.googlesource.com/c/1347571Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610863}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9e71de132fbc..d543f7dfed9b


git log 9e71de132fbc..d543f7dfed9b --date=short --no-merges --format='%ad %ae %s'
2018-11-26 janisozaur@users.noreply.github.com Don't use CMake's own property as variable name (#2112)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@d543f7dfed9b

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I26099ad7fa39368237ecee7624e13026f3c974e6
Reviewed-on: https://chromium-review.googlesource.com/c/1351229Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#610862}

Currently, the render process sends the statistics of
only the anchor elements that are in the viewport to
the browser. This CL changes it to also include the
anchor elements whose target URL is one digit different
from the document URL.

Note that there is still a limit of 40 on the count of anchor
elements that are sent from the render to the browser process.

Bug: 850624
Change-Id: I25443e44959c768b869f5b852a28baf5b0271034
Reviewed-on: https://chromium-review.googlesource.com/c/1344268Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610861}

- Checks the current thread preferred UI language and pass it onto
Chrome so that it presents itself with a language that matches the
logon screen.

Bug: 908451
Change-Id: I8f40a1501baabfe592cde6eea2c74bd19d47e9df
Reviewed-on: https://chromium-review.googlesource.com/c/1351249Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Tien Mai <tienmai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610860}

Change-Id: I80c5bea68c43493acb0b6cb95b9263adf51f856a
Reviewed-on: https://chromium-review.googlesource.com/c/1351209
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610859}

Change-Id: I15bd9474339a26f05cd3972e04ce3a40f50d3f27
Reviewed-on: https://chromium-review.googlesource.com/c/1343017Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610858}

Also remove a few entries that haven't been used since we made the bots
use filelists from .isolate files for comparison.

TBR=hans

Bug: 899438
Change-Id: Iba9e3d111063c352552a5af51cc14ba3d8219a29
Reviewed-on: https://chromium-review.googlesource.com/c/1351370Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610857}

Mark disable-threaded-scrolling non-expiring as it is a useful debugging
control when investigating scrolling issues.

Smooth scrolling was discussed on input-dev in https://goo.gl/qZ68P2 and
crbug.com/817814 tracks adding an accessibility setting for it, which we
should do before the flag expires.

Change-Id: I54fe4c4ff49b340af9b49d087e634f97d452a433
Reviewed-on: https://chromium-review.googlesource.com/c/1348868
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610856}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f9d7a25e1240..1b1a6401f31b


Created with:
  gclient setdep -r src-internal@1b1a6401f31b

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: If0f28e9ac4db453192d486de21df988122d034e2
Reviewed-on: https://chromium-review.googlesource.com/c/1351069Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#610855}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Ia05958c388696be00b9ce8dbbedc2a3202fbc065
Reviewed-on: https://chromium-review.googlesource.com/c/1350293Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#610854}

Apple’s documentation on menus is incorrect (see the linked bug)
so the test we were doing was wrong. And anyway, why double-check
the shortcut key? We're in -applicationShouldTerminate: so the
user *did* give a quit command. Just assume that the system did
the right thing and match on the fact that we're processing a
key down.

Also do some cleanup of comments and names that are just wrong.

BUG=142944

Change-Id: I797a97d3675e67e2426cc296e7c8642e08b91504
Reviewed-on: https://chromium-review.googlesource.com/c/1345030Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610853}

ContentSettingBubbleContents owns the underlying bubble model. It is
also a WebContentsObserver. This CL destroys the bubble model in
WebContentsDestroyed, which allows the model to avoid paranoid
null checking throughout the code.

In the process, we also remove:
1. Notification observation about profile / web contents destruction.
   The profile should be alive as long as the web contents.

2. Storing the profile directly and accessing the raw ptr. Instead,
   just pull it off the web contents.

One subtle thing about this patch. On WebContentsDestroyed, we do not
synchronously destroy the underlying ContentSettingBubbleContents,
instead, we synchronously hide it and post a task which actually
deletes it. This means we need to be careful about properly null
checking the content_setting_bubble_model_. Thankfully, we can assume
that event listeners are not invoked on hidden widgets.

Bug: None
Change-Id: I0a1ff38a705ace8a9898a4c89f81d51d8474b4da
Reviewed-on: https://chromium-review.googlesource.com/c/1334097
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610852}

The final state of the new password form parser is that it works
without any help of the old one. This CL introduces feature and flag
for this (implementation will be in the subsequent CL).

Bug: 831123
Change-Id: I03fa707f3efdc4a7be46454b72b41ef629bceeef
Reviewed-on: https://chromium-review.googlesource.com/c/1348059Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610851}

Spec PR: https://github.com/w3c/webappsec-csp/pull/358

Bug: 905301, 894228, 836148
Change-Id: I43ada2266d42d1cd56dbe3c6dd89d115e878a83a
Reviewed-on: https://chromium-review.googlesource.com/c/1314633
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610850}

https://skia.googlesource.com/skia.git/+log/bc97432f4f93..9a061a5c2b22


git log bc97432f4f93..9a061a5c2b22 --date=short --no-merges --format='%ad %ae %s'
2018-11-26 caryclark@skia.org fix pathops fuzz


Created with:
  gclient setdep -r src/third_party/skia@9a061a5c2b22

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:907844
TBR=borenet@chromium.org

Change-Id: I610db74ac84a8aeb531c8d0a3fbab536f902f89f
Reviewed-on: https://chromium-review.googlesource.com/c/1350233Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#610849}

Bug: 907467
Change-Id: I508359926472d5bfcda2c7564fc3d550f77e8a2b
Reviewed-on: https://chromium-review.googlesource.com/c/1350204Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610848}

The browser_console_module.js is apparently no longer needed.

Add

   'nacl_irt_x86_32.nexe',
   'nacl_irt_x86_32.nexe.debug',

which started misbehaving over the weekend.

Bug: 899438
Change-Id: I14a69aa7ff43203cc0dae4aef2db566db5d6cc12
Reviewed-on: https://chromium-review.googlesource.com/c/1351089Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610847}

This reverts commit 05522106.

Reason for revert: FindIt claims this is the reason for a failing
SuggestAppDialog/FilesAppBrowserTest.Test/suggestAppDialog on CROS 
MSAN:

https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/9831

Original change's description:
> Re-land "Don't unmount zip files when canceling password input."
> 
> The original change didn't handle the case where the injected code to
> click "Cancel" button was run after the dialog page has fully loaded. In
> this case, the DOMContentLoaded event has already fired.
> 
> BUG=808300
> 
> No-try: true
> Change-Id: Ibf8408a7a44ef8bc8029764d31bc9a5171119cc8
> Reviewed-on: https://chromium-review.googlesource.com/c/1350444
> Commit-Queue: Noel Gordon <noel@chromium.org>
> Reviewed-by: Noel Gordon <noel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610812}

TBR=noel@chromium.org,amistry@chromium.org

Change-Id: I1cd48d0aaf953cc3a635a016de129b20bad865f7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 808300
Reviewed-on: https://chromium-review.googlesource.com/c/1350912Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610846}

The responsibility of modules/peerconnection OWNERS should be no
different than platform/peerconnection. Making the platform OWNERS file
point to the modules OWNERS file.

NOTRY=True

Bug: none
Change-Id: I5054ba2f86bdae2f50991a3ad0b2eb315381c5fd
Reviewed-on: https://chromium-review.googlesource.com/c/1350871Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610845}

This bug is a follow up of [1] and [2], where production code
(//c/b/extensions/api/identity/identity_api.cc) is migrated away from
using PO2TS in favor of IdentityManager, and the API is extended to
accommodate the needs of this migration, respectively.

[1] https://crrev.com/b/1340890
[2] https://crrev.com/b/1346609

BUG=906615

Change-Id: Ib41f99f08b7d181bbcff28be97c8b55993aa8c04
Reviewed-on: https://chromium-review.googlesource.com/c/1343019
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610844}

IdentityManager currently wraps other signin APIs including SigninManager
and PO2TS. This CL migrates ArcPlayStoreEnabledPreferenceHandlerTest
and IdentityManager's testing facility IdentityTestEnvironment, and
hides the test internals from SigninManager APIs.

This is part of the servicification effort.

BUG=907484

Change-Id: I85f764f3477ee8e974298c0b41e22ac6277f61c5
Reviewed-on: https://chromium-review.googlesource.com/c/1349589
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610843}

This CL adds more integration tests; it also fixes a bug that
stopped local changes of billing address and local changes of
has_converted to get propagated to sync.

Compared to the original CL (patch set 1 here), patch set 2 in this CL
fixes (a) the fixture to make sure PDM converts addresses (a bug
introduced after landing the original CL) and (b) the Checker to wait
until PDM converts remote addresses to local ones (the reason for the
flakiness).

Bug: 894001
Change-Id: Idf4e87ae36f7ed6348250a5d69bcd66b1f16ec54
Reviewed-on: https://chromium-review.googlesource.com/c/1350614
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610842}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/500be6dd..89124cf9

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I60cf7e0d767315867e6a141430444e947ebb0ebb
Reviewed-on: https://chromium-review.googlesource.com/c/1350651Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#610841}