- 18 Dec, 2020 40 commits
-
-
Jonah Chin authored
GetSkImage() is being deprecated. Making it private as we work to remove the remaining callers. This will help prevent new callers being added. Bug: 1031051 Change-Id: I3350e1ebddc43151bfc9b2de9577267bf092bf6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597696Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#838484}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I925f493348ed581f901354aefb3e7469da361695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598617Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838483}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1608281112-88d0ddf14300db9b794d74edf4ee423dfb88388a.profdata to chrome-win64-master-1608301770-06e287340f948f5f8b3c9d0d066bd6a8223fd57f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If5eaa6d816192fc9be35ef8db9e2f52f889cf8ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596041Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838482}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1608292656-f4e77ce1df5bcf85a782ab8ba15317931c7bc284.profdata to chrome-linux-master-1608313318-0751b22489821c3640549132c59c2716d05bfe2a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I43192b2c1c31589afc4e1b4c0551118639c9a917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598489Reviewed-by:
-
John Budorick authored
Bug: chromium:1007101 Change-Id: Ic6ced991520288f18638ecf780a5ecf87781b6a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596045Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#838480}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608292656-9703ac908a9d7874f8ebb142529aafb38fb7b3af.profdata to chrome-mac-master-1608313318-f751eb3e0afe10dd0ffdda8eb8463b2fff104dc2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I37297d444b23c80fcab9eb99c8c87bf6764cbced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598604Reviewed-by:
-
Jordan Oroshiba authored
Adding preferences programmatically enables future ephemeral support where certain values might be a different preference type. Screenshots: https://crbug.com/1157989#c2 Bug: 1157989 Change-Id: I43f0e9d693fe10da41f2d5be1b3e68c5422eb086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587615 Commit-Queue: Jordan Oroshiba <oroshiba@google.com> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#838478}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/d1469c60c1ab..9a644c7903ca 2020-12-17 dneto@google.com spirv-reader: Restrict use of ConstOffset 2020-12-17 dneto@google.com [inspector] test interference between sampled and multisampled resources 2020-12-17 dneto@google.com Roll third_party/spirv-tools/ 2c458414c..8f4b35c33 (26 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: Icb97063456bb4c69ff1674560ee8ed5209ef4796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597928Reviewed-by:
-
Alison Maher authored
Currently, when a multi-column is a containing block for an OOF positioned element, the corresponding column is mistaken for the containing block, which causes various DCHECK failures. Columns are not allowed to be containing blocks, so this change ensures that we skip over columns when placing OOF positioned elements. Bug: 1158706 Change-Id: Id969b91a8f472d34b4767ffe891a3405770e8443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597769 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#838476}
-
Keren Zhu authored
ScreenCaptureNotificationUIViews overrides CanActivate() so that the widget is not activatable when it is hidden, and activable when visible. This was a hack to fix the a display bug on Windows that lacks an explanation on why it worked. See r256851. This hack is causing issue on Mac that the button on the notification widget will initially show in active style and change to inactive style after a mouse hover. Removing the hack solves the cosmetic issue on Mac. Manually tested on Windows and didn't observe any issue in hiding/restoring the widget as described in the comment and in r256851. Details on why the hack caused the cosmetic issue: 1. CanActivate() is false during widget initialization. This will make native widget inactive but visual style active. 2. CanActivate() becomes true after initialization. When a mouse hover triggers repaint of the button in the widget, widget->IsActive() returns false because the native widget is inactive. Thus on Mac, the button is rendered in inactive style. Bug: 1156580 Change-Id: Ic1e4d4bdbe3f29e6f65123880e5e9d373edb189b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596099Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#838475}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4acfef066a15..9c656afad176 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ica201cffa13dc7080560aa50158298266cb8a98e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597904Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838474}
-
Filip Gorski authored
TBR=bialpio@chromium.org Bug: 1158528 Change-Id: I5442f8e50a09b9ede1231aa7e2a56eaf24b3a0df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590367 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#838473}
-
John Delaney authored
This reverts commit 53e3903f. Reason for revert: Introduced test flakiness due to uninitialized member. Original change's description: > [conversions] Route impressions alongside rel="noopener" anchor navs > > What: > Route impressions for the Conversion Measurement API to the browser > process for anchor tags with rel="noopener". > > Why: > We currently drop impressions for anchor clicks which have noopener > set because the impressions do not get forwarded to the browser process. > > Anchor click navigations with the rel="noopener" attribute use a > different navigation path than those without the attribute, in which > the window creation mojo also navigates the frame to the target url. > This navigation is not annotated with an impression. > > How: > Add an Impression member to CreateNewWindowParams which will get > forwarded as a LoadURLParam for the subsequent navigation of the > window. > > This change also fixes a bug in which initiator_frame_tokens are not > set for noopener navigations. > > As of https://chromium-review.googlesource.com/c/chromium/src/+/2327963, > the lack of an initiator frame tokens are used to to indicate whether > an opener was suppressed for a navigation. Because attaching the token > breaks this logic, we route a new |was_opener_suppressed| param through > the NavigationController:LoadUrlWithParams() flow to recover the > behavior. > > Bug: 1155577 > Change-Id: I84739a9f4ec0df9a867f91397f80b46eea1bcee6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575223 > Commit-Queue: John Delaney <johnidel@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838275} TBR=dcheng@chromium.org,creis@chromium.org,csharrison@chromium.org,johnidel@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Iee257a09d1f198a4ec68c52004a23780cfb6c95c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1155577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598616Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#838472}
-
Olivier Yiptong authored
Implements the ability to select all fonts in the font chooser as a checkbox. Unselecting the checkbox will cause all selection to disappear. Bug: 1159246 Change-Id: Ia3ecda193457a70e8c5b3282362c4439945943ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594510 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#838471}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I255f255093be35b0820fa857dd3f4b823ee2a3c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598479Reviewed-by:
-
Jesse McKenna authored
This cleanup change makes the following changes to IllegalCharacters: * use base::Optional for delayed initialization instead of unique_ptr * remove unneeded line `friend class Singleton<IllegalCharacters>;` * make `code_point` variable descriptive type UChar32 instead of its underlying type uint32_t * rename DisallowedEverywhere() and DisallowedLeadingAndTrailing() methods to IsDisallowed*() * minor comment typo fixes Change-Id: I410fbbbb063ef191d92d326d1c1073007336ff11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586955 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#838469}
-
Nasko Oskov authored
The ReceivedBadMessage methods already ha LOG statements to help in local runs. It is very useful data, so I'm adding tracing output too so we can get the same data in tracing based debugging. TBR=jam@chromium.org Bug: 1043616 Change-Id: I289009d9a0ffa3cd841c1bd37526ab4a6137f414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597223 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#838468}
-
Morten Stenshorne authored
Instead of resetting AncestorSkipInfo every time we enter Container(), DCHECK that it has initial output values, and instead, make sure that we never re-use AncestorSkipInfo objects, like we did in SlowContainingLayer(). Change-Id: If244c447b41125a38242cf842fd9387500932d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595168 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#838467}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5d3227096daa..7bfdb1044916 2020-12-18 bsalomon@google.com Revert "Enable GrTessellationPathRenderer by default" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: tdenniston@google.com Change-Id: If36c31f1a4051ff26152be069848459206fada82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598480Reviewed-by:
-
Andrew Nicols authored
Improve detection of elements partially outside the viewport and return their correct height. When an element is only visible on the edge by between 0 and 0.5 the WebRect casts the visible width/height to 0, causing an ElementNotInteractable exception to be thrown with 'element has zero size'. This change updates the size calculation to round the intersection of the window and element under test in the same way that is performed when storing the Element Region into a WebRect object. This has the effect that the getElementRegion() function falls back to returning the clientRect size instead of the visible subregion when calculating the visible portion. R=johnchen@chromium.org, shengfa@google.com Bug: chromedriver:3682 Change-Id: I5868c6d61ea56f5d229b0681f679670174dedf48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594837Reviewed-by:
Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Auto-Submit: Andrew Nicols <andrewrn@gmail.com> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#838465}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c53eb817aee1..4acfef066a15 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ife8b8d69e90a53f81c20a1a2124953bd26eb2e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598539Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/70f81f6b5041..0cf9ac4bcdbf 2020-12-18 patrick.brosset@microsoft.com Layout: Make the expander icons smaller If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1159703 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2f1726fbde24363224325501c8caab04c4db4154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598477Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b9a172aaef22..5d3227096daa 2020-12-18 reed@google.com Take sampling params on device apis If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: tdenniston@google.com Change-Id: Id4d7df134c34e2339e25c89c087f634e2ed73ae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597045Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/64c5d601f89b..5d4fd88a7403 2020-12-18 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from a57f842be951 to 9a644c7903ca (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: Ifbc90b1d23ba4311b1dc89ae3b509e706d416c54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598497Reviewed-by:
-
Fredrik Söderqvist authored
Have the client be a ResourceClient, registering with the Resource by "passing through" the Entry. This means we can get rid of the |clients_| set in Entry and have it carry a reference to the Resource instead. This also means that we can replace the slightly awkward revalidation handling with a slightly less awkward setup: Instead of creating new Entry, set a flag on the existing Entry and have Entry::GetDocument() clear the currently parsed Document when the revalidation completes (i.e when the resource status is back to 'loaded' again). A minor wart in the new scheme is that the client needs to explicitly clear its resource reference if it explicitly drops the reference to the Entry (if the client is GCd the pre-finalizer will drop the reference). Bug: 109212 Change-Id: I2093094446b18238d77b1b667c45b8db7c45c5fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594773 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#838460}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012180600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/eqtd4lNDx7izMGW_17TOrdQecZugRD-GE5POK26KJCYC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: I6d22704949c505d5f7f0aec425b6a90365ead5ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598496Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1608228003-e74739fcdefa7518b67623025a08d95b63f00b00.profdata to chrome-win64-master-1608281112-88d0ddf14300db9b794d74edf4ee423dfb88388a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9ecf4156c2628a4e5f5012a82dd8842d609538b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598049Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cfc9e036a897..c53eb817aee1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ia6a55edec677ad0f97b2c3732614668d6c7429b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598055Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1608270660-61058158d4c2c4d0ef6b26849a7fbe6b1e868c2c.profdata to chrome-linux-master-1608292656-f4e77ce1df5bcf85a782ab8ba15317931c7bc284.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I761187537ab03f88938c42275ea9a3edf9f6ffc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598456Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/0a1e0410572e..4f67a285e221 2020-12-17 tsepez@chromium.org Remove out parameter from CJS_Global::ObjectToArray() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ifee3ea624fc060ff1006aae974958769ad9aacbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598050 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608270660-18803338ac16174284c6f853c8c8e431f99a687d.profdata to chrome-mac-master-1608292656-9703ac908a9d7874f8ebb142529aafb38fb7b3af.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7063d12751b671dc26b41290ec5efda2a163a62f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598054Reviewed-by:
-
Regan Hsu authored
When 'Open Tabs' sync type is disabled, the summary below the task continuation toggle will tell the user to turn on Chrome sync and the toggle will be disabled. Screenshot: https://screenshot.googleplex.com/6bHapjPrYypBWWV Fixed: 1156302 Bug: 1106937 Change-Id: I74bd4de355ef166b797d6eebf6ab1ee90a166f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597745 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#838453}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/68e7e8e4..f841b934 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I21bda018fcad637a511ae0d086243a3a8201fc44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598397Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838452}
-
Fredrik Söderqvist authored
This enables the full 'filter' property syntax on SVG elements. Since SVG elements expect effects of zoom to be included in their local transform, we have to take care to undo zoom from any Length parameters when building the filter chain. Bug: 109224 Change-Id: Ib7f6050f57cc2723d1396f05424da788df675188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595416Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#838451}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/50f3473f0f8a..70f81f6b5041 2020-12-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I99292ed7624dcbeeb7fbba26e9cb10e79f724738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597322Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/13ce523300da..cfc9e036a897 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I4c89afb125298da073b5d3997d12be0459b79ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598047Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2157c5d256c2..d7f750f7be4b 2020-12-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 31e5ea78..c48f2952 (838188:838429) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5785e5445848065960533d8b2482ec6b2515a52b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597319Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I3bcf610f5bd90223b1a31740d70cd88b15f901e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597642Reviewed-by:
-
Frédéric Wang authored
This CL removes host name "localhost.localdomain" from the list of known localhost addresses. This means it will be resolved using the native DNS resolver rather than Chrome's internal one and that it won't be treated as "potentially trustworthy" origins [1] [2]. This aligns with the behavior of WebKit and Firefox, is expected to have low backward compatibility risk and one can configure things to preserve existing support [3] [4]. [1] https://tools.ietf.org/html/draft-west-let-localhost-be-localhost-06 [2] https://w3c.github.io/webappsec-secure-contexts/#is-origin-trustworthy [3] https://chromestatus.com/feature/5668106045227008 [4] https://groups.google.com/a/chromium.org/g/blink-dev/c/hq4iR3UTyNw Bug: 1153337 Change-Id: Ie141a973783a142cd65117fe4904cc3c1f608b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577688Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#838446}
-
Eric Lawrence authored
Launching of URL protocol schemes handled by external applications is gated on a user-gesture check that allows only one attempt to launch such applications per gesture. This is a security measure to prevent malicious web content from trying to flood the user with prompts. Unfortunately, user-gestures are only recorded for interactions in the web content area, and thus the protection can block attempts to launch protocol handlers from bookmarks or the omnibox. Fix this by exempting such invocations from the user-gesture check. Bug: 1156651 Change-Id: I4860d9e75b9ed8426364a5006e4bc119776118c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581446Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#838445}
-
