- 22 Jan, 2021 40 commits
-
-
Nektarios Paisios authored
TBR=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: Ief1fff9084e42b284ec733ac344119d326fbe38b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642633Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#846108}
-
Pâris MEULEMAN authored
Add test verifying behavior when trying to execute javascript in a paused navigation from an early committed post-crash RFH. bug: 1072817 Change-Id: Ibd6b9c5b6e6484f278dcdc6ecc1ed0cf88780fd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627393 Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#846107}
-
Ossama Mahmoud authored
Bug: none Change-Id: Ic2e1a8e0eee10c5c4f7f33200247019d427764cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643719 Commit-Queue: Ossama Mahmoud <osamafathy@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#846106}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611284384-cbab22d10b31440218b066d1280e2c1fdae62cdc.profdata to chrome-win32-master-1611304267-88ef864b2fcc457a2d5ceb59f34a94c5685188fd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie280be289a4fecbf27d4c8d152020ea901c382a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643535Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846105}
-
Fredrik Söderqvist authored
SkipOptionalSVGSpaces() returns true if this condition (ptr < end) is true, so we don't need to check it again. Change-Id: I9bfe1b34758419aba95875430bb1cc6099a21320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642784 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#846104}
-
Fredrik Söderqvist authored
It's never called (there are no attributes of this type). When point syntax is used in attributes (for example for point lists or <animateMotion>) they open-code the parsing. Change-Id: I9c28a3c6a7c5d3b51d2d2df87d6de86b33e63bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643285 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1611294737-27b810d0fa6cfabfc1ee245c9b50455ece63f3ea.profdata to chrome-linux-master-1611316382-94c9fd181d84cd42486f5188444029563baefc6b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia10c6243dbaf85b2b11e29804fc7ad0894d0b7c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644840Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I2c2459593789e9256025a8183553ba3a86a86b77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644737Reviewed-by:
-
Clemens Arbesser authored
Bug: b/178098376 Change-Id: I2ae2d04a8f5af9d1676b29944b2644d21d127878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642335Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#846100}
-
Alex Ilin authored
This CL renames "Default" to "Default color" for the default color item in the profile picker. This is more consistent with other color labels as "Custom color", "Warm gray", etc. Updated screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/de2db892dd4af40ffa7a6efe510149423e449f57 Change-Id: Ie509c13bcc4e94b0981e6ee5f258c493ef5480d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643320 Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#846099}
-
Rushan Suleymanov authored
This CL implements actual move of parent_id field. This is important for bookmarks data type during the initial merge when it is extensively used. This CL doesn't change the existing behaviour, it just optimizes bookmarks initial merge. Bug: 1168132 Change-Id: I65ebaba306057c608aa2401c112b1f1b22a4c6ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640374Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#846098}
-
Benoit Lize authored
PartitionAlloc's thread cache improves performance (up to ~3% on speedometer 2.0 vs jemalloc) on Android Go, but at a memory cost. Since periodic purge is still disabled, this commit disables the thread cache on these configurations to recover. This CL introduces extended_api.h for PartitionAlloc, which is intended to become the central place to provide finer-grained control when PA-E is enabled, such as adjusting thread cache behavior (size, reclaiming behavior, or disabling it), and other allocator tuning parameters. As such, even if complete thread cache disabling is intended to be temporary, having an extended API is not. Bug: 1167218, 998048 Change-Id: I9c9801e41f1a0ed4dab6b3d96647540356428a50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637640 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#846097}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e4fd1ba31989..11215febb950 2021-01-22 danilchap@webrtc.org Require scalability mode to initialize av1 encoder. 2021-01-22 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2021-01-22T04:03:26). 2021-01-21 titovartem@webrtc.org Introduce network emulated endpoint optional name for better logging If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7c70dcb7fa26669d42cd593e8aa88b196c243ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643133Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/db383498c5c6..72cd1a5e8953 2021-01-22 cwallez@chromium.org dawn_native: Move beginRenderPass texture usage validation into the encoder 2021-01-22 cwallez@chromium.org Remove QueueWriteBufferTests.ManyWriteBuffer on Intel Vulkan 2021-01-22 cwallez@chromium.org dawn_native: Move pass validation of buffer usages into the encoder. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:980737 Tbr: sarahmashay@google.com Change-Id: Iac146e6b83e9960fa54c5c1d1c6688a334e1d1c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643128Reviewed-by:
-
Fergus Dall authored
This reverts commit 2d1e6ddf. Reason for revert: Broke tast tests by crashing chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome Original change's description: > Clear the cache in AutomationManagerAura when disabled. > > On the Tast tests which use the Automation features, I'm seeing > sometimes the automation node tree gets empty. During the debugging, > I've noticed that sometimes the automation tree fails to build > the tree updates (happens OnSerializeFailure). > > This can be resolved by clearing the cache when it is disabled > (which happens regularly on tests). > > Bug: 1165292 > Test: on kevin64, run informational Tast tests > AX-Relnotes: n/a > Change-Id: I835e06ca2118ae6c36d6fb8b877fad074bd41fcf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627715 > Commit-Queue: Jun Mukai <mukai@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845868} TBR=mukai@chromium.org,dtseng@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I43a2458db101f777ea81537127db2de2a85ca757 AX-Relnotes: n/a Bug: 1165292, 1169573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642843 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#846094}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/dbb39ce0d2ed..7d6a6f33a540 2021-01-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2021-01-22 petermarshall@chromium.org [surveys] Make the survey prompt text injectable by the caller 2021-01-22 sigurds@chromium.org Add presubmit check requiring an associated bug 2021-01-22 jacktfranklin@chromium.org Fix border-top regression on blocked URLs pane If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1112738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6a3bb92fa6a5dd875ee5693187a1d955e7bc7ea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643068Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1611294737-17c8474f67761118ef8f2490ffa8a435d02d7f3f.profdata to chrome-win64-master-1611304267-90669dcf550835de268a2353a6cf5648f5d0af68.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1192655830492fffd6f8105675ad95b5f7818771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643131Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/49fd77f3..fbab010f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic89f7c3bb413d25c2a72a2fcdf978be3e394da9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644560Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846091}
-
Christian Dullweber authored
This reverts commit 8e10fb2a. Reason for revert: Reenable the test to check if failure still exists Original change's description: > [sheriff] Disable SiteDataCountingHelperTest.SameHostDifferentScheme > > TBR=eirage@chromium.org > NOTRY=true > > Bug: 1168198 > Change-Id: I3196ad66bace95157d110f840babd269d394df32 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637963 > Reviewed-by: Xida Chen <xidachen@chromium.org> > Reviewed-by: Ella Ge <eirage@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844891} TBR=xidachen@chromium.org,eirage@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1168198 Change-Id: I67f5a97d8e82513e13025c37639ea3fdeede022b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642630Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#846090}
-
Yunke Zhou authored
Bug: 1157195 Change-Id: Ic4daf299819b3854a7aef924268c8e698271de69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643380 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
Omer Katz authored
Initializing a bucket is non-atomic because the hash table is not yet visible to the GC during initialization. When trying to recycle a deleted bucket, the bucket is reinitialized. This introduces data races with concurrent marking. To resolve the data races, we should initialize atomically. For hash table where the empty value is zero, we can atomically memset the bucket to zero. For other cases, atomically initializing is more complicated. Instead, in such cases, we prohibit reusing deleted bucket while marking is in progress. Bug: 1166985 Change-Id: I42d03371388e7cd702d2aec6c5bdfd02e2a38d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643716 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Aaron Leventhal authored
When an AXInlineTextBox::NextOnLine()/PrevOnLine() is used, the parent of any newly created AXInlineTextBox is not necessarily going to be the same one. Compute the correct parent in all cases. Addresses DCHECKs that are triggered in text-overflow:ellipsis cases. Bug: 1168643 Change-Id: Ib41bc4617bee4761ccad35ad94ab33fb8be4ab43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639167Reviewed-by:
-
Jérôme Lebel authored
Adds signout confirmation dialog for Mice based on this design: https://docs.google.com/presentation/d/1mfVdeJXk2hLXjyzOp9TBIx0E7-7jmuoN1-4oB6dYd5I/edit#slide=id.gaea85d524f_2_0 iPad: https://drive.google.com/file/d/1UAS0L-ANTaIDEN2FFh2mgAiwKe-ksQ5U https://drive.google.com/file/d/1kQJoi6Vqe-xEsbLokmePAlAWU5kNl99T https://drive.google.com/file/d/1DUou8tJ1UR54lQtI2Zzi5smJ3aoUbyXX iPhone: https://drive.google.com/file/d/13TPquf7Z8HbdkCDmQhXnyqwP0VQGxwTp https://drive.google.com/file/d/1UjLwwkEk4RKnkDfX-7BSLmfqo6Lj1Ewd https://drive.google.com/file/d/1aykwVlgT3npD3DQkMCPWJm3hYiMeJfLx Bug: 1166148 Change-Id: Ica58a513ee216d79f4994d155a4941ea5fdbe3d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627401 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#846086}
-
Renato Silva authored
The login screen in ChromeOS currently only performs one authentication attempt. Either against the user's PIN or password depending on a flag passed by the UI. When the combined 'PIN or password' input field is used, any input consisting of only digits is treated as a PIN. If the user's password is composed of only digits (The minimum is 8 digits.), trying to use the password on the login screen fails. This issue does not exist on the lock screen, where two authentication attempts are made when the input is composed of only digits. It first tries to authenticate against the PIN, and, in case of failure, it tries again against the password. Since the introduction of PIN 'automatic unlock' / 'auto submit', the default UI has been separated into dedicated PIN and password fields with a button to toggle between both. This CL fixes an issue that caused the input from the dedicated password field to be treated as a PIN instead of a password. It also improves tests on LoginAuthUserView. Note that the issue still exists for the combined 'PIN or password' field and it should be addressed in the near future. Bug: 1122939 Change-Id: I719c441d023e9b2c37b901d101e4939732061a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512916Reviewed-by:
Thomas Tellier <tellier@google.com> Reviewed-by:
-
Ben Mason authored
Change-Id: I392b7783b1252cf4844f11fa301df6b8f7b74856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643545 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846084}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ad73a7a4eb1f..0e20ed5f01b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC snijhara@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: snijhara@google.com Change-Id: I8b4e17bb1169489eac3eee16e5877dc49cc19dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644702Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846083}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 89d93205. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I735ebb34f47c5c5ec8bdd174523d778f24db4f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643544Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846082}
-
Richard Townsend authored
* HTMLDocumentParser::Finish no longer blocks (parsing continues asynchronously) * Now yields for parser-blocking scripts in the Document body. Both of these measures should improve TTFCP. Bug: 901056 Change-Id: Ib0aae3f4f07d047c7e83ca29ae3ad17608c2821c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622116 Commit-Queue: Richard Townsend <richard.townsend@arm.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#846081}
-
Clemens Arbesser authored
Bug: b/178098376 Change-Id: I10c80db6d54dc10c6b49d2ca48996c2271ef3d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642626Reviewed-by:
-
Sreeja Kamishetty authored
Currently, WebContentsObserver::RenderFrameHostChanged callback is being dispatched before WebContentsObserver::RenderFrameCreated callback for child frames. This is problematic as embedders use WebContentsObserver::RenderFrameCreated callback to initialize per-RenderFrameHost state. This CL fixes this ordering. BUG=1097143 Change-Id: Iced632ee3369b3dbf3822dd57620b687ed47cb5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614467 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Viktor Semeniuk authored
This change accepts remote changes when passwords are identical but compromised credentials are different during sync merge. Bug: 1169171 Change-Id: I3efb237d4c2c208ea1c97792e4332dead3620cef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642357 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#846078}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b6e28b60dec0..dbb39ce0d2ed 2021-01-22 jacktfranklin@chromium.org Avoid rendering hidden DOM in data-grid and batch scrolls 2021-01-22 pfaffe@chromium.org Rename and document EvalNodes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1169021 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib9e87d831228469ef2b684ff2825abc55d106856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643370Reviewed-by:
-
Sergei Glazunov authored
It's common for C++ code to have pointers right past the end of an allocation, i.e. of the form |allocation_start + allocation_size|. When |PartitionAllocGetSlotStart| receives such a pointer and the size of the allocation equals the size of its bucket, the function returns the address of the next slot (or even the area outside the slot span). Subsequent |PartitionRefCount| operations may then modify the reference count of an unrelated object or corrupt the slot's free list pointer (if it is in the "freed" state). Instead of adding more fields to the CheckedPtr ignore list, we modify |PartitionAllocGetSlotStart| to support past-the-end pointers. In addition, remove the workaround for a bug that has been caused by the past-the-end pointer in |base::BigEndianWriter::ptr_|. Bug: 1073933, 1164636 Change-Id: Ia582680d9d6c83357f45123416a86a52661fa71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636354 Commit-Queue: Sergei Glazunov <glazunov@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Aaron Tagliaboschi authored
Bring tokens inline with Section 3.1 of the Client Hints spec, which recommends tokens be the same as the header name they're associated with. Also fixing the *copious* tests associated with this change... Intent to Remove: https://groups.google.com/u/1/a/chromium.org/g/blink-dev/c/t-S9nnos9qU Bug: 1153688 Change-Id: I2bfe038abe887713d56ef835e8f9d61246001040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595089Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#846075}
-
Carlos Caballero authored
Removed GetFrameTree method from Render{View|Widget}HostDelegate and made FrameTree* a member of Render{View|Widget}HostImpl instead This will make delegate implementations easier once we have multiple FrameTrees per WebContents. Bug: 1164280 Change-Id: Ie0adb40eb60e696ab018194d1fe9b71650814c62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623291Reviewed-by: -
Victor Hugo Vianna Silva authored
The functionality of this class is specific to errors: notifying the user about them and providing a way to resolve them. This is now properly reflected in the name of the class. The name is also picked so as to match its ChromeOS counterpart in sync_error_notifier_ash.h. Bug: None Change-Id: I5fef45fa33df8d92a53e327f1c61d38a07fb54ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642333 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#846073}
-
Mihai Sardarescu authored
This CL changes the DICE account reconcilor to use the Gaia OAuthmultilogin endpoint by default. Bug: 1122988 Change-Id: Ib120979037d850f3100b618721cf51755f6f2376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640380Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#846072}
-
Adrienne Walker authored
This patch adds a CacheStorageControl remote to StoragePartitionImpl. BackgroundFetch and CodeCacheHost now use mojo instead of direct access to CacheStorageContextImpl. Followups to this patch will be to convert other CacheStorageContext users in StoragePartition to use the mojo interface and eventually remove the GetCacheStorageContext accessor. Bug: 1147642 Change-Id: I5c286be77c41bc189084a6a4d89f3f2c06b50fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628049 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#846071}
-
Sylvain Defresne authored
Requiring the BrowserState's path to be passed as a NSString* forces all callers to convert the base::FilePath to NSString* making the API harder to use (as the conversion is non trivial). Instead change the API of both classes to use base::FilePath directly and to do the conversion internally where it can be centralized in a few location makes the API easier to use. Bug: 1165798 Change-Id: Ida8294210f83875fcbeffa88a3e7f5ae78a2316f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635668 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#846070}
-
Sreeja Kamishetty authored
This CL disables BackForwardCache for WebContentsImplTest.CrossSiteNavigationBackOldNavigationIgnored test which assumes no interaction with the back-forward cache by performing a commit on a stored BFCached entry directly. Bug: 1163106 Change-Id: Id21e363950e71db70e7db302b57b8e02958ebb72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633441 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
-
