- 03 Apr, 2018 4 commits
-
-
François Degros authored
Change-Id: Ie13dbd479024c1a0b3bec97f8e7cb2a7183685ec Reviewed-on: https://chromium-review.googlesource.com/991213Reviewed-by:
David Vallet <dvallet@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#547576}
-
Takumi Fujimoto authored
This CL changes a ctor for HoverButton to take an optional View object for showing an arbitrary secondary icon, instead of taking a boolean for whether to show an arrow icon. The HoverButton will be used by the Cast dialog to list devices. Bug: 826089 Change-Id: Iac36c2bc8a60666bc6aa035fbcbbedd0f59c66cf Reviewed-on: https://chromium-review.googlesource.com/989023 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#547575}
-
https://skia.googlesource.com/skia.git/+log/3070926579a6..1a291b354f54 $ git log 307092657..1a291b354 --date=short --no-merges --format='%ad %ae %s' 2018-04-02 herb Cleanup Ops - remove extra bytes sent and received 2018-04-02 liyuqian Simplify SkDrawTiler; check emtpy pixmap and overflow 2018-03-29 bungeman SkScalerContext::getMetrics to not request metrics it will ignore. 2018-04-02 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 4a77de482..ad0c4f19b (1 commit) 2018-04-02 brianosman Revert "Disable GPU support by default when building for host in Fuchsia" 2018-04-02 mtklein Revert "implement SkTDArray with std::vector" 2018-04-02 mtklein Revert "In older STLs, std::vector::insert() returns void." 2018-04-02 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ d2cc6a7f7..4a77de482 (2 commits) 2018-04-02 angle-skia-autoroll Roll skia/third_party/externals/angle2/ d104918fd..5a7e61bbd (1 commit) 2018-03-29 halcanary SkPDF/SkTypefaceMetrics: Set PostScript Name in Directwrite backend. 2018-04-02 djsollen Add multilib support as the default build option for libskqp 2018-04-02 mtklein In older STLs, std::vector::insert() returns void. 2018-04-02 benjaminwagner Revert "Temporarily remove Win10 QuadroP400 from CQ." 2018-04-02 halcanary SkPDF/Clusterator: a second test 2018-03-28 csmartdalton ccpr: Normalize homogeneous coords with frexp/ldexp 2018-04-02 robertphillips Turn on rendertarget sorting 2018-03-22 mtklein implement SkTDArray with std::vector 2018-04-02 egdaniel Remove specVersion check on vk extensions. Created with: roll-dep src/third_party/skia BUG=chromium:b/77249109,chromium:821040 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: Ib45a57c51ee4a0e1efd4c7c14107e9a2bb728f20 Reviewed-on: https://chromium-review.googlesource.com/990810Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547574}
-
Benjamin Pastene authored
Bug: 793907 Change-Id: Id31acad64245e66741e0271941c55ea5d71986a1 Reviewed-on: https://chromium-review.googlesource.com/990582Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#547573}
-
- 02 Apr, 2018 36 commits
-
-
https://webrtc.googlesource.com/src.git/+log/a859c1ac3e12..7eca09361d6d $ git log a859c1ac3..7eca09361 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:826972 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib774178d6b9aa204e20bde42728730c640188818 Reviewed-on: https://chromium-review.googlesource.com/990933Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547572}
-
Matthew Jones authored
Bug: 827371 Change-Id: I48efd505632d33e935d1676ff298a53e9da1579e Reviewed-on: https://chromium-review.googlesource.com/991156 Commit-Queue: Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#547571}
-
Kai Ninomiya authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/3c1cb02..da5abe6 TBR=kbr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_angle_rel_ng;master.tryserver.chromium.angle:win_angle_rel_ng Change-Id: I4f9cd170e9767b959d73288f4e0a063caca59e95 Reviewed-on: https://chromium-review.googlesource.com/987372Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#547570}
-
Adam Langley authored
This is a trivial matter but makes a bit more sense when I make the inner Read call a little more complex in the next change. Change-Id: Ie1c19e8760a598cf36914e634037c519e7f78d72 Reviewed-on: https://chromium-review.googlesource.com/990194Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#547569}
-
Kevin Marshall authored
This CL grows Fuchsia blobstore by a specified amount, large enough to accommodate packaged executables installed at machine (QEMU) runtime. Roll SDK from 32a56ad5 to de50ae25 for "fvm extend" and the inclusion of fvm.blk. Bug: 798851, 707030 Change-Id: I5a6b6be21cc443e6ad46271918a2f40e191a26f6 Reviewed-on: https://chromium-review.googlesource.com/987012 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#547568}
-
Evan Stade authored
Also move the first run/force-maximizing logic into Chrome/, i.e. WindowSizerAsh. Removing it from ash::WindowPositioner seems OK because the logic should only really apply to browser windows. UX contact: jennschen PM contact: kuscher Bug: 764009 Change-Id: Ie0642d1a50c4047082de025a36f59fadc1a3fc1d Reviewed-on: https://chromium-review.googlesource.com/985015Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#547567}
-
David Grogan authored
It got dropped a long time ago http://wkb.ug/98464 Without it the second flex box is row instead of the intended column. Change-Id: Ic4e60cb14eb8584e89b5ac019e837647d1280c13 Reviewed-on: https://chromium-review.googlesource.com/991084Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#547566}
-
Lukasz Anforowicz authored
https://tools.ietf.org/html/rfc7303 says that if "new media type is introduced for an XML-based format, the name of the media type SHOULD end with '+xml'". https://tools.ietf.org/html/rfc6839 covers '+xml' and '+json' suffixes. https://mimesniff.spec.whatwg.org/#xml-mime-type says "An XML MIME type is any MIME type whose subtype ends in '+xml' or whose essence is 'text/xml' or 'application/xml'. [RFC7303]". https://mimesniff.spec.whatwg.org/#json-mime-type says "A JSON MIME type is any MIME type whose subtype ends in '+json' or whose essence is 'application/json' or 'text/json'." There are no occurences of "application/xml+", "text/xml+", "application/json+", "text/json+" or "text/x-json" in the specs above and on various lists of MIME types like: - https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types/Complete_list_of_MIME_types - https://en.wikipedia.org/wiki/Media_type - https://www.freeformatter.com/mime-types-list.html - https://www.sitepoint.com/mime-types-complete-list/ Bug: 826756 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ied30f9728bd4f082bb620fea150f342457ea4833 Reviewed-on: https://chromium-review.googlesource.com/985211 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#547565}
-
Sergey Ulanov authored
The test timeouts when running on bots with nested virtualization due to slow IPIs and CPU contention. Bug: 826952 Change-Id: I2f8583922bf0591357dd1a0259c879df99b845c2 Reviewed-on: https://chromium-review.googlesource.com/990731Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#547564}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fd5d1859f1e0..b90af5c203f7 $ git log fd5d1859f..b90af5c20 --date=short --no-merges --format='%ad %ae %s' 2018-04-02 chrome-bot Update config settings by config-updater. Created with: roll-dep src/third_party/chromite The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I9966fa6f5f53d7afe88ee46d728cdbdf79b65082 Reviewed-on: https://chromium-review.googlesource.com/990206Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547563}
-
Nektarios Paisios authored
Relational operators need to work when one of the positions is a text position and the other an anchored position that is the sibling of the text position, i.e. when comparing the order of container objects is not enough to determine position order. R=dmazzoni@chromium.org Change-Id: Idf720b9e35e77c0da6b970017dc45c07d73b6c82 Reviewed-on: https://chromium-review.googlesource.com/988740Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#547562}
-
Filip Gorski authored
* Wires the new bridge to the old prototype * Tentatively takes dependency on the content suggestion service to simplyfy favicon fetching (this may still not work, because the database is not filled with contextual suggestions). * Next step to fetch favicons is to extract and reuse the code, while dropping the dependency on content suggestion service. Bug: 824183 Change-Id: I50d6879b837a06f64ac9c376de4a1f6f6c151d2b Reviewed-on: https://chromium-review.googlesource.com/989612 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#547561}
-
Troy Hildebrandt authored
Right now we only record a metric on when a voice search is triggered in the omnibox, and nowhere else. This patch records where the start of a voice interaction comes from, and if completed successfully resulting in either suggestions or a navigation to a SRP, the source of the finish event as well. This currently includes omnibox, NTP, and the search widget. This also includes a minor refactoring, pulling voice search logic out LocationBarLayout and into its own class, LocationBarVoiceRecognitionHandler. Bug: 817228 Change-Id: Ie0a97ecbbec92c9189e4454e67c94b18ca4c7ffe Reviewed-on: https://chromium-review.googlesource.com/943598 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#547560}
-
Tom Anderson authored
BUG=827899 R=dpranke Change-Id: Idb5832232d46ffda9df2d540523031a9edfdad44 Reviewed-on: https://chromium-review.googlesource.com/990959Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#547559}
-
Eugene Ostroukhov authored
1. Disable pointer events in the HTML preview. 2. Fix font size in the IDB object store display header. Change-Id: I0b19333c28392cc7641fb551aac9ab3deb27f1e1 Reviewed-on: https://chromium-review.googlesource.com/990207Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Cr-Commit-Position: refs/heads/master@{#547558}
-
James Cook authored
Clean up before making it work with out-of-process ash (go/mustash). * Make FirstRunHelper a concrete class * Eliminate ash::Shell::CreateFirstRunHelper * Move some methods to FirstRunController in chrome Bug: 756057 Test: existing ash_unittests, browser_tests Change-Id: I6d3660f64e2184a03c2f92b204200a26b5f7dab8 Reviewed-on: https://chromium-review.googlesource.com/990725Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#547557}
-
Andre Goddard Rosa authored
It's okay to pass nullptr to delete, as by default it will call free() that will check for NULL, so there's no need for redundant checks. Bug: none Change-Id: I450ee684f78d0cf3f1394d18de788df67f6435c9 Reviewed-on: https://chromium-review.googlesource.com/988960Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Andre Goddard Rosa <andre.rosa@lge.com> Cr-Commit-Position: refs/heads/master@{#547556}
-
Hector Carmona authored
Bug: 819567 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3683ea8b25ef5e8df47a897eb8f12d392f091b7a Reviewed-on: https://chromium-review.googlesource.com/988737Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#547555}
-
Takuto Ikuta authored
This is build dependency optimization for the build like below https://chromium-build-stats.appspot.com/ninja_log/2018/04/02/win75-c4/ninja_log.win75-c4.chrome-bot.20180402-000428.8888.gz/trace.html from https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/135170 obj files for browser_tests compiled around 215s~245s wait remoting/webapp unnecessarily. Change-Id: I47fecd63b063382fde5e4c200f378eff7563521e Reviewed-on: https://chromium-review.googlesource.com/989855Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#547554}
-
Katie D authored
This makes the STS EventRewriter work with Sticky Keys mode, and is basically a revert of commit 0c0f3795 along with porting other modifications made since that commit. Bug: 819860 Change-Id: I340295ac0ca6e24057fcb9d4a0890d77b3cf0439 Reviewed-on: https://chromium-review.googlesource.com/988849 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#547553}
-
Miguel Casas authored
This CL cleans up a few things that I realized while debugging other CLs in the area: - |available_va_surfaces_| is a std::list on ToT, but has queue semantics, so it's changed int his CL. - s/output_buffers_/available_va_surfaces_/ because that's what they are. - s/TryOutputSurface/TryOutputPicture/ because that's what the method does. - s/pictures_/picture_map_/ to better define what it is. After dcastagna@ suggestion, it's made a base::small_map in PS7 Comments updated throughout these variables. No change in behaviour intended, but tested nonetheless with vp8/9-h264 crosvideo playback. Bug: 822346 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2117ceac29f7d6ed23d698c4abd5c72e0140ae47 Reviewed-on: https://chromium-review.googlesource.com/988512 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#547552}
-
Karan Bhatia authored
This CL adds more test coverage for an extensions ability to xhr file urls through an extension frame. To XHR a file url an extension should have "Allow access to file URLs" setting enabled and also have host permissions to file:///. Tests are also added for activeTab. This also helps discover a bug with the network service implementation of the same. BUG=816685 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ic53a1ad9c25a5db56c69eb421734f76ba9f95a1e Reviewed-on: https://chromium-review.googlesource.com/985798Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#547551}
-
Wez authored
Change-Id: Id2debad3159b74fe50a89368aa940d686a0f015b Reviewed-on: https://chromium-review.googlesource.com/990081Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#547550}
-
Andrii Shyshkalov authored
While chrome operations are deciding how to rework how CQ deals with buildbucket-experimental builders. R=ehmaldonado@chromium.org, nodir@chromium.org Bug: 828111 Change-Id: I44c10d9328763cff1bdf609d89841e5aa5aa2f0f No-Try: True Reviewed-on: https://chromium-review.googlesource.com/991082Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#547549}
-
Adrienne Walker authored
After https://chromium-review.googlesource.com/c/chromium/src/+/982098, enabling oop rasterization by the command line disables gpu rasterization which in turn disables oop rasterization and uses software rasterization instead. This also fixes uses of GrContext that are no longer supported in GpuImageDecodeCache. Bug: 826987, 793508 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ifdf1f18eb34e9e63eeb6e39cb66a6ab77e10afcd Reviewed-on: https://chromium-review.googlesource.com/986744Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#547548}
-
Brandon Jones authored
Ensures that the developer can't alter viewports or projection matrices mid-frame. Covers: XRSession.depthNear XRSession.depthFar XRWebGLLayer.requestViewportScaling() Bug: 828113 Change-Id: If61262fafaf497a2231b9a57eefa4dd6dbb481eb Reviewed-on: https://chromium-review.googlesource.com/990719Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#547547}
-
Adam Langley authored
If we enforce that each new map value is greater than the previous one then that ensures that no duplicates are allowed without doing a lookup for every insert. Bug: 827551 Change-Id: Idcc24b1070cc1707362f37a7f76198053882148a Reviewed-on: https://chromium-review.googlesource.com/982610 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#547546}
-
Charlie Reis authored
This reverts commit 1c854a22. Reason for revert: Failures were not due to this test. Passes locally. Original change's description: > Disable test FrameTreeTest.FindFrames > > Test FrameTreeTest.FindFrames is flaky. Disable it. > > TBR=creis@chromium.org > > Bug: 826599 > Change-Id: I3536ef001db9f8df4193ad7c709cc4f7c4246d97 > Reviewed-on: https://chromium-review.googlesource.com/985996 > Reviewed-by: Adam Rice <ricea@chromium.org> > Commit-Queue: Adam Rice <ricea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#546808} TBR=creis@chromium.org,ricea@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 826599 Change-Id: I1b3aeeaccb8458fc57959efdf236d126280cde5b Reviewed-on: https://chromium-review.googlesource.com/990752Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#547545}
-
Fady Samuel authored
The crash log in 826186 suggests that the previous surface was already destroyed by the time the next activates. It's unclear how we get into this state. One possible theory is surfaces are activating out of order: 1. CompositorFrame with LocalSurfaceID 2 activates. 2. CompositorFrame with LocalSurfaceID 3 activates. 3. LocalSurfaceID 2 is marked for destruction. 4. CompositorFrame with LocalSurfaceID 2 activates again. 5. Garbage collection happens, and LocalSurfaceID 2's surface is destroyed. 6. CompositorFrame with LocalSurfaceID 4 activates, but the previous surface, LocalSurfaceId 2 has been destroyed so SetPreviousFrameSurface crashes trying to access 2. The only way to get into this state if is if there are two pending CompositorFrames for a FrameSink at once. It's unclear how this can happen because cc should not be issuing a new CompositorFrame until the previous CompositorFrame has activated. Perhaps there's a cc bug? This CL adds a diagnostic check to verify that LocalSurfaceIds activate in a monotonically increasing fashion. Bug: 826186, 672962 Change-Id: I2c3826c63d2538fa9562be683d864a11de904dd0 Reviewed-on: https://chromium-review.googlesource.com/990200 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#547544}
-
Joshua Bell authored
Split out cases from a master "cookie-store-tests.js" suite, allowing them to be enabled/debugged separately. Also updates observation tests to use the new "change" event, and deletes "static" since we can assume a dependency on a test server here. Bug: 783229 Change-Id: I9e29ea74a2f0513a033a8f9c71da2836c000ee27 Reviewed-on: https://chromium-review.googlesource.com/986649 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#547543}
-
https://chromium.googlesource.com/angle/angle.git/+log/d104918fd531..5a7e61bbda82 $ git log d104918fd..5a7e61bbd --date=short --no-merges --format='%ad %ae %s' 2018-03-29 lfy GLES1: glNormal3(f|x) Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: If06aa967ee5cb916f99c9316dbfbbdb688bfed3b Reviewed-on: https://chromium-review.googlesource.com/990234Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547542}
-
Pavel Feldman authored
Bug: 824691 Change-Id: I78c4e15d956b858b385464e4265143ddfd1651ed Reviewed-on: https://chromium-review.googlesource.com/990481Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#547541}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0d466d22d8e2..31e7d56c28f1 $ git log 0d466d22d..31e7d56c2 --date=short --no-merges --format='%ad %ae %s' 2018-04-02 rmistry Support setting Auto-Submit during "git cl upload" 2018-04-02 ehmaldonado gclient setdep: Add support to create new variables. Created with: roll-dep src/third_party/depot_tools BUG=chromium:631551,chromium:760633 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ia87a7c017f69d30bc5cd22d7f3df08e3e5bc8a8a Reviewed-on: https://chromium-review.googlesource.com/990715 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547540}
-
Ken Rockot authored
Duplicate, Map, and MapAt on these various types do not and should not need to modify the calling object. Bug: 826213 Change-Id: Ice07621c23f36da00e20a13076a783cf1e41d7f2 Reviewed-on: https://chromium-review.googlesource.com/990673Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#547539}
-
erikchen authored
The syscall madvise(MADV_FREE_REUSE) is used to update accounting for memory-usage, and is intended to be paired with madvise(MADV_FREE_REUSABLE). Bug: 823915 Change-Id: Iedbeebf58c1c8dd85ce25615d0ddcfc5eb1d4afb Reviewed-on: https://chromium-review.googlesource.com/988194Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#547538}
-
Daniel Murphy authored
This change is to further investigate crbug/756447: * Fixes some vague error reporting in BlobReader * Adds a feature flag around IDB big value wrapping (and re-enables it) * Adds UMA metrics around blob reading and IDB large value reading. Bug: 756447, 788681 Change-Id: I398fee4e69582e76f0a81449ff26a45ec3abe32f Reviewed-on: https://chromium-review.googlesource.com/988843 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#547537}
-