GitLab

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome

Bug: b/129156659
Test: Local build
Change-Id: I603899c62a4c1e6aa4901442638a219d40d3229b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568686
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653385}

This reverts commit afbb99bf.

Reason for revert: will break build

Original change's description:
> Roll src/third_party/skia 29c1c8029a52..1f4c2bdfa2c1 (7 commits)
> 
> https://skia.googlesource.com/skia.git/+log/29c1c8029a52..1f4c2bdfa2c1
> 
> 
> git log 29c1c8029a52..1f4c2bdfa2c1 --date=short --no-merges --format='%ad %ae %s'
> 2019-04-23 mtklein@google.com sort, dedup skia_public_includes
> 2019-04-23 mtklein@google.com inject SkUserConfig.h with -DSK_USER_CONFIG_HEADER
> 2019-04-23 mtklein@google.com another stray <include> -> ""
> 2019-04-23 ethannicholas@google.com added support for interpreting generic SkSL functions
> 2019-04-23 mtklein@google.com are these include paths no longer needed?
> 2019-04-23 herb@google.com Only call findImage when needed
> 2019-04-23 mtklein@google.com switch some idiosyncratic <includes> to ""
> 
> 
> Created with:
>   gclient setdep -r src/third_party/skia@1f4c2bdfa2c1
> 
> The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> If the roll is causing failures, please contact the current sheriff, who should
> be CC'd on the roll, and stop the roller if necessary.
> 
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> TBR=mtklein@chromium.org
> 
> Change-Id: I6df4435268acbb8ddba0121ee6c397c85c95d284
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577574
> Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#653382}

TBR=mtklein@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com

Change-Id: Ic2144340f24989ffc2b05b0523fcd1dfb3827e94
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580044Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653384}

https://swiftshader.googlesource.com/SwiftShader.git/+log/652edcc30204..451cad2c0da4


git log 652edcc30204..451cad2c0da4 --date=short --no-merges --format='%ad %ae %s'
2019-04-23 chrisforbes@google.com Only do centroid sampling if multisampling
2019-04-23 chrisforbes@google.com Remove more stale renderer plumbing
2019-04-23 chrisforbes@google.com Wire up alphaToCoverage support
2019-04-23 chrisforbes@google.com Unify template-based and classic descriptor writes
2019-04-23 chrisforbes@google.com Add support for indexing into arrays of image descriptors
2019-04-23 chrisforbes@google.com Clean up storage image descriptor access


Created with:
  gclient setdep -r src/third_party/swiftshader@451cad2c0da4

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:b/118386749,chromium:b/118386749,chromium:b/118386749,chromium:b/123244275,chromium:b/131082089,chromium:b/131082089
TBR=swiftshader-team+autoroll@chromium.org

Change-Id: I4d84e339d929b09b3d47354d5e752ceba5e9bb30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579442Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#653383}

https://skia.googlesource.com/skia.git/+log/29c1c8029a52..1f4c2bdfa2c1


git log 29c1c8029a52..1f4c2bdfa2c1 --date=short --no-merges --format='%ad %ae %s'
2019-04-23 mtklein@google.com sort, dedup skia_public_includes
2019-04-23 mtklein@google.com inject SkUserConfig.h with -DSK_USER_CONFIG_HEADER
2019-04-23 mtklein@google.com another stray <include> -> ""
2019-04-23 ethannicholas@google.com added support for interpreting generic SkSL functions
2019-04-23 mtklein@google.com are these include paths no longer needed?
2019-04-23 herb@google.com Only call findImage when needed
2019-04-23 mtklein@google.com switch some idiosyncratic <includes> to ""


Created with:
  gclient setdep -r src/third_party/skia@1f4c2bdfa2c1

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=mtklein@chromium.org

Change-Id: I6df4435268acbb8ddba0121ee6c397c85c95d284
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577574Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#653382}

I opted to use ".has_value() &&" instead of ".value_or(~)" in
some places for generally readability reasons.  We don't want to
log certain metrics or strikes if the value was missing (which
SHOULD almost never happen, but rare race conditions are possible)
and I don't want to switch between _or(true) and _or(false) as
necessary in those situations.

Change-Id: Ieec56f5cdf9cae8855b17d49ed78a9850a2a8c91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576107Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#653381}

https://chromium.googlesource.com/angle/angle.git/+log/cff6f150eae1..83740f979584


git log cff6f150eae1..83740f979584 --date=short --no-merges --format='%ad %ae %s'
2019-04-23 cnorthrop@google.com Android: Add ANGLE version to logcat


Created with:
  gclient setdep -r src/third_party/angle@83740f979584

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: I2f95c3689393ce5488e943f9e4a2f8f6fd9c9ee7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579440Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#653380}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/643152926e86..d366d8c98e1b


Created with:
  gclient setdep -r src-internal@d366d8c98e1b

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org

Change-Id: I1c98deb6ca87dbd0d128f4fcc0f99cb8b25bdcbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577576Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#653379}

Warmup url fetch happens on startup and depending on whether it succeeds
the http/https proxy should be enabled or disabled in the custom proxy
config in network service. However the proxies are not getting disabled.
This CL fixes that and also adds a feature flag to turn off this
behavior.

Bug: 954958
Change-Id: I22f0dc4cfb0ef58b4922ecfe9ba57009744aba8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579026Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653378}

BUG=921357
TEST=try

Change-Id: I05b426832e5de4d1a2d5d340b408fdc06e9b97ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579560
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653377}

Bug: 955201
Change-Id: Ib6a1d94d342696a370a17ed62852d8f7b7f39d52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578119Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#653376}

In the current, non-threaded design, the DocumentPaintDefinition is
created in the global scope and passed to CSSPaintImageGeneratorImpl
where it is used directly from main-thread call-points. This doesn't
work for the threaded-worklet case, where the global scope runs on the
worklet thread.

Instead, the PaintWorkletProxyClient is responsible for gathering
and detecting incompatible definitions. Once a valid set of definitions
is received from all global scopes, a thread-safe version is created
(MainThreadDocumentPaintDefinition) and passed cross-thread to the
PaintWorklet instance on the main thread. That main thread version can
then be used for main-thread call-points (not done in this CL).

Bug: 946519
Change-Id: Ic150c42ae5d93610aec1e75ebf1117500441693b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576501Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653375}

Uses a separate V8Unwinder object for each profile collection. This is
required because of the unwinder's use of the ModuleCache, which is also
scoped to the profile collection. To support this change auxiliary
unwinder ownership is moved from ThreadProfiler to StackSamplerImpl.

Bug: 909957
Change-Id: Idc78d6be2bbff6bbb52240ee647b28b9915ac962
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577787
Commit-Queue: oysteine <oysteine@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Auto-Submit: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653374}

This patch also enables importing of the newly exported WebSocket
messages

Bug: 496006
Change-Id: I000468d266a570ca46eaa62ac9d7554713896acb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574606Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653373}

There are some cases where an elapsed timer that can be paused is
useful.

An example case is recording surface embedding time to UMA metric.
Currently, the surface embedding time is recorded by simply taking
the different between the TimeTicks of the surface id allocation time
and the TimeTicks of when Surface::OnWillBeDrawn is called.
However, it is possible that surface id is allocated when the Renderer
is not visible, i.e. when the child changes size while hidden.
In this case, the surface embedding time will be arbitrarily inflated
since Surface::OnWillBeDrawn will not be called until it becomes
visible.

By using a pausable elapsed timer, the surface embedding time can be
paused if the renderer is hidden, and resumed when it becomes visible
again.

Bug: 949967
Change-Id: Ide8e5b67a06bae7d3ca1352574c477f35e32369c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576331Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Edwin Joe <ejoe@google.com>
Cr-Commit-Position: refs/heads/master@{#653372}

When the backdrop rect for a render pass is empty, gl_renderer currently
sets use_shaders_for_blending to false, disregarding if the render
pass blend mode is supported by the underlying graphics API.
If it's not supported, a DCHECK is later hit when setting up alpha
blending.

This patch sets the blend function to kSrcOver in those cases where the
backdrop rect is empty.
The backdrop rect should be empty only in cases where the render pass
draw quad is completely clipped.
In the test case found by cluster fuzz the element has a
clip-path: polygon(3px 0px, 35px 1px) that limits the render pass
output rect. When computing the backdrop rect we intersect it with
the render pass output rect resulting in an empty rect.

Bug: 946464
Test: https://clusterfuzz.com/testcase?key=5140838366707712
Change-Id: Ie8a487a4f85c3a69ab4f809fc1ade1a71bdaaeda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576233Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653371}

Fixes a race where auto-enrollment screen would just hang if the
auto-enrollment check triggered in posted EULA steps reported
connection error, or server error before the auto enrollment check
screen was started.

The AutoEnrollmentController would report in complete state, but
requests to (re) start auto-enrollment checks would be ignored due
to client_ already being set.

BUG=894384

Change-Id: Idd770f3e9d437a0a80df0e6243fc200dc6ae3e30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576144
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653370}

Disable the Clear Browsing Data button (toolbar button in CBD table view)
when no browsing data items are selected.

Bug: 935346
Change-Id: I87417c2afca3d0297ae638cfb7cf100793bc2c81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575501
Commit-Queue: Huanzhong Huang <huanzhong@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653369}

This CL provides a feature flag that enables a small subset of
kOmniboxSuggestionTransparencyOptions.

It just enables the clock icon on search history matches.

Bug: 929477
Change-Id: I5aa112cd2627a25744ee00e70a735eed5892c0cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579466Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653368}

LocalSiteCharacteristicsWebContentsObserver (L41r) is the last user of
the PageSignalGenerator (PSG). This CL replaces that functionality with
a dedicated graph observer in preparation for retiring the PSG.
The storage of load time performance estimates is also removed. The PSG
maintains state for this that will be rewritten as a graph decorator in
due course.

Bug: 931407
Change-Id: I9840b6e9833702efde4d1587a990108c655e3b44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579363
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653367}

Reland with a fix for missing immediate data storage in the decoder
unittests.

These WebGPU IPC commands allows wrapping a mailbox in a Dawn texture
and associate it to a given ID in dawn_wire. There is the respective
dissociate command too.

SharedImageRepresentationIOSurfaceDawn is changed to destroy() the Dawn
texture on EndAccess so it is an error to access the texture after the
mailbox has been dissociated. The class also gets some refcounting
improvements.

This also makes some GPU service objects able to be used when no GL
context is present, as is the case when running WebGPU unittests.

BUG=chromium:877147

Change-Id: Ib0c8f6251441c9dbe69252773279b53a1fec3736
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577422Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653366}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/18d98f00a12c..9616947a9374


git log 18d98f00a12c..9616947a9374 --date=short --no-merges --format='%ad %ae %s'
2019-04-23 mathewk@chromium.org Mark lakitu boards as important
2019-04-23 norvez@chromium.org chromeos_config: mark nyan_big/blaze important
2019-04-23 derat@chromium.org chromeos_config: Run TastVMTest on amd64-generic-goma-full.


Created with:
  gclient setdep -r src/third_party/chromite@9616947a9374

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@chromium.org

Change-Id: Iddea723ccd0f9c77371ffcc01a9372959607ceb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579443Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#653365}

The tests check for two cases:
- When SendTabToSelf receiving is enabled on both devices, device
info for both are updated to reflect this.
- When SendTabToSelf receiving is disabled on one device, device
info accurately reflects this change.

Change-Id: Ie3350e66783890b8271d9700b1d6d4b35a8a84d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577946
Commit-Queue: Tanya Gupta <tgupta@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653364}

* Reworked how focus was stored and passed around. Instead of having a
JSON backed class with strong types, use a TypedKeyValues object
backed by a Bundle. Each ViewHolder is responsible for creating these
when they're focused, and after onViewBind() the ViewHolders are
offered a generic focus object to see whether they want to restore
focus with it.

* Reworked when requestFocus() is called to be a little later, during
LinearLayoutManager#onLayoutCompleted(). This was necessary for the
above the fold views to correctly focus, and the NTP to mirror EoS.

* Added support for focusing the view elements with the above the fold
 card. AboveTheFoldViewHolder itself is still outside of the MVC
pattern, but delegation to the OpenTabButton and SiteSuggestions
components follows MVC.

Bug: 937452
Change-Id: I2df007f3a41007fd6a2b327b4729e30042d16bb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563035
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653363}

https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/9f893b99598b..a53e931dcd00

$ git log 9f893b995..a53e931dc --date=short --no-merges --format='%ad %ae %s'
2019-04-18 gennadiycivil Update README.md
2019-04-18 misterg Googletest export
2019-04-18 absl-team Googletest export
2019-04-18 misterg Googletest export
2019-03-08 yaneurabeya clang: fix `-Wsign-conversion` errors

Created with:
  roll-dep src/third_party/googletest/src

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel,mac_optional_gpu_tests_rel,linux_chromium_cfi_rel_ng;luci.chrome.try:win_chrome_official
Change-Id: I063fb50f95b0af4a7686c3f59d01b7d0a2db6ae1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577861
Commit-Queue: Staphany Park <staphany@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Auto-Submit: Staphany Park <staphany@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653362}

Bug: 954797
Change-Id: Idec1306428c4efa4500534ad970da1606e132003
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575435
Commit-Queue: John Williams <jrw@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653361}

The function assumed that all calls would return non-null pointers.
Fixed that to explictly check for nullptr.

Bug: 950640
Change-Id: I7b1ff107b3dd6b94b439f486779cfefe2ae1688e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577977Reviewed-by: sebsg <sebsg@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Tanya Gupta <tgupta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653360}

This takes away one source of SSLConfig variation. We can instead put it
back in SSLConnectJob (the flattened socket pools should avoid the NTLM
bug), but no point when we don't need it anymore. TLS 1.3 has been
shipping for over a year now, and the admin policy expired in M75. Per
chrome/VERSION, trunk is now M76.

This CL does not change whether connections with TLS-1.3-intolerant
networks or servers fail. It only shifts the error back to
ERR_SSL_PROTOCOL_ERROR, ERR_CONNECTION_RESET, or whatever we actually
get out of the server.

Bug: 951205
Change-Id: I95f1730c7b835c9aab1998c0cda56bcfaca45e1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574368
Commit-Queue: David Benjamin <davidben@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653359}

-Add another initializer for ClearBrowsingDataManager
-Make BrowsingDataRemover and CounterProducer explicit dependencies of
CBDManager, so to allow dependency injections in tests.

Bug: 935350
Change-Id: I2e445e474c7a549b3aebcf1007b543b371644bbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577421
Commit-Queue: Huanzhong Huang <huanzhong@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653358}

Bug: 955638

Change-Id: I375ca09f4c117ad35b84a85c97dae9702d8b534a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579521Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Cr-Commit-Position: refs/heads/master@{#653357}

[chromecast] Add a function in CastContentBrowserClient to initialize CastURLLoaderThrottle::Delegate

Bug: b/129956026
Merge-With: eureka-internal/265739
Test: Manual test
Change-Id: Icebc1806c842ba7b69be7dac425ccda433b23d0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577960
Commit-Queue: Junbo Ke <juke@chromium.org>
Reviewed-by: Sean Topping <seantopping@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653356}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6d9913ab1893..158a65393019


git log 6d9913ab1893..158a65393019 --date=short --no-merges --format='%ad %ae %s'
2019-04-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@158a65393019

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I25cf0f0c3e52a1544216b8b57b61c2cf89c92f05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579439Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#653355}

This patch applies content sniffing to WebP images in order to determine
whether they use lossy or lossless compression. This allows the the
policies to be applied more precisely to WebP images.

Bug: 955580
Change-Id: Id5d97d9d10e1253fe353dc03ffbdbdee69e9428b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569691Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Paul Meyer <paulmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653354}

Neither of these should do anything yet:
  - add top-level Skia directory to include path so includes like
    "include/core/SkCanvas.h" will work
    (see https://skia-review.googlesource.com/c/skia/+/209706)
  - define SK_USER_CONFIG_HEADER to point to Chromium's SkUserConfig.h
    (see https://skia-review.googlesource.com/c/skia/+/209866)

As a small sanity cleanup:
  - remove Skia's include/config from the include path.  We don't ever
    want to use Skia's default SkUserConfig.h, only ever Chromium's.

I think the include order means we have no bug here, but removing
the undesirable include path should make that extra snuggly safe.

Change-Id: I87ac5132967251e80f7b0bbea01676df25195b02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577632Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653353}

This is a small code change with a lot of test changes. The two most
common reasons for those changes are:
* Cases where the ordering of messages reaching the browser process
  changed in ways that browser_tests were sensitive to.
* A navigation scheduled by NavigationScheduler doesn't prevent a
  DidStopLoading() callback, but starting the navigation
  immediately does prevent DidStopLoading(). So location API
  navigations inside onload used to result in two pairs of
  DidStartLoading/DidStopLoading callbacks, where there is now only
  one pair.

Bug: 914587
Change-Id: I83b016041c4579a64cf9ccfd7876dba335b799d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526426
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653352}

We want to know how our user base migrate to newer GPU generations
over time, so definitely want to keep this alive for much longer.

BUG=945562
TEST=bots

Change-Id: Ibc762346b315454d4918b22aa51816700a48ae80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575084Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653351}

Testing with media_unittests

Bug: 755368
Change-Id: I9b45735a5d3054207d3bc340bce45fb25014a447
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568847
Auto-Submit: Daniel McArdle <dmcardle@chromium.org>
Commit-Queue: Daniel McArdle <dmcardle@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653350}

Bug: 855182
Change-Id: I8760ab9eb7bf3fbae726674537555dad5dcb8870
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577876Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#653349}

Bug: 714962
Change-Id: I37dea7db4dfc33b561871a20969629e8b497c103
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579030Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653348}

Patches diff from
https://chromium-review.googlesource.com/c/chromium/src/+/1574440
to os settings.

Bug: 950007
Change-Id: Ifbd4489816055260f3fb1a48ee91620b53e6d61c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577943Reviewed-by: May Lippert <maybelle@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653347}

Change-Id: I5244ca5369eba162c2314ad1aedddfbe9c7ddb62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577583Reviewed-by: Nick Harper <nharper@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653346}