- 10 Apr, 2018 40 commits
-
-
Tommy Steimel authored
This CL adds a shadow to the overlay play button so that it's visible against white backgrounds. Bug: 831032 Change-Id: If9af93e25efe8a1e1b3cf802629a15c3e2d0597e Reviewed-on: https://chromium-review.googlesource.com/1004112Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#549594}
-
Douglas Creager authored
We now keep track of the number of attempted and successful uploads for each client, as well as the total number of reports in those (attempted and successful) uploads. We'll use this to construct a nice table view of the Reporting cache for the net-internals page. Bug: 829353 Change-Id: I3d7f34a9ca459666a9cbed3738ac1b578a4397a2 Reviewed-on: https://chromium-review.googlesource.com/995640Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Commit-Queue: Douglas Creager <dcreager@google.com> Cr-Commit-Position: refs/heads/master@{#549593}
-
Theresa authored
Prevent the contextual suggestions bottom sheet from appearing in CCTs and other sub-classes of ChromeActivity that aren't ChromeTabbedActivity. BUG=823987 Change-Id: I56c4ccfbc30ae078668d39cd8252e74468ae4dd7 Reviewed-on: https://chromium-review.googlesource.com/1005497Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#549592}
-
Oksana Zhuravlova authored
This change also converts the minimum necessary amount of C++ code to pass objects of base::Value by value instead of std::unique_ptr. TBR=jam@chromium.org Bug: 646113,799482 Change-Id: Ib216232ea68c225882890eb74356a8a663d38f13 Reviewed-on: https://chromium-review.googlesource.com/1000254 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#549591}
-
Bernhard Bauer authored
Screenshots: https://aberent-clankuicatalogue.googleplex.com/screenshot_view?screenshot_source=https://storage.cloud.google.com/chromium-result-details/a233cc605dc4d16fe77382e9b6bb848d85fdf6e6&key=0 https://aberent-clankuicatalogue.googleplex.com/screenshot_view?screenshot_source=https://storage.cloud.google.com/chromium-result-details/4235859320dfd9b9a63bb5ba4395aa6d2db85414&key=0 https://aberent-clankuicatalogue.googleplex.com/screenshot_view?screenshot_source=https://storage.cloud.google.com/chromium-result-details/0ea4efd9698da906d745c8654c0a1dcebafbe38e&key=0 Bug: 814365 Change-Id: Id895ad12fd2f79a82367511693f996c4c4756b6e Reviewed-on: https://chromium-review.googlesource.com/1000699Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#549590}
-
Max Moroz authored
R=csharrison@chromium.org TBR=haraken@chromium.org Bug: 830155 Change-Id: I41d40141d0db26933bc06f93a6bd63e5460c6cbb Reviewed-on: https://chromium-review.googlesource.com/1005405 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#549589}
-
Tom Anderson authored
TBR=dpranke Change-Id: I72e33bdcd009b62853434507f3096199e921c28d Reviewed-on: https://chromium-review.googlesource.com/1005446Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#549588}
-
Lambros Lambrou authored
This modifies the host to generate SDP messages with CRLF line-endings. Both host and client already accept incoming SDP with CRLF or just LF. However, the normalized form of SDP for signature-verification uses just LF endings, and we need to maintain this for compatibilty. So this CL introduces two normalized forms, one with CRLF endings for sending SDP, and one with LF endings for signature calculation. Bug: 830974 Test: Unittests, and manual end-to-end test using Chrome beta (M65). Change-Id: I061637cf639af97184295e4a1b23aa4b663e246d Reviewed-on: https://chromium-review.googlesource.com/1003773Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#549587}
-
chaopeng authored
An inertial scroll (fling) event from previous completed overscroll gesture sequence should not modify scroll state in ReceivedEventACK(). Bug: 647140 Change-Id: I48c595124c7f0e2e37b92d256ab13dc50a1ec400 Reviewed-on: https://chromium-review.googlesource.com/1003214 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#549586}
-
Tommy Steimel authored
This CL adds hover CSS rules to show a highlight when the media control buttons are hovered. Bug: 809021, 827568 Change-Id: I69dfc0d5571efc39226f0e1da30adc211825a402 Reviewed-on: https://chromium-review.googlesource.com/1004119 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#549585}
-
erikchen authored
The component will contain heap_profiling code that depends on content/, and needs to be used by Desktop Chrome, Android, and Android Webview. Bug: 827545 Change-Id: I32e93b800d315c9e99df8cc778bc770c640953ba Reviewed-on: https://chromium-review.googlesource.com/1005319Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#549584}
-
Ryan Hansberry authored
Bug: 819279 Change-Id: I169ea407b635ebe3749d6027e493e1c82c05fbdf Reviewed-on: https://chromium-review.googlesource.com/1004438Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#549583}
-
Evan Stade authored
Bug: 628715 Change-Id: I612e5043407ccb7396d222e33e713d1da90c47ce Reviewed-on: https://chromium-review.googlesource.com/1002545Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#549582}
-
Chris Mumford authored
Previously FileSystemContext::AttemptAutoMountForURLRequest passed a net::URLRequest pointer to the automount handlers. In order to support the network service this change switches to passing a FileSystemRequestInfo structure containing the original request (for legacy network operations), and a |content_id| for use by the network service. Bug: 797292 Change-Id: I6b09875e9f6ff46e7a10e575ffd0bf2c60f3880d Reviewed-on: https://chromium-review.googlesource.com/955663 Commit-Queue: Chris Mumford <cmumford@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#549581}
-
Demetrios Papadopoulos authored
Add optimize_webui() BUILD rules to generate HTML and JS bundles for new print preview. Bug: 811392 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8cc07893279dd97ef70e9cca6d6e33d4b433d411 Reviewed-on: https://chromium-review.googlesource.com/956620Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#549580}
-
Justin Cohen authored
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I78e2b3d1a6335a73a074e0534980238d3a61568c Reviewed-on: https://chromium-review.googlesource.com/1005439Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#549579}
-
Scott Violet authored
That's the only place it's currently used, and I'm tired of waiting on windows try bots. If we decide to use on windows we can move back to other section. BUG=none TEST=none Change-Id: Id1ff274daa25ea51ceef796948a1db9f0a5f60b9 Reviewed-on: https://chromium-review.googlesource.com/1004116Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#549578}
-
Ryan Sleevi authored
Record a histogram in the event the built-in list of known, publicly-trusted roots is out of date. This happens when the OS believes a given certificate is a known root, but the built-in list of SPKIs does not have this root. BUG=none Change-Id: I65f2f495f9e936a81e3cbe1b6d6169d4b682e40d Reviewed-on: https://chromium-review.googlesource.com/1003234Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#549577}
-
Ria Jiang authored
This CL sets up hit-test data provider in VizProcessTransportFactory for browser in the OOP-D (Viz DisplayCompositor) case. Browser shouldn't set ask flag for the renderers it embeds. Bug: 803548 Test: viz_unittests Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I5c00d4ef00ce40a4478f18e28585e07f450ecb15 Reviewed-on: https://chromium-review.googlesource.com/916828Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#549576}
-
Sadrul Habib Chowdhury authored
Turn on the sampling profiler on the main thread in renderer processes. Note that this turns on the profiler only for native (i.e. c++) code. Additional work needs to happen to turn this on for javascript code. See details here: https://docs.google.com/document/d/1MNl5x_01As_OTOs4PIM6rezQ4LNmEpPNZV3vuY26dcg/edit BUG=788808 Change-Id: I1b3f638daf6d24624db4eb9e9226cfd363328284 Reviewed-on: https://chromium-review.googlesource.com/1003377 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#549575}
-
Luke Halliwell authored
Blocking internal CQ - these tests wouldn't get built or run since they weren't included in the main tests target. Bug: None Test: Run CQ Change-Id: I49300ef1fb49c9a13524dfbfb08b04219788a6aa Reviewed-on: https://chromium-review.googlesource.com/1005027 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#549574}
-
crystallambert@chromium.org authored
List of permissions that can be optional was outated. This CL updates and organized them. Bug: 822371 Change-Id: Ie6ee5854b9ed5ca7636132a4e732abd15cb5d74b Reviewed-on: https://chromium-review.googlesource.com/978967 Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549573}
-
Bo Liu authored
Currently isDestroyed only checks for if native is actually destroyed. However we should really consider AwContents to be dead once WeakReferences to it has been cleared. It's espeically important to cancel all callbacks to the app once WeakReference has been cleared, so that app don't keep using which will be destroyed soon after. It's debatable whether weak reference check should also guard calls into webview. This CL chooses to be simple and guards these calls as well. Bug: 830492 Change-Id: I0c2868a55e0dc0b226d1575fc37875ddad0f2c42 Reviewed-on: https://chromium-review.googlesource.com/1003331Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#549572}
-
Tarun Bansal authored
Host specific random noise is added to the client hints. Change-Id: Ic08ac42095e9f484f91f1d8123b79b749eb3fe13 Bug: 826950 Reviewed-on: https://chromium-review.googlesource.com/1002232 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#549571}
-
Bernhard Bauer authored
Tablets use a different security icon for HTTP, so update the verification code to use getDefaultSecurityIcon() which takes this into account. Bug: 831174 Change-Id: Ifb21fd127163e98ff8129f67f378dc9b3f1a8d38 Reviewed-on: https://chromium-review.googlesource.com/1005514Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#549570}
-
Jun Choi authored
Currently FidoRequestHandler returns kConditionNotSatisfied for tokens that returns with UP-verified error and drops requests for tokens that responses with success return code with malformed data. However, in mojom::authenticator, NOTREACHED() check will fail for kConditionsNotSatisfied and kFailure handles the case of malformed response. Change return code handling in FidoRequestHandler accordingly. Bug: 780078 Change-Id: Ia8ae3ff3c8a2d805a9e7310e7a590493a1769cc5 Reviewed-on: https://chromium-review.googlesource.com/999127Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#549569}
-
Quinten Yearsley authored
These were added with "linux-ci", but should have "android-ci" (since these builders are listed under "chromium.android" in mb_config.pyl and the recipe config. Bug: 790311, 790308 Change-Id: I7948c68e36e6bf36ffdc1f341bb6aa5e4984ae4a Reviewed-on: https://chromium-review.googlesource.com/1003513Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#549568}
-
David Benjamin authored
Take advantage of inline member initializers, which are harder to forget, and operator=, which the compiler generates for us. Bug: none Change-Id: I6658cab836444ea74ae237fe3c065edebc400615 Reviewed-on: https://chromium-review.googlesource.com/1003553Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#549567}
-
Saman Sami authored
During navigation, if the new page is rendered by the same RenderWidget as the previous page, we don't hide the previous page until the new page has something to show. However, when the new page has to be rendered by a new RenderWidget we always show a flash during navigation. Two common cases are: - When user navigates by typing a new URL into the omnibox. - Any cross-site navigation when site isolation is enabled. Avoid the flash in these cases by showing the old page until the new page paints. If the new page fails to paint within 4 seconds, we hide the previous page for security reasons. This CL only applies to Aura platforms and Android because no matter what I do on Mac I still see a flash. Bug: 815187 Change-Id: I15345adcdfd8f8ef2ac2aedfe62958ba5621f6f6 Reviewed-on: https://chromium-review.googlesource.com/995915 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#549566}
-
Victor Costan authored
This makes it possible to use LinkNode subclasses with base::Optional. Bug: 729800 Change-Id: If2f3814879ec252ea0723f5ad1070d5917445e34 Reviewed-on: https://chromium-review.googlesource.com/1005022 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#549565}
-
David Roger authored
The TODO was addressed in: https://chromium-review.googlesource.com/c/chromium/src/+/986268 Bug: 823714 Change-Id: I1201f14edb15a8f89921865aabf6f1326bb0612b Reviewed-on: https://chromium-review.googlesource.com/995416 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#549564}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4acb5079..39414498 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I5bdff213c364d7c37bcb5bc15506c490b7639f37 Reviewed-on: https://chromium-review.googlesource.com/1005099Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#549563}
-
Istiaque Ahmed authored
AsyncExtensionFunction is deprecated and soon will be removed. This CL does not produce any behavior changes. Bug: 829174 Change-Id: Ic686837c11c4f8a4047a7748f133798e24d9203a Reviewed-on: https://chromium-review.googlesource.com/997098Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#549562}
-
Wei Li authored
ExtensionPopup used native windows server to draw its border beforei this change in the same way as Cocoa did. However, through hiding and showing the bubble, the shadow was not reliably drawn. Now we change to use views to draw its shadow. Other bubbles on Mac, as well as the extension popup on Cocoa, will still use native windows server to draw their shadows. BUG=821739 Change-Id: Ie4fa4f4499e9feed1f266eb79ab878e7fee92ab4 Reviewed-on: https://chromium-review.googlesource.com/1003046Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#549561}
-
Daniel Bratell authored
An accidental inclusion of a cc file caused interesting linking errors (duplicate chrome::kChromeUIPrintURL) in certain build configurations. Fix is to include the header instead of the cc file so that references to chrome::kChromeUIPrintURL will be external as intended. Change-Id: Iba69dbd17267955534609d308cef16ab0467671d Reviewed-on: https://chromium-review.googlesource.com/1005342Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#549560}
-
Xiaohan Wang authored
Description of icons: - infobar_protected_media_identifier.png: Blue icon used on the actual permission prompt. - permission_protected_media.png: Gray icon used on site settings. Optimized with: tools/resources/optimize-png-files.sh -o2 -c HEAD~ -v For historical context, previously those icons were added in https://codereview.chromium.org/2123533002 For Protected Content icon change on desktop platforms, see https://chromium-review.googlesource.com/c/chromium/src/+/1003146 Bug: 454980 Test: Manually tried it and verified on https://permission.site Change-Id: Idc74992632161ee19944146395ac87d79adee848 Reviewed-on: https://chromium-review.googlesource.com/996754 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#549559}
-
Asanka Herath authored
These values are already deprecated, but they appear in historical records. Change-Id: I4410003565ce10755c600db27db2df93c641d099 Reviewed-on: https://chromium-review.googlesource.com/1004915Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#549558}
-
Emircan Uysaler authored
This reverts commit 72de4972. Reason for revert: Caused issues with bitrate in WebRTC use of H264 encoder. Original change's description: > Reduce the frequency of key-frames of Windows MF H264 encoder > > Since WebRTC has its own key-frame management, it's not reasonable for MF H264 > encoder to generate key-frames regularly - it generates one key-frame per 30 > frames. > So this change sets CODECAPI_AVEncMPVGOPSize to UINT32_MAX to block it from > generating key-frames automatically. But this setting won't impact the key-frame > requests from WebRTC. > > Bug: chromium:769391 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I1e9e5ffdd7068c81ac02438e59ad3c92d75b8742 > Reviewed-on: https://chromium-review.googlesource.com/738916 > Commit-Queue: Zijie He <zijiehe@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#511969} TBR=sandersd@chromium.org,zijiehe@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:769391, chromium:798399 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I437d9a939fd4ae960eae278d6d13ee40330b3e46 Reviewed-on: https://chromium-review.googlesource.com/1003612 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#549557}
-
Mark Cogan authored
This CL adds support (via a gesture recognizer) for long-press-drag movement of grid cells to GridViewController. The cell movement gets the appropriate delegate plumbing so it can be fed back to the mediator. The GridViewController's consumer implementation is tweaked so that cell movement caused by user interaction doesn't trigger a collection view update (since that update has already happened as part of the move). Bug: 804592 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic8ba431d598dfee39f4a72f36f02a3d9ab52443d Reviewed-on: https://chromium-review.googlesource.com/986379 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#549556}
-
Daniel Cheng authored
As the contentDocument attribute and the getSVGDocument() method are the only IDL definitions that use CheckSecurity=ReturnValue, just modify the binding generator to emit calls to count instances of the exception being thrown. Bug: 582245 Change-Id: I4772cc225c4e2da33964b47cb8df3324a9d929f9 Reviewed-on: https://chromium-review.googlesource.com/905749Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#549555}
-