GitLab

This is a reland of 4c424ef5

Windows bot is fixed with crrev.com/c/1946985

Original change's description:
> Enable init_stack_vars for non-official Windows builds
>
> With crrev.com/c/1914359 merged so we can enable the flag on Windows.
> Patch is similar to crrev.com/c/1795632 and crrev.com/c/1838383.
>
> Bug: 977230
> Change-Id: I166392ee0f65ed7fd7f68cbdd5b7a3b7d589539b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854805
> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
> Auto-Submit: Vitaly Buka <vitalybuka@chromium.org>
> Reviewed-by: Hans Wennborg <hans@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#719737}

Bug: 977230
Change-Id: I7fa02038503e83eb5ccdbba8c07dc08010c2722f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941278Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720912}

To avoid potential memory leak in the future, we make the destructor
overridable.

Bug: 1029505
Change-Id: I75ac34ceface5a09404bb720528faab5e63b0f14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945819Reviewed-by: Richard Knoll <knollr@chromium.org>
Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720911}

This CL implements computing TBMv3 metrics using the Perfetto
trace processor. Metrics to compute should be passed as tags with
key "tbmv3".

Bug: 990304
Change-Id: I514396861f801d2d9889e5866bf95f2cae21be4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942651
Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720910}

mini_installer uses unusual linking configuration to avoid linking CRT.

Bug: 977230
Change-Id: I143a693aebc333c26c56c809038b5de3fab6ef91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946985Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720909}

During startup lots of tiny tasks are posted by FieldTrialSynchronizer.
Individually they are not a problem but on low end devices it can take
60+ ms to process all of these. This patch significantly reduces the
number of tasks posted.

Change-Id: I1d0bff3386cfb308c27641f90189aae2071a5fe0
BUG: 1013535
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849852Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Auto-Submit: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720908}

Fix l10n by no longer appending strings programmatically.

R=emaxx

      (e.g. smartcard), enter wrong PIN.

Bug: 1023360
Test: Enable RTL language, attempt to log in with PIN dialog
Change-Id: I9d4ffd3d1acef532d4899ef95a99d31af6fb682e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926483Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Fabian Sommer <fabiansommer@google.com>
Cr-Commit-Position: refs/heads/master@{#720907}

This patch is similar in spirit to the Android equivalent in
https://chromium-review.googlesource.com/c/chromium/src/+/1930796.

The overall idea is that, if encryption keys are missing, the UI needs
to display this state as an error, and the user should be able to go
through a reauth flow to retrieve the keys.

The actual logic to trigger the key retrieval process is deferred to
future patches and reflected in TODOs.

Bug: 1019685
Change-Id: Iad250aaca3519b7af50c0d8bfc038009a7d0f30d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937368
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720906}

This adds a histogram similar to CustomTabs.Visible which can be used
to separate metrics between those triggered in a Custom Tab and those
triggered in Tabbed Chrome.

This metric splits the use cases of Custom Tabs into Plain, Trusted
Web Activity, WebAPK and Webapp.

Bug: 1029500
Change-Id: I26fbbdb9eff1973ec660288a08abe902258dcd06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944170
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720905}

This adds metrics for the new phone number regex compared to the
previous one. These are logged when we show the context menu and when a
user selects a device from the menu. With those we can determine the
false positive and false negative rate compared to the current regex.

Bug: 1001033
Change-Id: Ibacfb095305eb106ec3dd21bce7c0e161172824c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942655Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720904}

This CL enables the disabled signin helper test.

Bug: 577880
Change-Id: I14d5f818a1b091b6392dca8083c217e179993239
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942089Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720903}

Defines bindings::DictionaryBase as a base class for IDL dictionaries
generated by the new code generator.
This CL also prepares some basic APIs; NativeValueTraits and ToV8.


Bug: 839389
Change-Id: I47012911933c9bd6a8934f4d18f27e4a86e80974
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898893
Auto-Submit: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720902}

This reverts commit a9700aba.

Reason for revert: Turned out this workaround does not work.

Original change's description:
> Prevent racy behavior breaking OOBE welcome dialog
> 
> It seems that the dialog's show() can be invoked prior to attached(),
> resulting in a null object being indexed. This adds a null
> check to prevent the race from completely breaking login flow.
> 
> Bug: 1028852
> Change-Id: I9bfae2e420b1a694a77479f49aa4633089689a54
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948185
> Auto-Submit: Ken Rockot <rockot@google.com>
> Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
> Commit-Queue: Ken Rockot <rockot@google.com>
> Cr-Commit-Position: refs/heads/master@{#720873}

TBR=rockot@google.com,rsorokin@chromium.org

Change-Id: I5220764c388c62240b42008e1caa25202d22f6f5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1028852
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948581Reviewed-by: Shuhei Takahashi <nya@chromium.org>
Commit-Queue: Shuhei Takahashi <nya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720901}

BUG=787254, 919392
R=guidou@chromium.org, haraken@chromium.org

Change-Id: I1125698a24e20fda4e6fbfecc0b2d52b5272d0c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946633Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#720900}

This reverts commit b5bf966d.

Reason for revert: Most likely culprit to break All/ShelfLayoutManagerTest.NoShelfUpdateDuringOverviewAnimation/1
(more details in the linked bug)

Original change's description:
> split view: Replace CanSnapInSplitview with SplitViewController function
> 
> Instead of a CanSnapInSplitview function referring to the root window of
> the argument window, there shall be a SplitViewController::CanSnapWindow
> function referring to the root window of the SplitViewController.
> Leveraging that, the split view drag indicators on each root window
> shall account for whether the dragged window can be snapped in split
> view on that root window. The present CL is also a step toward properly
> implementing functionality where you drag from one display to another
> and snap (see the TODO in OverviewWindowDragController::SnapWindow).
> 
> Bug: 970013, 995413
> Change-Id: I0e0b6d34ec8b3b3856d26fc5750bb062405f8dc6
> Fixed: 961171
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906931
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Commit-Queue: Avery Musbach <amusbach@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#720754}

TBR=oshima@chromium.org,amusbach@chromium.org

Change-Id: I1398c2eefc9d275d90708229521ff906ba667493
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 970013, 995413, 1030222
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947726Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720899}

This reverts commit 2f4e14b2.

Reason for revert: Most likely culprit for the consistently failing Windows devices tests (also bluetooth-related).

Original change's description:
> Track WinRT device connection status
> 
> Windows sometimes sends OnConnectionStatusChange events when the status
> has not changed. Previously we had assumed the status changed and acted
> accordingly.  This change keeps track of the connection status and if
> OnConnctionStatusChange fires with the same status it is now ignored.
> 
> Bug: 127810
> Change-Id: I64c5b3d99e0ac827f05ca1618d570ff83296a053
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939827
> Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
> Commit-Queue: James Hollyer <jameshollyer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#720876}

TBR=odejesush@chromium.org,jameshollyer@chromium.org

Change-Id: I8add21a3922e2a2c56ad72cd8e986e4a7b67a228
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 127810
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947648Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720898}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1e3659a4633a..6b4f6d08b82f

git log 1e3659a4633a..6b4f6d08b82f --date=short --first-parent --format='%ad %ae %s'
2019-12-03 mathias@chromium.org Update Device Toolbar user-agent strings for iPhone 6+

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@6b4f6d08b82f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1029031
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I51cc826d01db3b605bc795b098e0e1a5ad788279
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947762Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#720897}

This CL migrates code to the new BrowserInterfaceBroker class. This
allows retrieving the remote implementation in the browser process
without relying on the InterfaceProvider API.

Bug: 936482
Change-Id: I6f93bf8e1004234dc17d7aec7ab9f749581500d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942696Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#720896}

Using wpt-import in Chromium de587506.
With Chromium commits locally applied on WPT:
500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers."
a2a91a99 "Allow another touch start happen when there are active touch points"
85b61e6b "[resource-timing] Ensure workerStart is protected by TAO"
a75430aa "Fix appcache tests."
a50e7e60 "Move `Sec-Fetch-User` to SetSecFetchMetadataHeaders."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: I3127da76be08e729cade0b3586598f5110539436
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948324Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#720895}

Imported output frames must have the EGL format and size, otherwise the
image processor will complain of the mismatch since crrev.com/c/1939078.

BUG=chromium:1030190
TEST=vdatests passing on Hana.

Change-Id: I75356aff8c4b0fefb0d60bdce6d4eda889cc25fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948372
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
Auto-Submit: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Chih-Yu Huang <akahuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720894}

The DeviceLoginScreenFullScreenMagnifier used to check that user cannot
change preference value while it's set by recommended policy. This
worked (unreliable, but still) because of PolicyRecommendationRestorer
class, which switches preference value back to the recommended policy
(under some conditions, because of them it actually worked on real
devices, this is test-only issue).

This commit turns off PolicyRecommendationRestorer behaviour and makes
tests to verify that user has better priority than recommended policy,
as it should be.

Bug: 1015763
Change-Id: Ia6714fe58cedebb097d5eea24b70c590fbd04912
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930743Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Oleg Davydov <burunduk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720893}

Make FindInstanceTime(...) only handle the "strictly greater than" case
and rename it to NextAfter(...), adjusting the implementation
accordingly. This can be used for all the callers of
FindInstanceTime(...) except ResolveInterval(...).
Fold FindInstanceTime(...) with the "greater or equal" case into
ResolveInterval(...).

Bug: 1029573
Change-Id: Id727514e10586576796ecfacc5a045114217050c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944473
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720892}

https://android.googlesource.com/platform/external/perfetto.git/+log/9af0784b509e..bfcc2cabed77

git log 9af0784b509e..bfcc2cabed77 --date=short --first-parent --format='%ad %ae %s'
2019-12-03 rslawik@google.com Merge "Find process sizes during LMK"

Created with:
  gclient setdep -r src/third_party/perfetto@bfcc2cabed77

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Ic325a9ae7916863fa16e2241ed8630e0722a741c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947761Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#720891}

This test doesn't pass, because there is a problem with Chrome's
implementation (See https://crbug.com/980127) and because there are two
problems in the test itself.
 1) t_spv.done() is never called.
 2) A typing mistake in "tsv_unreached_func"

Bug: 980127
Change-Id: I91949f64db3f3d7d3033d559d8e277b2cb980b13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946482Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720890}

This CL disables some KioskUpdateTests which are incredibly flaky on
debug builds and have been disabled on release builds anyway.
In the last 200 builds, 30 failures were due to KioskUpdateTests, so I
consider disabling the test on debug in general (since they seem more
flaky there).

TBR=xiyuan@chromium.org

Bug: 949490
Change-Id: I09a31f794339bc55a2acba2b12d01f048454f597
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948426Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720889}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/db299863e0c5..d405652ad675


Created with:
  gclient setdep -r src-internal@d405652ad675

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I9dfcc82f1684785ef89289594210ca1fddc8e013
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947760Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#720888}

TabRendererData is moved moving_tab->SetData(std::move(data)); then
is used in layout_helper_->SetTabPinned(...data.pinned ?...)

Change-Id: I5b9ac8122b942985cb354f90726e78270113e1f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944676Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com>
Cr-Commit-Position: refs/heads/master@{#720887}

This CL adds support for passing text highlight information from
PDFiumEngine to mimehandler process using appropriate
AccessibilityHighlightInfo structs. Add
GetAccessibilityHighlightInfo() which works similar to
GetAccessibilityLinkInfo() called from within GetAccessibilityInfo() in
pdf/accessibility.cc. Also includes corresponding unit test.

Bug: 1008775
Change-Id: I7916177fef5e864f0e3b4b0a0b8c1693bf09f19c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871492Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Kalpak Tapas <katapas@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#720886}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/47f3eb42641b..3ed4586044f2

git log 47f3eb42641b..3ed4586044f2 --date=short --first-parent --format='%ad %ae %s'
2019-12-02 stevenperron@google.com Folding: perform add and sub on mismatched integer types (#3084)

Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@3ed4586044f2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64
Bug: None
Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com
Change-Id: I8ceda5cb6c6253d03ce360b5fc18473190483d9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947757Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#720885}

The offset in |NGFragmentItem| is relative to the inline
formatting context even when they are in inline boxes.

When painting self-painting inline boxes, |paint_offset| is
relative to the box itself. This patch adjusts it to
relative to the containing block.

Bug: 982194
Change-Id: Ie9b9233f1f78a4c79fdfb73932298701be2a19c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947608Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720884}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/75ba8e350e55..1e3659a4633a

git log 75ba8e350e55..1e3659a4633a --date=short --first-parent --format='%ad %ae %s'
2019-12-03 szuend@chromium.org Reland "Remove top-level await pre-processing"
2019-12-03 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS.
2019-12-02 etiennep@chromium.org Revert "Remove top-level await pre-processing"

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@1e3659a4633a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1021921,chromium:1029863
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I5466dd4d5508c5102bd395e55313b227136bea3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947755Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#720883}

This CL has below goals,
  1. Use To<SVGDefsElement> and DynamicTo<SVGDefsElement> as new
     downcast helper
  2. Use IsA<SVGDefsElement>(element) in place of
     IsSVGDefsElement(element)
  3. Use To<SVGCircleElement> and DynamicTo<SVGCircleElement> as new
     downcast helper
  4. Use IsA<SVGCircleElement>(element) in place of
     IsSVGCircleElement(element)
  5. Use DynamicTo<SVGAElement> as new downcast helper
  6. Use IsA<SVGAElement>(element) in place of IsSVGAElement(element)

Bug: 891908
Change-Id: If2c1706899083e924a7efc762e403c81a6c6c211
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946193
Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720882}

Removed unused a few functions and variables in MainThreadEventQueue
They were used for recording metrics and metrics were removed a while
ago.

Change-Id: I724ff6a4b80d34f7a0b9de0db2376f5fa35eb6be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946480Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720881}

TBR=ericwilligers@chromium.org

Bug: 1029640, 1029997
Change-Id: Ie1bae0880e4ee1610bc03e88f73237ddc6501a19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947263Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720880}

This reverts commit 8061760f.

Reason for revert: Seems to break windows test, see linked bug.

Original change's description:
> Roll src/third_party/angle ca1b0fb895ca..fb40d231c3e2 (5 commits)
> 
> https://chromium.googlesource.com/angle/angle.git/+log/ca1b0fb895ca..fb40d231c3e2
> 
> git log ca1b0fb895ca..fb40d231c3e2 --date=short --first-parent --format='%ad %ae %s'
> 2019-12-02 jmadill@chromium.org Add new test runner harness.
> 2019-12-02 syoussefi@chromium.org Vulkan: implement external semaphore barriers
> 2019-12-02 syoussefi@chromium.org Fix RenderingLimitToDefaultFBOSizeWithNoAttachments test
> 2019-12-02 syoussefi@chromium.org Add test for multithreaded shared-context resource
> 2019-12-02 geofflang@chromium.org D3D: Log why a renderer fails to initialize.
> 
> Created with:
>   gclient setdep -r src/third_party/angle@fb40d231c3e2
> 
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/angle-chromium-autoroll
> Please CC geofflang@google.com on the revert to ensure that a human
> is aware of the problem.
> 
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Bug: chromium:1026673,chromium:1029091
> Tbr: geofflang@google.com
> Change-Id: Ie7249b58c3681e8f2a2238cfc86689216142593c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947424
> Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#720769}

TBR=geofflang@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com

Change-Id: I33c8e7a4a8f9da17c1551f2ab0bda284f12778cf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1026673, chromium:1029091, 1030192
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948424Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720879}

This CL fixes a corner use case that was caught by one of the users
of Ozone/Wayland.

The problem appeared when the Chromium compositor sent a next frame into
the same buffer that had just been submitted and a OnSubmission callback
had been sent to the viz process located WaylandBufferManager. This
happened only when the remote inspector was attached and the screencast
was enabled.

In this case, Wayland compositor will not send an OnRelease callback
and we should not wait for that. Instead, we must complete the
submission immediately and set the |WaylandBuffer::released|
member to be false. Once another buffer is committed, Wayland compositor
will release the previous buffer.

Bug: 1029777
Change-Id: Ib74c16f41f128298998bc9699f8d9ded3697cd43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946479
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720878}

As a follow-up to
https://chromium-review.googlesource.com/c/chromium/src/+/1930820
this CL ensure that the "Inform quietly" checkbox is not visible if
the `QuietNotificationPrompts` feature is disabled.

Bug: 1014874
Change-Id: I205d46c86c1714f06e62849a10b1348252631930
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946484Reviewed-by: Kamila Hasanbega <hkamila@chromium.org>
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720877}

Windows sometimes sends OnConnectionStatusChange events when the status
has not changed. Previously we had assumed the status changed and acted
accordingly.  This change keeps track of the connection status and if
OnConnctionStatusChange fires with the same status it is now ignored.

Bug: 127810
Change-Id: I64c5b3d99e0ac827f05ca1618d570ff83296a053
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939827Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Commit-Queue: James Hollyer <jameshollyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720876}

Markers should have the following styles by default:
 - unicode-bidi: isolate
 - font-variant-numeric: tabular-nums

Spec: https://drafts.csswg.org/css-pseudo-4/#marker-pseudo

Bug: 457718

TEST=external/wpt/css/css-pseudo/marker-default-styles.html
TEST=external/wpt/css/css-pseudo/marker-font-variant-numeric-default.html
TEST=external/wpt/css/css-pseudo/marker-font-variant-numeric-normal.html
TEST=external/wpt/css/css-pseudo/marker-unicode-bidi-default.html
TEST=external/wpt/css/css-pseudo/marker-unicode-bidi-normal.html

The unicode-bidi tests fail in legacy because of bug 1012289.
And marker-font-variant-numeric-normal.html fails everywhere because
nested ::marker pseudo-elements are not supported yet.

Change-Id: I80360d0e2bfa78ebca1c10e1064daa17e66e6f22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943228Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#720875}

This is a reland of 3b866120

There is no changes in the code itself.

BUG=1029856
TEST=Confirmed on the kevin that the test pass with or without the changes below.

Original change's description:
> media/gpu/v4l2: abstract request logic in V4L2 framework
>
> Currently, the request creation and submission logic are handled
> inside the decoder's backend.
> This patch moves the request handling inside the V4L2 framework and
> provides new classes to abstract the request creation and submission.
>
> BUG=chromium:1009921
> TEST=tast video.DecodeAccelVD.h264* on veyron_minnie-kernelnext
> TEST=tast video.DecodeAccelVD.vp8* on veyron_minnie-kernelnext
> TEST=tast video.DecodeAccelPerf.vp8* on veyron_minnie-kernelnext
> TEST=tast video.DecodeAccelPerf.h264* on veyron_minnie-kernelnext
>
> Signed-off-by: Francois Buergisser <fbuergisser@chromium.org>
> Change-Id: Idacff87aa4324c26b287ce2617398c51dee2721a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918794
> Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
> Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#720402}

Bug: chromium:1009921, chromium:1029856
Change-Id: I32fe681693049291378e4f120cd66a5d6f4d9e71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947511Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720874}

It seems that the dialog's show() can be invoked prior to attached(),
resulting in a null object being indexed. This adds a null
check to prevent the race from completely breaking login flow.

Bug: 1028852
Change-Id: I9bfae2e420b1a694a77479f49aa4633089689a54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948185
Auto-Submit: Ken Rockot <rockot@google.com>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#720873}