GitLab

This CL implements B in the explainer [1].

[1] https://github.com/tkent-google/std-switch/blob/master/README.md#form-submission

Bug: 972476
Change-Id: I29e0e820753a8f9a35092dab3e85d88f2736ba43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772852
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691552}

https://chromium.googlesource.com/angle/angle.git/+log/5d27a6961601..80b1ba63edff

git log 5d27a6961601..80b1ba63edff --date=short --no-merges --format='%ad %ae %s'
2019-08-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src f27bd2aa2e3f..796df2d74e05 (4 commits)
2019-08-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 15fc19d0912d..73422a0a5ee1 (1 commits)

Created with:
  gclient setdep -r src/third_party/angle@80b1ba63edff

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Bug: chromium:None,chromium:None
Change-Id: I61310a4ea842c4ab4b8874541ba78b55a3aacf36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775922Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#691551}

This CL converts BlobURLStoreAssociatedRequest,
BlobURLStoreAssociatedPtr, BlobURLStorePtr, and
BlobURLStoreAssociatedRequest to new Mojo types.
It updates URLStoreForOrigin from blob_registry.mojom and
methods and members with new Mojo types.

Bug: 955171, 978694
Change-Id: I4206429d8d46cd9321ec871599818153ef9d1fe3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772790Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#691550}

This reverts commit 06142604.

Reason for revert: Reverting some CLs that are suspect for causing
flakiness in the tests

Original change's description:
> [Sync] Delete FakeServerInvalidationService
> 
> With the recent introduction of FakeServerInvalidationSender which
> excerises FCM-based invalidation production code, the
> FakeServerInvalidationService isn't needed anymore.
> 
> Change-Id: I18b8eba337c27d9d3f7a5d12dd101ed5aea0c38f
> Bug: 985287
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758242
> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
> Reviewed-by: Marc Treib <treib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#689579}

TBR=treib@chromium.org,mamir@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 985287
Change-Id: Id97b595432f575393bada8692217b8274c370658
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776018Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691549}

This adds support for the fundamentals required by column-span:all. We
still don't attempt to position the spanners correctly. We need to
margin-collapse between spanners and calculate the inline position
first. We also still don't support breaking between spanners, or between
column rows and spanners. This may be necessary if we're nested inside
another fragmentation context.

Spanners are detected during regular column layout, and will bubble up
to the column layout algorithm, where they will be laid out as children,
before regular column content resumes. The column content will see the
spanner as a forced column break.

Some tests now start to fail. Two dynamic tests fail because
NGPaintFragment doesn't really understand block fragmentation. One
starts to crash, because a spanner causes a break inside the containing
block of an out-of-flow positioned descendant, which we have never
supported anyway. See crbug.com/996655

Bug: 829028
Change-Id: I60229da59f745dd469bbf104f6f46e5f93e1a1de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771909
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691548}

This reverts commit 6268a44d.

Reason for revert: Test fails on ChromeOS, see: https://crbug.com/999072

Original change's description:
> Hide saved printers when empty
> 
> - The header for saved printers will be hidden when the saved printers
>   list is empty.
> - Adds a browsertest to reflect this change.
> 
> Bug: 993819
> Test: browser tests, end to end manual
> Change-Id: I4bbae8f389161a7c3252df09d39380c896413fa2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767488
> Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Reviewed-by: Bailey Berro <baileyberro@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#691391}

TBR=khorimoto@chromium.org,zentaro@chromium.org,baileyberro@chromium.org,jimmyxgong@chromium.org

Change-Id: Iee2c84d5e9aacd691bb695229a2c26d8ffff1b2a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 993819, 999072
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776039Reviewed-by: Oskar Sundbom <ossu@chromium.org>
Commit-Queue: Oskar Sundbom <ossu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691547}

This CL converts LockManagerRequest and LockManagerRequestPtr
to new Mojo types.
It also replaces using BindingSet with ReceiverSet.

Bug: 955171, 978694
Change-Id: Icc5f15537f3eb36deb94a3d26a5ccf2a91990898
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771364
Commit-Queue: Julie Kim <jkim@igalia.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691546}

https://webrtc.googlesource.com/src.git/+log/03307cb2b5ed..228900f8b1e0

git log 03307cb2b5ed..228900f8b1e0 --date=short --no-merges --format='%ad %ae %s'
2019-08-29 jonaso@webrtc.org Add TURN_LOGGING_ID to android sdk

Created with:
  gclient setdep -r src/third_party/webrtc@228900f8b1e0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: None
Change-Id: I24154364655784f13946b4d422aa42b994b2aec7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775920Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#691545}

This CL is purely a renaming refactoring.

Since its creation, the payment request action has long since diverged from what its name implies. We use it not just for payment methods, but for contact details, user login, and terms&conditions. Also, the equivalent action in the backend is already called CollectUserData. Thus it makes sense to rename.

Bug: 806868
Change-Id: I27b08db841fcba767fca184b1278d444cf8de24d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771612
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691544}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5c64cbb4..58d77ccd

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I513795e1d67caf369ca3c291b091b187f0961152
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775858Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#691543}

This reverts commit 4fa0fac0.

Reason for revert: Tests hit the DCHECK on Mac Retina Debug (AMD) tester: https://crbug.com/999065

Original change's description:
> Add support for lldbinit to macOS.
> 
> The build-flag `strip_absolute_paths_from_debug_symbols = 1` produces
> deterministic outputs and has better goma caching, but breaks lldb. This CL adds
> machinery to help users get functional symbols in lldb while still using that
> compile flag.
> 
> Bug: 330262
> Change-Id: I42f1e6c9c76296d451730ea481d7e1c3c0a69476
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775227
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Erik Chen <erikchen@chromium.org>
> Auto-Submit: Erik Chen <erikchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#691393}

TBR=thakis@chromium.org,erikchen@chromium.org

Change-Id: I801cd3afe2b1b89b050c7806d62295a4a269911b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 330262, 999065
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774627Reviewed-by: Oskar Sundbom <ossu@chromium.org>
Commit-Queue: Oskar Sundbom <ossu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691542}

https://swiftshader.googlesource.com/SwiftShader.git/+log/3ffa113f620b..2198b0fe1a2d

git log 3ffa113f620b..2198b0fe1a2d --date=short --no-merges --format='%ad %ae %s'
2019-08-29 swiftshader.regress@gmail.com Regres: Update test lists @ eea9d35b

Created with:
  gclient setdep -r src/third_party/swiftshader@2198b0fe1a2d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Bug: None
Change-Id: Ia9748480421212de1c8b9a4c5173362fdaad049c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775631Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#691541}

media::VideoDecoder implementation may be destroyed on different
thread from the thread that the client releases it. We should make
sure the destruction is done before test environment is released.

This CL call RunUntilIdle() before releasing the test environment.

BUG=none
TEST=run video_decode_accelerator_perf_tests on Eve

Change-Id: Ifeec98da8c2f7a9798d45f973bcf2e4901bdb411
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772874
Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: David Staessens <dstaessens@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691540}

In preparation for unifying WebSocketChannelImpl and
WebSocketHandleImpl, this CL stops using MockWebSocketHandle in
WebSocketChannelImplTest and starts using mojo instead. This allows us
to test IPC related behaviors in it, so this CL adds some tests for the
behaviors.

Bug: 977912
Change-Id: I87d9f208c44335d43576d13a3c44e22ca9070242
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774500Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691539}

This CL converts AuthenticationHandlerPtr to new Mojo types.
It updates CreateWebSocket from network_context.mojom and
methods and members with new Mojo types.

It also renames |binding_as_handshake_client_| to
|receiver_as_handshake_client_| from WebRequestProxyingWebSocket.

Bug: 955171, 978694
Change-Id: I211b7ed2f37fe18b4a60ba81839abf5f77548dba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772901
Commit-Queue: Julie Kim <jkim@igalia.com>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#691538}

Right now use_goma will be set to true if you have a ~/goma directory
on your system, not respecting any --no-goma option. I think it should
be the opposite: if you omit --no-goma, but don't have a ~/goma
directory, use_goma gets set to false.

Change-Id: I023ed84b121f9456be13e2bf5974f271dd8c8661
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775580Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691537}

This reverts commit 92159b3b.

Reason for revert: All the listed primitive types support __hash__, and they're memoized.  It turned out that we've not created copies of them too much aggressively.  The patch doesn't make sense.

Original change's description:
> IDL compiler: Stop creating copies of primitive objects.
> 
> A lot of copies of 'str' are just waste of memory in the
> current design/implementation, so this patch stops creating
> copies of primitive objects.
> 
> Bug: 839389
> Change-Id: I9873986dab0a13340768badfc119100c88eea733
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774004
> Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
> Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#691200}

TBR=peria@chromium.org,yukishiino@chromium.org

Change-Id: Ief2ede9d61045c4e3649be01265cb92956988d5c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 839389
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775650Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691536}

https://android.googlesource.com/platform/external/perfetto.git/+log/2cf8b53576ce..03e4f459a98e

git log 2cf8b53576ce..03e4f459a98e --date=short --no-merges --format='%ad %ae %s'
2019-08-29 primiano@google.com Merge "Amalgamator: recurse into header deps for protos"

Created with:
  gclient setdep -r src/third_party/perfetto@03e4f459a98e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: Ib9fabc5945e7d86fba8319c7e24120bb27d07a83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775637Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#691535}

Using wpt-import in Chromium cef551bc.
With Chromium commits locally applied on WPT:
5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport."
d3b97055 "Update simulateUserActivation to match webxr-test-api spec"
2d090a27 "[WPT/referrer-policy] Call getRequestURLs() for each subtest"
90789f54 "Implement fallback to element anchor"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I64d6fe9d334646f2347f2db5d685231db0e3ce7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773410Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#691534}

This CL converts VirtualAuthenticator{Ptr, Request} in content and
blink to the new Mojo types, and ueses
pending_remote<VirtualAuthenticator> in virtual_authenticator.mojom.

Bug: 955171, 978694
Change-Id: Ia323504b566d8b1c1b62a543b1aed88deb1b57b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774423Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Cr-Commit-Position: refs/heads/master@{#691533}

This reverts commit 51ae61cd.

Reason for revert: Reverting some CLs that are suspect for causing
flakiness in the tests

Original change's description:
> [Sync] Log dropped invalidations in Sync browser tests
> 
> This patch adds logging for the dropped invalidations in Sync browser
> tests. This will help investigate some flaky tests.
> 
> Invalidation are dropped if they are received before an
> FCMNetworkHandler is actually assigned and listening for FCM messages.
> 
> 
> Change-Id: I10409bfdda7b0616da6e45a6ecd5f00b3cd5bef0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771904
> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
> Reviewed-by: Marc Treib <treib@chromium.org>
> Reviewed-by: Jan Krcal <jkrcal@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#691090}

TBR=treib@chromium.org,jkrcal@chromium.org,mamir@chromium.org

Change-Id: I235908f6977eded9164da806156be5433aca8a83
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774625Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691532}

A VideoFrame is a better container for the output DMAs, especially if we
add support for ImageProcessor which requires it as a frame abstraction.

Prepare for ImageProcessor support by wrapping the VideoFrame in a
single place instead of passing DMAbufs around.

Bug: 132589320
Test: VDA unittest passes on Minnie in regular and import mode.

Change-Id: I10d0ee8fd749778ba5aba06612a7c4d9c46d4786
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768478
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Auto-Submit: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691531}

Following WebGPU spec change at https://github.com/gpuweb/gpuweb/issues/376,
GPURenderPassColorAttachmentDescriptor.storeOp default should be "store".

Bug: 877147
Change-Id: I7dd5db4e3cfcb0ddc4dd132342d8bf145bb8f28e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715186Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#691530}

Most of the changes are a straightforward replace:
kTableViewTextLabelColorBlue -> blue_color
kTableViewTextLabelColorLightGrey -> cr_labelColor
kTableViewSecondaryLabelLightGrayTextColor -> cr_secondaryLabelColor

This also sets the tint color for the language settings vc so the
accessory checkmarks appear correctly.

Bug: 976668
Change-Id: Ifb8b1f8fd7437d6910c60ed232bbbb8ae63f2c1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774443
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691529}

Service workers load scripts and sub resources. Currently There is only
one URLLoaderFactory type (kServiceWorkerSubResources) for all cases.
However, When ServiceWorkerImportedScriptUpdateCheck is enabled, only
scripts are loaded in browser process during the check. It's necessary
to separate the loader factory into two types.

So add ContentBrowserClient::URLLoaderFactoryType::kServiceWorkerScript.

Change-Id: I41564fba6b4702257324d77c3d9125be747b2ee4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774051Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Ting Shao <ting.shao@intel.com>
Cr-Commit-Position: refs/heads/master@{#691528}

This CL converts LockRequestAssociatedPtr,
LockRequestAssociatedPtrInfo, and LockRequestAssociatedRequest
to new Mojo types.
It also updates RequestLock from lock_manager.mojom.

Bug: 955171, 978694
Change-Id: Icb8a72f2758f1a604c6a687cc9488d7a8e1d6524
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768498Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#691527}

Bug: 832054
Change-Id: Ib242e10bc1aeba93ae7850f1127432beb2777ca4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768774Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Tove Petersson <tovep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691526}

PassphraseActivity was broken by https://crrev.com/c/1708895, as it was
checking for backstack entry count in the framework FragmentManager,
while fragments were added to FragmentManager from the support library.
This is fixed by using getSupportFragmentManager.
A second unrelated fix is a change of the base class from
FragmentActivity to AppCompatActivity. All Chrome activities should
inherit AppCompatActivity to make sure proper view classes from support
library are inflated.

Bug: 998412
Change-Id: I286544233c18f4bf0289cee7e3c7aa2618a76b54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768350
Auto-Submit: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691525}

onCloseWindow() will be called on the child window's chromeclient,
so moving the handling logic there.

Also, add a test around this behavior, which can be extended to handle
multi window support.

Bug: 994939, 996790
Change-Id: Iaf7cc8b3da21c0f1ad607ae8a8c725a3cc774713
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761650
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Andrew Luo <aluo@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691524}

Re-enable
  svg/animations/mpath-remove-from-dependents-on-delete-crash.html

This is likely fixed now.

Bug: 874442
Change-Id: I2ce2980fd59fab1b9951c4aa34b942c8645e080b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774620Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691523}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/efbbd1c2f621..0fa8a07ef4a9

git log efbbd1c2f621..0fa8a07ef4a9 --date=short --no-merges --format='%ad %ae %s'
2019-08-29 vapier@chromium.org cros_collections: specify global & local namespaces

Created with:
  gclient setdep -r src/third_party/chromite@0fa8a07ef4a9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I02060477007e1d8bc4366e51cf282631d851ba37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775634Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#691522}

This reverts commit b0a7925b.

Reason for revert: Performance regression crbug.com/998753

Original change's description:
> Allow cooperative scheduling for ScheduledAction
> 
> ScheduledAction::Execute is only ever called by DOMTimer::Fired which is called as a task. So the stack is simple and we should be able to add AllowedStackScope and allow cooperative scheduling.
> 
> Bug: 804661
> Change-Id: Ida6d3605810469d0e95b6e72ded3f1aed05ad341
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743236
> Commit-Queue: Keishi Hattori <keishi@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#691088}

TBR=haraken@chromium.org,keishi@chromium.org

Change-Id: Id4bfac72823155166006c0814e95cb8b46dff138
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 804661
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775940Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691521}

This CL introduces a new member to HttpCache::Transaction, called
|updated_prefetch_response_|. This response is optionally a copy of
|response_|, used when writing modified values on prefetch responses
for future transactions. This is used instead of the current flow of:
 - Modifying |response_|
 - Writing it
 - Un-modifying it for the current transaction

Furthermore, when |updated_prefetch_response_| is non-null,
WriteResponseInfoToEntry prefers writing this response to |response_|.

Bug: 939317
Change-Id: Ic92683411f495b99fca22a675191b050edd72a02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760632
Commit-Queue: Dominic Farolino <dom@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691520}

This CL converts ProgressClientAssociatedPtrInfo and
ProgressClientAssociatedPtr to new Mojo types.

Bug: 955171, 978694
Change-Id: I39781fbcb8f00c02510ba027ba72631335e217ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771223Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#691519}

Bug: b/139693028
Change-Id: I2bc6ac5ff200f580290ba46d5bc0a5a488e54ac3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775231Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Umesh Patil <upatil@google.com>
Cr-Commit-Position: refs/heads/master@{#691518}

This CL converts UsbDeviceManagerTest{Ptr, Request} in chrome and
services to the new Mojo types, and uses
pending_receiver<device.mojom.UsbDeviceManagerTest> in
usb_internals.mojom.

Bug: 955171
Change-Id: Iae751e32a5fb8b25cd1ab771fbf55244f5fdb2c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768515
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#691517}

This CL converts NativeFileSystemFileHandlePtr to new
Mojo types.

It also updates GetFile from
native_file_system_file_handle.mojom.

Bug: 955171, 978694
Change-Id: Ie1242e453a0331215a005afdd117a5286a18b971
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771485
Commit-Queue: Julie Kim <jkim@igalia.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#691516}

This CL converts InternalAuthenticator{Ptr, Reqeust} in components
to the new Mojo types.

Bug: 955171
Change-Id: Ibc5ab83b99cb1fbfc6cbee2fdfa04735652e12e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773009
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691515}

Tracking unexpected tap for 15s is too long and confuse users. 5s is a
much more reasonable delay.

Change-Id: Ia4ffa4b624a23cbc4c52be58abf22e79ab7d69a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771903
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Auto-Submit: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691514}

Moving paragraph breaking logic from AddPageContent() into its own
function.

Bug: 981448
Change-Id: I6b23a39824a5aac7599a912ec162e195b01939d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775680Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Ankit Kumar 🌪️ <ankk@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#691513}