- 06 Oct, 2017 13 commits
-
-
Xianzhu Wang authored
This is a preparation CL for SPv175 raster invalidation which will use CompositedLayerRasterInvalidator in GraphicsLayer. To reduce differences between SPv1 and SPv175, in this CL we also let SPv1 use CompositedLayerRasterInvalidator but only use its raster invalidation tracking functionality. 1. RasterInvalidationTracking is converted from a struct to a class. 2. Now each GraphicsLayer is associated with a RasterInvalidator instead of a RasterInvalidationTracking. Previously the association was implemented by a hash map, now is directly owned using unique_ptr. 3. Empty invalidation rect is no longer reported in SPv2. Bug: 771643 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I125ffc2e6cdff8931eabdaf7e4630d17135a5189 Reviewed-on: https://chromium-review.googlesource.com/701663 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#506935}
-
Jialiu Lin authored
account_info_ is initialized when ChromePasswordProtectionService is created (browser startup time).So if user changed their signin state afterward, CPPS cannot capture it. We should in fact get AccountInfo struct from SigninManager whenever it is being used. Bug: 772041 Change-Id: Idedbcc71c444d84446662d2b9ed595901ac25ae8 Reviewed-on: https://chromium-review.googlesource.com/702915 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#506934}
-
smut authored
Bug: 756270 Change-Id: I68e4b762f3324c19fe8a20e8d5a180adb6a30305 Reviewed-on: https://chromium-review.googlesource.com/703889Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#506933}
-
Devlin Cronin authored
Add a OneTimeMessagingHandler to handle sending one-time messages (such as those from chrome.runtime.sendMessage) with native bindings. These messages open a message channel, similar to the long-lived connections of chrome.runtime.connect(), but the channel is only open for a single message-and-response cycle. The OneTimeMessagingHandler is responsible for creating and maintaining these message channels, and cleaning them up when complete. Add tests for the same. Note: currently, these constructs are still only used in tests. A later CL will hook them up to the bindings system. Bug: 653596 Change-Id: Ibeae3bda73b66306a85b13749f1cab1a1edfb33b Reviewed-on: https://chromium-review.googlesource.com/675305 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#506932}
-
Lei Zhang authored
Use a single map with a struct to keep track of incoming requests, instead of two separate maps. Change-Id: If5dbb806de2b42f95bbe2697512beaedd39c80df Reviewed-on: https://chromium-review.googlesource.com/703493Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#506931}
-
Ilya Sherman authored
BUG=772159 R=mark@chromium.org Change-Id: I596b085a93b0dde4717f03db2e5d2cd4cd2fec82 Reviewed-on: https://chromium-review.googlesource.com/703919Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#506930}
-
Cait Phillips authored
Bug: 700812 Change-Id: I4ab2534057debd0d1c94b20e6c8b8844fd364d87 Reviewed-on: https://chromium-review.googlesource.com/666059Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Commit-Queue: Cait Phillips <caitkp@chromium.org> Cr-Commit-Position: refs/heads/master@{#506929}
-
Ryan Sturm authored
Currently, a pingback report will only contain LoFi as a preview if a server LoFi image was served. However, there are experiments that only show Client LoFi instead of server LoFi, and it is possible in any case to have HTTPS images on an HTTP page that are served via client LoFi. Because the server decides LoFi in this case, we should count the page as LoFi as long as an modified images were served (or at least requested with range headers). Bug: 772170 Change-Id: I791494624bed715a7da6b84f6a6d27624d5ab858 Reviewed-on: https://chromium-review.googlesource.com/704018Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#506928}
-
David Trainor authored
If two downloads have the same scheduling criteria and the same cancel time, have the one that was created first be a better candidate to start. Bug: 772152 Change-Id: Ib1459a95a6703685b34d712cf5d00e188e5d5ccb Reviewed-on: https://chromium-review.googlesource.com/703735Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#506927}
-
Peter Collingbourne authored
Should fix anything that explicitly passes use_debug_fission=true (or use_lld=true, which can imply use_debug_fission=true). Bug: 607968 Change-Id: I22cd532c12e1fa334c7273b09f566d5168f5b260 Reviewed-on: https://chromium-review.googlesource.com/703688Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#506926}
-
Kenneth Russell authored
MSAA is too expensive on these GPUs. At least for the time being, use the CMAA extension wherever it's supported. BUG=535198, 768400 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3e5da867cbfcfdc08113949e7d93c5662e4ad115 Reviewed-on: https://chromium-review.googlesource.com/701922 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Stéphane Marchesin <marcheu@chromium.org> Cr-Commit-Position: refs/heads/master@{#506925}
-
Scott Violet authored
Removes build files and json files no longer needed. BUG=763529 TEST=none Change-Id: I2926af9e461e1178ec63b0f0c1e1368d4dc26d51 Reviewed-on: https://chromium-review.googlesource.com/701258 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#506924}
-
David Tseng authored
This change replaces most of the mappings required for package name to tree source translations. It results in a lot of cleanup namely: - removal of all package name specifics - removal of various observations for task id creation/activeness - removal of current task id state - removal of fallback tree work (e.g. actions, browsing, etc). Test: open many apps. Verify touch explore, ChromeVox interactions Bug: 768532 Change-Id: Ic6f679fc8bb3f649334a29f98e86a34b52e5cfbc Reviewed-on: https://chromium-review.googlesource.com/688023 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#506923}
-
- 05 Oct, 2017 27 commits
-
-
Sergey Ulanov authored
makesdk.go now expects aarch64 builds, but local-sdk.py wasn't building it. Updated it to build both i86-64 and aarch64 Change-Id: I6598010205bd6dbe1da522dcd0455a0df267a73d Reviewed-on: https://chromium-review.googlesource.com/703997Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#506922}
-
dpapad authored
This is in preparation of using optimizing with polymer-bundler. Bug: 764126 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I96a88dff699389366122d39344044023d5b20b3c Reviewed-on: https://chromium-review.googlesource.com/699245Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#506921}
-
Shanfeng Zhang authored
Bug: 769018 Change-Id: I5bdaf2ebfc8998f77d5c8ffaa3bded58facedb2a Reviewed-on: https://chromium-review.googlesource.com/688660 Commit-Queue: Shanfeng Zhang <szhangcs@google.com> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#506920}
-
Theresa Wellington authored
:( BUG=769611 Change-Id: I6d455b6bba646a27f81f47c4d1058a80778712fd Reviewed-on: https://chromium-review.googlesource.com/703994Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#506919}
-
khmel authored
This CL makes it possible to safely change one app item launcher to another. Normally this should not happen, however in some edge cases this still may happen during the ARC failure boot. provided simulation of conditions that may lead to showing the Play Store while ARC OptIn UI is active. No crash observed. Test: Manually on device. Could not find the reproduction stage and Test: Extended unit tests by adding different scenarios. Bug: 770005 Change-Id: I0eb1b571e239af6f8dea3906836852b2d6035c32 Reviewed-on: https://chromium-review.googlesource.com/698350 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:Michael Wasserman <msw@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#506918}
-
Khushal authored
Add a finch flag for enabling image animations in the compositor. Its currently disabled by default. R=piman@chromium.org Bug: 735662 Change-Id: I171d05b9411e3b3fa72b4df1be612deb0bd289b2 Reviewed-on: https://chromium-review.googlesource.com/703507Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#506917}
-
Yoland Yan authored
HistoryActivityTest is refactored in the following ways: - test class use espresso IntentTestRule for a couple of tests that ensure intent is sent after activity launch (ActivityMonitor does NOT track or block intent in Android JUnit4 now) - Add test helper method to HistoryAdapter for testSupervisedUser. For more on JUnit4 migration, please check src/testing/android/docs/junit4.md Bug: 640116 Change-Id: I58f84f296226e97d56b9b152d4173122df5a2475 Reviewed-on: https://chromium-review.googlesource.com/696033 Commit-Queue: Yoland Yan <yolandyan@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#506916}
-
Eric Willigers authored
virtual/threaded/animations/play-state-initially-paused.html was failing, and had platform-specific (failure) expectations. The test has been redesigned to not rely on precise sample timing. BUG=392706 Change-Id: Iffb469427a9af700b111f1c654ae98e47a1aa304 Reviewed-on: https://chromium-review.googlesource.com/702180Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#506915}
-
Ben Chan authored
Bug: None Change-Id: I779f4a692b9ed403efe2c3999a043fb87ba4cc02 Reviewed-on: https://chromium-review.googlesource.com/703397Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#506914}
-
Troy Hildebrandt authored
Bug: 761470 Change-Id: Id0f7795f425cef12bd9d77329770adaeb74dc055 Reviewed-on: https://chromium-review.googlesource.com/701364Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#506913}
-
Mike Baxley authored
This test is failing reliabily on the iOS 10 device bots. TBR: edchin Bug: 772186 Change-Id: If08dcce9410a2d8884fc455f0b33b7ba2f6801c9 Reviewed-on: https://chromium-review.googlesource.com/703999 Commit-Queue: Mike Baxley <baxley@chromium.org> Reviewed-by:
Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#506912}
-
Jonathan authored
Another test is flaky on telemetry_unittests, skipping it in config. TBR=sky@chromium.org Bug: 758065 Change-Id: I9d08df3109e43682b1edcff11b545bc684f06ab5 Reviewed-on: https://chromium-review.googlesource.com/703684Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#506911}
-
Kevin Marshall authored
There are some issues that need to be worked out, such as sharing resource files to embedder processes, before sandboxing will work satisfactorily on Fuchsia. This CL disables sandboxing and logs a soft NOTIMPLEMENTED() error when the browser attempts to launch one. Bug: 750938 Change-Id: I7a0253a2c4532e79fd8158d23cd262779285cf6f Reviewed-on: https://chromium-review.googlesource.com/701636Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#506910}
-
Vladimir Levin authored
This patch adds a check to ensure that we have the images that we expect to have (even if it's an empty set). R=khushalsagar@chromium.org Bug: 757049 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic544760e175be2bf95d467008cb3b5a59dc32a35 Reviewed-on: https://chromium-review.googlesource.com/703505Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#506909}
-
Xing Liu authored
This CL fixed an issue that transient download may trigger android UI and cancel the download in download resumption. How it happens: In resumption, we feed current path as initial path to target determiner instead of forced path. Target determiner may change the download path from DS internal storage to external storage, this creates the following issues: 1. External storage needs permission. 2. Conflict files are not rewritten, but needs user confirmation with a snackbar, because we don't have webcontents, target determiner will delete itself and fail the download with reason USER_CANCEL. All the Android leak will call into DownloadManagerService::OnDownloadCanceled, where it shows two kinds of error messages in toast. This issue may be also related to issue 762173. Bug: 769805, 769426 Change-Id: I1ac6d2446fcc05c00517a65b465d7bf1ea2ccfeb Reviewed-on: https://chromium-review.googlesource.com/693400Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#506908}
-
Antoine Labour authored
This reverts commit afd24343. Reason for revert: Caused a memory regression on Mac, for some reason: https://bugs.chromium.org/p/chromium/issues/detail?id=771766 Original change's description: > Avoid checking overlay ResourcePool in non CA Layer > > Overlay ResourcePool is only used for CA layer. > BUG=None > > Change-Id: Id37572e65d1b7a2c3307fa80be9820a94d693f7a > Reviewed-on: https://chromium-review.googlesource.com/685947 > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Xing Xu <xing.xu@intel.com> > Cr-Commit-Position: refs/heads/master@{#505913} TBR=xing.xu@intel.com,piman@chromium.org,danakj@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: None Change-Id: I0543fa78a715438d9d27c9eb38f643008745679f Reviewed-on: https://chromium-review.googlesource.com/703714Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#506907}
-
Steven Bennetts authored
This adds a new WebUI dialog for network configuraiton using the shared network-config component. Bug: 380937 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I44d9db4f01e366afc59e56286cc8fd7adf536bea Reviewed-on: https://chromium-review.googlesource.com/693288Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#506906}
-
Ted Choc authored
Use SwitchCompat to get a material looking switch. Mutate the download and history icons to not break their usage in the rest of Chrome. Fix animation timing/display. The animation was not triggered because super.setVisible was not returning true (i.e. that it had changed). It likely defaulted to true pre-L. Second, setting the alpha values was not triggering invalidateSelf. Third, we were not registered as Drawable.Callback[s] for the child drawables so even if they did say invalidateSelf, it would have fallen on deaf ears. Fourth, due to rounding, there was a 1px gap on the border, so this makes the sheet drawable just a "bit" bigger to cover the gap. Fifth, there is nothing left, I'm just wondering if you're still reading. Kudos. BUG=772070, 772052 Change-Id: Ie4544977f09f1f0198c3ef2944fd044cda2dedfc Reviewed-on: https://chromium-review.googlesource.com/703510Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#506905}
-
Toni Barzic authored
This delayes final step in lock screen apps initialization (observing session state, thus preventing the state controller from reacting on session being locked) until stylus input is detected (for one settings UI for controlling lock screen apps is only shown for stylus enabled devices). Remove somewhat hacky solution where lock screen apps were disabled by simply not reporting any app lock screen enabled. BUG=765029 Change-Id: I214dbe09e95babdd4779268fa6abfa5c1615e80b Reviewed-on: https://chromium-review.googlesource.com/693961 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#506904}
-
Yuly Novikov authored
https://chromium.googlesource.com/angle/angle.git/+log/a60d356..000dab8 BUG=None TBR=cwallez@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I619e797dbdb70aa00d0ae9d017bdbde3f79a4d19 Reviewed-on: https://chromium-review.googlesource.com/703459Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#506903}
-
Ryan Landay authored
This reverts commit 0e5c6697. Reason for revert: This is instacrashing my test device (Pixel C) when I navigate to file:///sdcard/. Original change's description: > Added fieldtrial_testing_config entry for Client-side LoFi. > > Bug: > Change-Id: I9f792d5b74dd28ee9442725a182a69de62c4f66e > Reviewed-on: https://chromium-review.googlesource.com/700794 > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Scott Little <sclittle@chromium.org> > Commit-Queue: Scott Little <sclittle@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506482} TBR=rkaplow@chromium.org,sclittle@chromium.org,holte@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Id44e53b31dbfcad4639fe4e6ed70c942b8b2a4fa Reviewed-on: https://chromium-review.googlesource.com/703715Reviewed-by:
Ryan Landay <rlanday@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#506902}
-
Tien-Ren Chen authored
This cleanup CL refactors TransformNode structure so that its member variables are splitted into input values and derived values, so that it is clearer which values are expected to be set by the client and which are to be recalculated by impl thread every frame. In the process, pre_local and post_local are eliminated and is only computed on the fly. To achieve this, the calculation of post_local needs to be unified between root and non-root layers. Previously the transform node #0 stores the scale component of the root transform[1], and node #1 stores the root transform with scale component extracted. With this CL, transform node #0 stores the whole root transform and node #1 becomes a regular node. This CL affects rounding error of draw matrices due to the change in association order. Should introduce no other behavior change. [1] root transform = device_transform * device_scale * page_scale Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia553ec5816d71eff6e2d7bc42b51b439817d9d2b Reviewed-on: https://chromium-review.googlesource.com/685544Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#506901}
-
Yue Li authored
If PlayStore setup runs into an error (such as no network), close the wait a second screen. BUG=b/67100483 Change-Id: I5581b9411bed0396bd4acf0c5030eac55c5e3c2c Reviewed-on: https://chromium-review.googlesource.com/701494Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#506900}
-
Maks Orlovich authored
(but still close it when closing them all) Not sure if this could ever be hit IRL (testcase would check-fail on file being invalid in File::Read off ReadSparseRange), but I am going to be touching this for FD limits, and it helps if the code makes sense. Bug: 636400 Change-Id: Ie33f1787a81f90b893d963e1fcb1db3b4fd0aab2 Reviewed-on: https://chromium-review.googlesource.com/652965 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#506899}
-
Fernando Serboncini authored
Also makes FontFaceInvalidated a virtual on FontSelector. Bug: 722511 Change-Id: I6144965b1d559bb418d2b823b4d6486e5769d8bc Reviewed-on: https://chromium-review.googlesource.com/702684 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#506898}
-
Matt Menke authored
All consumers now use a single thread for prefs and the network stack, so there's no need for it to have thread hopping logic. This also makes HttpServerPropertiesManager better support the case where prefs aren't loaded when it's created (Always the case in consumers), and makes it flush to prefs on destruction, which can now be done, since the net and prefs threads are the same. This also fixes a crasher in the single-thread case, due to the use of base::Unretained when calling from the prefs thread to the network thread, which doesn't work when they're the same thread. Bug: 768884, 770179 NOPRESUBMIT=true (Unfortunately, the tests use banned APIs. This use predates this CL, and this CL doesn't introduce new uses of them. Fixing a crasher is more important than removing banned APIs). Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2692e3c02ff6028b585416808b60cabcf9d2e2e6 Reviewed-on: https://chromium-review.googlesource.com/693054Reviewed-by:Andrei Kapishnikov <kapishnikov@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#506897}
-
iOS Autoroller authored
TBR=smut Change-Id: Ie4d656a4a09c8504206be049b39531a0373e967b Reviewed-on: https://chromium-review.googlesource.com/703755Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506896}
-